[Bug 705112] Re: the menubar with appmenu-gtk is 1px tall

2011-03-15 Thread Santtu Lakkala
As discussed with Cimi on irc, this one now uses unmap/map to avoid
setting the GTK_VISIBLE flag, so that the notifications come through
correctly.

** Patch added: Re-try of the fixed patch using map/unmap
   
https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/705112/+attachment/1909982/+files/043_ubuntu_menu_proxy.patch

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/705112

Title:
  the menubar with appmenu-gtk is 1px tall

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 705112] Re: the menubar with appmenu-gtk is 1px tall

2011-03-15 Thread Santtu Lakkala
This patch fixes a couple of coding style issues and simplifies
gtk_menubar_show and _hide.

** Patch added: Re-re-try of the fixed patch using map/unmap
   
https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/705112/+attachment/1910444/+files/043_ubuntu_menu_proxy.patch

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/705112

Title:
  the menubar with appmenu-gtk is 1px tall

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 705112] Re: the menubar with appmenu-gtk is 1px tall

2011-02-16 Thread Santtu Lakkala
The updated patch helps with the issue, but some kind of race still
prevails. The updated test program sometimes shows and sometimes hides
the bar. Upping the priority to G_PRIORITY_HIGH_IDLE shows the menubar
(nearly) every time.

** Attachment added: lp705112-regression.c
   
https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/705112/+attachment/1853534/+files/lp705112-regression.c

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/705112

Title:
  the menubar with appmenu-gtk is 1px tall

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 705112] Re: the menubar with appmenu-gtk is 1px tall

2011-02-16 Thread Santtu Lakkala
Found the problem to be that GtkWidgetClass::hide is only called if the widget 
was visible, thus if the call order is:
1. show()
2. hide()
3. local_notify(local = 1)

the menubar remains shown, but if the call order is:
1. show()
2. local_notify(local = 1)
3. hide()

things work correctly.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/705112

Title:
  the menubar with appmenu-gtk is 1px tall

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 717358] Re: nautilus puts a menu bar at the top of the desktop

2011-02-16 Thread Santtu Lakkala
The updated patch doesn't fix cases which do _show() ... _hide() (where
hide is called before local_notify). I wrote some findings in bug
705112, but in short the problem is that gtk_widget_hide() only calls
GtkWidget::hide if the widget was visible.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/717358

Title:
  nautilus puts a menu bar at the top of the desktop

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 717358] Re: nautilus puts a menu bar at the top of the desktop

2011-02-16 Thread Santtu Lakkala
This rather obtrusive patch seems to fix the issue, not sure if it
breaks something though; some applications may expect that ::show is not
called multiple times without ::hide in between (or vice versa). This is
the best/simplest solution I can think of right now.

Uploaded a package with this patch to my ppa if someone likes to test.

** Patch added: 043_ubuntu_menu_proxy.patch
   
https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/717358/+attachment/1854469/+files/043_ubuntu_menu_proxy.patch

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/717358

Title:
  nautilus puts a menu bar at the top of the desktop

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 705112] Re: the menubar with appmenu-gtk is 1px tall

2011-02-15 Thread Santtu Lakkala
The patch breaks applications that don't want to show a menubar on
startup (I noticed it with gnome-terminal). Attached file shows broken
behavior: even though menubar is explicitly hidden, it still shows up
when run.

** Attachment added: Sample application showing regression with the patch
   
https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/705112/+attachment/1851524/+files/lp705112-regression.c

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/705112

Title:
  the menubar with appmenu-gtk is 1px tall

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 129240] Vte doesn't underline spaces

2007-07-30 Thread Santtu Lakkala
Public bug reported:

Any vte-based (since vte 0.14, I think) terminal doesn't show
underlining on whitespace. This totally breaks my irssi theme.

Steps to reproduce:
1. launch terminal 
2. run echo -e '\e[4mfoo foo\e[0m'

Actual results:
Two underlined foos are echoed

Expected results:
Two foos with one underline should be echoed

Other: I've reported this also as gnome bug #434230, but there's been no
activity in 3 months. Noticed this again when doing an apt-get upgrade
and my hand-crafted package got replaced by new version.

** Affects: vte (Ubuntu)
 Importance: Undecided
 Status: New

-- 
Vte doesn't underline spaces
https://bugs.launchpad.net/bugs/129240
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is a bug contact for vte in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 129240] Re: Vte doesn't underline spaces

2007-07-30 Thread Santtu Lakkala

** Attachment added: A simple patch that fixes the issue
   http://launchpadlibrarian.net/8606364/70_fix-underscore.patch

-- 
Vte doesn't underline spaces
https://bugs.launchpad.net/bugs/129240
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is a bug contact for vte in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs