[Bug 117180] Re: Encoding is deprecated
** Changed in: desktop-file-utils Importance: Unknown = Wishlist -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to desktop-file-utils in ubuntu. https://bugs.launchpad.net/bugs/117180 Title: Encoding is deprecated -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Changed in: desktop-file-utils Importance: Wishlist = Unknown -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to desktop-file-utils in ubuntu. https://bugs.launchpad.net/bugs/117180 Title: Encoding is deprecated -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
Fixed with the new release. desktop-file-utils (0.13-0ubuntu1) gutsy; urgency=low * New upstream release -- Baptiste Mille-Mathias [EMAIL PROTECTED] Mon, 11 Jun 2007 08:58:58 +0200 ** Changed in: desktop-file-utils (Ubuntu) Assignee: RainCT = (unassigned) Status: In Progress = Fix Released -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Changed in: desktop-file-utils (upstream) Status: Needs Info = Rejected -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
Sure, let me know if you have something up for review. -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Changed in: desktop-file-utils (upstream) Status: Unknown = Needs Info -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
Question from Upstream developers: --- Comment #2 From Vincent Untz 2007-06-03 12:41:54 PST [reply] --- Can you verify with the code that is in cvs? Basically, the validator has been rewritten, so it's very likely that this is already fixed. ** Changed in: desktop-file-utils (Ubuntu) Status: Confirmed = Needs Info -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
This issue is fixed in a new upstream version in CVS, I'll try to package it myself if that's ok. ** Description changed: - Binary package hint: desktop-file-utils - - The utility desktop-file-validator is reporting the Encoding entry as - missing if a .desktop file doesn't has it but, like you can read here - [1], this item is deprecated; it shouldn't complain if it isn't there, - and perhaps print a warning if it is. - - - [1] http://standards.freedesktop.org/desktop-entry-spec/latest/apc.html + There is a new version of desktop-file-utils that includes many + deprecations and new categories on FreeDesktop's repository. It would be + good to update the package to that new one. ** Tags added: needs-packaging ** Tags added: upgrade ** Tags removed: needs-packaging ** Changed in: desktop-file-utils (Ubuntu) Assignee: (unassigned) = RainCT Status: Needs Info = In Progress -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
Thank you for the continued work to improve desktop-file-validate. This patch applies cleanly, and seems to do many of the right things, but the resulting package does not compile for me. Separately, a few notes: 1) Line 741 of the resulting file compresses an else statement to a single line. Is there a strong reason for this? The typical GNOME practice is to use a separate line excepting when using an else if construction. 2) You probably don't need the definition of fix_encoding around line 924 -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Attachment added: validate.c.patch http://launchpadlibrarian.net/7932892/validate.c.patch -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Attachment added: validate.c.patch http://launchpadlibrarian.net/7933062/validate.c.patch -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Attachment added: validate.c.patch http://launchpadlibrarian.net/7933145/validate.c.patch -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
This patch looks great. Thanks a lot. The next step is to get this applied upstream. Please open a bug on http://bugzilla.gnome.org, assign to the desktop-file-utils product, and attach your patch. -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
Patch posted upstream: https://bugs.freedesktop.org/show_bug.cgi?id=11126 ** Bug watch added: Freedesktop Bugzilla #11126 https://bugs.freedesktop.org/show_bug.cgi?id=11126 ** Also affects: desktop-file-utils (upstream) via https://bugs.freedesktop.org/show_bug.cgi?id=11126 Importance: Unknown Status: Unknown -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
Following additional categories were missing (added them): Publishing Printing Chat TelephonyTools VideoConference ArtificialIntelligence ComputerScience DataVisualization Economy Electricity Geography Geoscience History ImageProcessing Literature NumericalAnalysis Robotics Sports ParallelComputing Compression Documentation -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
Deprecated keys: Encoding, FilePattern, Actions, SwallowTitle, SwallowExec Only for KDE keys: Dev, FSType, MountPoint, ReadOnly, UnmountIcon, SortOrder -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Attachment added: validate.c.patch http://librarian.launchpad.net/7870111/validate.c.patch -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
Okay, here you have the new one (generated a .deb and tested it, should be working fine). ** Attachment added: validate.c.patch http://librarian.launchpad.net/7859838/validate.c.patch -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Changed in: desktop-file-utils (Ubuntu) Assignee: RainCT = (unassigned) Status: In Progress = Confirmed -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
This patch applies cleanly, but I still don't believe it accomplishes
the goal of modifying validate.c so that encoding matches the other
deprecations. As far as I can see, for other cases where a specific
entry is deprecated, the upstream authors have removed the entire
handlers for those sections from the source. As we try not to have
significantly invasive patches in Ubuntu, I recommend that instead of
deleting these sections, you either wrap the entire section in a
comment, or prevent compilation if an #ifdef 0 .. #endif construction.
You no longer need the child functions, as you have defined TRUE for the
Encoding defnition (with { Encoding, validate_string, TRUE },
/* 0.9.5: deprecated */). This applies to both the section starting at
line 729 and the section starting at line 936.
--
Encoding is deprecated
https://bugs.launchpad.net/bugs/117180
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu.
--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Changed in: desktop-file-utils (Ubuntu) Importance: Undecided = Wishlist Status: Unconfirmed = Confirmed -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
The problem is in file src/validate.c on lines 950-955. ** Changed in: desktop-file-utils (Ubuntu) Status: Confirmed = Unconfirmed ** Changed in: desktop-file-utils (Ubuntu) Assignee: (unassigned) = RainCT Status: Unconfirmed = In Progress -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
Sorry, the last patch was wrong. Here is a working patch (compiled and tested it). It is commenting out all missing Encoding stuff, and prints a warning message when it find a Encoding item. ** Attachment added: validate.c.patch http://librarian.launchpad.net/7850001/validate.c.patch ** Changed in: desktop-file-utils (Ubuntu) Assignee: RainCT = (unassigned) Status: In Progress = Confirmed -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Changed in: desktop-file-utils (Ubuntu) Assignee: (unassigned) = Martin Peeks -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Changed in: desktop-file-utils (Ubuntu) Status: Confirmed = In Progress -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Changed in: desktop-file-utils (Ubuntu) Assignee: Martin Peeks = RainCT -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Changed in: desktop-file-utils (Ubuntu) Assignee: RainCT = (unassigned) ** Changed in: desktop-file-utils (Ubuntu) Status: In Progress = Confirmed ** Changed in: desktop-file-utils (Ubuntu) Status: Confirmed = In Progress -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
** Changed in: desktop-file-utils (Ubuntu) Assignee: (unassigned) = RainCT -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 117180] Re: Encoding is deprecated
Thanks for the patch. A few notes: 1) It's probably a good idea to add a comment around line 456 that Encoding is deprecated (see other comments in the area. Check the spec to see in which version it was deprecated. 2) You don't need to note the deprecation in the check. Try to more closely mirror the other deprecations 3) As a result of 2), Consider just wrapping lines 729 to 742 in a comment. When you send it upstream, they may consider removing it. -- Encoding is deprecated https://bugs.launchpad.net/bugs/117180 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug contact for desktop-file-utils in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
