Heads up: potential hash table ordering changes in GLib
Hi all, As a heads up, we’ve just merged some performance improvements to GHashTable, done by Hans Petter Jansson: https://gitlab.gnome.org/GNOME/glib/merge_requests/208 https://gitlab.gnome.org/GNOME/glib/issues/1198 https://hpjansson.org/blag/2018/08/29/what-ails-ghashtable/ https://hpjansson.org/blag/2018/07/24/a-hash-table-re-hash/ These may change the hash table iteration order. If you are using GHashTable incorrectly by relying on it to iterate over its entries in a particular order, this may break your code. You should fix this by either making your code independent of order, or sorting the entries once you’ve extracted them from the GHashTable (and before your order-dependent iteration over them). This is not a bug in GLib. To the best of my knowledge, we last changed iteration order in 2008, so some code written since then may break. Have fun, Philip signature.asc Description: This is a digitally signed message part ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Renaming gitg project file to GNOME Commits
There's also https://github.com/indie-mirror/gnomit ! Crowded namespace! On Wed, Oct 10, 2018 at 6:04 PM Hashem Nasarat wrote: > > GNOME Git seems pretty reasonable. I'm not sure there's a large > discoverability issue with "gitg" though. It shows up when I search "git" > in GNOME Software... > I don't know if we have a policy for "gnome front-ends to existing third > party tools", but there's already a small precedence with > https://github.com/vinszent/gnome-twitch#-gnome-twitch > > (Too bad https://github.com/bahmutov/ggit is a thing.) > > On Wed, Oct 10, 2018 at 5:50 PM Alberto Fanjul Alonso via > desktop-devel-list wrote: > >> Seing https://git-scm.com/downloads/guis and asumming GNOME is a >> desktop environment (GUI is supposed) maybe GNOME Git Tool, but tool is >> little redundant here, that's why looking for something that this git GUI >> Tool can do. Maybe GNOME Git Commits as it shows them (history) and creates >> them. >> >> El mié., 10 oct. 2018 a las 23:26, Milan Crha via desktop-devel-list (< >> desktop-devel-list@gnome.org>) escribió: >> >>> On Wed, 2018-10-10 at 08:34 +0200, Alberto Fanjul Alonso wrote: >>> > On gitg we are considering to adopt GNOME Commits as project name. >>> >>> Hi, >>> I'm used to gitk (which uses Qt, if I'm not mistaken). The gitg always >>> meant to me a gtk+ variant "of the same". I never looked for the real >>> reasoning behind the name (which you gave earlier). >>> >>> Can it work with anything else than git? I do commit to svn, I used to >>> commit to cvs as well. There are several other version systems where >>> users can "commit" their changes. I mean, "GNOME Commits" is too >>> generic, too vague. "GNOME git viewer" might be more accurate, but not >>> that fancy. I surely would not get rid of the 'git' word, especially >>> when it's the only version system it can work with. When searching for >>> 'git' in repositories, it would be nice to have git itself and "the >>> viewer" shown together. >>> >>> Just my opinion. >>> Bye, >>> Milan >>> >>> ___ >>> desktop-devel-list mailing list >>> desktop-devel-list@gnome.org >>> https://mail.gnome.org/mailman/listinfo/desktop-devel-list >>> >> ___ >> desktop-devel-list mailing list >> desktop-devel-list@gnome.org >> https://mail.gnome.org/mailman/listinfo/desktop-devel-list > > ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Renaming gitg project file to GNOME Commits
GNOME Git seems pretty reasonable. I'm not sure there's a large discoverability issue with "gitg" though. It shows up when I search "git" in GNOME Software... I don't know if we have a policy for "gnome front-ends to existing third party tools", but there's already a small precedence with https://github.com/vinszent/gnome-twitch#-gnome-twitch (Too bad https://github.com/bahmutov/ggit is a thing.) On Wed, Oct 10, 2018 at 5:50 PM Alberto Fanjul Alonso via desktop-devel-list wrote: > Seing https://git-scm.com/downloads/guis and asumming GNOME is a desktop > environment (GUI is supposed) maybe GNOME Git Tool, but tool is little > redundant here, that's why looking for something that this git GUI Tool can > do. Maybe GNOME Git Commits as it shows them (history) and creates them. > > El mié., 10 oct. 2018 a las 23:26, Milan Crha via desktop-devel-list (< > desktop-devel-list@gnome.org>) escribió: > >> On Wed, 2018-10-10 at 08:34 +0200, Alberto Fanjul Alonso wrote: >> > On gitg we are considering to adopt GNOME Commits as project name. >> >> Hi, >> I'm used to gitk (which uses Qt, if I'm not mistaken). The gitg always >> meant to me a gtk+ variant "of the same". I never looked for the real >> reasoning behind the name (which you gave earlier). >> >> Can it work with anything else than git? I do commit to svn, I used to >> commit to cvs as well. There are several other version systems where >> users can "commit" their changes. I mean, "GNOME Commits" is too >> generic, too vague. "GNOME git viewer" might be more accurate, but not >> that fancy. I surely would not get rid of the 'git' word, especially >> when it's the only version system it can work with. When searching for >> 'git' in repositories, it would be nice to have git itself and "the >> viewer" shown together. >> >> Just my opinion. >> Bye, >> Milan >> >> ___ >> desktop-devel-list mailing list >> desktop-devel-list@gnome.org >> https://mail.gnome.org/mailman/listinfo/desktop-devel-list >> > ___ > desktop-devel-list mailing list > desktop-devel-list@gnome.org > https://mail.gnome.org/mailman/listinfo/desktop-devel-list ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Renaming gitg project file to GNOME Commits
Seing https://git-scm.com/downloads/guis and asumming GNOME is a desktop environment (GUI is supposed) maybe GNOME Git Tool, but tool is little redundant here, that's why looking for something that this git GUI Tool can do. Maybe GNOME Git Commits as it shows them (history) and creates them. El mié., 10 oct. 2018 a las 23:26, Milan Crha via desktop-devel-list (< desktop-devel-list@gnome.org>) escribió: > On Wed, 2018-10-10 at 08:34 +0200, Alberto Fanjul Alonso wrote: > > On gitg we are considering to adopt GNOME Commits as project name. > > Hi, > I'm used to gitk (which uses Qt, if I'm not mistaken). The gitg always > meant to me a gtk+ variant "of the same". I never looked for the real > reasoning behind the name (which you gave earlier). > > Can it work with anything else than git? I do commit to svn, I used to > commit to cvs as well. There are several other version systems where > users can "commit" their changes. I mean, "GNOME Commits" is too > generic, too vague. "GNOME git viewer" might be more accurate, but not > that fancy. I surely would not get rid of the 'git' word, especially > when it's the only version system it can work with. When searching for > 'git' in repositories, it would be nice to have git itself and "the > viewer" shown together. > > Just my opinion. > Bye, > Milan > > ___ > desktop-devel-list mailing list > desktop-devel-list@gnome.org > https://mail.gnome.org/mailman/listinfo/desktop-devel-list > ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Renaming gitg project file to GNOME Commits
On Wed, Oct 10, 2018 at 11:26 PM Milan Crha via desktop-devel-list wrote: > I'm used to gitk (which uses Qt, if I'm not mistaken). gitk uses tk (as in Tcl/Tk). qgit uses Qt. > Can it work with anything else than git? No. -- Alexandre Franke GNOME Hacker ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Renaming gitg project file to GNOME Commits
On Wed, 2018-10-10 at 08:34 +0200, Alberto Fanjul Alonso wrote: > On gitg we are considering to adopt GNOME Commits as project name. Hi, I'm used to gitk (which uses Qt, if I'm not mistaken). The gitg always meant to me a gtk+ variant "of the same". I never looked for the real reasoning behind the name (which you gave earlier). Can it work with anything else than git? I do commit to svn, I used to commit to cvs as well. There are several other version systems where users can "commit" their changes. I mean, "GNOME Commits" is too generic, too vague. "GNOME git viewer" might be more accurate, but not that fancy. I surely would not get rid of the 'git' word, especially when it's the only version system it can work with. When searching for 'git' in repositories, it would be nice to have git itself and "the viewer" shown together. Just my opinion. Bye, Milan ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Renaming gitg project file to GNOME Commits
I'm fine with idea of giving it a fresh name. Gitg never really made sense to me, though I never knew the reasoning behind it. GNOME Commits might be clear to all people familiar with git, but for the average user they might think it's an activist app or something. Or like a charity app. This might not be a legitimate concern, just a thought On Tue, Oct 9, 2018, 11:35 PM Alberto Fanjul Alonso wrote: > On gitg we are considering to adopt GNOME Commits as project name. > > Same as nautilus is GNOME Files, we though that gitg (a joke around > gitx and software which at some point in time use to have a G around to > denote it is under GNOME) is not easy to locate for people looking for a > git GUI viewer. > > We want to be sure that do not cause any problem downstream or in > development. > > There's an open issue about that > https://gitlab.gnome.org/GNOME/gitg/issues/138 > > Side note: We are looking for a new icon, since now we use the one from > git. Drafts on: https://gitlab.gnome.org/GNOME/gitg/issues/137 > > thoughs? > ___ > desktop-devel-list mailing list > desktop-devel-list@gnome.org > https://mail.gnome.org/mailman/listinfo/desktop-devel-list ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Renaming gitg project file to GNOME Commits
On 10/10/2018 08:34 AM, Alberto Fanjul Alonso wrote: On gitg we are considering to adopt GNOME Commits as project name. Same as nautilus is GNOME Files, we though that gitg (a joke around gitx and software which at some point in time use to have a G around to denote it is under GNOME) is not easy to locate for people looking for a git GUI viewer. We want to be sure that do not cause any problem downstream or in development. There's an open issue about that https://gitlab.gnome.org/GNOME/gitg/issues/138 Side note: We are looking for a new icon, since now we use the one from git. Drafts on: https://gitlab.gnome.org/GNOME/gitg/issues/137 thoughs? With my downstream hat on, feel free to rename the visible name in the UI and the desktop file and appdata etc, but please don't change the project name from gitg, that just creates more work for downstreams. Thanks, Kalev ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Renaming gitg project file to GNOME Commits
On gitg we are considering to adopt GNOME Commits as project name. Same as nautilus is GNOME Files, we though that gitg (a joke around gitx and software which at some point in time use to have a G around to denote it is under GNOME) is not easy to locate for people looking for a git GUI viewer. We want to be sure that do not cause any problem downstream or in development. There's an open issue about that https://gitlab.gnome.org/GNOME/gitg/issues/138 Side note: We are looking for a new icon, since now we use the one from git. Drafts on: https://gitlab.gnome.org/GNOME/gitg/issues/137 thoughs? ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list