Re: Commit auto-links in bugzilla comments
Out of curiosity, is there anything wrong with just copy/pasting a link? You know, something like https://git.gnome.org/browse/gnome-shell/commit/?id=d54b87c4559bd9d74fa10d3e3d1e38a933bea051 I find that trying to remember crazy syntax and exceptions is a bit difficult. Does it work inside parens with immediate closing like (see also comment #13)? Does it work with and without the number sign? After a line-break, one like Bugzilla likes to auto-add? I've ran into so many exceptions it's hard to remember what's valid. On Wed, Feb 11, 2015 at 9:43 AM, Xavier Claessens xclae...@gmail.com wrote: Le mardi 10 février 2015 à 08:38 +0100, Milan Crha a écrit : Hello, I'd like to ask: how does the auto-links for commits in the new bugzilla work? I mean, if I write something like: commit abcde12345 then the abcde12345 will become a link to the sources in the product the current bug is filled for. It works similarly to bug auto-link references, which is nice. Related to this, I've proposed to also link branch wip/... in this bug: https://bugzilla.gnome.org/show_bug.cgi?id=744068 My problem is when one change for a product A requires also a change in product B and I reference commits for both products within one bug report. That may cause one of the commit links invalid. Is there a way to tell the comment parser that the commit itself belongs to another product than the one the bug is filled for? If we come with a way to specify the module, would be nice to adapt my patch likewise :) Regards, Xavier Claessens. ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list -- Jasper ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Commit auto-links in bugzilla comments
Le mardi 10 février 2015 à 08:38 +0100, Milan Crha a écrit : Hello, I'd like to ask: how does the auto-links for commits in the new bugzilla work? I mean, if I write something like: commit abcde12345 then the abcde12345 will become a link to the sources in the product the current bug is filled for. It works similarly to bug auto-link references, which is nice. Related to this, I've proposed to also link branch wip/... in this bug: https://bugzilla.gnome.org/show_bug.cgi?id=744068 My problem is when one change for a product A requires also a change in product B and I reference commits for both products within one bug report. That may cause one of the commit links invalid. Is there a way to tell the comment parser that the commit itself belongs to another product than the one the bug is filled for? If we come with a way to specify the module, would be nice to adapt my patch likewise :) Regards, Xavier Claessens. ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Commit auto-links in bugzilla comments
Le mardi 10 février 2015 à 08:38 +0100, Milan Crha a écrit : Hello, I'd like to ask: how does the auto-links for commits in the new bugzilla work? I mean, if I write something like: commit abcde12345 then the abcde12345 will become a link to the sources in the product the current bug is filled for. It works similarly to bug auto-link references, which is nice. Related to this, I've proposed to also link branch wip/... in this bug: https://bugzilla.gnome.org/show_bug.cgi?id=744068 My problem is when one change for a product A requires also a change in product B and I reference commits for both products within one bug report. That may cause one of the commit links invalid. Is there a way to tell the comment parser that the commit itself belongs to another product than the one the bug is filled for? If we come with a way to specify the module, would be nice to adapt my patch likewise :) Regards, Xavier Claessens. ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Commit auto-links in bugzilla comments
Le mercredi 11 février 2015 à 09:52 -0800, Jasper St. Pierre a écrit : Out of curiosity, is there anything wrong with just copy/pasting a link? You know, something like https://git.gnome.org/browse/gnome-shell/commit/?id=d54b87c4559bd9d74fa10d3e3d1e38a933bea051 There is nothing wrong with copy/pasting the link, but then you have to browse git.gnome.org to find the commit/branch link. The nice thing with letting bugzilla build the link is that all you need to know is the commit hash or branch name, and that info is in your terminal. I find that trying to remember crazy syntax and exceptions is a bit difficult. Does it work inside parens with immediate closing like (see also comment #13)? Does it work with and without the number sign? After a line-break, one like Bugzilla likes to auto-add? I've ran into so many exceptions it's hard to remember what's valid. It's indeed hidden secret, and the regex isn't always perfect the first time. Nobody is forced to use it, but IMO it's nice little trick that doesn't cost us much, does it? On Wed, Feb 11, 2015 at 9:43 AM, Xavier Claessens xclae...@gmail.com wrote: Le mardi 10 février 2015 à 08:38 +0100, Milan Crha a écrit : Hello, I'd like to ask: how does the auto-links for commits in the new bugzilla work? I mean, if I write something like: commit abcde12345 then the abcde12345 will become a link to the sources in the product the current bug is filled for. It works similarly to bug auto-link references, which is nice. Related to this, I've proposed to also link branch wip/... in this bug: https://bugzilla.gnome.org/show_bug.cgi?id=744068 My problem is when one change for a product A requires also a change in product B and I reference commits for both products within one bug report. That may cause one of the commit links invalid. Is there a way to tell the comment parser that the commit itself belongs to another product than the one the bug is filled for? If we come with a way to specify the module, would be nice to adapt my patch likewise :) Regards, Xavier Claessens. ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list -- Jasper ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Commit auto-links in bugzilla comments
On Wed, 2015-02-11 at 09:52 -0800, Jasper St. Pierre wrote: Out of curiosity, is there anything wrong with just copy/pasting a link? Hi, I did that for the past few months. My comments in bugzilla sometimes look like: Created commit 123456 in evo master (x.y.z+) [1] Created commit 987654 in eds master (x.y.z+) [2] [1] link-to-evo-commit-123456 [2] link-to-eds-commit-987654 where x.y.z+ is version when the fix will be included first. The thing is that since the update of the bugzilla the part of the text Created commit ... was recognized and the commit number had been underlined (made click-able). As you can see, one of the auto-links will be wrong in the example above, because one bug cannot be in both evolution-data-server and evolution. Such false-positive may make confusion to bug readers. That was the reason to start this thread. Bye, Milan ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Commit auto-links in bugzilla comments
On Tue, Feb 10, 2015 at 08:38:39AM +0100, Milan Crha wrote: Is there a way to tell the comment parser that the commit itself belongs to another product than the one the bug is filled for? I could add support for something like: module $FOO commit $BAR Just as now you can do: comment 13 bug 163163 comment 13 -- Regards, Olav ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Commit auto-links in bugzilla comments
On Tue, Feb 10, 2015 at 9:56 AM, Olav Vitters o...@vitters.nl wrote: On Tue, Feb 10, 2015 at 08:38:39AM +0100, Milan Crha wrote: Is there a way to tell the comment parser that the commit itself belongs to another product than the one the bug is filled for? I could add support for something like: module $FOO commit $BAR Just as now you can do: comment 13 bug 163163 comment 13 First of all, I'd like to point that the bug report for this feature is still open at https://bugzilla.gnome.org/show_bug.cgi?id=559537 We started discussing the commit in another product issue there, so maybe we can continue there? I would also like to point out that pushed as abcd123, the default phrase used by git-bz, creates the same link as commit abcd123, which is also a nice feature. -- Alexandre Franke ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Commit auto-links in bugzilla comments
On Tue, 2015-02-10 at 10:20 +0100, Alexandre Franke wrote: First of all, I'd like to point that the bug report for this feature is still open at https://bugzilla.gnome.org/show_bug.cgi?id=559537 We started discussing the commit in another product issue there, so maybe we can continue there? Hi, sure, I wasn't aware of the opened bug report (neither searched for it, due to not expecting any such exists). Thanks and bye, Milan ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Commit auto-links in bugzilla comments
Hello, I'd like to ask: how does the auto-links for commits in the new bugzilla work? I mean, if I write something like: commit abcde12345 then the abcde12345 will become a link to the sources in the product the current bug is filled for. It works similarly to bug auto-link references, which is nice. My problem is when one change for a product A requires also a change in product B and I reference commits for both products within one bug report. That may cause one of the commit links invalid. Is there a way to tell the comment parser that the commit itself belongs to another product than the one the bug is filled for? Bye, Milan ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
