Re: broken bug-buddy support in applets

2007-03-31 Thread Kjartan Maraas
fre, 30.03.2007 kl. 19.25 -0400, skrev Matthias Clasen:
 Hey,
 
 I noticed today that for virtually every applet I shot down with kill
 -BUS, bug-buddy
 claimed to not know it and did not offer to send out a bug report.
 The .server files
 of the applets did have the necessary bugzilla information, and
 debugging bug-buddy
 showed that it actually reads all this information.
 
 Looking into this a bit further, I found that the problem is most
 likely caused by the
 GOption conversion that was done a while ago... The bugzilla data in
 the the .server
 files has the binary name in other_binaries, but libgnomeui uses 
 g_get_prgname()
 when passing the appname to gnome_segv and then on to bug-buddy. E.g
 for the fish applet, the .server file has fish-applet-2, but bug-buddy gets
 That-stupid-fish as appname, because that is the string passed in to
 PANEL_APPLET_BONOBO_FACTORY().
 
 The options for fixing this are a) adding these other names to all the .server
 files or b) fixing libgnomeui/gnome_segv to pass the binary name down
 to bug-buddy.
 
 opinions ?
 
Fixing libgnomeui/gnome_segv sounds like the easiest route, and avoids
bloating the server files too?

Cheers
Kjartan


___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: broken bug-buddy support in applets

2007-03-31 Thread Loïc Minier
On Fri, Mar 30, 2007, Matthias Clasen wrote:
 I noticed today that for virtually every applet I shot down with kill
 -BUS, bug-buddy
 claimed to not know it and did not offer to send out a bug report.

 I couldn't find the corresponding bug in a quick search against
 libgnomeui and bug-buddy and I'm interested in tracking this issue;
 which bug # is this?   Thanks!

 (Thanks for bringing this up; I noticed this when testing bug-buddy
 2.18, but did not know where the regression came from.)

-- 
Loïc Minier
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: broken bug-buddy support in applets

2007-03-31 Thread Matthias Clasen
On 3/31/07, Loïc Minier [EMAIL PROTECTED] wrote:
 On Fri, Mar 30, 2007, Matthias Clasen wrote:
  I noticed today that for virtually every applet I shot down with kill
  -BUS, bug-buddy
  claimed to not know it and did not offer to send out a bug report.

  I couldn't find the corresponding bug in a quick search against
  libgnomeui and bug-buddy and I'm interested in tracking this issue;
  which bug # is this?   Thanks!

  (Thanks for bringing this up; I noticed this when testing bug-buddy
  2.18, but did not know where the regression came from.)

I haven't filed a bug yet, since I wasn't sure which way to take it.
I'lll file a libgnomeui  bug later.
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


broken bug-buddy support in applets

2007-03-30 Thread Matthias Clasen
Hey,

I noticed today that for virtually every applet I shot down with kill
-BUS, bug-buddy
claimed to not know it and did not offer to send out a bug report.
The .server files
of the applets did have the necessary bugzilla information, and
debugging bug-buddy
showed that it actually reads all this information.

Looking into this a bit further, I found that the problem is most
likely caused by the
GOption conversion that was done a while ago... The bugzilla data in
the the .server
files has the binary name in other_binaries, but libgnomeui uses g_get_prgname()
when passing the appname to gnome_segv and then on to bug-buddy. E.g
for the fish applet, the .server file has fish-applet-2, but bug-buddy gets
That-stupid-fish as appname, because that is the string passed in to
PANEL_APPLET_BONOBO_FACTORY().

The options for fixing this are a) adding these other names to all the .server
files or b) fixing libgnomeui/gnome_segv to pass the binary name down
to bug-buddy.

opinions ?


Matthias
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


bug-buddy support

2006-07-21 Thread Matthias Clasen
I noticed that bug-buddy refuses to file bugs against a number of core
desktop applications (I just found yelp and evince). I think we should
make an effort to ensure that all core desktop apps have the necessary
information in their .desktop files by 2.16.

Matthias
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: bug-buddy support

2006-07-21 Thread Jason D. Clinton
On Fri, 2006-07-21 at 12:35 -0400, Matthias Clasen wrote:
 I noticed that bug-buddy refuses to file bugs against a number of core
 desktop applications (I just found yelp and evince). I think we should
 make an effort to ensure that all core desktop apps have the necessary
 information in their .desktop files by 2.16.

I just noticed this as well. See bug #347679.

Pardon my ignorance as I have just become the maintainer but, when did
this change and what needs to be done?




signature.asc
Description: This is a digitally signed message part
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list

Bug buddy maintainer? (Was Re: bug-buddy support)

2006-07-21 Thread Brent Smith
Matthias Clasen wrote:
 On 7/21/06, Jason D. Clinton [EMAIL PROTECTED] wrote:
 On Fri, 2006-07-21 at 12:35 -0400, Matthias Clasen wrote:
 I noticed that bug-buddy refuses to file bugs against a number of core
 desktop applications (I just found yelp and evince). I think we should
 make an effort to ensure that all core desktop apps have the necessary
 information in their .desktop files by 2.16.
 I just noticed this as well. See bug #347679.

 Pardon my ignorance as I have just become the maintainer but, when did
 this change and what needs to be done?
 
 See, this is something that I would have expected the bug-buddy maintainers
 to announce to desktop-announce-list when they made these changes...

When I was hacking on bug-buddy a few months ago, I noticed that it uses
the gmenu API to find and add applications for which it reports bugs.
Unfortunately, this causes problems for programs which are not included
in the menus (like evince and yelp).  I don't know if this is how
bug-buddy worked with 2.14.0 or what, but I agree this is a rather large
problem.  One solution is to include our own bug-buddy.menu file without
any filters, but this doesn't solve the issue for applications with
NoDisplay=true in the .desktop file as I don't believe the gmenu API
returns these applications.

Bug-buddy is pretty much maintainerless from what I can tell - Fer is
not very active, and I have my hands full with Yelp.  Is there someone
out there that would be interested in taking bug-buddy by both reins?

--
Brent Smith [EMAIL PROTECTED]
IRC: smitten / #docs / irc.gnome.org
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: Bug buddy maintainer? (Was Re: bug-buddy support)

2006-07-21 Thread Sebastien Bacher
On ven, 2006-07-21 at 11:28 -0600, Brent Smith wrote:

 NoDisplay=true in the .desktop file as I don't believe the gmenu API
 returns these applications.

Since gnome-menus 2.13.5 there is a GMENU_TREE_FLAGS_INCLUDE_NODISPLAY
flag allowing to do that


Cheers,

Sebastien Bacher

___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: Bug buddy maintainer? (Was Re: bug-buddy support)

2006-07-21 Thread Sebastien Bacher
On ven, 2006-07-21 at 11:28 -0600, Brent Smith wrote:

 Unfortunately, this causes problems for programs which are not included
 in the menus (like evince and yelp)

I've attached a patch to bug #347422 that fixes that issue


Cheers,

Sebastien Bacher

___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: Bug buddy maintainer? (Was Re: bug-buddy support)

2006-07-21 Thread Fernando Herrera
On 7/21/06, Brent Smith [EMAIL PROTECTED] wrote:

 Bug-buddy is pretty much maintainerless from what I can tell - Fer is
 not very active, and I have my hands full with Yelp.  Is there someone
 out there that would be interested in taking bug-buddy by both reins?

Well, here it's Fer :)

I am sorry about the non-regular releases of bug-buddy (as well as
gconf-editor and gnome-keyring-manager) during last months.

As some of you know I move to Helsinki a month and a half ago. My home
computer arrived last week, and my home DSL connection is coming in 10
days. Also I hope to get proper access to {cvs,svn}.gnome.org at work
soon.

Anyway, I did my best to get new bug-buddy interface and internal
ready for 2.16, after the great work from Olav in bugzilla.gnome.org
and lot of help from Brent. I am sorry about breaking the command line
interface that yelp and other applications were using (it's a
developer release!) and will try to fix it ASAP. Of course, any help
with bug-buddy (as with any other module in GNOME) is very welcome.


   Fer, from a mobile phone connection.

Salu2
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: Bug buddy maintainer? (Was Re: bug-buddy support)

2006-07-21 Thread Jason D. Clinton
On Fri, 2006-07-21 at 21:06 +0200, Fernando Herrera wrote:
 Anyway, I did my best to get new bug-buddy interface and internal
 ready for 2.16, after the great work from Olav in bugzilla.gnome.org
 and lot of help from Brent. I am sorry about breaking the command line
 interface that yelp and other applications were using (it's a
 developer release!) and will try to fix it ASAP. Of course, any help
 with bug-buddy (as with any other module in GNOME) is very welcome.

Besides the command line changes, what else must be done?




signature.asc
Description: This is a digitally signed message part
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: Bug buddy maintainer? (Was Re: bug-buddy support)

2006-07-21 Thread Matthias Clasen
On 7/21/06, Jason D. Clinton [EMAIL PROTECTED] wrote:
 On Fri, 2006-07-21 at 21:06 +0200, Fernando Herrera wrote:
  Anyway, I did my best to get new bug-buddy interface and internal
  ready for 2.16, after the great work from Olav in bugzilla.gnome.org
  and lot of help from Brent. I am sorry about breaking the command line
  interface that yelp and other applications were using (it's a
  developer release!) and will try to fix it ASAP. Of course, any help
  with bug-buddy (as with any other module in GNOME) is very welcome.

 Besides the command line changes, what else must be done?


You need to add something to the .desktop file to convince bug-buddy
to consider your app. Check out a desktop file of an app that bug-buddy
does recognize for the details.
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: Bug buddy maintainer? (Was Re: bug-buddy support)

2006-07-21 Thread Jason D. Clinton
On Fri, 2006-07-21 at 15:20 -0400, Matthias Clasen wrote:
 You need to add something to the .desktop file to convince bug-buddy
 to consider your app. Check out a desktop file of an app that bug-buddy
 does recognize for the details.

I do appreciate your help but I was hoping for something a little more
definitive.

What is it?
Which parts are mandatory? Optional?
How long has it been there?
Is it going to change again?
Does it need to be translated?



signature.asc
Description: This is a digitally signed message part
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: Bug buddy maintainer? (Was Re: bug-buddy support)

2006-07-21 Thread Fernando Herrera
On 7/21/06, Matthias Clasen [EMAIL PROTECTED] wrote:
 On 7/21/06, Jason D. Clinton [EMAIL PROTECTED] wrote:
  On Fri, 2006-07-21 at 21:06 +0200, Fernando Herrera wrote:
   Anyway, I did my best to get new bug-buddy interface and internal
   ready for 2.16, after the great work from Olav in bugzilla.gnome.org
   and lot of help from Brent. I am sorry about breaking the command line
   interface that yelp and other applications were using (it's a
   developer release!) and will try to fix it ASAP. Of course, any help
   with bug-buddy (as with any other module in GNOME) is very welcome.
 
  Besides the command line changes, what else must be done?
 

 You need to add something to the .desktop file to convince bug-buddy
 to consider your app. Check out a desktop file of an app that bug-buddy
 does recognize for the details.


Yeah, they are:

[example for gnome-calculator .desktop file]

X-GNOME-Bugzilla-Bugzilla=GNOME
X-GNOME-Bugzilla-Product=gcalctool
X-GNOME-Bugzilla-Component=general
X-GNOME-Bugzilla-OtherBinaries=gnome-calculator

and they were needed for bug-buddy for years. However when I merged
the new xmlrpc branch I added a little utility on bug-buddy/src for
verifying installed applications. Running it on my laptop (jhbuild
gnome 2.16 moduleset) complains about these applications missing
X-GNOME-Bugzilla info (only for those applicatrions having a
Categories=GNOME in the .desktop file):
gnome-nettool
evolution-2.6

However this tool is not checking that the product/component stored in
.desktop file actually matches anything in bugzilla server (for
example gnome-panel one is broken right now). To solve this problem
(outdated .desktop file product/component after bugzilla renaming, for
example) we were planning (Olav, correct me if I am wrong here) to
have some kind of fallback matching magic on our bugzilla server

Salu2
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


Re: Bug buddy maintainer? (Was Re: bug-buddy support)

2006-07-21 Thread Matthias Clasen
On 7/21/06, Jason D. Clinton [EMAIL PROTECTED] wrote:
 On Fri, 2006-07-21 at 15:20 -0400, Matthias Clasen wrote:
  You need to add something to the .desktop file to convince bug-buddy
  to consider your app. Check out a desktop file of an app that bug-buddy
  does recognize for the details.

 I do appreciate your help but I was hoping for something a little more
 definitive.

 What is it?
 Which parts are mandatory? Optional?
 How long has it been there?
 Is it going to change again?
 Does it need to be translated?

I don't know any of this. And I guess we are not alone in this...
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list


[Fwd: Re: Bug buddy maintainer? (Was Re: bug-buddy support)]

2006-07-21 Thread Jason D. Clinton
Here is the information everyone needs. Apparently mistakenly sent only
to me.


---BeginMessage---

Hi,

On 7/21/06, Jason D. Clinton [EMAIL PROTECTED] wrote:

I do appreciate your help but I was hoping for something a little more
definitive.

What is it?


Metainformation about the application used to report bugs on out BTS


Which parts are mandatory? Optional?


X-GNOME-Bugzilla-Bugzilla=GNOME -- Mandatory
X-GNOME-Bugzilla-Product=XXX --Mandatory
X-GNOME-Bugzilla-Component=YYY -- Mandatory
X-GNOME-Bugzilla-OtherBinaries=ZZZ -- Optional, only if you
application has several binaries
X-GNOME-Bugzilla-Version=X.Y.Z -- Optional, and should need expansion
from configure script, so if you want this you need a
application.desktop.in.in to expand here @VERSION@
(application.desktop.in is used by intltool for translations).


How long has it been there?


circa 2002


Is it going to change again?


No and yes. If you refer at the field names, they haven't changed
since 2002 (X-GNOME-Bugzilla-Version was added on 2003). If you mean
the values, bugzilla product/component could be changed if the
maintainer ask the bugmaster to do it and should update the info in
the desktop file after the change. As I mentioned on a previous email,
afer this product/component renaming would break any old instalation
of the application for submiting bugs, but we are working on a server
side fallback to solve it.

Does it need to be translated?


Hope this helps.

Salu2
---End Message---


signature.asc
Description: This is a digitally signed message part
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: Bug buddy maintainer? (Was Re: bug-buddy support)

2006-07-21 Thread Matthias Clasen
On 7/21/06, Fernando Herrera [EMAIL PROTECTED] wrote:

 Yeah, they are:

 [example for gnome-calculator .desktop file]

 X-GNOME-Bugzilla-Bugzilla=GNOME
 X-GNOME-Bugzilla-Product=gcalctool
 X-GNOME-Bugzilla-Component=general
 X-GNOME-Bugzilla-OtherBinaries=gnome-calculator

Can you explain what other values bug-buddy supports for
the Bugzilla entry ?
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/desktop-devel-list