Created attachment 118203 Allow font library to return Suspended more than once per request
fonts: Continue when font calls return Suspended more than once Patch 3ab6cd31cbdf8095b2948034fce5fb645422d8da fixed Xinerama interactions with font servers by not putting clients to sleep multiple times. However, it introduced additional changes dealing with libXfont routine returning Suspended more than once for the same request. This additional change was to abandon processing of the current request and free the closure data by jumping to 'xinerama_sleep' in each of the functions. Font library functions shouldn't return Suspended more than once, except for ListFontsWithInfo, which produces multiple replies, and thus ends up returning Suspended many times during processing. With the jump to xinerama_sleep occurring after the first reply was processed, the closure for the request was freed and future calls into the ListFontsWithInfo callback resulted in dereferencing freed memory. This patch removes the added branches, reverting the code to its previous behaviour, which permitted multiple Suspended returns and simply waited for the client to be signaled again so that the callback could continue processing the request. Signed-off-by: Keith Packard <kei...@keithp.com> Cc: Adam Jackson <a...@redhat.com> -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to xorg-server in Ubuntu. https://bugs.launchpad.net/bugs/738526 Title: crash accessing font info with xfs in fontpath Status in X.Org X server: Confirmed Status in xorg-server package in Ubuntu: Incomplete Status in xorg-server package in Debian: Confirmed Bug description: This occurs even AFTER the fix released in https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/650539 . So please do not mark this bug "duplicate" without first reopening 650539. Symptoms are exactly the same, when I try to launch Google Earth, Skype or certain other apps my X session crashes. I am running on a 64bit machine with Ubuntu 10.10, nvidia-current 260.19.06-0ubuntu1 and xserver-xorg-core 2:1.9.0-0ubuntu7.3. Also happens with xserver-xorg-core 2:1.9.0-0ubuntu7.1. To manage notifications about this bug go to: https://bugs.launchpad.net/xorg-server/+bug/738526/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp