[Desktop-packages] [Bug 357864]

2015-03-25 Thread Neil-httl
Created attachment 8583150
Revised patch

Now resets the From address correctly when you select the current
identity from the drop-down, adds a one-time warning dialog, and removes
the Linux/OSX CSS because that wasn't working in its current state.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-03-25 Thread Neil-httl
(In reply to Ben Bucksch from comment #146)
> Please note that there's a minor UI glitch here: We have 2 dropdown arrows,
> as you can see in the screenshot. They both have the same effect. When
> clicking the right one, the left one even shows a pressed state.

OK, so this is to do with the changes in bug 906264; they don't play
nicely with editable menulists on Linux (the editable menulist looks
fine with them removed; there's also a good chance that they're causing
problems on Mac too.) I don't know whether I should remove them or just
file a bug to get them updated to work with editable menulists.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-03-24 Thread Neil-httl
(In reply to Thomas D. from comment #151)
> Clicking at the low end of a dropdown to
> edit the current entry at the top is bad UX imo.

So, top of the dropdown then? Or do you prefer attachment 8574154?

(In reply to Ben Bucksch from comment #147)
> when I select the same identity that I originally selected, I do not
> return to the original From address, but my edited one stays.

Huh, I wonder why that happens.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-03-07 Thread Neil-httl
Created attachment 8574154
Screenshot showing the moved menuitem

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-03-04 Thread Neil-httl
Created attachment 8572084
Possible patch

I hid the option in the Options menu where it might be less
discoverable.

(In reply to Thomas D. from comment #132)
> - allow editing only after double-click on sender (plus first-time warning)
Probably not possible because the popup code gets in the way.
Also, what do you do from the keyboard?

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-03-03 Thread Neil-httl
(In reply to Josiah Bruner from comment #128)
> The backend changes in this patch causes it to not apply, that's all I was
> noting. :)
Sure, but they'll get merged out when I update anyway.

> What platform have you tested this on?
Windows and Linux.

(In reply to Ben Bucksch from comment #129)
> * If you really want to pref this feature away, I think the best way would
> be a checkbox in "Account Settings..." | "Manage Identities...".
So, the presence of the "customize" option would depend on which identity you 
had selected?

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-02-28 Thread Neil-httl
(In reply to Josiah Bruner from comment #125)
> - "Customize From Address" is confusing. “Enter a custom address” perhaps?
OK (but see below)

> - If you choose a custom address (which focuses the field), and then you
> deselect the field, and click it again, we should show the drop down (don't
> keep it editable).
You and your drop down again. What's going wrong on your system that you can't 
use an editable drop down? Making the field uneditable would unedit the custom 
address, so that's pointless.

> - What if users try to use it as a separate address and they don’t actually 
> have the account added to TB. Any replies to it will never show up.
This is already possible via the multiple identity support.

> I like the drop down UI though, just needs an option to pick the server.
It uses the server of the address that you customised. (But then again you 
would know that if your editable drop down was working.)

> *customize please. :)
;-)

> All of this is unnecessary now because of your backend changes landing.
Well you didn't have review authority over it anyway.

Just to check your editable drop down, please can you try the following steps:
* Open an HTML Compose window
* Click in the message body area
* Format - Page Colours and Background
* Advanced Edit...
Under Attribute there should be a dropdown that gives you the options of 
background, bgcolor, text, link, vlink, alink, id, class, title, lang and dir 
but is also editable.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-02-11 Thread Neil-httl
Comment on attachment 8562431
Fixed fix

https://hg.mozilla.org/comm-central/rev/c3bf5c52ce41

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-02-11 Thread Neil-httl
Created attachment 8562431
Fixed fix

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-02-09 Thread Neil-httl
Created attachment 8561373
Test fix

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-02-09 Thread Neil-httl
Comment on attachment 8551328
Backend changes

https://hg.mozilla.org/comm-central/rev/6fe2526c838f

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-02-06 Thread Neil-httl
(In reply to Joshua Cranmer from comment #118)
> > +  from = MimeHeaders_get(mdd->headers, HEADER_FROM, false, false);
> 
> This hunk seems unnecessary?

I accidentally already checked it in without review, so this is post-
facto review, so to speak.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-01-23 Thread Neil-httl
Created attachment 8553148
Possible patch

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-01-20 Thread Neil-httl
Created attachment 8551328
Backend changes

While you bikeshed over the UI, let me get the backend changes reviewed
(or post-facto reviewed in the case of the second hunk).

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-01-05 Thread Neil-httl
(In reply to Josiah Bruner from comment #108)
> > +  from = MimeHeaders_get(mdd->headers, HEADER_FROM, false, false);
> 
> This is obsolete now (and the patch fails to apply because of it).

Whoops I accidentally checked that line in as part of bug 11039.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-01-05 Thread Neil-httl
(In reply to Josiah Bruner from comment #109)
> It would also be preferable to allow clicking the drop down icon to always
> bring up the list, regardless of the field's current state.

It does on sane platforms, thus the original version always had the
field editable.

Just to make sure that we're looking at the same thing here, there are
other editable lists in the UI. The easiest one is the advanced
attribute editor. Compose an HTML message, then go to Format - Page
Colours and Background, then click Advanced Edit. On the bottom left is
an editable list of commonly used attributes (background, bgcolor, text,
link, vlink, alink, id, class, title, lang, dir).

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2015-01-05 Thread Neil-httl
(In reply to comment #111)
> It does on sane platforms

OK that was a bit harsh but I can't reproduce your problems on Windows.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2014-11-19 Thread Neil-httl
Created attachment 8525381
Possible patch

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2014-10-21 Thread Neil-httl
Created attachment 8507858
87987.png

This is what I get locally... are you not seeing this?

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2014-10-16 Thread Neil-httl
(In reply to Josiah Bruner from comment #97)
> This completely removes the ability to choose from your accounts

It wasn't supposed to... what are you seeing?

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 357864]

2014-09-19 Thread Neil-httl
Created attachment 8491619
Possible patch

This seems to work, it even remembers the address you entered if you
save a draft and reopen it later.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/357864

Title:
  Editing the "From" field for the current email only (as text, not
  dropdown)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: thunderbird

  I want to quite often use a particular email address (e.g. for writing
  to a mailing list), where I do not have added the email address to the
  account settings yet.

  However, Thunderbird does not allow to edit the From field, but only
  provides the configured email addresses in a dropdown.

  It would be nice, if you could also edit the From field in a text
  input.

  KMail provides this, for example, and there appear to be some
  extensions for it, but I'd like to avoid using an addon for this, but
  rather think it's a nice feature to have by default.

  I could imagine, that the last entry in the dropdown would say
  "Edit..." or "Custom..." and change the dropdown into a text field.

  ProblemType: Bug
  Architecture: i386
  DistroRelease: Ubuntu 9.04
  NonfreeKernelModules: nvidia
  Package: mozilla-thunderbird 2.0.0.21+nobinonly-0ubuntu1
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, user)
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  Uname: Linux 2.6.28-11-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/357864/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 222635]

2014-04-23 Thread Neil-httl
(In reply to Masatoshi Kimura from comment #82)
> Comment on attachment 8398925
> Part 2: Read charset from the channel
> 
> This part is no longer needed with the follow-up patch of bug 989576.

Although, would it be nice to emit a  tag if we
know that the charset is UTF-8 so that we don't have to detect it later
on (and report that annoying warning to the console)?

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/222635

Title:
  firefox ftp client don't understand links in cyrillic letters

Status in The Mozilla Firefox Browser:
  Fix Released
Status in “firefox” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: firefox-3.0

  Ubuntu 8.04
   3.0~b5+nobinonly-0ubuntu2

  When ftp session is open and I want to follow a link that contains
  cyrillic letters in, Firefox getting an error

  ProblemType: Bug
  Architecture: i386
  Date: Sat Apr 26 19:59:05 2008
  DistroRelease: Ubuntu 8.04
  NonfreeKernelModules: nvidia
  Package: firefox-3.0 3.0~b5+nobinonly-0ubuntu2
  PackageArchitecture: i386
  ProcEnviron:
   PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
   LANG=ru_RU.UTF-8
   SHELL=/bin/bash
  SourcePackage: firefox-3.0
  Uname: Linux 2.6.24-16-generic i686

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/222635/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 214366]

2014-02-23 Thread Neil-httl
(In reply to aceman from comment #125)
> I knew octal literals are deprecated so somehow I extended that to hex too.
> Thanks.

The only reason old-style octal literals are deprecated is because it's
too easy to confuse them with decimal literals e.g. 160 - 060 != 100.
Hex literals and new-style octal literals (0o60) are fine, of course.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366

Title:
  Can't delete a folder if Trash already contains a folder of the same
  name

Status in Mozilla Thunderbird Mail and News:
  In Progress
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  1. Create a new folder, eg. "Temp"
  2. Delete it, OK
  3. Create the same folder again
  4. Delete it, OK

  I expect it to be moved to my Trash folder, perhaps with a suffix
  appended (it being the second instance of that folder in the trash).

  Thunderbird popped up an error message. On an imap host:
 The current command did not succeed. The mail server responded: Mailbox 
already exists.
  In the local folders:
 A folder with that name already exists. Please enter a different name (!)

  Workarounds:
  1. Empty the trash
  2. Rename the folder before deletion
  3. Rename the folder already in the trash
  4. Delete (permanently) the folder that is already in the trash

  Ubuntu 7.10 Gutsy
  thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 214366]

2014-02-23 Thread Neil-httl
Comment on attachment 8377817
patch v5

>+  rv = bundle->FormatStringFromName(MOZ_UTF16("confirmDuplicateFolderRename"),
>+formatStrings, 3, 
>getter_Copies(confirmString));
If you'd used MOZ_ARRAY_LENGTH(formatStrings) it would have saved you the 
trouble of changing it each time ;-)

>+  } catch (e if e.result == 0x8055001a) {
>+// catch only the expected error, otherwise fail the test.
Nice!

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366

Title:
  Can't delete a folder if Trash already contains a folder of the same
  name

Status in Mozilla Thunderbird Mail and News:
  In Progress
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  1. Create a new folder, eg. "Temp"
  2. Delete it, OK
  3. Create the same folder again
  4. Delete it, OK

  I expect it to be moved to my Trash folder, perhaps with a suffix
  appended (it being the second instance of that folder in the trash).

  Thunderbird popped up an error message. On an imap host:
 The current command did not succeed. The mail server responded: Mailbox 
already exists.
  In the local folders:
 A folder with that name already exists. Please enter a different name (!)

  Workarounds:
  1. Empty the trash
  2. Rename the folder before deletion
  3. Rename the folder already in the trash
  4. Delete (permanently) the folder that is already in the trash

  Ubuntu 7.10 Gutsy
  thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 214366]

2014-02-18 Thread Neil-httl
(In reply to aceman from comment #123)
> (In reply to comment #122)
> > (From update of attachment 8374439)
> Is this issue really that important that we make tens of comments in such a
> long thread? It is not a perf critical path.

I'm after readability here, not perf, in particular I don't like
breaking at the end of a for loop, because it's easy to miss that this
skips the increment.

> > >+  try {
> > >+root.copyFolderLocal(folderDeleted3, true, null, null);
> > >+do_throw("copyFolderLocal() should have failed here due to user 
> > >prompt!");
> > I'm not sure why you're trying to throw from inside this try block, but I
> > don't know enough about writing tests to know whether there's a better way.
> I expect .copyFolderLocal to throw and be catched by my catch. But if it
> does not throw (wrong behaviour), the next throw is not catched and fails
> the test.
Sure, but my question is is it safe to put do_throw in a try block?

> > >+  } catch (e) {
> > >+do_check_eq(e.result, parseInt("0x8055001a", 16));
> > Why not just write 0x8055001a?
> Because e.result returns the code in decimal. Is there other method of 'e' I
> can use?

nsIException.idl (if that's the right one) says that result is an
unsigned long, not a decimal. So I don't see why you can't compare it to
any other integer.

> > >+confirmDuplicateFolderRename=A folder with that name already exists under 
> > >folder '%1$S'. Would you like to copy the folder under a new name of 
> > >'%2$S'?
> > A subfolder with that name already exists in the folder '%1$S'. Would you
> > like to move the folder using the new name of '%2$S'?
> 
> Irving proposed some other wording with more arguments. So what should I do
> now?

Sorry, I hadn't seen his wording. How about:
A subfolder with the name '%$1S' already exists in the folder '%2$S'. Would you 
like to move this folder using the new name of '%3$S'?
(I don't really want to use a / because that's an implementation detail.)

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366

Title:
  Can't delete a folder if Trash already contains a folder of the same
  name

Status in Mozilla Thunderbird Mail and News:
  In Progress
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  1. Create a new folder, eg. "Temp"
  2. Delete it, OK
  3. Create the same folder again
  4. Delete it, OK

  I expect it to be moved to my Trash folder, perhaps with a suffix
  appended (it being the second instance of that folder in the trash).

  Thunderbird popped up an error message. On an imap host:
 The current command did not succeed. The mail server responded: Mailbox 
already exists.
  In the local folders:
 A folder with that name already exists. Please enter a different name (!)

  Workarounds:
  1. Empty the trash
  2. Rename the folder before deletion
  3. Rename the folder already in the trash
  4. Delete (permanently) the folder that is already in the trash

  Ubuntu 7.10 Gutsy
  thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 214366]

2014-02-15 Thread Neil-httl
Comment on attachment 8374439
WIP patch 4

>+bool containsChild = true;
>+uint32_t i;
>+for (i = 1; ; i++) {
>+  newFolderName.Assign(folderName);
>+  if (i > 1) {
>+// This could be localizable but Toolkit is fine without it, see
>+// mozilla/toolkit/content/contentAreaUtils.js::uniqueFile()
>+newFolderName.Append('(');
>+newFolderName.AppendInt(i);
>+newFolderName.Append(')');
>+  }
>+  rv = ContainsChildNamed(newFolderName, &containsChild);
>+  if (NS_WARN_IF(NS_FAILED(rv))) {
>+return rv;
>+  }
>+  if (!containsChild)
>+break;
>+}
Did you mean for (i = 1; containsChild; i++) ? Note that if you do this then i 
ends the loop being at least 2, so you'd need to change the subsequent check. 
Alternatively, you would have to rewrite the loop something like this (sorry if 
this is what the code did in one of the earlier patches):

uint32_t i = 1;
newFolderName.Assign(folderName);
for (;;) {
  bool containsChild;
  rv = ContainsChildNamed(newFolderName, &containsChild);
  NS_ENSURE_SUCCESS(rv, rv);
  if (!containsChild)
break;

  i++;
  newFolderName.Assign(folderName);
  newFolderName.Append('(');
  newFolderName.AppendInt(i);
  newFolderName.Append(')');
}

>+  try {
>+root.copyFolderLocal(folderDeleted3, true, null, null);
>+do_throw("copyFolderLocal() should have failed here due to user prompt!");
I'm not sure why you're trying to throw from inside this try block, but I don't 
know enough about writing tests to know whether there's a better way.

>+  } catch (e) {
>+do_check_eq(e.result, parseInt("0x8055001a", 16));
Why not just write 0x8055001a?

>+confirmDuplicateFolderRename=A folder with that name already exists under 
>folder '%1$S'. Would you like to copy the folder under a new name of '%2$S'?
A subfolder with that name already exists in the folder '%1$S'. Would you like 
to move the folder using the new name of '%2$S'?

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366

Title:
  Can't delete a folder if Trash already contains a folder of the same
  name

Status in Mozilla Thunderbird Mail and News:
  In Progress
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  1. Create a new folder, eg. "Temp"
  2. Delete it, OK
  3. Create the same folder again
  4. Delete it, OK

  I expect it to be moved to my Trash folder, perhaps with a suffix
  appended (it being the second instance of that folder in the trash).

  Thunderbird popped up an error message. On an imap host:
 The current command did not succeed. The mail server responded: Mailbox 
already exists.
  In the local folders:
 A folder with that name already exists. Please enter a different name (!)

  Workarounds:
  1. Empty the trash
  2. Rename the folder before deletion
  3. Rename the folder already in the trash
  4. Delete (permanently) the folder that is already in the trash

  Ubuntu 7.10 Gutsy
  thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 214366]

2014-02-09 Thread Neil-httl
Comment on attachment 8371072
WIP patch 3

>+  nsAutoString newFolderName(EmptyString());
[Strings default to empty...]

>+while (containsChild) {
>+  rv = ContainsChildNamed(newFolderName, &containsChild);
>+  NS_ENSURE_SUCCESS(rv, rv);
>+  if (!containsChild)
>+break;
[Weird use of loop condition.]

>+  newFolderName.AppendLiteral("(");
[Could use Append('(');]

>+confirmDuplicateFolderRename=A folder with that name already exists. Would 
>you like to copy the folder under a different name?
You should include the suggested new folder name in the message, otherwise the 
user will expect to choose the new name.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366

Title:
  Can't delete a folder if Trash already contains a folder of the same
  name

Status in Mozilla Thunderbird Mail and News:
  In Progress
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  1. Create a new folder, eg. "Temp"
  2. Delete it, OK
  3. Create the same folder again
  4. Delete it, OK

  I expect it to be moved to my Trash folder, perhaps with a suffix
  appended (it being the second instance of that folder in the trash).

  Thunderbird popped up an error message. On an imap host:
 The current command did not succeed. The mail server responded: Mailbox 
already exists.
  In the local folders:
 A folder with that name already exists. Please enter a different name (!)

  Workarounds:
  1. Empty the trash
  2. Rename the folder before deletion
  3. Rename the folder already in the trash
  4. Delete (permanently) the folder that is already in the trash

  Ubuntu 7.10 Gutsy
  thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 214366]

2014-02-09 Thread Neil-httl
Comment on attachment 8371072
WIP patch 3

>+newFolderName.Assign(folderName);
>+bool containsChild = true;
>+uint32_t i = 1;
>+while (containsChild) {
>+  rv = ContainsChildNamed(newFolderName, &containsChild);
>+  NS_ENSURE_SUCCESS(rv, rv);
>+  if (!containsChild)
>+break;
>+  // This could be localizable but Toolkit is fine without it, see
>+  // mozilla/toolkit/content/contentAreaUtils.js::uniqueFile()
>+  i++;
>+  newFolderName.Assign(folderName);
>+  newFolderName.AppendLiteral("(");
>+  newFolderName.AppendInt(i);
>+  newFolderName.AppendLiteral(")");
>+}
bool containsChild;
rv = ContainsChildNamed(folderName, &containsChild);
NS_ENSURE_SUCCESS(rv, rv);
while (containsChild) {
  i++;
  newFolderName.Assign(folderName);
  newFolderName.AppendLiteral("(");
  newFolderName.AppendInt(i);
  newFolderName.AppendLiteral(")");
  rv = ContainsChildNamed(newFolderName, &containsChild);
  NS_ENSURE_SUCCESS(rv, rv);
}

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366

Title:
  Can't delete a folder if Trash already contains a folder of the same
  name

Status in Mozilla Thunderbird Mail and News:
  In Progress
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  1. Create a new folder, eg. "Temp"
  2. Delete it, OK
  3. Create the same folder again
  4. Delete it, OK

  I expect it to be moved to my Trash folder, perhaps with a suffix
  appended (it being the second instance of that folder in the trash).

  Thunderbird popped up an error message. On an imap host:
 The current command did not succeed. The mail server responded: Mailbox 
already exists.
  In the local folders:
 A folder with that name already exists. Please enter a different name (!)

  Workarounds:
  1. Empty the trash
  2. Rename the folder before deletion
  3. Rename the folder already in the trash
  4. Delete (permanently) the folder that is already in the trash

  Ubuntu 7.10 Gutsy
  thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 214366]

2014-02-06 Thread Neil-httl
(In reply to aceman from comment #81)
> Neil is this still a wrong place to do it and can you propose a better one
> that David Bienvenu was talking about?
Well, as I see it there are two options:
1. Make moving a folder automatically rename if the destination already exists, 
but allow copies to continue to merge the folders. (This was a lifesaver for me 
when I was moving mail between two accounts and hadn't provided sufficient 
quota on the destination account first.) Also make this work for IMAP.
2. Propagate the optional destination folder name throughout the mailnews 
codebase, including the copy service and the imap service. Then you would 
update the two implementations of DeleteSubFolders to handle the duplicate 
folder name case.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366

Title:
  Can't delete a folder if Trash already contains a folder of the same
  name

Status in Mozilla Thunderbird Mail and News:
  In Progress
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  1. Create a new folder, eg. "Temp"
  2. Delete it, OK
  3. Create the same folder again
  4. Delete it, OK

  I expect it to be moved to my Trash folder, perhaps with a suffix
  appended (it being the second instance of that folder in the trash).

  Thunderbird popped up an error message. On an imap host:
 The current command did not succeed. The mail server responded: Mailbox 
already exists.
  In the local folders:
 A folder with that name already exists. Please enter a different name (!)

  Workarounds:
  1. Empty the trash
  2. Rename the folder before deletion
  3. Rename the folder already in the trash
  4. Delete (permanently) the folder that is already in the trash

  Ubuntu 7.10 Gutsy
  thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 214366]

2014-02-06 Thread Neil-httl
Comment on attachment 8370331
WIP patch 2

>+  PRUint32 i = 2;
>+  nsAutoString newFolderNameUnderTrash(folderName);
>+  while (1) {
>+rv = CheckIfFolderExists(newFolderNameUnderTrash, this, NULL);
>+if (rv == NS_MSG_FOLDER_EXISTS) {
>+  newFolderNameUnderTrash.Assign(folderName);
>+  newFolderNameUnderTrash.AppendLiteral("-"); // do we want this 
>localizable? "-"
>+  newFolderNameUnderTrash.AppendInt(i);
>+  i++;
>+} else if (NS_SUCCEEDED(rv)) {
>+  // NS_OK so the tried folder name doesn't exist
>+  break;
>+} else {
>+  return rv;
>+}
>+  }
CheckIfFolderExists is overkill if you don't want to alert, use 
ContainsChildNamed instead. Also, the loop is horribly written, though maybe 
you might think my version is going too far the other way:
bool containsChild;
for (int32_t i = 2; ContainsChildNamed(destFolderName, &containsChild), 
containsChild; i++) {
  // compute new folder name
}

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366

Title:
  Can't delete a folder if Trash already contains a folder of the same
  name

Status in Mozilla Thunderbird Mail and News:
  In Progress
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  1. Create a new folder, eg. "Temp"
  2. Delete it, OK
  3. Create the same folder again
  4. Delete it, OK

  I expect it to be moved to my Trash folder, perhaps with a suffix
  appended (it being the second instance of that folder in the trash).

  Thunderbird popped up an error message. On an imap host:
 The current command did not succeed. The mail server responded: Mailbox 
already exists.
  In the local folders:
 A folder with that name already exists. Please enter a different name (!)

  Workarounds:
  1. Empty the trash
  2. Rename the folder before deletion
  3. Rename the folder already in the trash
  4. Delete (permanently) the folder that is already in the trash

  Ubuntu 7.10 Gutsy
  thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 214366]

2014-02-06 Thread Neil-httl
(In reply to aceman from comment #89)
> (In reply to Irving Reid from comment #88)
> > I don't think this needs to be localizable.
> I think it should be localizable if it is not complicated.
It doesn't need to be localisable (compare uniqueFile from contentAreaUtils.js).

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366

Title:
  Can't delete a folder if Trash already contains a folder of the same
  name

Status in Mozilla Thunderbird Mail and News:
  In Progress
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  1. Create a new folder, eg. "Temp"
  2. Delete it, OK
  3. Create the same folder again
  4. Delete it, OK

  I expect it to be moved to my Trash folder, perhaps with a suffix
  appended (it being the second instance of that folder in the trash).

  Thunderbird popped up an error message. On an imap host:
 The current command did not succeed. The mail server responded: Mailbox 
already exists.
  In the local folders:
 A folder with that name already exists. Please enter a different name (!)

  Workarounds:
  1. Empty the trash
  2. Rename the folder before deletion
  3. Rename the folder already in the trash
  4. Delete (permanently) the folder that is already in the trash

  Ubuntu 7.10 Gutsy
  thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 214366]

2014-02-06 Thread Neil-httl
(In reply to aceman from comment #95)
> In nsMsgLocalMailFolder::CopyFolder it seems when we are moving folder then
> it calls CopyFolderLocal (which I am touching). If we are copying then it
> calls CopyFolderAcrossServer (which I do not touch). So if
> CopyFolderAcrossServer merges, then all is fine. Is that what you meant?

Technically yes, but that's more by luck than design.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366

Title:
  Can't delete a folder if Trash already contains a folder of the same
  name

Status in Mozilla Thunderbird Mail and News:
  In Progress
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  1. Create a new folder, eg. "Temp"
  2. Delete it, OK
  3. Create the same folder again
  4. Delete it, OK

  I expect it to be moved to my Trash folder, perhaps with a suffix
  appended (it being the second instance of that folder in the trash).

  Thunderbird popped up an error message. On an imap host:
 The current command did not succeed. The mail server responded: Mailbox 
already exists.
  In the local folders:
 A folder with that name already exists. Please enter a different name (!)

  Workarounds:
  1. Empty the trash
  2. Rename the folder before deletion
  3. Rename the folder already in the trash
  4. Delete (permanently) the folder that is already in the trash

  Ubuntu 7.10 Gutsy
  thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 237341]

2013-12-01 Thread Neil-httl
Comment on attachment 8337339
fix bucket groups to be based off of a calendar week concept

Sorry for the delay. The code seems reasonable but this needs to have
ui-review before I can review it properly.

>+// TODO - in the calculation for thisWeek, the + 0 should be based of off
>+// the localization for first day of calendar
If only it were that easy...

As a side note I'd like to compare to Firefox's History sidebar which uses the 
following groupings:
> Today
> Yesterday
> Last 7 days
> This month (if today is the 8th or later)
> 5 entries, one for each previous month
> Older than 6 months

Out of interest, Outlook seems to be use the following groupings:
> Today
> Yesterday
> 5 entries, one for each previous day
> Last Week (7-13 days ago)
> Two Weeks Ago (14-20 days ago)
> Three Weeks Ago (21-27 days ago)
> Earlier This Month
> Last Month
> Older
What I don't know is whether these groups are based on the day of the week or 
fixed numbers of days.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/237341

Title:
  mozilla-thunderbird locates 2/6/2008 as last week in 4/6/2008

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  Hi,

  Thunderbird version 2.0.0.14 (20080502) 
  Folowing this menus (Translating from my menus localiced in ES_es)
  View => Order => Desc.
  View => Order => Group

  Today is wensday 04/jun/2008, and monday 04/jun/2008 appears in last
  week.

  ProblemType: Bug
  Architecture: i386
  Date: Wed Jun  4 14:46:46 2008
  Dependencies:
   
  DistroRelease: Ubuntu 7.10
  NonfreeKernelModules: vmnet vmmon
  Package: mozilla-thunderbird None
  PackageArchitecture: all
  SourcePackage: thunderbird
  Uname: Linux Pesc11-128 2.6.22-14-generic #1 SMP Tue Feb 12 07:42:25 UTC 2008 
i686 GNU/Linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/237341/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 191006]

2013-05-31 Thread Neil-httl
I still would like to know what choice this patch actually gives you.
(The string somewhat unhelpfully says "Continue?" which suggests that it
gives you the choice of using up lots of CPU and memory now or annoying
you with another prompt again in 100 minutes.)

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/191006

Title:
  Thunderbird RSS should have a per feed limit per download

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  Steps to reproduce:

  Open Thunderbird 2.0.0.9 in the last version of Ubuntu 8.04 (wrote at
  february 11, 2007).

  Thunderbird starts some task that uses 10% of CPU (centrino duo
  1,8GHz) and a very high amount of physical memory.

  In two minutes, 217 MB. In one hour, 400+ MB.

  I currently have 3 e-mail accounts and 5 RSS subscriptions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/191006/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 191006]

2013-05-30 Thread Neil-httl
Comment on attachment 755964
updated for comments

>+  mLastModified: null,
Not sure how this change relates.

>-  win.updateStatusItem("statusText", message, aErrorCode);
>+  let code = feed.url.startsWith("http") ? aErrorCode : null;
>+  win.updateStatusItem("statusText", message, code);
Not sure how this change relates.

>-onunload="return FeedSubscriptions.onUnload();"
>+onclose="return FeedSubscriptions.onClose();"
Not sure how this change relates.

>+  HIGH_COUNT_LIMIT_SUBSCRIBE: 200,
>+  HIGH_COUNT_LIMIT_UPDATE: 1000,
>+  CANCEL_REQUESTED: false,
What happens when there are too many items? (By comparison, for newsgroups, you 
can choose to either download the latest N (ignoring the rest) or the next N, 
although I don't know whether the RSS code would be able to let you do this. 
Also, N is pref-controlled, although we can leave that to a separate bug.)
Also, wouldn't it be more likely for there to be many items when you first 
subscribe? (I know a feed that only used to update every few days or so but the 
RSS feed contained the entire archive should you so want it.)

>+  confirmHighItemCount: function(aFeed, aCount) {
Where does this actually get called?

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/191006

Title:
  Thunderbird RSS should have a per feed limit per download

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in “thunderbird” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: mozilla-thunderbird

  Steps to reproduce:

  Open Thunderbird 2.0.0.9 in the last version of Ubuntu 8.04 (wrote at
  february 11, 2007).

  Thunderbird starts some task that uses 10% of CPU (centrino duo
  1,8GHz) and a very high amount of physical memory.

  In two minutes, 217 MB. In one hour, 400+ MB.

  I currently have 3 e-mail accounts and 5 RSS subscriptions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/191006/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 209509]

2013-02-11 Thread Neil-httl
(In reply to alexander surkov from comment #78)
> Mounir, I assume you use @value attribute on that xul:label. Is it possible
> to switch to text node instead?
He can't *switch* to text node because he requires the crop behaviour, but I 
believe the value attribute takes priority over the text node so that if he 
provides both then it will show cropped text but obviously I don't know whether 
the accessibility code will see the text node. (Is it possible to query the 
accessible tree in DOM Inspector to find out?)

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/209509

Title:
   does not accept textual input

Status in XUL + XPCOM application runner:
  In Progress
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Won't Fix
Status in “firefox-3.5” package in Ubuntu:
  Won't Fix

Bug description:
  Binary package hint: firefox

  Firefox 3 (3.0~b4+nobinonly-0ubuntu1) immediately opens a "file upload" 
dialog when I click on the file name field. Ff should only open this dialog if 
click on [Browse...]. Even after I close the dialog window I can neither input 
a file name directly into the field nor can I remove the file from the input 
field.
  It should be as easy editable as in firefox 2.

  I use Hardy amd64.

To manage notifications about this bug go to:
https://bugs.launchpad.net/xulrunner/+bug/209509/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 41179]

2013-01-25 Thread Neil-httl
Comment on attachment 706354
Store Master Password to Gnome Keyring patch v1

You need build system and PSM reviews, so I'll just comment on code
patterns.

>+  PRUnichar *password = nullptr;
>+  nsAutoString promptString;
>+  
>+  // Get prompt message for Gnome Keyring master password
>+  nsCOMPtr nssComponent(do_GetService(kNSSComponentCID, 
>&rv));
>+  if (NS_FAILED(rv))
>+return;
>+
>+  const PRUnichar* formatStrings[1] = { 
>+ToNewUnicode(NS_LITERAL_STRING("Gnome Keyring"))
>+  };
NS_NAMED_LITERAL_STRING gnomeKeyring("Gnome Keyring");
const PRUnichar* formatStrings[] = { gnomeKeyring.get() };
Or since this is linux-only, MOZ_LL, NS_LL or u"Gnome Keyring" might work.
This avoids having to free the string manually.

>+// Return if promp was closed without confirmation or password is 
>wrong
Typo: prompt

>+if (value)
[I had to look up the .idl to find out what this value meant.]

>+  nsCString utf8password;
>+  utf8password = NS_ConvertUTF16toUTF8(password);
>+  NS_Free(password);
>+  password = nullptr;
>+  if (gnome_keyring_unlock_sync(NULL, utf8password.get()) == 
>GNOME_KEYRING_RESULT_OK)
gnome_keyring_unlock_sync(NULL, NS_ConvertUTF16toUTF8(password).get())

>+mResult = g_strdup(keyringRecord->secret);
[Does this get freed with g_free?]

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/41179

Title:
  Integrate with Gnome Keyring

Status in The Mozilla Firefox Browser:
  Confirmed
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “xulrunner-1.9” package in Ubuntu:
  Won't Fix
Status in “xulrunner-1.9.1” package in Ubuntu:
  Triaged

Bug description:
  For a really good Gnome integration, it would be great to have the
  ability to save passwords in the Gnome keyring.

  A similar thing has been proposed for Epiphany: see
  https://launchpad.net/malone/bugs/3467.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/41179/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 411358]

2012-11-15 Thread Neil-httl
Comment on attachment 680081
fix for gconf v1

Sorry, we can't accept a diff against the mozilla-beta part of a comm-
beta checkout. If you think the issue affects Thunderbird 17 then you
will need to submit a patch against mozilla-central and get it uplifted
to mozilla-beta.

Also I'm not a reviewer for toolkit/system/gnome, please try karlt
instead.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/411358

Title:
  Thunderbird2 gconf gmt problem 'Bad key or directory name' because of
  plus symbol (+)

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in “thunderbird” package in Ubuntu:
  Confirmed

Bug description:
  Here is an error message for Thunderbird 2 in Jaunty

  gnubyexample@k8amd:~$ thunderbird
  GConf Error: Bad key or directory name: 
"/desktop/gnome/url-handlers/GMT+02/command": `+' is an invalid character in 
key/directory names
  gnubyexample@k8amd:~$ date;uname -a;cat /etc/*version*;dpkg -l | grep 
underbird
  Sun Aug  9 14:48:37 BST 2009  
  
  Linux k8amd 2.6.28-14-generic #47-Ubuntu SMP Sat Jul 25 00:28:35 UTC 2009 
i686 GNU/Linux
  5.0   
  
  ii  enigmail   2:0.95.7-1ubuntu2  
Enigmail - GPG support for Thunderbird
  ii  thunderbird
2.0.0.22+build1+nobinonly-0ubuntu0.9.04.1  mail/news client 
with RSS and integrated spam filter support 

 
  ii  thunderbird-locale-en-gb   1:2.0.0.14+1-0ubuntu2  
Thunderbird English language/region package  

  From reading this extract ( 
http://osdir.com/ml/os.solaris.opensolaris.desktop/2008-03/msg00020.html ):
Subject:Re: GConf/Thunderbird error on Solaris Nevada

"Hi Mats,I believe you download the contribute builds of Thunderbird 2, and 
run
  it on snv_70.

  For some reason, the fix is upstreamed to Thunderbird 3 alpha, but not
  community version of Thunderbird 2.
  Fixed in snv_68 means the fix was integrated to Thunderbird bundled
  with snv_68."

  
  ...it seems that the fix for this in thunderbird2 might require some manual 
intervention as although the problem is well know, the fix was only 
incorporated in the newer thunderbird3.

  Have just checked the Karmic version at:
http://packages.ubuntu.com/karmic/thunderbird
  which currently shows that version 2 of thunderbird is planned for Karmic 
release.

  As thunderbird3 is at Beta 3 right now I can perhaps see why debian and 
ubuntu are sticking with Thunderbird2 just now.
http://www.mozillamessaging.com/en-US/about/press/archive/2009-07-21-01

  However it does seem a shame to ship a new release with this known
  gconf issue unpatched.

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/411358/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2012-03-12 Thread Neil-httl
If I've done my sums right, you should find that it's currently
available in Firefox Aurora, will become available in Beta on the 13th,
and then released on the 24th of April. (If you think 17 weeks is a long
time to wait, don't forget that Firefox 4 came out 14 months after
Firefox 3.6!)

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  Fix Released
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-12-31 Thread Neil-httl
Fair enough, and I can put the test back too, but I might as well use
bug 714164.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  Fix Released
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-12-25 Thread Neil-httl
Pushed changeset 4d0391866459 to mozilla-central.

(In reply to dindog from comment #56)
> Neil, would you please look into the copy menuitem too?
Yes, I'll do copy (but not select all, because it's harder) in bug 692153.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  Fix Released
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-12-24 Thread Neil-httl
> warnings: 24
> failure: 15
Most of these are hidden; 3 randomorange show up on tbpl by default.
More oranges and the reds show up with noignore or via self-serve but they're 
all Lion, Tegra and/or Jetpack so nobody cares about them.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-12-24 Thread Neil-httl
Created attachment 584062
With test fixes (for check in)

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-12-22 Thread Neil-httl
test_showcaret.xul: uses cmd_scrollBottom, got renamed to cmd_moveBottom
test_selection_move_commands.xul: many renames...
test_movement_by_characters/word.html: rely on the buggy behaviour!

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-12-22 Thread Neil-httl
test_movement_by_characters.html's reliance on this bug is due to it
failing to focus the content before performing the navigation.

test_movement_by_words.html has the above bug but did also find a real
bug; with this patch, you can't move by words to the very end of a
contenteditable area, because it tries to move right out of the
contenteditable area...

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-12-22 Thread Neil-httl
test_selection_move_commands actually tests for the broken commands.
Sigh...

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-11-25 Thread Neil-httl
(In reply to dindog from comment #44)
> Neil, any news about this bug?
ehsan, should I be asking someone else for review?

> It affects Fx9+(current beta), if we don't fix it in Fx11, then user have to
> wait at least 3*6=18 weeks before thay can copy text in those page again...

(In reply to dindog from comment #45)
> Sorry, I mistaken this bug for bug 692153.
Actually it turned out to be fairly straightforward to adapt this patch to 
apply to Copy, but it won't help with the Select All case.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-10-28 Thread Neil-httl
Created attachment 570250
Fixed patch

So, I ended up having to separate the cursor movement commands into
their own command table so that I could append that controller for
textareas and inputs.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-10-28 Thread Neil-httl
So, things didn't go quite as well as I'd hoped.

Text areas and input fields need to have the editor behaviour.
Design mode and contenteditable windows need to have the global behaviour.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-10-26 Thread Neil-httl
Created attachment 569554
Proposed patch

The names of the commands are configured in three places:
* GTK2 Native keybindings
* Editor bindings (editor-base.inc and libeditor)
* Browser bindings (browser-base.inc and nsGlobalWindowCommands)
The browser bindings have six differences to the other two sets of bindings,
all cmd_scroll* names, which I have renamed for consistency.
The browser bindings were missing implementations for selecting by page.
The stubs also used the wrong command names, so I corrected that too.
This then allowed me to remove the editor implementation.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-10-26 Thread Neil-httl
(In reply to Ehsan Akhgari from comment #40)
> Does my test case pass with this patch?
Yes, it does.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-10-14 Thread Neil-httl
(In reply to Ehsan Akhgari from comment #37)
> If so, we can get them landed.  :-)

Except it's very much proof of concept (although I wouldn't mind landing
the nsFocusManager.cpp change which would be necessary anyway).

In particular, I'm not sure a) which keys need to be changed b) whether
those keys should map to the same commands in textareas and
browsers/editors c) how native Linux key bindings fit in.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-10-11 Thread Neil-httl
Created attachment 565950
Fixed proof of concept

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-08-19 Thread Neil-httl
(In reply to Neil Deakin from comment #28)
> (In reply to n...@parkwaycc.co.uk from comment #27)
> > (In reply to Neil Deakin from comment #26)
> > > Expected:
> > >   The caret moves up/down a line
> > Well, that's what I get locally. Does caret browsing work in your build?
> I get the same whether caret browsing is enabled or not.
Sorry, I wasn't clear, I meant caret browsing in general, not just in editable 
areas.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 107247]

2011-08-19 Thread Neil-httl
(In reply to Neil Deakin from comment #26)
> Expected:
>   The caret moves up/down a line
Well, that's what I get locally. Does caret browsing work in your build?

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/107247

Title:
  Launchpad bug pages trigger caret browsing in Firefox and other Gecko
  browsers

Status in The Mozilla Firefox Browser:
  In Progress
Status in Launchpad itself:
  Fix Released
Status in “firefox” package in Ubuntu:
  Won't Fix
Status in “firefox-3.0” package in Ubuntu:
  Triaged
Status in “firefox-3.5” package in Ubuntu:
  Triaged

Bug description:
  It is possible for a Web page to turn on Firefox's "caret browsing"
  mode just for that page, such that Firefox displays a cursor in the
  Web page text and prevents scrolling from working as normal. This
  should never happen.

  This bug was triggered by bug 107376 in a previous version of
  Launchpad, suggesting that the general cause is JavaScript focusing a
  text field, and then using CSS to hide that field. It seems unrelated
  to the document.designMode DOM property, because the page did not
  become editable.

  Steps to reproduce:
  1. In Firefox or Epiphany, open any bug page, such as this one.
  2. Wait for the Subscribers box to finish loading.
  3. Press the Up or Down arrow keys.

  What should happen: The page scrolls.
  What actually happens: A visible caret moves through the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/107247/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp