subject:"\[Desktop\-packages\] \[Bug 1862056\] Re\: Theme\: use other exported colors"

[Desktop-packages] [Bug 1862056] Re: Theme: use other exported colors

2020-02-11 Thread Frederik Feichtmeier

Here is the MR: https://gitlab.gnome.org/GNOME/gnome-
software/merge_requests/421

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1862056

Title:
  Theme: use other exported colors

Status in gnome-software package in Ubuntu:
  Fix Released

Bug description:
  Adwaita and Yaru both export colors at the top of their CSS file from within 
this source files:
  
https://gitlab.gnome.org/GNOME/gtk/blob/master/gtk/theme/Adwaita/_colors-public.scss#L84
  
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/_colors-public.scss

  gnome-software uses some of those colors in their in-app CSS that overwrites 
the global gtk theme:
  https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css

  Most likely those are the correct colors. In three cases sadly not and
  it is too late to get an upstream change for 20.04 now because gnome
  is already in UI freeze for this cycle:

  1) The round checkmarks inside the App boxes that show that the app is
  installed are orange instead of green, which is semantically wrong
  since they are not selected and should instead show that you
  successfully installed that app:

  
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L12
  Change
  .installed-icon {
color: @theme_selected_bg_color;
  }
  to
  .installed-icon {
color: @success_color;
  }
  
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/_colors-public.scss#L84
  -> exported to: 
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/gtk-contained.css#L2021


  2) The little [1] boxes inside the "stackswitcher" in the headerbar (it's 
actually a buttonbox in this case, but this is offtopic) that show up if you 
are either installing X apps or have X updates would be orange, if we would not 
"hack" a bg box-shadow over them to make them green. This is first of all a 
dirty hack and secondly there are little orange pixels showing up at the 
rounding
  Change
  .counter-label {
...
...
background-color: mix(@theme_selected_bg_color, 
@theme_selected_fg_color, 0.3);
...
...
...
  }

  To
  .counter-label {
...
...
background-color: @success_color;
...
...
...
  }
  
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L422

  3) The "given" stars are not visible in both Adwaita and Yaru dark. For some 
reason, upstream transparentizes them into oblivion with the "shade-function". 
The enabled stars should just use the theme's fg color:
  Change
  .star-enabled,
  .star-enabled:disabled {
color: shade(@theme_fg_color, 0.8);
  }
  to
  .star-enabled,
  .star-enabled:disabled {
color: @theme_fg_color;
  }
  
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L412

  Thank you very much in advance! I try to get this into gnome-shell's
  upstream repo in the next cycle

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1862056/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

[Desktop-packages] [Bug 1862056] Re: Theme: use other exported colors

2020-02-10 Thread Frederik Feichtmeier

** Attachment added: "Bildschirmfoto-20200211084652-1252x893.png"
   
https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1862056/+attachment/5327256/+files/Bildschirmfoto-20200211084652-1252x893.png

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1862056

Title:
  Theme: use other exported colors

Status in gnome-software package in Ubuntu:
  Fix Released

Bug description:
  Adwaita and Yaru both export colors at the top of their CSS file from within 
this source files:
  
https://gitlab.gnome.org/GNOME/gtk/blob/master/gtk/theme/Adwaita/_colors-public.scss#L84
  
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/_colors-public.scss

  gnome-software uses some of those colors in their in-app CSS that overwrites 
the global gtk theme:
  https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css

  Most likely those are the correct colors. In three cases sadly not and
  it is too late to get an upstream change for 20.04 now because gnome
  is already in UI freeze for this cycle:

  1) The round checkmarks inside the App boxes that show that the app is
  installed are orange instead of green, which is semantically wrong
  since they are not selected and should instead show that you
  successfully installed that app:

  
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L12
  Change
  .installed-icon {
color: @theme_selected_bg_color;
  }
  to
  .installed-icon {
color: @success_color;
  }
  
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/_colors-public.scss#L84
  -> exported to: 
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/gtk-contained.css#L2021


  2) The little [1] boxes inside the "stackswitcher" in the headerbar (it's 
actually a buttonbox in this case, but this is offtopic) that show up if you 
are either installing X apps or have X updates would be orange, if we would not 
"hack" a bg box-shadow over them to make them green. This is first of all a 
dirty hack and secondly there are little orange pixels showing up at the 
rounding
  Change
  .counter-label {
...
...
background-color: mix(@theme_selected_bg_color, 
@theme_selected_fg_color, 0.3);
...
...
...
  }

  To
  .counter-label {
...
...
background-color: @success_color;
...
...
...
  }
  
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L422

  3) The "given" stars are not visible in both Adwaita and Yaru dark. For some 
reason, upstream transparentizes them into oblivion with the "shade-function". 
The enabled stars should just use the theme's fg color:
  Change
  .star-enabled,
  .star-enabled:disabled {
color: shade(@theme_fg_color, 0.8);
  }
  to
  .star-enabled,
  .star-enabled:disabled {
color: @theme_fg_color;
  }
  
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L412

  Thank you very much in advance! I try to get this into gnome-shell's
  upstream repo in the next cycle

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1862056/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

[Desktop-packages] [Bug 1862056] Re: Theme: use other exported colors

2020-02-10 Thread Frederik Feichtmeier

Hey! Awesome it got fixed to fast, just received the update in 20.04
daily :) Cheers!

I will try to get this into upstream, since it makes more sense for them
too!

--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1862056

Title:
Theme: use other exported colors

Status in gnome-software package in Ubuntu:
Fix Released

Bug description:
Adwaita and Yaru both export colors at the top of their CSS file from within
this source files:

https://gitlab.gnome.org/GNOME/gtk/blob/master/gtk/theme/Adwaita/_colors-public.scss#L84

https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/_colors-public.scss

gnome-software uses some of those colors in their in-app CSS that overwrites
the global gtk theme:
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css

Most likely those are the correct colors. In three cases sadly not and
it is too late to get an upstream change for 20.04 now because gnome
is already in UI freeze for this cycle:

1) The round checkmarks inside the App boxes that show that the app is
installed are orange instead of green, which is semantically wrong
since they are not selected and should instead show that you
successfully installed that app:

https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L12
Change
.installed-icon {
color: @theme_selected_bg_color;
}
to
.installed-icon {
color: @success_color;
}

https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/_colors-public.scss#L84
-> exported to:
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/gtk-contained.css#L2021

2) The little [1] boxes inside the "stackswitcher" in the headerbar (it's
actually a buttonbox in this case, but this is offtopic) that show up if you
are either installing X apps or have X updates would be orange, if we would not
"hack" a bg box-shadow over them to make them green. This is first of all a
dirty hack and secondly there are little orange pixels showing up at the
rounding
Change
.counter-label {
...
...
background-color: mix(@theme_selected_bg_color,
@theme_selected_fg_color, 0.3);
...
...
...
}

To
.counter-label {
...
...
background-color: @success_color;
...
...
...
}

https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L422

3) The "given" stars are not visible in both Adwaita and Yaru dark. For some
reason, upstream transparentizes them into oblivion with the "shade-function".
The enabled stars should just use the theme's fg color:
Change
.star-enabled,
.star-enabled:disabled {
color: shade(@theme_fg_color, 0.8);
}
to
.star-enabled,
.star-enabled:disabled {
color: @theme_fg_color;
}

https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L412

Thank you very much in advance! I try to get this into gnome-shell's
upstream repo in the next cycle

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1862056/+subscriptions

--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp

[Desktop-packages] [Bug 1862056] Re: Theme: use other exported colors

2020-02-10 Thread Launchpad Bug Tracker

This bug was fixed in the package gnome-software - 3.35.2-0ubuntu2

---
gnome-software (3.35.2-0ubuntu2) focal; urgency=medium

  * d/p/0029-Fix-CSS-colors-to-work-correctly-with-Yaru-Adwaita.patch:
- Use theme exported colors (LP: #1862056)
  * d/p/0001-GsApp-Add-a-new-do-not-auto-update-quirk.patch:
  * d/p/0002-fwupd-Use-new-GS_APP_QUIRK_DO_NOT_AUTO_UPDATE.patch:
  * d/p/0003-snap-Stop-snaps-from-being-automatically-updated.patch:
- Stop snaps being automatically updated (LP: #1862158)

 -- Robert Ancell   Tue, 11 Feb 2020
12:07:52 +1300

** Changed in: gnome-software (Ubuntu)
   Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1862056

Title:
  Theme: use other exported colors

Status in gnome-software package in Ubuntu:
  Fix Released

Bug description:
  Adwaita and Yaru both export colors at the top of their CSS file from within 
this source files:
  
https://gitlab.gnome.org/GNOME/gtk/blob/master/gtk/theme/Adwaita/_colors-public.scss#L84
  
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/_colors-public.scss

  gnome-software uses some of those colors in their in-app CSS that overwrites 
the global gtk theme:
  https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css

  Most likely those are the correct colors. In three cases sadly not and
  it is too late to get an upstream change for 20.04 now because gnome
  is already in UI freeze for this cycle:

  1) The round checkmarks inside the App boxes that show that the app is
  installed are orange instead of green, which is semantically wrong
  since they are not selected and should instead show that you
  successfully installed that app:

  
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L12
  Change
  .installed-icon {
color: @theme_selected_bg_color;
  }
  to
  .installed-icon {
color: @success_color;
  }
  
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/_colors-public.scss#L84
  -> exported to: 
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/gtk-contained.css#L2021


  2) The little [1] boxes inside the "stackswitcher" in the headerbar (it's 
actually a buttonbox in this case, but this is offtopic) that show up if you 
are either installing X apps or have X updates would be orange, if we would not 
"hack" a bg box-shadow over them to make them green. This is first of all a 
dirty hack and secondly there are little orange pixels showing up at the 
rounding
  Change
  .counter-label {
...
...
background-color: mix(@theme_selected_bg_color, 
@theme_selected_fg_color, 0.3);
...
...
...
  }

  To
  .counter-label {
...
...
background-color: @success_color;
...
...
...
  }
  
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L422

  3) The "given" stars are not visible in both Adwaita and Yaru dark. For some 
reason, upstream transparentizes them into oblivion with the "shade-function". 
The enabled stars should just use the theme's fg color:
  Change
  .star-enabled,
  .star-enabled:disabled {
color: shade(@theme_fg_color, 0.8);
  }
  to
  .star-enabled,
  .star-enabled:disabled {
color: @theme_fg_color;
  }
  
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L412

  Thank you very much in advance! I try to get this into gnome-shell's
  upstream repo in the next cycle

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1862056/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

[Desktop-packages] [Bug 1862056] Re: Theme: use other exported colors

2020-02-10 Thread Robert Ancell

** Changed in: gnome-software (Ubuntu)
 Assignee: (unassigned) => Robert Ancell (robert-ancell)

** Changed in: gnome-software (Ubuntu)
   Status: Confirmed => Triaged

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1862056

Title:
  Theme: use other exported colors

Status in gnome-software package in Ubuntu:
  Triaged

Bug description:
  Adwaita and Yaru both export colors at the top of their CSS file from within 
this source files:
  
https://gitlab.gnome.org/GNOME/gtk/blob/master/gtk/theme/Adwaita/_colors-public.scss#L84
  
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/_colors-public.scss

  gnome-software uses some of those colors in their in-app CSS that overwrites 
the global gtk theme:
  https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css

  Most likely those are the correct colors. In three cases sadly not and
  it is too late to get an upstream change for 20.04 now because gnome
  is already in UI freeze for this cycle:

  1) The round checkmarks inside the App boxes that show that the app is
  installed are orange instead of green, which is semantically wrong
  since they are not selected and should instead show that you
  successfully installed that app:

  
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L12
  Change
  .installed-icon {
color: @theme_selected_bg_color;
  }
  to
  .installed-icon {
color: @success_color;
  }
  
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/_colors-public.scss#L84
  -> exported to: 
https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/gtk/theme/Adwaita/gtk-contained.css#L2021


  2) The little [1] boxes inside the "stackswitcher" in the headerbar (it's 
actually a buttonbox in this case, but this is offtopic) that show up if you 
are either installing X apps or have X updates would be orange, if we would not 
"hack" a bg box-shadow over them to make them green. This is first of all a 
dirty hack and secondly there are little orange pixels showing up at the 
rounding
  Change
  .counter-label {
...
...
background-color: mix(@theme_selected_bg_color, 
@theme_selected_fg_color, 0.3);
...
...
...
  }

  To
  .counter-label {
...
...
background-color: @success_color;
...
...
...
  }
  
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L422

  3) The "given" stars are not visible in both Adwaita and Yaru dark. For some 
reason, upstream transparentizes them into oblivion with the "shade-function". 
The enabled stars should just use the theme's fg color:
  Change
  .star-enabled,
  .star-enabled:disabled {
color: shade(@theme_fg_color, 0.8);
  }
  to
  .star-enabled,
  .star-enabled:disabled {
color: @theme_fg_color;
  }
  
https://gitlab.gnome.org/GNOME/gnome-software/blob/master/src/gtk-style.css#L412

  Thank you very much in advance! I try to get this into gnome-shell's
  upstream repo in the next cycle

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1862056/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

[Desktop-packages] [Bug 1862056] Re: Theme: use other exported colors

2020-02-10 Thread Robert Ancell

Frederik - can you propose these changes upstream now? Even though may
not land, they're worth discussing now to confirm they are correct. It's
also not too hard to get a freeze exception if the change is obviously
correct.

--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-software in Ubuntu.
https://bugs.launchpad.net/bugs/1862056

Title:
Theme: use other exported colors

Status in gnome-software package in Ubuntu:
Confirmed