[Desktop-packages] [Bug 1901290] Re: [SRU] Enchant-2 does not work properly with backends that want a NUL-terminated string

2020-11-17 Thread Launchpad Bug Tracker
This bug was fixed in the package enchant-2 - 2.2.8-1ubuntu0.20.04.1

---
enchant-2 (2.2.8-1ubuntu0.20.04.1) focal; urgency=medium

  * debian/patches/Fix_back-ends_that_want_a_NUL-terminated_string.patch:
- Fix Zemberek and Voikko backends under eg gspell (LP: #1901290)

 -- Timo Jyrinki   Thu, 05 Nov 2020 16:13:12 +0200

** Changed in: enchant-2 (Ubuntu Focal)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to enchant-2 in Ubuntu.
https://bugs.launchpad.net/bugs/1901290

Title:
  [SRU] Enchant-2 does not work properly with backends that want a NUL-
  terminated string

Status in enchant-2 package in Ubuntu:
  Fix Released
Status in enchant-2 source package in Focal:
  Fix Released
Status in enchant-2 source package in Groovy:
  Fix Released
Status in enchant-2 package in Debian:
  Unknown

Bug description:
  [Impact]

  Spell checking / spelling error highlighting does not work properly in
  eg gedit, gnote or gtranslator when using a language which uses Voikko
  (often Finnish, but also North Sámi (giella-sme package) or user
  installed HFST spellers like other Sámi languages or Greenlandic) or
  Zemberek (Turkish) backend via Enchant-2.

  [Test Case]

  (from https://gitlab.gnome.org/GNOME/gspell/-/issues/10)

  1. apt install libenchant-2-voikko voikko-fi
  2. Run gedit, gnote, gtranslator or other gspell using program
  3. (in gedit) Enable underlining of incorrectly typed words, and set Finnish 
(suomi) as language
  4. Copy-paste for example "tämä on testitekstiä" ("this is test text"), maybe 
for a comparison "tämmä on vihre" (1st and 3rd word incorrect)
  5. Note how everything is underlined - in suggestions, you can choose the 
same word and the underlining disappears, but as soon as you eg "leave" the 
word (press space after it) it gets underlined again. However, if doing manual 
spell checking the words are correctly understood as being correct.

  [Where problems could occur]

  The patch changes code in voikko and zemberek plugins, which are built
  and shipped separately. Zemberek is not built at all in Debian or
  Ubuntu. Thus, no changes (or problems) should be possible to happen
  outside the Voikko plugin (libenchant-2-voikko binary package), unless
  a toolchain change since the last build in March 2020 would cause a
  change with unchanged source.

  Voikko plugin would be good to test via multiple libraries like
  gspell, gtkspell, sonnet that there are no regressions.

  --- original report ---

  This shows up particularly with the inline checking feature of gspell
  in eg gedit which is part of the default Ubuntu installation.

  The issue is fixed in Enchant 2.2.12, and after that release reaches
  Debian and Ubuntu hirsute, I hope a backport of this patch to https
  ://patch-diff.githubusercontent.com/raw/AbiWord/enchant/pull/260.patch
  can be done to groovy and focal.

  SRU paperwork to be added later, but in general all backends would be
  good to test after the backport in various ways like gspell, sonnet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/enchant-2/+bug/1901290/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 1901290] Re: [SRU] Enchant-2 does not work properly with backends that want a NUL-terminated string

2020-11-17 Thread Launchpad Bug Tracker
This bug was fixed in the package enchant-2 - 2.2.8-1ubuntu0.20.10.1

---
enchant-2 (2.2.8-1ubuntu0.20.10.1) groovy; urgency=medium

  * debian/patches/Fix_back-ends_that_want_a_NUL-terminated_string.patch:
- Fix Zemberek and Voikko backends under eg gspell (LP: #1901290)

 -- Timo Jyrinki   Thu, 05 Nov 2020 16:13:12 +0200

** Changed in: enchant-2 (Ubuntu Groovy)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to enchant-2 in Ubuntu.
https://bugs.launchpad.net/bugs/1901290

Title:
  [SRU] Enchant-2 does not work properly with backends that want a NUL-
  terminated string

Status in enchant-2 package in Ubuntu:
  Fix Released
Status in enchant-2 source package in Focal:
  Fix Released
Status in enchant-2 source package in Groovy:
  Fix Released
Status in enchant-2 package in Debian:
  Unknown

Bug description:
  [Impact]

  Spell checking / spelling error highlighting does not work properly in
  eg gedit, gnote or gtranslator when using a language which uses Voikko
  (often Finnish, but also North Sámi (giella-sme package) or user
  installed HFST spellers like other Sámi languages or Greenlandic) or
  Zemberek (Turkish) backend via Enchant-2.

  [Test Case]

  (from https://gitlab.gnome.org/GNOME/gspell/-/issues/10)

  1. apt install libenchant-2-voikko voikko-fi
  2. Run gedit, gnote, gtranslator or other gspell using program
  3. (in gedit) Enable underlining of incorrectly typed words, and set Finnish 
(suomi) as language
  4. Copy-paste for example "tämä on testitekstiä" ("this is test text"), maybe 
for a comparison "tämmä on vihre" (1st and 3rd word incorrect)
  5. Note how everything is underlined - in suggestions, you can choose the 
same word and the underlining disappears, but as soon as you eg "leave" the 
word (press space after it) it gets underlined again. However, if doing manual 
spell checking the words are correctly understood as being correct.

  [Where problems could occur]

  The patch changes code in voikko and zemberek plugins, which are built
  and shipped separately. Zemberek is not built at all in Debian or
  Ubuntu. Thus, no changes (or problems) should be possible to happen
  outside the Voikko plugin (libenchant-2-voikko binary package), unless
  a toolchain change since the last build in March 2020 would cause a
  change with unchanged source.

  Voikko plugin would be good to test via multiple libraries like
  gspell, gtkspell, sonnet that there are no regressions.

  --- original report ---

  This shows up particularly with the inline checking feature of gspell
  in eg gedit which is part of the default Ubuntu installation.

  The issue is fixed in Enchant 2.2.12, and after that release reaches
  Debian and Ubuntu hirsute, I hope a backport of this patch to https
  ://patch-diff.githubusercontent.com/raw/AbiWord/enchant/pull/260.patch
  can be done to groovy and focal.

  SRU paperwork to be added later, but in general all backends would be
  good to test after the backport in various ways like gspell, sonnet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/enchant-2/+bug/1901290/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 1901290] Re: [SRU] Enchant-2 does not work properly with backends that want a NUL-terminated string

2020-11-09 Thread Timo Jyrinki
** Description changed:

  [Impact]
  
  Spell checking / spelling error highlighting does not work properly in
  eg gedit, gnote or gtranslator when using a language which uses Voikko
  (often Finnish, but also North Sámi (giella-sme package) or user
  installed HFST spellers like other Sámi languages or Greenlandic) or
  Zemberek (Turkish) backend via Enchant-2.
  
  [Test Case]
  
  (from https://gitlab.gnome.org/GNOME/gspell/-/issues/10)
  
  1. apt install libenchant-2-voikko voikko-fi
  2. Run gedit, gnote, gtranslator or other gspell using program
  3. (in gedit) Enable underlining of incorrectly typed words, and set Finnish 
(suomi) as language
  4. Copy-paste for example "tämä on testitekstiä" ("this is test text"), maybe 
for a comparison "tämmä on vihre" (1st and 3rd word incorrect)
  5. Note how everything is underlined - in suggestions, you can choose the 
same word and the underlining disappears, but as soon as you eg "leave" the 
word (press space after it) it gets underlined again. However, if doing manual 
spell checking the words are correctly understood as being correct.
  
- [Regression Potential]
+ [Where problems could occur]
  
- The patch changes code only in voikko and zemberek backends, so
- regression potential would be very low outside of those, and Zemberek
- backend is currently disabled by default in Debian and Ubuntu. Voikko
- backend would be good to test via multiple libraries like gspell,
+ The patch changes code in voikko and zemberek plugins, which are built
+ and shipped separately. Zemberek is not built at all in Debian or
+ Ubuntu. Thus, no changes (or problems) should be possible to happen
+ outside the Voikko plugin (libenchant-2-voikko binary package), unless a
+ toolchain change since the last build in March 2020 would cause a change
+ with unchanged source.
+ 
+ Voikko plugin would be good to test via multiple libraries like gspell,
  gtkspell, sonnet that there are no regressions.
  
  --- original report ---
  
  This shows up particularly with the inline checking feature of gspell in
  eg gedit which is part of the default Ubuntu installation.
  
  The issue is fixed in Enchant 2.2.12, and after that release reaches
  Debian and Ubuntu hirsute, I hope a backport of this patch to https
  ://patch-diff.githubusercontent.com/raw/AbiWord/enchant/pull/260.patch
  can be done to groovy and focal.
  
  SRU paperwork to be added later, but in general all backends would be
  good to test after the backport in various ways like gspell, sonnet.

** Also affects: enchant-2 (Ubuntu Groovy)
   Importance: Undecided
   Status: New

** Also affects: enchant-2 (Ubuntu Focal)
   Importance: Undecided
   Status: New

** Changed in: enchant-2 (Ubuntu Focal)
   Importance: Undecided => Low

** Changed in: enchant-2 (Ubuntu Groovy)
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to enchant-2 in Ubuntu.
https://bugs.launchpad.net/bugs/1901290

Title:
  [SRU] Enchant-2 does not work properly with backends that want a NUL-
  terminated string

Status in enchant-2 package in Ubuntu:
  Fix Released
Status in enchant-2 source package in Focal:
  New
Status in enchant-2 source package in Groovy:
  New
Status in enchant-2 package in Debian:
  Unknown

Bug description:
  [Impact]

  Spell checking / spelling error highlighting does not work properly in
  eg gedit, gnote or gtranslator when using a language which uses Voikko
  (often Finnish, but also North Sámi (giella-sme package) or user
  installed HFST spellers like other Sámi languages or Greenlandic) or
  Zemberek (Turkish) backend via Enchant-2.

  [Test Case]

  (from https://gitlab.gnome.org/GNOME/gspell/-/issues/10)

  1. apt install libenchant-2-voikko voikko-fi
  2. Run gedit, gnote, gtranslator or other gspell using program
  3. (in gedit) Enable underlining of incorrectly typed words, and set Finnish 
(suomi) as language
  4. Copy-paste for example "tämä on testitekstiä" ("this is test text"), maybe 
for a comparison "tämmä on vihre" (1st and 3rd word incorrect)
  5. Note how everything is underlined - in suggestions, you can choose the 
same word and the underlining disappears, but as soon as you eg "leave" the 
word (press space after it) it gets underlined again. However, if doing manual 
spell checking the words are correctly understood as being correct.

  [Where problems could occur]

  The patch changes code in voikko and zemberek plugins, which are built
  and shipped separately. Zemberek is not built at all in Debian or
  Ubuntu. Thus, no changes (or problems) should be possible to happen
  outside the Voikko plugin (libenchant-2-voikko binary package), unless
  a toolchain change since the last build in March 2020 would cause a
  change with unchanged source.

  Voikko plugin would be good to test via multiple libraries like
  gspell, gtkspell, sonnet that there are no regressions.

  --- original report ---

  This