[Desktop-packages] [Bug 1968377] Re: New Chromium icon, not yet used by Snap

2022-08-31 Thread Olivier Tilloy
** Tags added: snap

** Summary changed:

- New Chromium icon, not yet used by Snap
+ [snap] New Chromium icon, not yet used by Snap

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/1968377

Title:
  [snap] New Chromium icon, not yet used by Snap

Status in chromium-browser package in Ubuntu:
  Triaged

Bug description:
  Google updated the Chrome/Chromium icons recently (see more at
  https://twitter.com/elvin_not_11/status/1489647032201465861), but I
  don't think the Snap icon has been updated.

  Here's the Chromium icons on the Chromium source GitHub mirror, which
  was easier for me to search:
  https://github.com/chromium/chromium/tree/main/chrome/app/theme/chromium/linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1968377/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 1968377] Re: New Chromium icon, not yet used by Snap

2022-08-31 Thread Nathan Teodosio
Hi Alexander, thanks for your report!

> (If the code was on GitHub I'd submit a PR, but I'm very much a
beginner with git and haven't done it on LP before.)

Yeah, navigating Launchpad may be hard for the first time. However, if
you are interested, this is how you would go about it:

- Create a SSH key pair for Launchpad[1].

- Get the development branch from the chromium-browser:

git clone -b dev https://git.launchpad.net/~chromium-team/chromium-
browser/+git/snap-from-source

  As described in its page[2].

- Push to your own Launchpad repository. It should be something like

git remote add origin 
git+ssh://elc...@git.launchpad.net/~elcste/+git/REPOSITORY_NAME
git push --set-upstream origin master

- If you visit your repository (assuming the branch is "dev",
https://code.launchpad.net/~elcste/chromium-browser/+git/chromium-
browser/+ref/dev), you can "propose for merging" against the ~chromium-
team/chromium-browser/+git/snap-from-source repository on the dev
branch.

Please feel free to drop any question if you get stuck, either here or
sending me an email[3].

[1]: https://help.launchpad.net/YourAccount/CreatingAnSSHKeyPair
[2]: 
https://code.launchpad.net/~chromium-team/chromium-browser/+git/snap-from-source/+ref/dev
[3]: https://launchpad.net/%7Enteodosio/+contactuser

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/1968377

Title:
  New Chromium icon, not yet used by Snap

Status in chromium-browser package in Ubuntu:
  Triaged

Bug description:
  Google updated the Chrome/Chromium icons recently (see more at
  https://twitter.com/elvin_not_11/status/1489647032201465861), but I
  don't think the Snap icon has been updated.

  Here's the Chromium icons on the Chromium source GitHub mirror, which
  was easier for me to search:
  https://github.com/chromium/chromium/tree/main/chrome/app/theme/chromium/linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1968377/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 1968377] Re: New Chromium icon, not yet used by Snap

2022-08-31 Thread Nathan Teodosio
** Changed in: chromium-browser (Ubuntu)
   Status: New => Triaged

** Changed in: chromium-browser (Ubuntu)
   Importance: Undecided => Wishlist

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/1968377

Title:
  New Chromium icon, not yet used by Snap

Status in chromium-browser package in Ubuntu:
  Triaged

Bug description:
  Google updated the Chrome/Chromium icons recently (see more at
  https://twitter.com/elvin_not_11/status/1489647032201465861), but I
  don't think the Snap icon has been updated.

  Here's the Chromium icons on the Chromium source GitHub mirror, which
  was easier for me to search:
  https://github.com/chromium/chromium/tree/main/chrome/app/theme/chromium/linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1968377/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 1968377] Re: New Chromium icon, not yet used by Snap

2022-04-09 Thread Alexander Browne
Looking at the snapcraft.yaml (https://git.launchpad.net/~chromium-
team/chromium-browser/+git/snap-from-source/tree/snapcraft.yaml#n233)

I think what needs to change is

  cp chrome/app/theme/chromium/product_logo_256.png
$SNAPCRAFT_PART_INSTALL/chromium.png

to

  cp chrome/app/theme/chromium/linux/product_logo_256.png
$SNAPCRAFT_PART_INSTALL/chromium.png

That is, add `linux` to the icon source path, since these new icons
differ by platform.

(If the code was on GitHub I'd submit a PR, but I'm very much a beginner
with git and haven't done it on LP before.)

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/1968377

Title:
  New Chromium icon, not yet used by Snap

Status in chromium-browser package in Ubuntu:
  New

Bug description:
  Google updated the Chrome/Chromium icons recently (see more at
  https://twitter.com/elvin_not_11/status/1489647032201465861), but I
  don't think the Snap icon has been updated.

  Here's the Chromium icons on the Chromium source GitHub mirror, which
  was easier for me to search:
  https://github.com/chromium/chromium/tree/main/chrome/app/theme/chromium/linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1968377/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp