[Desktop-packages] [Bug 1970994] Re: /usr/libexec/gnome-remote-desktop-daemon:11:setChannelError:rdpgfx_server_thread_func:thread_launcher:start_thread:clone3

2022-06-15 Thread Robie Basak
This needed rebasing onto to the security update 2.6.1+dfsg1-3ubuntu2.1.
To save time I've done that and sponsored a re-upload for you, using the
version string 2.6.1+dfsg1-3ubuntu2.2. I trust that's OK.

This upload contains a significant rewrite of thread handling code.
Normally that would be unsuitable for an SRU on the basis of a
microrelease update. It's not something I'd expect to see in an upstream
"stable" branch, and I think casts doubt on whether this is an
appropriate upstream project to take "stable" microrelease updates from
in general without a change-by-change analysis an individual
justifications each time.

So, thank you for submitting this change on an individual basis. I think
the error counts for this particular issue do justify the SRU in this
case.

However, I do think there is considerable regression risk. Because of
the nature of the change being introduced, the scope of a regression
appears to be wide. Deadlocks, crashes and other race conditions may
appear anywhere. Please look out for this during SRU verification.


** Description changed:

  Impact
  --
  The Ubuntu Error Tracker has been receiving reports about a problem regarding 
gnome-remote-desktop.  This problem was most recently seen with package version 
42.0-4ubuntu1, the problem page at 
https://errors.ubuntu.com/problem/77f41623474304919ac793c6665505547b583b60 
contains more details, including versions of packages affected, stacktrace or 
traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software 
developer, you can request it at http://forms.canonical.com/reports/.
  
  Test Case 1
  ---
  Unfortunately, we weren't able to identify a reliable test case.
  
  We will know if this bug is fixed if errors.ubuntu.com stops reporting
  that error with a fully upgraded system. However, that means this update
  will need to be pushed to -updates
  
  Test Case 2
  ---
  Install all updates. Log out and log back in.
  Open the Settings app to the Sharing page. Turn on Sharing and turn on Remote 
Desktop Sharing.
  Turn it off then on because there may be a gnome-control-center bug with 
initial enabling.
  
  From a second computer, connect to the first computer using Remmina.
  
  The Remote Desktop page on the first computer provides the username and
  password to use. I wasn't able to get the "Remote Desktop Address" to
  work (maybe avahi doesn't work well?) so just use the first computer's
  IP address.
  
  So something like:
  RDP jeremy@192.168.1.1
  
  Ensure that the connection works.
  
  Then repeat the test after updating the second computer to use the
  updated freerdp2 since Remmina itself uses freerdp2. Basically we want
  to make sure things keep working after the update but also continue to
  work for connections between systems that aren't using the same version
  of freerdp2.
  
  What Could Go Wrong
  ---
- RDP Sharing using freerdp2 is a new feature for Ubuntu 22.04 LTS as part of 
GNOME 42.
+ 
+ [racb] This upload contains a significant rewrite of thread handling
+ code. So the scope of a regression appears to be wide. Deadlocks,
+ crashes and other race conditions may appear anywhere.
+ 
+ RDP Sharing using freerdp2 is a new feature for Ubuntu 22.04 LTS as part
+ of GNOME 42.
  
  RDP Sharing can be used for providing remote support so it's important
  that this feature works well because it may be difficult for the remote
  admin to fix issues in person.
  
  freerdp2 is also used by the Remmina and GNOME Connections apps as the
  "client" app for RDP Sharing. (The GNOME feature is the "server" side.)
  
  This fix is cherrypicked from the stable freerdp2 branch.

** Changed in: freerdp2 (Ubuntu Jammy)
   Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-jammy

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to freerdp2 in Ubuntu.
https://bugs.launchpad.net/bugs/1970994

Title:
  /usr/libexec/gnome-remote-desktop-
  
daemon:11:setChannelError:rdpgfx_server_thread_func:thread_launcher:start_thread:clone3

Status in freerdp2 package in Ubuntu:
  Fix Released
Status in gnome-remote-desktop package in Ubuntu:
  Invalid
Status in freerdp2 source package in Jammy:
  Fix Committed

Bug description:
  Impact
  --
  The Ubuntu Error Tracker has been receiving reports about a problem regarding 
gnome-remote-desktop.  This problem was most recently seen with package version 
42.0-4ubuntu1, the problem page at 
https://errors.ubuntu.com/problem/77f41623474304919ac793c6665505547b583b60 
contains more details, including versions of packages affected, stacktrace or 
traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software 
developer, you can request it at http://forms.canonical.com/reports/.

  Test Case 1
  ---
  Unfortunately, we weren't able to 

[Desktop-packages] [Bug 1970994] Re: /usr/libexec/gnome-remote-desktop-daemon:11:setChannelError:rdpgfx_server_thread_func:thread_launcher:start_thread:clone3

2022-06-01 Thread Jeremy Bicha
** Description changed:

+ Impact
+ --
  The Ubuntu Error Tracker has been receiving reports about a problem regarding 
gnome-remote-desktop.  This problem was most recently seen with package version 
42.0-4ubuntu1, the problem page at 
https://errors.ubuntu.com/problem/77f41623474304919ac793c6665505547b583b60 
contains more details, including versions of packages affected, stacktrace or 
traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software 
developer, you can request it at http://forms.canonical.com/reports/.
  
+ Test Case 1
+ ---
+ Unfortunately, we weren't able to identify a reliable test case.
  
- It's believed this issue will be fixed with
- https://github.com/FreeRDP/FreeRDP/pull/7836
+ We will know if this bug is fixed if errors.ubuntu.com stops reporting
+ that error with a fully upgraded system. However, that means this update
+ will need to be pushed to -updates
+ 
+ Test Case 2
+ ---
+ Install all updates. Log out and log back in.
+ Open the Settings app to the Sharing page. Turn on Sharing and turn on Remote 
Desktop Sharing.
+ Turn it off then on because there may be a gnome-control-center bug with 
initial enabling.
+ 
+ From a second computer, connect to the first computer using Remmina.
+ 
+ The Remote Desktop page on the first computer provides the username and
+ password to use. I wasn't able to get the "Remote Desktop Address" to
+ work (maybe avahi doesn't work well?) so just use the first computer's
+ IP address.
+ 
+ So something like:
+ RDP jeremy@192.168.1.1
+ 
+ Ensure that the connection works.
+ 
+ Then repeat the test after updating the second computer to use the
+ updated freerdp2 since Remmina itself uses freerdp2. Basically we want
+ to make sure things keep working after the update but also continue to
+ work for connections between systems that aren't using the same version
+ of freerdp2.
+ 
+ What Could Go Wrong
+ ---
+ RDP Sharing using freerdp2 is a new feature for Ubuntu 22.04 LTS as part of 
GNOME 42.
+ 
+ RDP Sharing can be used for providing remote support so it's important
+ that this feature works well because it may be difficult for the remote
+ admin to fix issues in person.
+ 
+ freerdp2 is also used by the Remmina and GNOME Connections apps as the
+ "client" app for RDP Sharing. (The GNOME feature is the "server" side.)
+ 
+ This fix is cherrypicked from the stable freerdp2 branch.

** Changed in: gnome-remote-desktop (Ubuntu)
   Status: Triaged => Invalid

** Changed in: freerdp2 (Ubuntu)
   Status: Triaged => Fix Released

** Changed in: freerdp2 (Ubuntu Jammy)
   Status: Triaged => In Progress

** Changed in: freerdp2 (Ubuntu)
   Importance: Undecided => Medium

** Changed in: freerdp2 (Ubuntu Jammy)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to freerdp2 in Ubuntu.
https://bugs.launchpad.net/bugs/1970994

Title:
  /usr/libexec/gnome-remote-desktop-
  
daemon:11:setChannelError:rdpgfx_server_thread_func:thread_launcher:start_thread:clone3

Status in freerdp2 package in Ubuntu:
  Fix Released
Status in gnome-remote-desktop package in Ubuntu:
  Invalid
Status in freerdp2 source package in Jammy:
  In Progress

Bug description:
  Impact
  --
  The Ubuntu Error Tracker has been receiving reports about a problem regarding 
gnome-remote-desktop.  This problem was most recently seen with package version 
42.0-4ubuntu1, the problem page at 
https://errors.ubuntu.com/problem/77f41623474304919ac793c6665505547b583b60 
contains more details, including versions of packages affected, stacktrace or 
traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software 
developer, you can request it at http://forms.canonical.com/reports/.

  Test Case 1
  ---
  Unfortunately, we weren't able to identify a reliable test case.

  We will know if this bug is fixed if errors.ubuntu.com stops reporting
  that error with a fully upgraded system. However, that means this
  update will need to be pushed to -updates

  Test Case 2
  ---
  Install all updates. Log out and log back in.
  Open the Settings app to the Sharing page. Turn on Sharing and turn on Remote 
Desktop Sharing.
  Turn it off then on because there may be a gnome-control-center bug with 
initial enabling.

  From a second computer, connect to the first computer using Remmina.

  The Remote Desktop page on the first computer provides the username
  and password to use. I wasn't able to get the "Remote Desktop Address"
  to work (maybe avahi doesn't work well?) so just use the first
  computer's IP address.

  So something like:
  RDP jeremy@192.168.1.1

  Ensure that the connection works.

  Then repeat the test after updating the second computer to use the
  updated freerdp2 since Remmina itself uses freerdp2. Basically we want
  to make sure 

[Desktop-packages] [Bug 1970994] Re: /usr/libexec/gnome-remote-desktop-daemon:11:setChannelError:rdpgfx_server_thread_func:thread_launcher:start_thread:clone3

2022-05-12 Thread Pascal Nowack
To provide some context, when this crash can happen: It can happen, after 
attempting to start a remote desktop session, when the screen is locked.
In such case, g-s directly refuses the start request and therefore the lifetime 
of the rdpgfx thread in FreeRDP is very short.

The journal message for this looks like this:
`Failed to start remote desktop session: 
GDBus.Error:org.freedesktop.DBus.Error.AccessDenied: Session creation inhibited`

Now, the error here is, that FreeRDP does not correctly wait for the
rdpgfx thread to be created and this can lead to in this situation, that
the rdpgfx thread is not teared down, when stopping the session, which
can can lead to segfaults, like in this report or to memory corruption.

Personally, I was not able to reproduce the error. However, with the help of 
the journal entries I was able to find this cause.
https://github.com/FreeRDP/FreeRDP/pull/7836 takes care of the problem.

Sessions, that are not locked, should not be affected by this issue.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to freerdp2 in Ubuntu.
https://bugs.launchpad.net/bugs/1970994

Title:
  /usr/libexec/gnome-remote-desktop-
  
daemon:11:setChannelError:rdpgfx_server_thread_func:thread_launcher:start_thread:clone3

Status in freerdp2 package in Ubuntu:
  Triaged
Status in gnome-remote-desktop package in Ubuntu:
  Triaged
Status in freerdp2 source package in Jammy:
  Triaged

Bug description:
  The Ubuntu Error Tracker has been receiving reports about a problem regarding 
gnome-remote-desktop.  This problem was most recently seen with package version 
42.0-4ubuntu1, the problem page at 
https://errors.ubuntu.com/problem/77f41623474304919ac793c6665505547b583b60 
contains more details, including versions of packages affected, stacktrace or 
traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software 
developer, you can request it at http://forms.canonical.com/reports/.

  
  It's believed this issue will be fixed with
  https://github.com/FreeRDP/FreeRDP/pull/7836

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freerdp2/+bug/1970994/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 1970994] Re: /usr/libexec/gnome-remote-desktop-daemon:11:setChannelError:rdpgfx_server_thread_func:thread_launcher:start_thread:clone3

2022-04-29 Thread Jeremy Bicha
** Changed in: freerdp2 (Ubuntu Jammy)
   Status: New => Triaged

** Changed in: freerdp2 (Ubuntu Jammy)
 Assignee: (unassigned) => Jeremy Bicha (jbicha)

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to freerdp2 in Ubuntu.
https://bugs.launchpad.net/bugs/1970994

Title:
  /usr/libexec/gnome-remote-desktop-
  
daemon:11:setChannelError:rdpgfx_server_thread_func:thread_launcher:start_thread:clone3

Status in freerdp2 package in Ubuntu:
  Triaged
Status in gnome-remote-desktop package in Ubuntu:
  Triaged
Status in freerdp2 source package in Jammy:
  Triaged

Bug description:
  The Ubuntu Error Tracker has been receiving reports about a problem regarding 
gnome-remote-desktop.  This problem was most recently seen with package version 
42.0-4ubuntu1, the problem page at 
https://errors.ubuntu.com/problem/77f41623474304919ac793c6665505547b583b60 
contains more details, including versions of packages affected, stacktrace or 
traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software 
developer, you can request it at http://forms.canonical.com/reports/.

  
  It's believed this issue will be fixed with
  https://github.com/FreeRDP/FreeRDP/pull/7836

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freerdp2/+bug/1970994/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 1970994] Re: /usr/libexec/gnome-remote-desktop-daemon:11:setChannelError:rdpgfx_server_thread_func:thread_launcher:start_thread:clone3

2022-04-29 Thread Jeremy Bicha
** Changed in: gnome-remote-desktop (Ubuntu)
   Status: New => Triaged

** Changed in: gnome-remote-desktop (Ubuntu)
 Assignee: (unassigned) => Jeremy Bicha (jbicha)

** Also affects: freerdp2 (Ubuntu)
   Importance: Undecided
   Status: New

** Changed in: freerdp2 (Ubuntu)
   Status: New => Triaged

** Changed in: freerdp2 (Ubuntu)
 Assignee: (unassigned) => Jeremy Bicha (jbicha)

** Also affects: freerdp2 (Ubuntu Jammy)
   Importance: Undecided
   Status: New

** Also affects: gnome-remote-desktop (Ubuntu Jammy)
   Importance: Undecided
   Status: New

** No longer affects: gnome-remote-desktop (Ubuntu Jammy)

** Description changed:

  The Ubuntu Error Tracker has been receiving reports about a problem regarding 
gnome-remote-desktop.  This problem was most recently seen with package version 
42.0-4ubuntu1, the problem page at 
https://errors.ubuntu.com/problem/77f41623474304919ac793c6665505547b583b60 
contains more details, including versions of packages affected, stacktrace or 
traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software 
developer, you can request it at http://forms.canonical.com/reports/.
+ 
+ 
+ It's believed this issue will be fixed with
+ https://github.com/FreeRDP/FreeRDP/pull/7836

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-remote-desktop in Ubuntu.
https://bugs.launchpad.net/bugs/1970994

Title:
  /usr/libexec/gnome-remote-desktop-
  
daemon:11:setChannelError:rdpgfx_server_thread_func:thread_launcher:start_thread:clone3

Status in freerdp2 package in Ubuntu:
  Triaged
Status in gnome-remote-desktop package in Ubuntu:
  Triaged
Status in freerdp2 source package in Jammy:
  New

Bug description:
  The Ubuntu Error Tracker has been receiving reports about a problem regarding 
gnome-remote-desktop.  This problem was most recently seen with package version 
42.0-4ubuntu1, the problem page at 
https://errors.ubuntu.com/problem/77f41623474304919ac793c6665505547b583b60 
contains more details, including versions of packages affected, stacktrace or 
traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software 
developer, you can request it at http://forms.canonical.com/reports/.

  
  It's believed this issue will be fixed with
  https://github.com/FreeRDP/FreeRDP/pull/7836

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freerdp2/+bug/1970994/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp