[GitHub] activemq-artemis issue #820: ARTEMIS-770 AMQP Message Transformer refactor
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/820 There are a few regressions under org.apache.activemq.artemis.tests.integration.amqp.* AmqpTransactionTest::testReceiversCommitAndRollbackWithMultipleSessionsInSingleTX and ProtonPubTest has a few failing. You think you could look into those and amend the commit? But overall it looks great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #820: ARTEMIS-770 AMQP Message Transformer ref...
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/820#discussion_r82112176
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/jms/ServerJMSObjectMessage.java
---
@@ -16,55 +16,48 @@
*/
package org.apache.activemq.artemis.protocol.amqp.converter.jms;
+import java.io.Serializable;
+
import javax.jms.JMSException;
import javax.jms.ObjectMessage;
-import java.io.ByteArrayInputStream;
-import java.io.ByteArrayOutputStream;
-import java.io.ObjectOutputStream;
-import java.io.Serializable;
import org.apache.activemq.artemis.api.core.Message;
import org.apache.activemq.artemis.core.message.impl.MessageInternal;
-import org.apache.activemq.artemis.utils.ObjectInputStreamWithClassLoader;
+import org.apache.qpid.proton.amqp.Binary;
public class ServerJMSObjectMessage extends ServerJMSMessage implements
ObjectMessage {
- private static final String DEFAULT_WHITELIST;
- private static final String DEFAULT_BLACKLIST;
-
- static {
- DEFAULT_WHITELIST =
System.getProperty(ObjectInputStreamWithClassLoader.WHITELIST_PROPERTY,
"java.lang,java.math,javax.security,java.util,org.apache.activemq,org.apache.qpid.proton.amqp");
-
- DEFAULT_BLACKLIST =
System.getProperty(ObjectInputStreamWithClassLoader.BLACKLIST_PROPERTY, null);
- }
+ public static final byte TYPE = Message.OBJECT_TYPE;
- public static final byte TYPE = Message.STREAM_TYPE;
-
- private Serializable object;
+ private Binary payload;
public ServerJMSObjectMessage(MessageInternal message, int
deliveryCount) {
super(message, deliveryCount);
}
@Override
public void setObject(Serializable object) throws JMSException {
- this.object = object;
+ throw new UnsupportedOperationException("Cannot set Object on this
internal message");
}
@Override
public Serializable getObject() throws JMSException {
- return object;
+ throw new UnsupportedOperationException("Cannot set Object on this
internal message");
+ }
+
+ public void setSerializedForm(Binary payload) {
+ this.payload = payload;
+ }
+
+ public Binary getSerializedForm() {
+ return payload;
}
@Override
public void encode() throws Exception {
super.encode();
- ByteArrayOutputStream out = new ByteArrayOutputStream();
- ObjectOutputStream ous = new ObjectOutputStream(out);
- ous.writeObject(object);
- byte[] src = out.toByteArray();
- getInnerMessage().getBodyBuffer().writeInt(src.length);
- getInnerMessage().getBodyBuffer().writeBytes(src);
+ getInnerMessage().getBodyBuffer().writeInt(payload.getLength());
--- End diff --
yay! @tabish121 very nice!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #820: ARTEMIS-770 AMQP Message Transformer ref...
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/820 ARTEMIS-770 AMQP Message Transformer refactor Refactor the AMQP Message transformers both for better performance and also to fix a number of issues with the transformers creating inbound and outbound messages with incorrectly mapped values or extra data appended where it should not be. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-770 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/820.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #820 commit 22eceeb6740f02631de7ae2c553505093149e6b5 Author: Timothy Bish Date: 2016-10-03T18:23:50Z ARTEMIS-770 AMQP Message Transformer refactor Refactor the AMQP Message transformers both for better performance and also to fix a number of issues with the transformers creating inbound and outbound messages with incorrectly mapped values or extra data appended where it should not be. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request #204: Setting TmpDataDirectory for setTempDataStore Me...
GitHub user shailendra14k opened a pull request: https://github.com/apache/activemq/pull/204 Setting TmpDataDirectory for setTempDataStore Method Related to Improvement AMQ-6403, tmpDataDirectory value is not set You can merge this pull request into a Git repository by running: $ git pull https://github.com/shailendra14k/activemq tmpDataIssue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/204.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #204 commit 59ecbc221936c6fb5cf95a7e20d267575f45153f Author: Shailendra Kumar Singh Date: 2016-10-05T16:50:02Z Setting TmpDataDirectory for tempDataStore --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #819: osgi fixes
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/819 and @jbertram didn't notice as well :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #819: osgi fixes
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/819 and forgot to remove it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #819: osgi fixes
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/819 @graben oops.. thanks... it was a test I wanted to make. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #819: osgi fixes
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/819 osgi fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis osgi Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/819.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #819 commit f8038268e0699c7d9726b433cec6aa830df68ec2 Author: Benjamin Graf <> Date: 2016-10-05T15:40:07Z ARTEMIS-752 fixing NPE Done as a patch on https://issues.apache.org/jira/browse/ARTEMIS-752 commit d61c13ed77ecad432576442da31398ce77c87eb0 Author: Clebert Suconic Date: 2016-10-05T15:40:46Z NO-JIRA: Improving default configuration from OSGI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #:
Github user graben commented on the pull request: https://github.com/apache/activemq-artemis/commit/d61c13ed77ecad432576442da31398ce77c87eb0#commitcomment-19304638 tcp://0.0.0.0:61616?tcpSendBufferSize=1048576;tcpReceiveBufferSize=1048576;protocols= Should artemis really wait for protocol being initialized? :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #819: osgi fixes
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/819 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
