Re: HEADS-UP/DISCUSS Artemis 1.4.1
I won't have time to whip up the actual code tonight, maybe tomorrow. If someone else has some interest in implementing https://issues.apache.org/jira/browse/ARTEMIS-821 I added some notes on where it looks like the header reading is missing. Please take a look, comment on how far off I might be. John On Tue, Oct 25, 2016 at 7:06 PM Clebert Suconicwrote: > Just an update on the status. > > I am a bit late (at least on what I pleanned) for this release as > there are a few issues I wanted to get as part of 1.5.0. > > I have 2 JIRAs now as blocker for 1.5.0, meaning I will release when I > clear the blockers. If there's also something you think it must/should > come on 1.5.0 please let me know now. > > > so far I have: > > Support scheduled messages with the STOMP protocol - > https://issues.apache.org/jira/browse/ARTEMIS-821 > Reduce thread synchronization on the Journal - > https://issues.apache.org/jira/browse/ARTEMIS-822 > > I am currently working on ARTEMIS-822. I mean also create another > blocker JIRA coming out of this work. > > > If anyone could volunteer on ARTEMIS-821, it would be great :) > Since I'm asking for help, if you start working on it.. please either > add a comment or use Start Progress on the JIRA (to make sure we > wouldn't have more than one person working on the same thing and > wasting time) > > > > Thanks, > > > Clebert > > On Mon, Oct 17, 2016 at 12:40 PM, Clebert Suconic > wrote: > > I will just call it 1.5.0 to be on the safe side.. not more discussion > needed :) > > > > On Mon, Oct 17, 2016 at 11:58 AM, Clebert Suconic > > wrote: > >> I'm looking at a git log between 1.4.0 and HEAD, and from what I see, > >> there are a few improvements that could be translated as either > >> features/improvements or bugs. > >> > >> A few tweaks on the wording could change them into either bug or fix... > e.g: > >> > >> Reloading Divert Support - Feature, > >> Diverts are not reloaded = Bug > >> > >> > >> > >> The only real feature I could find so far was your commit here: > >> > >> > >> commit 9163c679ef21e70ba94f54c9a1bed9a12ad6bcca > >> Author: John D. Ament > >> Date: Sun Jul 31 22:12:50 2016 -0400 > >> ARTEMIS-756 introduce CDI based integration for Artemis. Includes > >> integration tests on both Weld and OWB. > >> > >> > >> > >> If you'd like I can call it 1.5.0 based on this change. it's up to you > >> really since it's your commit. WDYT? > >> > >> > >> > >> > >> > >> On Mon, Oct 17, 2016 at 11:09 AM, John D. Ament > wrote: > >>> Is there a changelog of whats going in? If its all bug fixes, 1.4.1 > makes > >>> sense. if its feature, I would think 1.5.0 is more appropriate. > >>> > >>> On Mon, Oct 17, 2016 at 10:52 AM Clebert Suconic < > clebert.suco...@gmail.com> > >>> wrote: > >>> > I want to make a release early next week. (as I have pointed a few > weeks > ago). > > > I will release from master... there are a few new packages added > around OSGI, but I was still considering calling 1.4.1, and reserve > 1.5.0 for a few more major features that will change the broker > itself. > > > If no objections I will call it 1.4.1, but I wouldn't mind calling it > 1.5.0 if anyone objects. > > >> > >> > >> > >> -- > >> Clebert Suconic > > > > > > > > -- > > Clebert Suconic > > > > -- > Clebert Suconic >
Re: HEADS-UP/DISCUSS Artemis 1.4.1
Just an update on the status. I am a bit late (at least on what I pleanned) for this release as there are a few issues I wanted to get as part of 1.5.0. I have 2 JIRAs now as blocker for 1.5.0, meaning I will release when I clear the blockers. If there's also something you think it must/should come on 1.5.0 please let me know now. so far I have: Support scheduled messages with the STOMP protocol - https://issues.apache.org/jira/browse/ARTEMIS-821 Reduce thread synchronization on the Journal - https://issues.apache.org/jira/browse/ARTEMIS-822 I am currently working on ARTEMIS-822. I mean also create another blocker JIRA coming out of this work. If anyone could volunteer on ARTEMIS-821, it would be great :) Since I'm asking for help, if you start working on it.. please either add a comment or use Start Progress on the JIRA (to make sure we wouldn't have more than one person working on the same thing and wasting time) Thanks, Clebert On Mon, Oct 17, 2016 at 12:40 PM, Clebert Suconicwrote: > I will just call it 1.5.0 to be on the safe side.. not more discussion needed > :) > > On Mon, Oct 17, 2016 at 11:58 AM, Clebert Suconic > wrote: >> I'm looking at a git log between 1.4.0 and HEAD, and from what I see, >> there are a few improvements that could be translated as either >> features/improvements or bugs. >> >> A few tweaks on the wording could change them into either bug or fix... e.g: >> >> Reloading Divert Support - Feature, >> Diverts are not reloaded = Bug >> >> >> >> The only real feature I could find so far was your commit here: >> >> >> commit 9163c679ef21e70ba94f54c9a1bed9a12ad6bcca >> Author: John D. Ament >> Date: Sun Jul 31 22:12:50 2016 -0400 >> ARTEMIS-756 introduce CDI based integration for Artemis. Includes >> integration tests on both Weld and OWB. >> >> >> >> If you'd like I can call it 1.5.0 based on this change. it's up to you >> really since it's your commit. WDYT? >> >> >> >> >> >> On Mon, Oct 17, 2016 at 11:09 AM, John D. Ament >> wrote: >>> Is there a changelog of whats going in? If its all bug fixes, 1.4.1 makes >>> sense. if its feature, I would think 1.5.0 is more appropriate. >>> >>> On Mon, Oct 17, 2016 at 10:52 AM Clebert Suconic >>> wrote: >>> I want to make a release early next week. (as I have pointed a few weeks ago). I will release from master... there are a few new packages added around OSGI, but I was still considering calling 1.4.1, and reserve 1.5.0 for a few more major features that will change the broker itself. If no objections I will call it 1.4.1, but I wouldn't mind calling it 1.5.0 if anyone objects. >> >> >> >> -- >> Clebert Suconic > > > > -- > Clebert Suconic -- Clebert Suconic
[GitHub] activemq-artemis pull request #865: ARTEMIS-820 AMQP: Add frame inspection c...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/865 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #865: ARTEMIS-820 AMQP: Add frame inspection capabili...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/865 @tabish121 if we had a common repository between artemis and AMQ5, it would come handy here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #860: ARTEMIS-817 and ARTEMIS-818 openwire fix...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/860 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #849: ARTEMIS-805 old JMS clients failing on new brok...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/849 @TomasHofman, right now there is no 1.4 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #865: ARTEMIS-820 AMQP: Add frame inspection capabili...
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/865 This looks to pull in the differences I'm aware of between 5.x and Artemis versions of the client, nice one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #865: ARTEMIS-820 AMQP: Add frame inspection c...
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/865 ARTEMIS-820 AMQP: Add frame inspection capability to the test client. You can merge this pull request into a Git repository by running: $ git pull https://github.com/franz1981/activemq-artemis frame_inspection_test_client Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/865.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #865 commit 3d877556b92f0b6caedc3dadaabd60fb0adf4f66 Author: Francesco NigroDate: 2016-10-25T15:15:43Z ARTEMIS-820 AMQP: Add frame inspection capability to the test client. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Many old open PRs
+1 for using a temporary branch and then deleting it after the PR is closed. That way there's no empty commits laying around. On Mon, Oct 24, 2016 at 5:15 PM, Clebert Suconicwrote: > On Mon, Oct 24, 2016 at 4:28 PM, John D. Ament > wrote: > > You can also push up the commits to a separate branch, which closes the > PR, > > then delete that branch (note you have to eventually push a real commit > on > > top so there will be a short delay until someone commits to git in a > > non-delete fashion). > > > > Ah a temporary branch... h > > We can push -f :temporary-branch when it's closed. > > > That works >
[GitHub] activemq-artemis issue #849: ARTEMIS-805 old JMS clients failing on new brok...
Github user TomasHofman commented on the issue: https://github.com/apache/activemq-artemis/pull/849 @clebertsuconic will this get into 1.4 branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request #206: Add missing runlevels to Default-Start
GitHub user TomyLobo opened a pull request: https://github.com/apache/activemq/pull/206 Add missing runlevels to Default-Start According to the manual (and the `runlevel` command), Debian starts in runlevel 2 by default: https://www.debian.org/doc/manuals/debian-reference/ch03.en.html#_sysv_style_init So in order for ActiveMQ to start up when a Debian VM starts, you have to add it to these runlevels. Workaround: `insserv -v activemq,start=2` Side-effects: RedHat doesn't use runlevels 2 and 4, so it should be fine: https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/3/html/Reference_Guide/s1-boot-init-shutdown-sysv.html SLES doesn't use runlevel 4, but it does use runlevel 2 for "Local multiuser mode without remote network (NFS, etc.)": https://www.suse.com/documentation/sles11/book_sle_admin/data/sec_boot_init.html So the only side-effect on these systems is that SLES will try to run ActiveMQ in Local multiuser mode without remote network (and probably fail). I think that is an acceptable side-effect since people booting Debian into runlevel 2 is a *lot* more common due to it being the default. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TomyLobo/activemq patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #206 commit 7eb9d60c8d203829b020025b20411628a20ab780 Author: TomyLoboDate: 2016-10-25T09:03:44Z Add missing runlevels to Default-Start Debian starts in runlevel 2 by default. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #860: ARTEMIS-817 and ARTEMIS-818 openwire fixes
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/860 done. the failure looks environmental --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---