[GitHub] activemq-artemis issue #1295: ARTEMIS-1185 Inter-Process Journal Sampler Pro...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1295
  
PR raised to hopefully end the sevntu curse (aka use new version published 
now in maven central)
https://github.com/apache/activemq-artemis/pull/1299


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1295: ARTEMIS-1185 Inter-Process Journal Samp...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1295#discussion_r118992513
  
--- Diff: 
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/counters/Profiler.java
 ---
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.core.io.buffer.counters;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.activemq.artemis.journal.ActiveMQJournalLogger;
+
+/**
+ * Factory class to instantiate {@link FlushProfiler}s classes.
+ */
+public final class Profiler {
+
+   private static final FlushProfiler BLACK_HOLE_PROFILER = new 
FlushProfiler() {
--- End diff --

or even remove if go with setting to null and separate guard statements


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1299: ARTEMIS-1188: Update sevntu to 1.24.0 availabl...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1299
  
FYI - I'm happy to sort prolific check style violations now picked up on 
upgrade of checkstyle to latest (key ones are redundant final modifiers and 
also do while loop formatting) , but will do this later, key to this is just to 
get sevntu updated to the maven central version, so builds are more stable :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1299: ARTEMIS-1188: Update sevntu to 1.24.0 a...

[michaelandrepearce]

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1299

ARTEMIS-1188: Update sevntu to 1.24.0 available in maven central

remove custom repo
update groupid to match artifact in maven central.
bump version also to that now deployed to maven central.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
sevntu-checks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1299


commit aabbad4b680fc01116a67d9793c6dfc1088c6e08
Author: Michael Andre Pearce 
Date:   2017-05-29T20:48:19Z

ARTEMIS-1188: Update sevntu to 1.24.0 available in maven central

remove custom repo
update groupid to match artifact in maven central.
bump version also to that now deployed to maven central.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1295: ARTEMIS-1185 Inter-Process Journal Sampler Pro...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1295
  
Looks good +1, comments are just comments, I'm happy with as is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1295: ARTEMIS-1185 Inter-Process Journal Samp...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1295#discussion_r118982620
  
--- Diff: 
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.java
 ---
@@ -288,7 +266,14 @@ private void flush(final boolean force) {
 buffer.getBytes(0, bufferToFlush);
 
 final List ioCallbacks = callbacks == null ? 
Collections.emptyList() : callbacks;
-bufferObserver.flushBuffer(bufferToFlush, pendingSyncs.get() > 
0, ioCallbacks);
+
+final boolean requiredSync = pendingSyncs.get() > 0;
+this.flushProfiler.onStartFlush(bufferToFlush.position(), 
requiredSync);
--- End diff --

why not a guard statement here? so if disabled the JVM would simply compile 
out the code when disabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1295: ARTEMIS-1185 Inter-Process Journal Samp...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1295#discussion_r118982819
  
--- Diff: 
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.java
 ---
@@ -93,10 +82,10 @@
public TimedBuffer(final int size, final int timeout, final boolean 
logRates) {
   bufferSize = size;
 
-  this.logRates = logRates;
-
   if (logRates) {
--- End diff --

NIT: is there a better name for this, i can't think of one, but name just 
seems misleading a little, as actually this is enabling a profiler not logging 
out anything to the std log file. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1295: ARTEMIS-1185 Inter-Process Journal Samp...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1295#discussion_r118983292
  
--- Diff: 
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.java
 ---
@@ -93,10 +82,10 @@
public TimedBuffer(final int size, final int timeout, final boolean 
logRates) {
   bufferSize = size;
 
-  this.logRates = logRates;
-
   if (logRates) {
- logRatesTimer = new Timer(true);
+ this.flushProfiler = Profiler.instrumented();
+  } else {
+ this.flushProfiler = Profiler.none();
--- End diff --

would it not be better to set to null, as so don't then need a Noop 
implementation, and later do a guard statement so the code can be compiled out 
if not enabled..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1295: ARTEMIS-1185 Inter-Process Journal Samp...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1295#discussion_r118982923
  
--- Diff: 
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/counters/Profiler.java
 ---
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.core.io.buffer.counters;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.activemq.artemis.journal.ActiveMQJournalLogger;
+
+/**
+ * Factory class to instantiate {@link FlushProfiler}s classes.
+ */
+public final class Profiler {
+
+   private static final FlushProfiler BLACK_HOLE_PROFILER = new 
FlushProfiler() {
--- End diff --

Why not make use of java 8 default methods and define in the interface to 
have default methods, that do nothing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1295: ARTEMIS-1185 Inter-Process Journal Samp...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1295#discussion_r118983050
  
--- Diff: 
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/journal/StatJournal.java
 ---
@@ -0,0 +1,288 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.cli.commands.tools.journal;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.PrintStream;
+import java.util.Arrays;
+import java.util.Comparator;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.concurrent.locks.LockSupport;
+
+import io.airlift.airline.Command;
+import io.airlift.airline.Option;
+import org.apache.activemq.artemis.cli.commands.ActionContext;
+import org.apache.activemq.artemis.cli.commands.Configurable;
+import org.apache.activemq.artemis.core.config.impl.FileConfiguration;
+import 
org.apache.activemq.artemis.core.io.buffer.counters.FlushSampleFlyweight;
+import org.apache.activemq.artemis.core.io.buffer.counters.Profiler;
+import org.apache.activemq.artemis.utils.collections.MulticastSample;
+
+@Command(name = "stat", description = "Provide performance statistics 
around the journal usage")
--- End diff --

maybe journal-stat?, stat seems a little too generic, e.g. what if other 
stat tools added for other parts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1298: ARTEMIS-1187 Incompatible version when ...

[TomasHofman]

GitHub user TomasHofman opened a pull request:

https://github.com/apache/activemq-artemis/pull/1298

ARTEMIS-1187 Incompatible version when recreating a session with olde…

…r server

https://issues.apache.org/jira/browse/ARTEMIS-1187
https://issues.jboss.org/browse/JBEAP-9522

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TomasHofman/activemq-artemis JBEAP-9522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1298


commit c3871a183f48b6cccaa3a65e7c14b2b64e16b39d
Author: Tomas Hofman 
Date:   2017-05-29T10:27:09Z

ARTEMIS-1187 Incompatible version when recreating a session with older 
server




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] New logo discussion

[Bennet Schulz]

+1 

maybe we could get in contact with Claus Ibsen. He’s doing the same for Apache 
Camel.

> Am 25.05.2017 um 23:30 schrieb artnaseef :
> 
> Yeah, feels like 1 month is a good start.  Perhaps allow it to draw out a
> longer (not indefinitely) if there's continued, constructive activity.
> 
> 
> On Thu, May 25, 2017 at 7:37 AM, clebertsuconic [via ActiveMQ] <
> ml+s2283324n4726567...@n4.nabble.com> wrote:
> 
>> How long should I keep the submission open before we call for a Vote.
>> I thought about 1 month? It's summer, and perhaps that will attract
>> students.
>> 
>> On Thu, May 25, 2017 at 10:49 AM, Clebert Suconic
>> <[hidden email] >
>> wrote:
>> 
>>> Just so as a heads up.. I will post a blog about the submission next
>>> week after the US Holiday.
>>> 
>>> On Thu, May 25, 2017 at 9:23 AM, Clebert Suconic
>>> <[hidden email] >
>> wrote:
 On Thu, May 25, 2017 at 9:16 AM, Justin Bertram <[hidden email]
>> > wrote:
>> Aspect ratio - square or banner?
> 
> I think we would need both - a banner for the top of web pages plus a
>> square icon for other purposes.  Here [1] is an example submission from the
>> Camel process which Clebert linked to at the beginning of this thread.
 
 If the submission is also including an abstract image.. a square image
 would be great... yeah...
 
 
 @Michael Pearce: I loved the abstraction for MQ..
 I wouldn't put the 6 on the Logo though.. just for practical reasons..
 (What to do when there's a 7?)
 
 
> 
> 
> Justin
> 
> [1] https://github.com/apache/camel/pull/1556/commits/
>> f28ff8739cc895314a95ebec323c075c38a08813
> 
> - Original Message -
> From: "Timothy Nodine" <[hidden email]
>> >
> To: [hidden email]
>> 
> Sent: Wednesday, May 24, 2017 4:20:08 PM
> Subject: Re: [DISCUSS] New logo discussion
> 
> Aspect ratio - square or banner?
> 
> Clebert Suconic wrote:
>> I talked to the PMC private list and we have consensus that starting
>> this would be a good idea.
>> 
>> Before we start a call for logo,  We need to define the requirements
>> for the logo and what we will ask:
>> 
>> I'm thinking of defining these as requirements:
>> 
>> - vector based file (.svg) and .png images
>> - an abstract image representing ActiveMQ would be awesome (we don't
>> have one)
>> - (in case of an abstract image, it would be nice to have the image
>> and the name separated, like camel)
>> - minimalistic and modern design.
>> 
>> 
>> 
>> thoughts?
>> 
> 
 
 
 
 --
 Clebert Suconic
>>> 
>>> 
>>> 
>>> --
>>> Clebert Suconic
>> 
>> 
>> 
>> --
>> Clebert Suconic
>> 
>> 
>> --
>> If you reply to this email, your message will be added to the discussion
>> below:
>> http://activemq.2283324.n4.nabble.com/DISCUSS-New-logo-
>> discussion-tp4726454p4726567.html
>> To start a new topic under ActiveMQ - Dev, email
>> ml+s2283324n2368404...@n4.nabble.com
>> To unsubscribe from ActiveMQ - Dev, click here
>> 
>> .
>> NAML
>> 
>> 
> 
> 
> 
> 
> --
> View this message in context: 
> http://activemq.2283324.n4.nabble.com/DISCUSS-New-logo-discussion-tp4726454p4726594.html
> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.

[GitHub] activemq-artemis pull request #1297: ARTEMIS-1186 Consumer.receive hangs if ...

[TomasHofman]

GitHub user TomasHofman opened a pull request:

https://github.com/apache/activemq-artemis/pull/1297

ARTEMIS-1186 Consumer.receive hangs if http acceptor with non-zero ba…

…tch-delay is configured

https://issues.apache.org/jira/browse/ARTEMIS-1186
https://issues.jboss.org/browse/JBEAP-6570

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TomasHofman/activemq-artemis JBEAP-6570

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1297


commit ae9faac09ee65cd3dc657aedd23ac36f423f5a19
Author: Tomas Hofman 
Date:   2017-05-29T10:00:32Z

ARTEMIS-1186 Consumer.receive hangs if http acceptor with non-zero 
batch-delay is configured




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1286: Fix missing JSON support

[gnodet]

Github user gnodet commented on the issue:

https://github.com/apache/activemq-artemis/pull/1286
  
Sorry, I was in vacation last week and haven't had any time to work further 
on that.
Artemis does use json in some cases.  The problem is that in OSGi, the json 
api bundle is deployed, but it can't locate any provider.  I pushed an updated 
spec to servicemix to fix the problem as it's usually done for this kind of 
spec bundles:
  
https://git1-us-west.apache.org/repos/asf?p=servicemix-specs.git;a=commitdiff;h=9265f72331f26f8374765d4530522d238edeecf2
The above commit allows finding a json provider inside a bundle deployed in 
the OSGi framework.

So this commit deploys this new json api bundle and forces the installation 
of the johnzon provider.

I plan to create a test case to demonstrate the changes i've been working 
on, i.e. #1284, #1285 and #1286


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1296: DOC(Addressing Model) minor typos and word cor...

[jdanekrh]

Github user jdanekrh commented on the issue:

https://github.com/apache/activemq-artemis/pull/1296
  
I have two more small fixes that I did not want to put into a PR of its 
own. Can you please look at https://github.com/michalxo/activemq-artemis/pull/1 
and maybe incorporate? thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1296: DOC(Addressing Model) minor typos and w...

[michalxo]

GitHub user michalxo opened a pull request:

https://github.com/apache/activemq-artemis/pull/1296

DOC(Addressing Model) minor typos and word corrections

My first try of PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michalxo/activemq-artemis doc-issues

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1296.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1296


commit 821e034482d4c8b35cee4fad30b2e06984d1d915
Author: Michal Tóth 
Date:   2017-05-29T08:39:02Z

DOC(Addressing Model) minor typos and word corrections




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1295: ARTEMIS-1185 Inter-Process Journal Samp...

[franz1981]

GitHub user franz1981 opened a pull request:

https://github.com/apache/activemq-artemis/pull/1295

ARTEMIS-1185 Inter-Process Journal Sampler Profiler + CLI command



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/franz1981/activemq-artemis 
real_time_journal_latency

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1295


commit 87b59431dbab8d987d217bb9bcdaac688bd5f120
Author: Francesco Nigro 
Date:   2017-05-17T08:35:35Z

ARTEMIS-1185 Inter-Process Journal Sampler Profiler + CLI command




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---