[GitHub] activemq-artemis issue #1466: ARTEMIS-1353 ensure replication packet order

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1466
  
I want to do some review on the extra wait. Wait for me to merge this ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1466: ARTEMIS-1353 ensure replication packet order

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1466
  
The wait is in ReplicationManager#sendStartSyncMessage.  It's essentially 
the same kind of thing that's done in 
ReplicationManager#sendSynchronizationDone.

BTW, I ran the full test-suite.  No regressions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

How to use ActiveMQCPP work on AIX??

[yupub]

I build ActiveMQCPP on AIX with compiler xlC, But it not work well. On Linux
is ok. It suspend on transport->start. Who use ActiveMQCPP on aix?



--
View this message in context: 
http://activemq.2283324.n4.nabble.com/How-to-use-ActiveMQCPP-work-on-AIX-tp4729715.html
Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.

[GitHub] activemq-artemis issue #1466: ARTEMIS-1353 ensure replication packet order

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1466
  
Where did you add the wait ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1466: ARTEMIS-1353 ensure replication packet order

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1466
  
Please wait me to merge this?  I want to review this carefully tomorrow. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1466: ARTEMIS-1353 ensure replication packet ...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1466

ARTEMIS-1353 ensure replication packet order

Incorrect ordering of replication packets may happen because of
useExecutor parameter in the sendReplicatePacket method.
ReplicationStartSyncMessage packets are sent as first, but they are sent
with useExecutor=true. Although ReplicationSyncFileMessage packets are
sent after ReplicationStartSyncMessage packets, they are sent with
useExecutor=false. So sending of ReplicationStartSyncMessage packets is
scheduled to executor and there is no guarantee when the task will be
executed, whereas ReplicationStartSyncMessage packets are sent
immediately.

The solution is to wait for an ack for ReplicationStartSyncMessages.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1353

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1466


commit a9f3dcfb10314763d5feeff6d56de9694cc0ede1
Author: Justin Bertram 
Date:   2017-08-16T17:08:31Z

ARTEMIS-1353 ensure replication packet order

Incorrect ordering of replication packets may happen because of
useExecutor parameter in the sendReplicatePacket method.
ReplicationStartSyncMessage packets are sent as first, but they are sent
with useExecutor=true. Although ReplicationSyncFileMessage packets are
sent after ReplicationStartSyncMessage packets, they are sent with
useExecutor=false. So sending of ReplicationStartSyncMessage packets is
scheduled to executor and there is no guarantee when the task will be
executed, whereas ReplicationStartSyncMessage packets are sent
immediately.

The solution is to wait for an ack for ReplicationStartSyncMessages.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[question] Gluster file system

[Clebert Suconic]

Has anyone tried activemq 5 with shared storage and gluster file system?

If so what challenges did you have?

I'm wondering what I would need to change in artemis to support it. (If any
change is required)



Thanks.
-- 
Clebert Suconic

[GitHub] activemq-artemis pull request #1465: NOJIRA fix security policy for Netty te...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1465

NOJIRA fix security policy for Netty test



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis master_work

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1465


commit e2cfaa69c6b6c65c40022cca4a8aa878724430e6
Author: Justin Bertram 
Date:   2017-08-16T17:49:40Z

NOJIRA fix security policy for Netty test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1464: Implement support for intercepting additional ...

[orpiske]

Github user orpiske commented on the issue:

https://github.com/apache/activemq-artemis/pull/1464
  
Sample output from running the modified Interceptor example:

```
server-out:MQTT Interceptor gets called 
server-out:A MQTT control packet was intercepted CONNACK
server-out:MQTT Interceptor gets called 
server-out:A MQTT control packet was intercepted CONNECT
server-out:A MQTT CONNECT control packet was intercepted 
MqttConnectMessage[fixedHeader=MqttFixedHeader[messageType=CONNECT, 
isDup=false, qosLevel=AT_MOST_ONCE, isRetain=false, remainingLength=34], 
variableHeader=MqttConnectVariableHeader[name=MQIsdp, version=3, 
hasUserName=false, hasPassword=false, isWillRetain=false, isWillFlag=false, 
isCleanSession=true, keepAliveTimeSeconds=30], 
payload=MqttConnectPayload[clientIdentifier=7f01d5e85993fe7f, 
willTopic=null, willMessage=null, userName=null, password=null]]
Connected to Artemis
server-out:MQTT Interceptor gets called 
server-out:A MQTT control packet was intercepted SUBSCRIBE
Subscribed to topics.
server-out:MQTT Interceptor gets called 
server-out:A MQTT control packet was intercepted PUBLISH
server-out:Original message: This is message 1
server-out:MQTT Interceptor gets called 
server-out:A MQTT control packet was intercepted PUBLISH
server-out:Original message: Modified message 
server-out:MQTT Interceptor gets called 
server-out:A MQTT control packet was intercepted PUBREC
server-out:MQTT Interceptor gets called 
server-out:A MQTT control packet was intercepted PUBREL
server-out:MQTT Interceptor gets called 
server-out:A MQTT control packet was intercepted PUBCOMP
Sent message
Received message: Modified message 
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1464: Implement support for intercepting additional ...

[orpiske]

Github user orpiske commented on the issue:

https://github.com/apache/activemq-artemis/pull/1464
  
Some additional comments: @jbertram suggested to also look at  
org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl#invokeInterceptors.
 

While I agree that it seems how it should have been done, it also seems 
like a more comprehensive change. Therefore, I decided to just extend the 
original code to intercept the other MQTT control packets.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1464: Implement support for intercepting addi...

[orpiske]

GitHub user orpiske opened a pull request:

https://github.com/apache/activemq-artemis/pull/1464

Implement support for intercepting additional MQTT control packets

Previously, only the PUBLISH packet was intercepted. This patch modifies 
the code to add support for the other incoming/outgoing MQTT control packets.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/orpiske/activemq-artemis mqtt-interceptor-conn

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1464


commit 48b9573c66d428722fab172290865b986573f764
Author: Otavio R. Piske 
Date:   2017-08-14T17:12:39Z

Implement support for intercepting additional MQTT control packets

Previously, only the PUBLISH packet was intercepted. This patch modifies
the code to add support for the other incoming/outgoing MQTT control
packets.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---