[VOTE] Apache ActiveMQ Artemis 2.3.0

[Clebert Suconic]

I would like to propose an Apache ActiveMQ Artemis 2.3.0 release, CR2.



We had these new features added as part of 2.3.0:

[ARTEMIS-1270] - Provide a Management Console for Artemis
[ARTEMIS-1322] - Add a ServerLocator option to ignore topology for
load-balancing
[ARTEMIS-1324] - Critical Analysis and deadlock detection on broker
[ARTEMIS-1342] - Support Netty Native KQueue on MacOS
[ARTEMIS-1348] - Support LVQ for AMQP
[ARTEMIS-1373] - Allow chaining of Kerberos and LDAP JAAS Login
Modules for authentication and authorisation


Since last week when I first introduced the voting for 2.3.0 (CR1) we
had a few updates addressing issues found on the admin console:

https://github.com/apache/activemq-artemis/commit/e8783e31d04bf850a0e20925f810cbfcb8ac1bb7



The release notes can be found here:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920=12341247


Source and binary distributions can be found here:
https://repository.apache.org/content/repositories/orgapacheactivemq-1148/org/apache/activemq/apache-artemis/2.3.0/


The Maven repository is here:
https://repository.apache.org/content/repositories/orgapacheactivemq-1148


In case you want to give it a try with the maven repo on examples:
http://activemq.apache.org/artemis/docs/latest/hacking-guide/validating-releases.html


The source tag:
https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;a=tag;h=refs/tags/2.3.0

I will update the website after the vote has passed.



[ ] +1 approve the release as Apache Artemis 2.3.0
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Here's my (binding) +1

Regards

[GitHub] activemq-artemis issue #1507: NO-JIRA: Add non-null check to ServerSessionIm...

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1507
  
Thanks guys. @jdanekrh I believe it's same as ARTEMIS-1376. I'll update the 
status.


---

[GitHub] activemq-artemis issue #1505: ARTEMIS-1383 Improved Priority queue

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1505
  
@clebertsuconic Agree, but I wanted to start first with something smaller 
in order to add features when (if) it proves to be stable enough.

Currently I've provided only a fast (a-la ArrayDeque) internal iterator (ie 
forEach): an external Iterator is for sure feasible to be implemented using the 
same algorithm.
What I've to think better is how implement Iterator::remove and 
Iterator::repeat operations: I don't know if they can be replaced by something 
more sympathic with the mechanics of this queue, maybe simplifying the 
QueueImpl code too.

If it shoudn't be possible I'll try to implement the original semantic of 
LinkedListImpl's Iterator on ChunkedQueue too, but I really don't know how much 
time will be needed.


---

[GitHub] activemq-artemis pull request #1510: NO-JIRA improve password masking doc & ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1510


---

[GitHub] activemq-artemis pull request #1510: NO-JIRA improve password masking doc & ...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1510#discussion_r137107873
  
--- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/PasswordMaskingUtil.java
 ---
@@ -54,7 +54,7 @@ private LazySecureProcessorHolder() {
   static {
  HashProcessor processor = null;
  Exception exception = null;
- final String codecDesc = 
"org.apache.activemq.artemis.utils.DefaultSensitiveStringCodec;algorithm=one-way";
--- End diff --

@jbertram duh.. I just read the actual change... thanks!


---

[GitHub] activemq-artemis pull request #1510: NO-JIRA improve password masking doc & ...

[jbertram]

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1510#discussion_r137107437
  
--- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/PasswordMaskingUtil.java
 ---
@@ -54,7 +54,7 @@ private LazySecureProcessorHolder() {
   static {
  HashProcessor processor = null;
  Exception exception = null;
- final String codecDesc = 
"org.apache.activemq.artemis.utils.DefaultSensitiveStringCodec;algorithm=one-way";
--- End diff --

Yes.  There's no semantic change here.  Just changing a hard-coded string 
to something a little more dynamic.


---

[GitHub] activemq-artemis pull request #1510: NO-JIRA improve password masking doc & ...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1510#discussion_r137106890
  
--- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/PasswordMaskingUtil.java
 ---
@@ -54,7 +54,7 @@ private LazySecureProcessorHolder() {
   static {
  HashProcessor processor = null;
  Exception exception = null;
- final String codecDesc = 
"org.apache.activemq.artemis.utils.DefaultSensitiveStringCodec;algorithm=one-way";
--- End diff --

previously encoded passwords will still work?


---

[GitHub] activemq-artemis pull request #1508: Artemis 1373

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1508


---

[GitHub] activemq-artemis issue #1508: Artemis 1373

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1508
  
I will merge now.. @gtully can update docs later.


---

[GitHub] activemq-artemis issue #1503: NO-JIRA added unit test to exercise ActiveMQSe...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1503
  
you need to fix ActiveMQServerControlUsingCoreTest as part of this. Can you 
fix it please?


---

[GitHub] activemq-artemis pull request #1507: NO-JIRA: Add non-null check to ServerSe...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1507


---

[GitHub] activemq-artemis pull request #1510: NO-JIRA improve password masking doc & ...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1510

NO-JIRA improve password masking doc & code

Move password masking documentation into its own chapter and tweak it a
bit for clarity and comprehensiveness.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis master_work

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1510.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1510


commit 42606b3e5ad83af4d49ea9397834fe3528b2dbd6
Author: Justin Bertram 
Date:   2017-09-05T19:30:40Z

NO-JIRA improve password masking doc & code

Move password masking documentation into its own chapter and tweak it a
bit for clarity and comprehensiveness.




---

[GitHub] activemq-artemis issue #1505: ARTEMIS-1383 Improved Priority queue

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1505
  
the biggest chunk you would see in performance would be by changing the 
QueueImpl's collection.

There are a few requirements we need to meet on that collection. starting 
from converting PriorityLinkedListTest to work with the same semantics on 
ChunkedQueue.


I don't see an implementation for Iterator at your Queue though.


---

[GitHub] activemq-artemis issue #1507: NO-JIRA: Add non-null check to ServerSessionIm...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1507
  
for an internal session only.



---

[GitHub] activemq-artemis issue #1507: NO-JIRA: Add non-null check to ServerSessionIm...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1507
  
this happens only on OpenWire.


---

[GitHub] activemq-artemis pull request #1506: ARTEMIS-1384 adding CLI command (stat) ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1506


---

[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (stat) to disp...

[pgfox]

Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/1506
  
changed to 
```
./artemis queue stat ...
```


---

[GitHub] activemq-artemis issue #1508: Artemis 1373

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1508
  
It's really nice to have the documentation update on the same commit as the 
code update so it's easier to understand everything when looking back through 
the history.  However, if that's especially problematic for you then I'm fine 
with you pushing the doc update separately.


---

[GitHub] activemq-artemis issue #1508: Artemis 1373

[gtully]

Github user gtully commented on the issue:

https://github.com/apache/activemq-artemis/pull/1508
  
I will push the doc updates directly if that is ok


---

[GitHub] activemq-artemis issue #1508: Artemis 1373

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1508
  
The code looks good to me, but I'd love to see some documentation updates 
to go along with this.


---

[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (qstat) to dis...

[pgfox]

Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/1506
  
@clebertsuconic hi Clebert, perhaps I am missing something;  I am already 
extending from AbstractAction.  AbstractAction extends from ConnectionAbstract. 
 So I seem to be getting all the connectionAbstract goodness and staying with 
established pattern. It does ask for the user/password if not supplied as you 
mentions. 

thanks
Pat
 


---

[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (qstat) to dis...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1506
  
Can you extend ConnectionAbstract ?

look what I do with Consumer...


if you can't connect, it will ask you for user and password through input.


I find it quite useful but it should keep the standard at least?


---

[GitHub] activemq-artemis pull request #1509: ARTEMIS-1385 fixed uncomplete comment a...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1509


---

[GitHub] activemq-artemis pull request #1509: ARTEMIS-1385 fixed uncomplete comment a...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1509#discussion_r136994424
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt
 ---
@@ -1,6 +1,6 @@
   

[GitHub] activemq-artemis pull request #1509: ARTEMIS-1385 fixed uncomplete comment a...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1509#discussion_r136994236
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt
 ---
@@ -1,6 +1,6 @@
   

[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (qstat) to dis...

[pgfox]

Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/1506
  
@jbertram Thanks Justin. I will move it under the queue group as you 
suggested. 




---

[GitHub] activemq-artemis pull request #1509: ARTEMIS-1385 fixed uncomplete comment a...

[stanlyDoge]

Github user stanlyDoge commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1509#discussion_r136987322
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt
 ---
@@ -1,6 +1,6 @@
   

[GitHub] activemq-artemis pull request #1507: NO-JIRA: Add non-null check to ServerSe...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1507#discussion_r136985490
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
 ---
@@ -348,7 +348,9 @@ public boolean removeConsumer(final long consumerID) 
throws Exception {
}
 
protected void doClose(final boolean failed) throws Exception {
-  callback.close(failed);
--- End diff --

callback is a final... I would rather fix why this became null.. this 
wasn't supposed to be null.


---

[GitHub] activemq-artemis pull request #1509: ARTEMIS-1385 fixed uncomplete comment a...

[jdanekrh]

Github user jdanekrh commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1509#discussion_r136984584
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt
 ---
@@ -1,6 +1,6 @@
   

[GitHub] activemq-artemis pull request #1509: ARTEMIS-1385 fixed uncomplete comment a...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1509#discussion_r136983654
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt
 ---
@@ -1,6 +1,6 @@
   

[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (qstat) to dis...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1506
  
I think rather than having this as a "top level" command it should be 
nested under the resource type, in this case "queue" so that the command would 
be:

`./artemis queue stat ...`

I can imagine in the future we'll want to add a CLI 'stat' command for 
other resource types like address and maybe consumer.

This is a great addition, BTW.  Kudos, @pgfox. 


---

[GitHub] activemq-artemis issue #1506: ARTEMIS-1384 adding CLI command (qstat) to dis...

[pgfox]

Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/1506
  
Updated to filter on any of the columns returned 

```
$ ./artemis qstat --user admin --password admin --field ADDRESS --operation 
EQUALS --value test500
|NAME |ADDRESS  |CONSUMER_COUNT 
|MESSAGE_COUNT |MESSAGES_ADDED |DELIVERING_COUNT |MESSAGES_ACKED |
|test500  |test500  |0  |1000   
   |1000   |0|0  |
```

--queueName=X can still be used as a shortcut to filter by "NAME that 
contains String X"

```
$ ./artemis qstat --user admin --password admin --queueName test
|NAME |ADDRESS  |CONSUMER_COUNT 
|MESSAGE_COUNT |MESSAGES_ADDED |DELIVERING_COUNT |MESSAGES_ACKED |
|test500  |test500  |0  |1000   
   |1000   |0|0  |
|test501  |test501  |0  |50 
   |50 |0|0  |
|test502  |test502  |0  |75 
   |75 |0|0  |
|test503  |test503  |0  |90 
   |90 |0|0  |
|test504  |test504  |0  |200
   |200|0|0  |

```



---

[GitHub] activemq-artemis pull request #1509: ARTEMIS-1385 fixed uncomplete comment a...

[jdanekrh]

Github user jdanekrh commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1509#discussion_r136912715
  
--- Diff: docs/user-manual/en/configuration-index.md ---
@@ -112,7 +112,7 @@ system-property-prefix | Prefix for replacing 
configuration settings using Bean
 [transaction-timeout](transaction-config.md "Resource Manager 
Configuration")  |  how long (in ms) before a transaction can be 
removed from the resource manager after create time. Default=30
 [transaction-timeout-scan-period](transaction-config.md "Resource Manager 
Configuration")  |  how often (in ms) to scan for timeout transactions. 
Default=1000
 [wild-card-routing-enabled](wildcard-routing.md "Routing Messages With 
Wild Cards")|  true means that the server supports wild card routing. 
Default=true
-[network-check-NIC](network-isolation.md) | The network internet card to 
be used on InetAddress.isReacheable
+[network-check-NIC](network-isolation.md) | The network internet 
controller to be used on InetAddress.isReacheable
--- End diff --

NIC is Network Interface Controller. I had to google that and I guess it 
won't be obvious to more people. Maybe write the abbreviation and the meaning 
in parens after it, so that people learn this right away.

Also, it may not be entirely obvious what are the NIC names. Something like 
eth0 on Linux? What it is on Windows? How can I list them? Any alternatives to 
this for older systems, that do not have the more robust "enp0s25" style naming 
and eth0 and eth1 may be randomly switched; or is that no longer a problem?


---

[GitHub] activemq-artemis issue #1505: ARTEMIS-1383 Improved Priority queue

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1505
  
@clebertsuconic In the meantime I've done some experiments with [Java 
Object Layout](http://openjdk.java.net/projects/code-tools/jol/), a tool that 
compute the deep size of any instance on the heap, to evaluate the difference 
(memory wise) between `LinkedListImpl` and `ChunkedQueue`.
I've used a very small chunk size of 32 (ie with arrays of 33 elements for 
each chunk), to compare with `LinkedListImpl`.
With no instances:
```
org.apache.activemq.artemis.utils.collections.LinkedListImpl@7ba4f24fd 
footprint:
 COUNT   AVG   SUM   DESCRIPTION
 15656   
[Lorg.apache.activemq.artemis.utils.collections.LinkedListImpl$Iterator;
 14040   
org.apache.activemq.artemis.utils.collections.LinkedListImpl
 13232   
org.apache.activemq.artemis.utils.collections.LinkedListImpl$Node
 3 128   (total)


org.apache.activemq.load.generator.ChunkedQueue@6ed3ef1d footprint:
 COUNT   AVG   SUM   DESCRIPTION
 1   152   152   [Ljava.lang.Object;
 14040   
org.apache.activemq.load.generator.ChunkedQueue
 2 192   (total)
```
With 31 instances:
```
org.apache.activemq.artemis.utils.collections.LinkedListImpl@7ba4f24fd 
footprint:
 COUNT   AVG   SUM   DESCRIPTION
 15656   
[Lorg.apache.activemq.artemis.utils.collections.LinkedListImpl$Iterator;
 12424   java.lang.Long
 14040   
org.apache.activemq.artemis.utils.collections.LinkedListImpl
3232  1024   
org.apache.activemq.artemis.utils.collections.LinkedListImpl$Node
351144   (total)


org.apache.activemq.load.generator.ChunkedQueue@57fa26b7d footprint:
 COUNT   AVG   SUM   DESCRIPTION
 1   152   152   [Ljava.lang.Object;
 12424   java.lang.Long
 14040   
org.apache.activemq.load.generator.ChunkedQueue
 3 216   (total)
```
With 1 instance:
```
org.apache.activemq.artemis.utils.collections.LinkedListImpl@7ba4f24fd 
footprint:
 COUNT   AVG   SUM   DESCRIPTION
 15656   
[Lorg.apache.activemq.artemis.utils.collections.LinkedListImpl$Iterator;
 12424   java.lang.Long
 14040   
org.apache.activemq.artemis.utils.collections.LinkedListImpl
 1000132320032   
org.apache.activemq.artemis.utils.collections.LinkedListImpl$Node
 10004  320152   (total)


org.apache.activemq.load.generator.ChunkedQueue@1894593ad footprint:
 COUNT   AVG   SUM   DESCRIPTION
   323   152 49096   [Ljava.lang.Object;
 12424   java.lang.Long
 11616   java.lang.Object
 14040   
org.apache.activemq.load.generator.ChunkedQueue
   326   49176   (total)
```
Totals are pretty explicative, the `ChunkedQueue` (even with very small 
chunk size) tends to have a 10X smaller memory footprint than a 
`LinkedListImpl`.






---

[GitHub] activemq-artemis pull request #1509: ARTEMIS-1385 fixed uncomplete comment a...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1509

ARTEMIS-1385 fixed uncomplete comment and typo



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1385

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1509


commit a6c0789e4da2b2f4b5854db8b3e67bb770d86c2f
Author: Stanislav Knot 
Date:   2017-09-05T07:09:01Z

ARTEMIS-1385 fixed uncomplete comment and typo




---