[GitHub] activemq-artemis pull request #1542: ARTEMIS-1424 Openwire not work with dif...

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1542#discussion_r139854686
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java
 ---
@@ -436,11 +435,11 @@ public ServerSession getCoreSession() {
public ActiveMQServer getCoreServer() {
   return this.server;
}
-
+/*
--- End diff --

doh, forgot it. I think I commented it out back then thinking it might be 
used somewhere else.
Thanks @tabish121 . Branch updated.


---

Apache NMS with .NET Standard/Core

[thierrym06]

Hello,

The last APACHE.NMS (v1.7.1) assembly is apparently not compatible with .NET
standard / .NET Core.

Do you have any plan to convert this assembly to a .NET standard assembly?
When?

Thanks.

Regard,
Thierry M.




--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

[GitHub] activemq-artemis pull request #1542: ARTEMIS-1424 Openwire not work with dif...

[tabish121]

Github user tabish121 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1542#discussion_r139834842
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java
 ---
@@ -436,11 +435,11 @@ public ServerSession getCoreSession() {
public ActiveMQServer getCoreServer() {
   return this.server;
}
-
+/*
--- End diff --

Why comment this out, the source control maintains history so leaving old 
dead code in is not needed, you can just review the commit history to see it.  


---

[GitHub] activemq-artemis pull request #1543: NO-JIRA update StatQueue to allow GREAT...

[pgfox]

GitHub user pgfox opened a pull request:

https://github.com/apache/activemq-artemis/pull/1543

NO-JIRA update StatQueue to allow GREATER_THAN/LESS_THAN operations



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pgfox/activemq-artemis statQueue_update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1543.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1543


commit 5fba30521a62f3b57396b8b678a6e96f09255bba
Author: Pat Fox 
Date:   2017-09-19T14:45:07Z

NO-JIRA update StatQueue to allow GREATER_THAN/LESS_THAN comparison




---

APACHE NMS with .NET Standard/Core

[thierrym06]

Hello, 

The last APACHE.NMS (v1.7.1) assembly is apparently not compatible with .NET
standard / .NET Core. 

Do you have any plan to convert this assembly to a .NET standard assembly?
When? 

Thanks. 

Regard, 
Thierry M. 



--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

[GitHub] activemq-artemis pull request #1534: ARTEMIS-1420 limit non-ssl connection h...

[stanlyDoge]

Github user stanlyDoge commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1534#discussion_r139663458
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpClientTestSupport.java
 ---
@@ -185,6 +187,7 @@ protected TransportConfiguration 
addAcceptorConfiguration(ActiveMQServer server,
   HashMap params = new HashMap<>();
   params.put(TransportConstants.PORT_PROP_NAME, String.valueOf(port));
   params.put(TransportConstants.PROTOCOLS_PROP_NAME, 
getConfiguredProtocols());
+  params.put(TransportConstants.NETTY_READ_TIMEOUT, readTimeout);
--- End diff --

Actually it is 3 seconds. It is just typo in property string. I've tried to 
make test as you say. Check it in new commit. And thanks for reviewing! :)


---