[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

[jmesnil]

Github user jmesnil commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1764#discussion_r160605068
  
--- Diff: 
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
 ---
@@ -188,13 +189,15 @@ public void setDeserializationWhiteList(String 
whiteList) {
@Override
public void readExternal(ObjectInput in) throws IOException, 
ClassNotFoundException {
   String url = in.readUTF();
+  System.out.println("Reading " + url);
--- End diff --

should be removed


---

[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

[jmesnil]

Github user jmesnil commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1764#discussion_r160605042
  
--- Diff: 
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
 ---
@@ -95,6 +95,7 @@ public void writeExternal(ObjectOutput out) throws 
IOException {
   URI uri = toURI();
 
   try {
+ System.out.println("writing " + uri.toASCIIString());
--- End diff --

should be removed


---

[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

[jmesnil]

Github user jmesnil commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1764#discussion_r160605094
  
--- Diff: 
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
 ---
@@ -188,13 +189,15 @@ public void setDeserializationWhiteList(String 
whiteList) {
@Override
public void readExternal(ObjectInput in) throws IOException, 
ClassNotFoundException {
   String url = in.readUTF();
+  System.out.println("Reading " + url);
   ConnectionFactoryParser parser = new ConnectionFactoryParser();
   ServerLocatorParser locatorParser = new ServerLocatorParser();
   try {
  URI uri = new URI(url);
  serverLocator = locatorParser.newObject(uri, null);
  parser.populateObject(uri, this);
   } catch (Exception e) {
+ e.printStackTrace();
--- End diff --

should be removed


---

[GitHub] activemq-artemis issue #1757: ARTEMIS-1586 Reduce GC pressure due to String ...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1757
  
@franz1981 done, also spotted a few wasteful bits in AMQP as well, where it 
went from String to SimpleString, back to String and back to SimpleString (or 
repeatedly created SimpleString from String), so cleaned that up .


---

[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1764#discussion_r160573966
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java
 ---
@@ -143,6 +143,8 @@ public void channelRead(ChannelHandlerContext ctx, 
Object msg) throws Exception
  }
   }
 
+
+  // the innitial communication happens here...
--- End diff --

hahaha you left this in from the web conf :) 


---

[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

[clebertsuconic]

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1764

ARTEMIS-1595 Fixing serialization issues between Artemis 1.5 and master



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis serialization

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1764.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1764


commit 37b89625b929ea1966dd534d47de9c60e133bee4
Author: Clebert Suconic 
Date:   2018-01-10T01:27:17Z

ARTEMIS-1595 Fixing serialization issues between Artemis 1.5 and master




---

Re: [DISCUSS] Video call on ActiveMQ Artemis

[Clebert Suconic]

I will send the video tomorrow.

On Tue, Jan 9, 2018 at 3:00 PM Christopher Shannon <
christopher.l.shan...@gmail.com> wrote:

> I won't be able to make it today but I'll be sure to check out the replay,
> thanks again Clebert.
>
> On Tue, Jan 9, 2018 at 11:46 AM, Michael André Pearce <
> michael.andre.pea...@me.com> wrote:
>
> > Great cannot wait.
> >
> > And thanks in advance.
> >
> >
> > We shall have to tweet your video!
> >
> > Sent from my iPhone
> >
> > > On 9 Jan 2018, at 15:08, Clebert Suconic 
> > wrote:
> > >
> > > this will be done today at 3 PM EST (5 hours from the time I'm sending
> > > this email)
> > >
> > >
> > > I will be using bluejeans, which is an app I use at work... you need
> > > to install the software, in order to do so, visit:
> > >
> > > https://www.bluejeans.com
> > >
> > > There are apps for windows, mac, Linux, iOS and Android as far as I
> > know...
> > >
> > >
> > >
> > > I will start the meeting promptly at 3PM EST, for that follow this
> link:
> > >
> > > https://bluejeans.com/6546711481
> > >
> > >
> > >
> > >
> > > I will record the meeting, and upload it to my personal youtube and
> > > provide a link here. (we should perhaps create an youtube account for
> > > activemq)
> > >
> > >
> > >
> > >> On Sat, Dec 30, 2017 at 11:18 AM, Arthur Naseef 
> wrote:
> > >> I might be able to make it then.  Probably 50/50.  That week involves
> > >> travel for me.
> > >>
> > >> Art
> > >>
> > >>
> > >> On Wed, Dec 20, 2017 at 3:49 PM, Clebert Suconic <
> > clebert.suco...@gmail.com>
> > >> wrote:
> > >>
> > >>> What about Jan-9th, 3PM EST?
> > >>>
> > >>> On Tue, Dec 19, 2017 at 8:37 AM, Bruce Snyder <
> bruce.sny...@gmail.com>
> > >>> wrote:
> >  Can we schedule something now so that the time is blocked in our
> > >>> calendars?
> > 
> >  Bruce
> > 
> >  On Mon, Dec 18, 2017 at 8:03 PM, Clebert Suconic <
> > >>> clebert.suco...@gmail.com>
> >  wrote:
> > 
> > > I got so deeply involved with the compatibility issue I was working
> > > on.. and the year is already gone for me...
> > >
> > >
> > > I will try this around 2nd week of Jan.
> > >
> > > On Fri, Dec 8, 2017 at 3:30 AM, Francesco Nigro <
> nigro@gmail.com
> > >
> > > wrote:
> > >> +1 I've had something similar with Clebert in the past and it was
> > very
> > >> useful indeed!
> > >>
> > >> Thanks Clebert for this great idea and I agree with Michael that
> > > probably I
> > >> will follow it in the evening too :)
> > >>
> > >> Cheers,
> > >> Franz
> > >>
> > >> Il giorno ven 8 dic 2017 alle ore 02:04 Christopher Shannon <
> > >> christopher.l.shan...@gmail.com> ha scritto:
> > >>
> > >>> +1 from me as well.  Recording the session is a great idea for
> > anyone
> > > who
> > >>> can’t make it
> > >>>
> >  On Thu, Dec 7, 2017 at 6:52 PM artnaseef 
> wrote:
> > 
> >  +1 Count me in.  Hope I can make it.
> > 
> > 
> > 
> > 
> >  --
> >  Sent from:
> > 
> http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
> > 
> > >>>
> > >
> > >
> > >
> > > --
> > > Clebert Suconic
> > >
> > 
> > 
> > 
> >  --
> >  perl -e 'print
> >  unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E > );'
> > 
> >  ActiveMQ in Action: http://bit.ly/2je6cQ
> >  Blog: http://bsnyder.org/ 
> >  Twitter: http://twitter.com/brucesnyder
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Clebert Suconic
> > >>>
> > >
> > >
> > >
> > > --
> > > Clebert Suconic
> >
>
-- 
Clebert Suconic

Re: [DISCUSS] Video call on ActiveMQ Artemis

[Christopher Shannon]

I won't be able to make it today but I'll be sure to check out the replay,
thanks again Clebert.

On Tue, Jan 9, 2018 at 11:46 AM, Michael André Pearce <
michael.andre.pea...@me.com> wrote:

> Great cannot wait.
>
> And thanks in advance.
>
>
> We shall have to tweet your video!
>
> Sent from my iPhone
>
> > On 9 Jan 2018, at 15:08, Clebert Suconic 
> wrote:
> >
> > this will be done today at 3 PM EST (5 hours from the time I'm sending
> > this email)
> >
> >
> > I will be using bluejeans, which is an app I use at work... you need
> > to install the software, in order to do so, visit:
> >
> > https://www.bluejeans.com
> >
> > There are apps for windows, mac, Linux, iOS and Android as far as I
> know...
> >
> >
> >
> > I will start the meeting promptly at 3PM EST, for that follow this link:
> >
> > https://bluejeans.com/6546711481
> >
> >
> >
> >
> > I will record the meeting, and upload it to my personal youtube and
> > provide a link here. (we should perhaps create an youtube account for
> > activemq)
> >
> >
> >
> >> On Sat, Dec 30, 2017 at 11:18 AM, Arthur Naseef  wrote:
> >> I might be able to make it then.  Probably 50/50.  That week involves
> >> travel for me.
> >>
> >> Art
> >>
> >>
> >> On Wed, Dec 20, 2017 at 3:49 PM, Clebert Suconic <
> clebert.suco...@gmail.com>
> >> wrote:
> >>
> >>> What about Jan-9th, 3PM EST?
> >>>
> >>> On Tue, Dec 19, 2017 at 8:37 AM, Bruce Snyder 
> >>> wrote:
>  Can we schedule something now so that the time is blocked in our
> >>> calendars?
> 
>  Bruce
> 
>  On Mon, Dec 18, 2017 at 8:03 PM, Clebert Suconic <
> >>> clebert.suco...@gmail.com>
>  wrote:
> 
> > I got so deeply involved with the compatibility issue I was working
> > on.. and the year is already gone for me...
> >
> >
> > I will try this around 2nd week of Jan.
> >
> > On Fri, Dec 8, 2017 at 3:30 AM, Francesco Nigro  >
> > wrote:
> >> +1 I've had something similar with Clebert in the past and it was
> very
> >> useful indeed!
> >>
> >> Thanks Clebert for this great idea and I agree with Michael that
> > probably I
> >> will follow it in the evening too :)
> >>
> >> Cheers,
> >> Franz
> >>
> >> Il giorno ven 8 dic 2017 alle ore 02:04 Christopher Shannon <
> >> christopher.l.shan...@gmail.com> ha scritto:
> >>
> >>> +1 from me as well.  Recording the session is a great idea for
> anyone
> > who
> >>> can’t make it
> >>>
>  On Thu, Dec 7, 2017 at 6:52 PM artnaseef  wrote:
> 
>  +1 Count me in.  Hope I can make it.
> 
> 
> 
> 
>  --
>  Sent from:
>  http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
> 
> >>>
> >
> >
> >
> > --
> > Clebert Suconic
> >
> 
> 
> 
>  --
>  perl -e 'print
>  unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E );'
> 
>  ActiveMQ in Action: http://bit.ly/2je6cQ
>  Blog: http://bsnyder.org/ 
>  Twitter: http://twitter.com/brucesnyder
> >>>
> >>>
> >>>
> >>> --
> >>> Clebert Suconic
> >>>
> >
> >
> >
> > --
> > Clebert Suconic
>

Re: Board report for January 2018

[Bruce Snyder]

Thank you, Justin.

Bruce

On Tue, Jan 9, 2018 at 12:24 PM, Justin Bertram  wrote:

> I added a bullet point for the Artemis 2.4.0 release.
>
>
> Justin
>
> On Tue, Jan 9, 2018 at 1:20 PM, Bruce Snyder 
> wrote:
>
> > Hi Mike,
> >
> > Hmm, I'm not sure why you would not be able to edit the wiki page. I did
> > not restrict it in any way.
> >
> > Anyhow, thank you very much for the contributions. I will add these to
> the
> > report.
> >
> > Bruce
> >
> > On Tue, Jan 9, 2018 at 9:55 AM, Michael André Pearce <
> > michael.andre.pea...@me.com> wrote:
> >
> > > Hi Bruce I can’t seem to edit the wiki.
> > >
> > > Anyhow I think should mention Clebert’s web conference of a broker walk
> > > through that’s happening tonight.
> > >
> > > Also should mention the web console for artemis has had good adoption
> > with
> > > contributors beyond that of the originals joining in.
> > >
> > > Cheers
> > > Mike
> > >
> > > Sent from my iPhone
> > >
> > > > On 9 Jan 2018, at 13:34, Bruce Snyder 
> wrote:
> > > >
> > > > Just one more reminder, there has been zero contributions to the
> board
> > > > report and I really need some help compiling it.
> > > >
> > > > Please take just a few minutes to glance over what I have so far and
> > > > augment it with some additional information, even if it's just a
> > sentence
> > > > or two.
> > > >
> > > > https://cwiki.apache.org/confluence/pages/viewpage.
> > > action?pageId=75956340
> > > >
> > > > Time is of the essence as this report needs to be submitted tomorrow.
> > > >
> > > > Thanks for your help!
> > > >
> > > > Bruce
> > > >
> > > >> On Tue, Jan 2, 2018 at 2:58 PM, Bruce Snyder <
> bruce.sny...@gmail.com>
> > > wrote:
> > > >>
> > > >> Happy New Year!
> > > >>
> > > >> It's always helpful to the board to understand the actual activity
> > > within
> > > >> the project beyond just releases and boilerplate muck. I have added
> a
> > > few
> > > >> items regarding activity to get the report started. Please take a
> few
> > > >> moments to contribute to this month's report:
> > > >>
> > > >> https://cwiki.apache.org/confluence/pages/viewpage.
> > > action?pageId=75956340
> > > >>
> > > >> This report must be submitted by 10 Jan 2018.
> > > >>
> > > >> Bruce
> > > >>
> > > >> --
> > > >> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> > > >> 5R\"F)R=6-E+G-N>61E > > >>
> > > >> ActiveMQ in Action: http://bit.ly/2je6cQ
> > > >> Blog: http://bsnyder.org/ 
> > > >> Twitter: http://twitter.com/brucesnyder
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > > perl -e 'print
> > > > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E > );'
> > > >
> > > > ActiveMQ in Action: http://bit.ly/2je6cQ
> > > > Blog: http://bsnyder.org/ 
> > > > Twitter: http://twitter.com/brucesnyder
> > >
> >
> >
> >
> > --
> > perl -e 'print
> > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E >
> > ActiveMQ in Action: http://bit.ly/2je6cQ
> > Blog: http://bsnyder.org/ 
> > Twitter: http://twitter.com/brucesnyder
> >
>



-- 
perl -e 'print
unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E
Twitter: http://twitter.com/brucesnyder

Re: Board report for January 2018

[Bruce Snyder]

Sorry about this, Mike. I have added it to the current report.

Bruce

On Tue, Jan 9, 2018 at 10:00 AM, Michael André Pearce <
michael.andre.pea...@me.com> wrote:

> One other I’m not personally fussed.
>
> But I noted that in last report it was omitted that I was added as a
> committer. Not sure if formally it was meant to have been reported or
> noted, and if any correction needs to be made in this one
>
> Sent from my iPhone
>
> > On 9 Jan 2018, at 16:55, Michael André Pearce <
> michael.andre.pea...@me.com> wrote:
> >
> > Hi Bruce I can’t seem to edit the wiki.
> >
> > Anyhow I think should mention Clebert’s web conference of a broker walk
> through that’s happening tonight.
> >
> > Also should mention the web console for artemis has had good adoption
> with contributors beyond that of the originals joining in.
> >
> > Cheers
> > Mike
> >
> > Sent from my iPhone
> >
> >> On 9 Jan 2018, at 13:34, Bruce Snyder  wrote:
> >>
> >> Just one more reminder, there has been zero contributions to the board
> >> report and I really need some help compiling it.
> >>
> >> Please take just a few minutes to glance over what I have so far and
> >> augment it with some additional information, even if it's just a
> sentence
> >> or two.
> >>
> >> https://cwiki.apache.org/confluence/pages/viewpage.
> action?pageId=75956340
> >>
> >> Time is of the essence as this report needs to be submitted tomorrow.
> >>
> >> Thanks for your help!
> >>
> >> Bruce
> >>
> >>> On Tue, Jan 2, 2018 at 2:58 PM, Bruce Snyder 
> wrote:
> >>>
> >>> Happy New Year!
> >>>
> >>> It's always helpful to the board to understand the actual activity
> within
> >>> the project beyond just releases and boilerplate muck. I have added a
> few
> >>> items regarding activity to get the report started. Please take a few
> >>> moments to contribute to this month's report:
> >>>
> >>> https://cwiki.apache.org/confluence/pages/viewpage.
> action?pageId=75956340
> >>>
> >>> This report must be submitted by 10 Jan 2018.
> >>>
> >>> Bruce
> >>>
> >>> --
> >>> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> >>> 5R\"F)R=6-E+G-N>61E >>>
> >>> ActiveMQ in Action: http://bit.ly/2je6cQ
> >>> Blog: http://bsnyder.org/ 
> >>> Twitter: http://twitter.com/brucesnyder
> >>>
> >>
> >>
> >>
> >> --
> >> perl -e 'print
> >> unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E );'
> >>
> >> ActiveMQ in Action: http://bit.ly/2je6cQ
> >> Blog: http://bsnyder.org/ 
> >> Twitter: http://twitter.com/brucesnyder
>



-- 
perl -e 'print
unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E
Twitter: http://twitter.com/brucesnyder

Re: Board report for January 2018

[Justin Bertram]

I added a bullet point for the Artemis 2.4.0 release.


Justin

On Tue, Jan 9, 2018 at 1:20 PM, Bruce Snyder  wrote:

> Hi Mike,
>
> Hmm, I'm not sure why you would not be able to edit the wiki page. I did
> not restrict it in any way.
>
> Anyhow, thank you very much for the contributions. I will add these to the
> report.
>
> Bruce
>
> On Tue, Jan 9, 2018 at 9:55 AM, Michael André Pearce <
> michael.andre.pea...@me.com> wrote:
>
> > Hi Bruce I can’t seem to edit the wiki.
> >
> > Anyhow I think should mention Clebert’s web conference of a broker walk
> > through that’s happening tonight.
> >
> > Also should mention the web console for artemis has had good adoption
> with
> > contributors beyond that of the originals joining in.
> >
> > Cheers
> > Mike
> >
> > Sent from my iPhone
> >
> > > On 9 Jan 2018, at 13:34, Bruce Snyder  wrote:
> > >
> > > Just one more reminder, there has been zero contributions to the board
> > > report and I really need some help compiling it.
> > >
> > > Please take just a few minutes to glance over what I have so far and
> > > augment it with some additional information, even if it's just a
> sentence
> > > or two.
> > >
> > > https://cwiki.apache.org/confluence/pages/viewpage.
> > action?pageId=75956340
> > >
> > > Time is of the essence as this report needs to be submitted tomorrow.
> > >
> > > Thanks for your help!
> > >
> > > Bruce
> > >
> > >> On Tue, Jan 2, 2018 at 2:58 PM, Bruce Snyder 
> > wrote:
> > >>
> > >> Happy New Year!
> > >>
> > >> It's always helpful to the board to understand the actual activity
> > within
> > >> the project beyond just releases and boilerplate muck. I have added a
> > few
> > >> items regarding activity to get the report started. Please take a few
> > >> moments to contribute to this month's report:
> > >>
> > >> https://cwiki.apache.org/confluence/pages/viewpage.
> > action?pageId=75956340
> > >>
> > >> This report must be submitted by 10 Jan 2018.
> > >>
> > >> Bruce
> > >>
> > >> --
> > >> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> > >> 5R\"F)R=6-E+G-N>61E > >>
> > >> ActiveMQ in Action: http://bit.ly/2je6cQ
> > >> Blog: http://bsnyder.org/ 
> > >> Twitter: http://twitter.com/brucesnyder
> > >>
> > >
> > >
> > >
> > > --
> > > perl -e 'print
> > > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E );'
> > >
> > > ActiveMQ in Action: http://bit.ly/2je6cQ
> > > Blog: http://bsnyder.org/ 
> > > Twitter: http://twitter.com/brucesnyder
> >
>
>
>
> --
> perl -e 'print
> unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E
> ActiveMQ in Action: http://bit.ly/2je6cQ
> Blog: http://bsnyder.org/ 
> Twitter: http://twitter.com/brucesnyder
>

Re: Board report for January 2018

[Bruce Snyder]

Hi Mike,

Hmm, I'm not sure why you would not be able to edit the wiki page. I did
not restrict it in any way.

Anyhow, thank you very much for the contributions. I will add these to the
report.

Bruce

On Tue, Jan 9, 2018 at 9:55 AM, Michael André Pearce <
michael.andre.pea...@me.com> wrote:

> Hi Bruce I can’t seem to edit the wiki.
>
> Anyhow I think should mention Clebert’s web conference of a broker walk
> through that’s happening tonight.
>
> Also should mention the web console for artemis has had good adoption with
> contributors beyond that of the originals joining in.
>
> Cheers
> Mike
>
> Sent from my iPhone
>
> > On 9 Jan 2018, at 13:34, Bruce Snyder  wrote:
> >
> > Just one more reminder, there has been zero contributions to the board
> > report and I really need some help compiling it.
> >
> > Please take just a few minutes to glance over what I have so far and
> > augment it with some additional information, even if it's just a sentence
> > or two.
> >
> > https://cwiki.apache.org/confluence/pages/viewpage.
> action?pageId=75956340
> >
> > Time is of the essence as this report needs to be submitted tomorrow.
> >
> > Thanks for your help!
> >
> > Bruce
> >
> >> On Tue, Jan 2, 2018 at 2:58 PM, Bruce Snyder 
> wrote:
> >>
> >> Happy New Year!
> >>
> >> It's always helpful to the board to understand the actual activity
> within
> >> the project beyond just releases and boilerplate muck. I have added a
> few
> >> items regarding activity to get the report started. Please take a few
> >> moments to contribute to this month's report:
> >>
> >> https://cwiki.apache.org/confluence/pages/viewpage.
> action?pageId=75956340
> >>
> >> This report must be submitted by 10 Jan 2018.
> >>
> >> Bruce
> >>
> >> --
> >> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> >> 5R\"F)R=6-E+G-N>61E >>
> >> ActiveMQ in Action: http://bit.ly/2je6cQ
> >> Blog: http://bsnyder.org/ 
> >> Twitter: http://twitter.com/brucesnyder
> >>
> >
> >
> >
> > --
> > perl -e 'print
> > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E >
> > ActiveMQ in Action: http://bit.ly/2je6cQ
> > Blog: http://bsnyder.org/ 
> > Twitter: http://twitter.com/brucesnyder
>



-- 
perl -e 'print
unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E
Twitter: http://twitter.com/brucesnyder

[GitHub] activemq-artemis issue #1759: [ARTEMIS-1241] check for FQQN and autocreate q...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1759
  
This looks OK to me.  @mtaylor, will you review this since you opened the 
JIRA?


---

[GitHub] activemq-artemis issue #1754: ARTEMIS-1576 couple more tests for good measur...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1754
  
I ran the PR build myself and it succeeded.  It's been so long since the 
failure that the artifacts have been removed so I can't see why it failed 
originally.


---

[GitHub] activemq-artemis issue #1757: ARTEMIS-1586 Reduce GC pressure due to String ...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1757
  
@franz1981 I've spotted something else the ActiveMQMessage wraps Strings 
into SimpleStrings instead of calling the core Message string equiv methods, as 
such its not getting the benefit, ill do this tonight/tomorrow (depending how 
long Cleberts web conf goes, btw you're attending right? ) 


---

[GitHub] activemq-artemis pull request #1763: ARTEMIS-1594 don't log dlq/expiry warn ...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1763

ARTEMIS-1594 don't log dlq/expiry warn for internal q



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1594

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1763.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1763


commit 373a19aedd7adf8c9eb29392a90bac7c3c40894e
Author: Justin Bertram 
Date:   2018-01-09T17:29:33Z

ARTEMIS-1594 don't log dlq/expiry warn for internal q




---

Re: Board report for January 2018

[Michael André Pearce]

One other I’m not personally fussed.

But I noted that in last report it was omitted that I was added as a committer. 
Not sure if formally it was meant to have been reported or noted, and if any 
correction needs to be made in this one

Sent from my iPhone

> On 9 Jan 2018, at 16:55, Michael André Pearce  
> wrote:
> 
> Hi Bruce I can’t seem to edit the wiki.
> 
> Anyhow I think should mention Clebert’s web conference of a broker walk 
> through that’s happening tonight.
> 
> Also should mention the web console for artemis has had good adoption with 
> contributors beyond that of the originals joining in.
> 
> Cheers
> Mike
> 
> Sent from my iPhone
> 
>> On 9 Jan 2018, at 13:34, Bruce Snyder  wrote:
>> 
>> Just one more reminder, there has been zero contributions to the board
>> report and I really need some help compiling it.
>> 
>> Please take just a few minutes to glance over what I have so far and
>> augment it with some additional information, even if it's just a sentence
>> or two.
>> 
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75956340
>> 
>> Time is of the essence as this report needs to be submitted tomorrow.
>> 
>> Thanks for your help!
>> 
>> Bruce
>> 
>>> On Tue, Jan 2, 2018 at 2:58 PM, Bruce Snyder  wrote:
>>> 
>>> Happy New Year!
>>> 
>>> It's always helpful to the board to understand the actual activity within
>>> the project beyond just releases and boilerplate muck. I have added a few
>>> items regarding activity to get the report started. Please take a few
>>> moments to contribute to this month's report:
>>> 
>>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75956340
>>> 
>>> This report must be submitted by 10 Jan 2018.
>>> 
>>> Bruce
>>> 
>>> --
>>> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
>>> 5R\"F)R=6-E+G-N>61E>> 
>>> ActiveMQ in Action: http://bit.ly/2je6cQ
>>> Blog: http://bsnyder.org/ 
>>> Twitter: http://twitter.com/brucesnyder
>>> 
>> 
>> 
>> 
>> -- 
>> perl -e 'print
>> unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E> 
>> ActiveMQ in Action: http://bit.ly/2je6cQ
>> Blog: http://bsnyder.org/ 
>> Twitter: http://twitter.com/brucesnyder

Re: Board report for January 2018

[Michael André Pearce]

Hi Bruce I can’t seem to edit the wiki.

Anyhow I think should mention Clebert’s web conference of a broker walk through 
that’s happening tonight.

Also should mention the web console for artemis has had good adoption with 
contributors beyond that of the originals joining in.

Cheers
Mike

Sent from my iPhone

> On 9 Jan 2018, at 13:34, Bruce Snyder  wrote:
> 
> Just one more reminder, there has been zero contributions to the board
> report and I really need some help compiling it.
> 
> Please take just a few minutes to glance over what I have so far and
> augment it with some additional information, even if it's just a sentence
> or two.
> 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75956340
> 
> Time is of the essence as this report needs to be submitted tomorrow.
> 
> Thanks for your help!
> 
> Bruce
> 
>> On Tue, Jan 2, 2018 at 2:58 PM, Bruce Snyder  wrote:
>> 
>> Happy New Year!
>> 
>> It's always helpful to the board to understand the actual activity within
>> the project beyond just releases and boilerplate muck. I have added a few
>> items regarding activity to get the report started. Please take a few
>> moments to contribute to this month's report:
>> 
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75956340
>> 
>> This report must be submitted by 10 Jan 2018.
>> 
>> Bruce
>> 
>> --
>> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
>> 5R\"F)R=6-E+G-N>61E> 
>> ActiveMQ in Action: http://bit.ly/2je6cQ
>> Blog: http://bsnyder.org/ 
>> Twitter: http://twitter.com/brucesnyder
>> 
> 
> 
> 
> -- 
> perl -e 'print
> unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E 
> ActiveMQ in Action: http://bit.ly/2je6cQ
> Blog: http://bsnyder.org/ 
> Twitter: http://twitter.com/brucesnyder

Re: [DISCUSS] Video call on ActiveMQ Artemis

[Michael André Pearce]

Great cannot wait. 

And thanks in advance.


We shall have to tweet your video!

Sent from my iPhone

> On 9 Jan 2018, at 15:08, Clebert Suconic  wrote:
> 
> this will be done today at 3 PM EST (5 hours from the time I'm sending
> this email)
> 
> 
> I will be using bluejeans, which is an app I use at work... you need
> to install the software, in order to do so, visit:
> 
> https://www.bluejeans.com
> 
> There are apps for windows, mac, Linux, iOS and Android as far as I know...
> 
> 
> 
> I will start the meeting promptly at 3PM EST, for that follow this link:
> 
> https://bluejeans.com/6546711481
> 
> 
> 
> 
> I will record the meeting, and upload it to my personal youtube and
> provide a link here. (we should perhaps create an youtube account for
> activemq)
> 
> 
> 
>> On Sat, Dec 30, 2017 at 11:18 AM, Arthur Naseef  wrote:
>> I might be able to make it then.  Probably 50/50.  That week involves
>> travel for me.
>> 
>> Art
>> 
>> 
>> On Wed, Dec 20, 2017 at 3:49 PM, Clebert Suconic 
>> wrote:
>> 
>>> What about Jan-9th, 3PM EST?
>>> 
>>> On Tue, Dec 19, 2017 at 8:37 AM, Bruce Snyder 
>>> wrote:
 Can we schedule something now so that the time is blocked in our
>>> calendars?
 
 Bruce
 
 On Mon, Dec 18, 2017 at 8:03 PM, Clebert Suconic <
>>> clebert.suco...@gmail.com>
 wrote:
 
> I got so deeply involved with the compatibility issue I was working
> on.. and the year is already gone for me...
> 
> 
> I will try this around 2nd week of Jan.
> 
> On Fri, Dec 8, 2017 at 3:30 AM, Francesco Nigro 
> wrote:
>> +1 I've had something similar with Clebert in the past and it was very
>> useful indeed!
>> 
>> Thanks Clebert for this great idea and I agree with Michael that
> probably I
>> will follow it in the evening too :)
>> 
>> Cheers,
>> Franz
>> 
>> Il giorno ven 8 dic 2017 alle ore 02:04 Christopher Shannon <
>> christopher.l.shan...@gmail.com> ha scritto:
>> 
>>> +1 from me as well.  Recording the session is a great idea for anyone
> who
>>> can’t make it
>>> 
 On Thu, Dec 7, 2017 at 6:52 PM artnaseef  wrote:
 
 +1 Count me in.  Hope I can make it.
 
 
 
 
 --
 Sent from:
 http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
 
>>> 
> 
> 
> 
> --
> Clebert Suconic
> 
 
 
 
 --
 perl -e 'print
 unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E
 Twitter: http://twitter.com/brucesnyder
>>> 
>>> 
>>> 
>>> --
>>> Clebert Suconic
>>> 
> 
> 
> 
> -- 
> Clebert Suconic

[GitHub] activemq-artemis issue #1534: ARTEMIS-1420 limit non-ssl connection hangs up...

[mbukosky]

Github user mbukosky commented on the issue:

https://github.com/apache/activemq-artemis/pull/1534
  
@jbertram perfect. Thanks for the help. I'll wait until the 2.5.0 release.


---

[GitHub] activemq-artemis issue #1757: ARTEMIS-1586 Reduce GC pressure due to String ...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1757
  
@franz1981 i have now rebased again this brach, after merging 
https://github.com/apache/activemq-artemis/pull/1760 - if you wanted to check 
it out, and re-test.


---

[GitHub] activemq-artemis pull request #1758: More fixes around compatibility

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1758


---

[GitHub] activemq-artemis issue #1534: ARTEMIS-1420 limit non-ssl connection hangs up...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1534
  
@mbukosky, please note that a bug regarding this change was just resolved.  
See #1750.


---

[GitHub] activemq-artemis issue #1534: ARTEMIS-1420 limit non-ssl connection hangs up...

[mtaylor]

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1534
  
@mbukosky Hi, could you open a JIRA here: 
https://issues.apache.org/jira/projects/ARTEMIS.  You can add a description of 
the issue and potential solution.  Also a PR with the fix would be very much 
appreciated.  Thanks


---

[GitHub] activemq-artemis issue #1534: ARTEMIS-1420 limit non-ssl connection hangs up...

[mbukosky]

Github user mbukosky commented on the issue:

https://github.com/apache/activemq-artemis/pull/1534
  
I found a bug with this change. I also have a possible solution. How should 
I got about requesting a fix? Thanks


---

[GitHub] activemq-artemis pull request #1762: ARTEMIS-1580 Browsing in hawtio console...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1762

ARTEMIS-1580 Browsing in hawtio console does not allow to show empty …

…pages

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1580

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1762.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1762


commit c649bc5b64b57c3541125e0ddd38b479bf9d07ac
Author: Stanislav Knot 
Date:   2018-01-09T16:17:49Z

ARTEMIS-1580 Browsing in hawtio console does not allow to show empty pages




---

[GitHub] activemq-artemis pull request #1756: [ARTEMIS-1590] Properties-based SQLProv...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1756#discussion_r160451205
  
--- Diff: artemis-jdbc-store/src/main/resources/journal-sql.properties ---
@@ -0,0 +1,63 @@
+# Generic SQL statements
--- End diff --

It is needed to add on top:
```
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License.  You may obtain a copy of the License at
#
#   http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied.  See the License for the
# specific language governing permissions and limitations
# under the License.

```


---

[GitHub] activemq-artemis pull request #1760: ARTEMIS-1593 RemotingConnectionImpl lea...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1760


---

[GitHub] activemq-artemis pull request #1758: More fixes around compatibility

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1758#discussion_r160436610
  
--- Diff: 
tests/compatibility-tests/src/main/resources/servers/hornetqServer.groovy ---
@@ -19,7 +23,7 @@ import org.hornetq.core.config.impl.ConfigurationImpl
 import org.hornetq.core.remoting.impl.netty.NettyAcceptorFactory
 import org.hornetq.core.remoting.impl.netty.TransportConstants
 import org.hornetq.jms.server.config.impl.JMSConfigurationImpl
-import org.hornetq.jms.server.config.impl.JMSQueueConfigurationImpl
+import org.hornetq.jms.server.config.impl.*
--- End diff --

I will keep this one as is actually... I have no help from the IDE on what 
classes to import as this is hornetq... (It wasn't part of my change now 
anyways).


(this is the reason I'm using groovy.. I can tweak the classloader.. and 
have no direct dependency on the project.. totally optional. even the scan is 
done by a plugin.


---

[GitHub] activemq-artemis pull request #1758: More fixes around compatibility

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1758#discussion_r160434660
  
--- Diff: 
tests/compatibility-tests/src/main/resources/exportimport/import1X.groovy ---
@@ -0,0 +1,11 @@
+import org.apache.activemq.artemis.cli.commands.ActionContext
--- End diff --

@dudaerich the reason we have export / export1X is because the package 
names are different.

I could have fixed it differently with a different script just to 
instantiate the export.. but the script was so small that I decided just to 
have different versions for each branch.


the script wouldn't load (or compile) if I had any sort of if inside.


---

[GitHub] activemq-artemis pull request #1758: More fixes around compatibility

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1758#discussion_r160433959
  
--- Diff: 
tests/compatibility-tests/src/main/resources/exportimport/import1X.groovy ---
@@ -0,0 +1,11 @@
+import org.apache.activemq.artemis.cli.commands.ActionContext
--- End diff --

It was picked actually.


---

[GitHub] activemq-artemis pull request #1758: More fixes around compatibility

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1758#discussion_r160434008
  
--- Diff: 
tests/compatibility-tests/src/main/resources/exportimport/import1X.groovy ---
@@ -0,0 +1,11 @@
+import org.apache.activemq.artemis.cli.commands.ActionContext
--- End diff --

the reason is failed...


---

[GitHub] activemq-artemis pull request #1758: More fixes around compatibility

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1758#discussion_r160433884
  
--- Diff: 
tests/compatibility-tests/src/main/resources/servers/hornetqServer.groovy ---
@@ -19,7 +23,7 @@ import org.hornetq.core.config.impl.ConfigurationImpl
 import org.hornetq.core.remoting.impl.netty.NettyAcceptorFactory
 import org.hornetq.core.remoting.impl.netty.TransportConstants
 import org.hornetq.jms.server.config.impl.JMSConfigurationImpl
-import org.hornetq.jms.server.config.impl.JMSQueueConfigurationImpl
+import org.hornetq.jms.server.config.impl.*
--- End diff --

I didn't care much as this is a groovy script. but i will expand it.


---

Re: [DISCUSS] Video call on ActiveMQ Artemis

[Clebert Suconic]

this will be done today at 3 PM EST (5 hours from the time I'm sending
this email)


I will be using bluejeans, which is an app I use at work... you need
to install the software, in order to do so, visit:

https://www.bluejeans.com

There are apps for windows, mac, Linux, iOS and Android as far as I know...



I will start the meeting promptly at 3PM EST, for that follow this link:

https://bluejeans.com/6546711481




I will record the meeting, and upload it to my personal youtube and
provide a link here. (we should perhaps create an youtube account for
activemq)



On Sat, Dec 30, 2017 at 11:18 AM, Arthur Naseef  wrote:
> I might be able to make it then.  Probably 50/50.  That week involves
> travel for me.
>
> Art
>
>
> On Wed, Dec 20, 2017 at 3:49 PM, Clebert Suconic 
> wrote:
>
>> What about Jan-9th, 3PM EST?
>>
>> On Tue, Dec 19, 2017 at 8:37 AM, Bruce Snyder 
>> wrote:
>> > Can we schedule something now so that the time is blocked in our
>> calendars?
>> >
>> > Bruce
>> >
>> > On Mon, Dec 18, 2017 at 8:03 PM, Clebert Suconic <
>> clebert.suco...@gmail.com>
>> > wrote:
>> >
>> >> I got so deeply involved with the compatibility issue I was working
>> >> on.. and the year is already gone for me...
>> >>
>> >>
>> >> I will try this around 2nd week of Jan.
>> >>
>> >> On Fri, Dec 8, 2017 at 3:30 AM, Francesco Nigro 
>> >> wrote:
>> >> > +1 I've had something similar with Clebert in the past and it was very
>> >> > useful indeed!
>> >> >
>> >> > Thanks Clebert for this great idea and I agree with Michael that
>> >> probably I
>> >> > will follow it in the evening too :)
>> >> >
>> >> > Cheers,
>> >> > Franz
>> >> >
>> >> > Il giorno ven 8 dic 2017 alle ore 02:04 Christopher Shannon <
>> >> > christopher.l.shan...@gmail.com> ha scritto:
>> >> >
>> >> >> +1 from me as well.  Recording the session is a great idea for anyone
>> >> who
>> >> >> can’t make it
>> >> >>
>> >> >> On Thu, Dec 7, 2017 at 6:52 PM artnaseef  wrote:
>> >> >>
>> >> >> > +1 Count me in.  Hope I can make it.
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> > --
>> >> >> > Sent from:
>> >> >> > http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
>> >> >> >
>> >> >>
>> >>
>> >>
>> >>
>> >> --
>> >> Clebert Suconic
>> >>
>> >
>> >
>> >
>> > --
>> > perl -e 'print
>> > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E> >
>> > ActiveMQ in Action: http://bit.ly/2je6cQ
>> > Blog: http://bsnyder.org/ 
>> > Twitter: http://twitter.com/brucesnyder
>>
>>
>>
>> --
>> Clebert Suconic
>>



-- 
Clebert Suconic

[GitHub] activemq-artemis issue #1756: [ARTEMIS-1590] Properties-based SQLProvider

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1756
  
@jmesnil 
> Is there a way to trigger it again?
Not sure but maybe just forcing another push it will restart a CI job?


---

[GitHub] activemq-artemis issue #1756: [ARTEMIS-1590] Properties-based SQLProvider

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1756
  
@jmesnil I'm looking into it :+1: 


---

[GitHub] activemq-artemis pull request #1761: [ARTEMIS-1527] - [Artemis Testsuite] Ac...

[JiriOndrusek]

Github user JiriOndrusek commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1761#discussion_r160421530
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
 ---
@@ -990,17 +,26 @@ public CloseRunnable(RemotingConnection conn, String 
scaleDownTargetNodeID) {
   // can cause reconnect loop
   @Override
   public void run() {
- try {
-CLOSE_RUNNABLES.add(this);
-if (scaleDownTargetNodeID == null) {
-   
conn.fail(ActiveMQClientMessageBundle.BUNDLE.disconnected());
-} else {
-   
conn.fail(ActiveMQClientMessageBundle.BUNDLE.disconnected(), 
scaleDownTargetNodeID);
-}
- } finally {
-CLOSE_RUNNABLES.remove(this);
+ CLOSE_RUNNABLES.add(this);
+ CountDownLatch latch;
+ if (scaleDownTargetNodeID == null) {
+latch = 
conn.fail(ActiveMQClientMessageBundle.BUNDLE.disconnected());
+ } else {
+latch = 
conn.fail(ActiveMQClientMessageBundle.BUNDLE.disconnected(), 
scaleDownTargetNodeID);
  }
 
+ //TODO(jondruse) is there constant or property usable for this 
kind of wait interval?
--- End diff --

I have too use "constant" for repetitive checking, whether action is 
already finished. May I use some generic timeout used in project (or define new 
attribute, ...)


---

[GitHub] activemq-artemis issue #1761: [ARTEMIS-1527] - [Artemis Testsuite] ActiveMQM...

[JiriOndrusek]

Github user JiriOndrusek commented on the issue:

https://github.com/apache/activemq-artemis/pull/1761
  
In 2 places I have to use "constant" for repetitive checking, whether 
action is already finished. May I use some generic timeout used in project (or 
define new attribute, ...)
(ClientSessionFactoryImpl line 1123 and RemotingConnectionImpl line 254) 


---

[GitHub] activemq-artemis pull request #1761: [ARTEMIS-1527] - [Artemis Testsuite] Ac...

[JiriOndrusek]

Github user JiriOndrusek commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1761#discussion_r160420636
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java
 ---
@@ -205,14 +211,59 @@ public void fail(final ActiveMQException me, String 
scaleDownTargetNodeID) {
   }
 
   // Then call the listeners
-  callFailureListeners(me, scaleDownTargetNodeID);
+  List failureLatches = callFailureListeners(me, 
scaleDownTargetNodeID);
 
   callClosingListeners();
 
-  internalClose();
+  CountDownLatch latch = new CountDownLatch(1);
 
-  for (Channel channel : channels.values()) {
- channel.returnBlocking(me);
+  new ScheduledInternalClose(failureLatches, me, latch).run();
+
+  return latch;
+   }
+
+   // internalClose has to be called after failureListeners are finished.
+   private class ScheduledInternalClose implements Runnable {
+
+  private final List failureLatches;
+  private final ActiveMQException me;
+  private final CountDownLatch latch;
+
+  public ScheduledInternalClose(List failureLatches, 
final ActiveMQException me, CountDownLatch latch) {
+ this.failureLatches = failureLatches;
+ this.me = me;
+ this.latch = latch;
+  }
+
+  @Override
+  public void run() {
+ List running = new LinkedList<>();
+ failureLatches.forEach((l) -> {
+try {
+   //interval is defined during scheduled execution
+   if (!l.await(1, TimeUnit.MILLISECONDS)) {
+  running.add(l);
+   }
+} catch (InterruptedException e) {
+   ActiveMQClientLogger.LOGGER.warn(e.getMessage(), e);
+}
+ });
+
+ if (!running.isEmpty()) {
+//TODO(jondruse) is there constant or propertyF usable for 
this kind of wait interval?
+scheduledExecutorService.schedule(new 
ScheduledInternalClose(running, me, latch), 500, TimeUnit.MILLISECONDS);
--- End diff --

I have too use "constant" for repetitive checking, whether action is 
already finished. May I use some generic timeout used in project (or define new 
attribute, ...)


---

[GitHub] activemq-artemis pull request #1758: More fixes around compatibility

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1758#discussion_r160420445
  
--- Diff: 
tests/compatibility-tests/src/main/resources/servers/hornetqServer.groovy ---
@@ -19,7 +23,7 @@ import org.hornetq.core.config.impl.ConfigurationImpl
 import org.hornetq.core.remoting.impl.netty.NettyAcceptorFactory
 import org.hornetq.core.remoting.impl.netty.TransportConstants
 import org.hornetq.jms.server.config.impl.JMSConfigurationImpl
-import org.hornetq.jms.server.config.impl.JMSQueueConfigurationImpl
+import org.hornetq.jms.server.config.impl.*
--- End diff --

nit: but can this expanded import, especially as still explicitly importing 
other class's from the same package.


---

[GitHub] activemq-artemis pull request #1758: More fixes around compatibility

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1758#discussion_r160420063
  
--- Diff: 
tests/compatibility-tests/src/main/resources/exportimport/import1X.groovy ---
@@ -0,0 +1,11 @@
+import org.apache.activemq.artemis.cli.commands.ActionContext
--- End diff --

License header missing, should this not be picked up by RAT report? Do we 
need to make rat look at groovy files?


---

[GitHub] activemq-artemis pull request #1676: [ARTEMIS-1527] - [Artemis Testsuite] Ac...

[JiriOndrusek]

Github user JiriOndrusek closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1676


---

[GitHub] activemq-artemis issue #1676: [ARTEMIS-1527] - [Artemis Testsuite] ActiveMQM...

[JiriOndrusek]

Github user JiriOndrusek commented on the issue:

https://github.com/apache/activemq-artemis/pull/1676
  
Replaced with https://github.com/apache/activemq-artemis/pull/1761


---

[GitHub] activemq-artemis pull request #1761: [ARTEMIS-1527] - [Artemis Testsuite] Ac...

[JiriOndrusek]

GitHub user JiriOndrusek opened a pull request:

https://github.com/apache/activemq-artemis/pull/1761

[ARTEMIS-1527] - [Artemis Testsuite] ActiveMQMessageHandlerTest#testS…

…erverShutdownAndReconnect fails

Issue: https://issues.apache.org/jira/browse/ARTEMIS-1527

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JiriOndrusek/activemq-artemis ARTEMIS-1527-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1761.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1761


commit 367e633846b020bb002e0cc0ff228df6bddefaa3
Author: JiriOndrusek 
Date:   2018-01-09T08:24:03Z

[ARTEMIS-1527] - [Artemis Testsuite] 
ActiveMQMessageHandlerTest#testServerShutdownAndReconnect fails




---

[GitHub] activemq-artemis issue #1760: ARTEMIS-1593 RemotingConnectionImpl leaks

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1760
  
@michaelandrepearce Sure! Anyway this was a very subtle leak :O


---

[GitHub] activemq-artemis issue #1760: ARTEMIS-1593 RemotingConnectionImpl leaks

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1760
  
+1 LGTM will wait for PR build to complete successfully if thats ok


---

[GitHub] activemq-artemis issue #1757: ARTEMIS-1586 Reduce GC pressure due to String ...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1757
  
@franz1981 once the build of that PR for fixing the leaking 
RemotingConnectionImpl is green, ill merge it, and then ill rebase this branch 
again. 


---

[GitHub] activemq-artemis issue #1760: ARTEMIS-1593 RemotingConnectionImpl leaks

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1760
  
This PR is addressing an issue present into master and found on 
https://github.com/apache/activemq-artemis/pull/1757


---

[GitHub] activemq-artemis pull request #1760: ARTEMIS-1593 RemotingConnectionImpl lea...

[franz1981]

GitHub user franz1981 opened a pull request:

https://github.com/apache/activemq-artemis/pull/1760

ARTEMIS-1593 RemotingConnectionImpl leaks

FileNameKey was holding a reference to PropertiesLoader.this due to its 
inner class definition, causing RemotingConnectionImpl to leak through a long 
chain of dependencies rooted in a PropertiesLoader's subclass property ie 
PropertiesLoaderModule::callbackHandler.
FileNameKey is turned into a inner static class to break this hidden 
dependency.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-1593

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1760.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1760


commit ca7e0a1e6fc088e17e3c907e974ef7e57db752f3
Author: Francesco Nigro 
Date:   2018-01-09T14:12:44Z

ARTEMIS-1593 RemotingConnectionImpl leaks

FileNameKey was holding a reference to PropertiesLoader.this due to its 
inner class definition, causing RemotingConnectionImpl to leak through a long 
chain of dependencies rooted in a PropertiesLoader's subclass property ie 
PropertiesLoaderModule::callbackHandler.
FileNameKey is turned into a inner static class to break this hidden 
dependency.




---

Re: Board report for January 2018

[Bruce Snyder]

Just one more reminder, there has been zero contributions to the board
report and I really need some help compiling it.

Please take just a few minutes to glance over what I have so far and
augment it with some additional information, even if it's just a sentence
or two.

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75956340

Time is of the essence as this report needs to be submitted tomorrow.

Thanks for your help!

Bruce

On Tue, Jan 2, 2018 at 2:58 PM, Bruce Snyder  wrote:

> Happy New Year!
>
> It's always helpful to the board to understand the actual activity within
> the project beyond just releases and boilerplate muck. I have added a few
> items regarding activity to get the report started. Please take a few
> moments to contribute to this month's report:
>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75956340
>
> This report must be submitted by 10 Jan 2018.
>
> Bruce
>
> --
> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> 5R\"F)R=6-E+G-N>61E
> ActiveMQ in Action: http://bit.ly/2je6cQ
> Blog: http://bsnyder.org/ 
> Twitter: http://twitter.com/brucesnyder
>



-- 
perl -e 'print
unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E
Twitter: http://twitter.com/brucesnyder

[GitHub] activemq-artemis issue #1757: ARTEMIS-1586 Reduce GC pressure due to String ...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1757
  
@michaelandrepearce Probably I've fixed it: it was subtle...



---

[GitHub] activemq-artemis issue #1759: [ARTEMIS-1241] check for FQQN and autocreate q...

[gtully]

Github user gtully commented on the issue:

https://github.com/apache/activemq-artemis/pull/1759
  
I added to some existing auto create address logic in the code path which 
suffices for my test case. It does appear a little hacky to have three xxToUse 
local variables and the toString messing on simpleString does not look right. 
One thought was to pass a null routingtype to this method but it is not 
clear to me where that decision should be made. Pulling the value from config 
for the auto creation case does make sense however.
Please review and maybe it is time to consider pulling all of the auto 
creation logic into one place.


---

[GitHub] activemq-artemis issue #1757: ARTEMIS-1586 Reduce GC pressure due to String ...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1757
  
@michaelandrepearce Exactly...

![image](https://user-images.githubusercontent.com/13125299/34721713-241f7984-f544-11e7-874e-f79a6750db84.png)




---

[GitHub] activemq-artemis pull request #1759: [ARTEMIS-1241] check for FQQN and autoc...

[gtully]

GitHub user gtully opened a pull request:

https://github.com/apache/activemq-artemis/pull/1759

[ARTEMIS-1241] check for FQQN and autocreate queue using the configur…

…ed default routing type

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gtully/activemq-artemis ARTEMIS-1241

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1759.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1759


commit 41e227e7fb2832829606233770b3234d82aa14aa
Author: gtully 
Date:   2018-01-09T12:27:59Z

[ARTEMIS-1241] check for FQQN and autocreate queue using the configured 
default routing type




---

[GitHub] activemq-artemis issue #1757: ARTEMIS-1586 Reduce GC pressure due to String ...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1757
  
@franz1981 could you fully expand the fields in references pane until root? 
I suspect the login context is there holding the jaas callback hadler


---

[GitHub] activemq-artemis issue #1756: [ARTEMIS-1590] Properties-based SQLProvider

[jmesnil]

Github user jmesnil commented on the issue:

https://github.com/apache/activemq-artemis/pull/1756
  
The CI is reporting an error but the build has already disappeared from its 
history.
Is there a way to trigger it again?


---

[GitHub] activemq-artemis issue #1757: ARTEMIS-1586 Reduce GC pressure due to String ...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1757
  
@michaelandrepearce 
It is near to be fixed, but I've opened a separate JIRA for it:

![image](https://user-images.githubusercontent.com/13125299/34717813-9b9fc4ec-f534-11e7-95c2-e7efc40db9aa.png)
Re memory leaks of `RemotingConnectionImpl` into `JaasCallbackHandler` 
probably @gtully or @jbertram would be super fast to indentify why are not 
collected propertly...


---

[GitHub] activemq-artemis pull request #1757: ARTEMIS-1586 Reduce GC pressure due to ...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1757#discussion_r160355213
  
--- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
 ---
@@ -259,22 +281,23 @@ public boolean equals(final Object other) {
   if (other instanceof SimpleString) {
  SimpleString s = (SimpleString) other;
 
- if (data.length != s.data.length) {
-return false;
- }
-
- for (int i = 0; i < data.length; i++) {
-if (data[i] != s.data[i]) {
-   return false;
-}
- }
-
- return true;
+ return ByteUtil.equals(data, s.data);
--- End diff --

I will perform some benchs to see if it will impact positively on checks 
and/or pattern matching based on equals: only in that case I will send a 
separate improvement PR :+1: 


---

[GitHub] activemq-artemis issue #1757: ARTEMIS-1586 Reduce GC pressure due to String ...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1757
  
That's what I was talking about:

![image](https://user-images.githubusercontent.com/13125299/34713778-8687e452-f527-11e7-8bfb-a7db8157cfb4.png)
This `RemotingConnectionImpl` it has survived after several full GC and it 
is been already destroyed: it seems a leak to me, wdyt?


---

[GitHub] activemq-artemis pull request #1757: ARTEMIS-1586 Reduce GC pressure due to ...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1757#discussion_r160352626
  
--- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
 ---
@@ -259,22 +281,23 @@ public boolean equals(final Object other) {
   if (other instanceof SimpleString) {
  SimpleString s = (SimpleString) other;
 
- if (data.length != s.data.length) {
-return false;
- }
-
- for (int i = 0; i < data.length; i++) {
-if (data[i] != s.data[i]) {
-   return false;
-}
- }
-
- return true;
+ return ByteUtil.equals(data, s.data);
--- End diff --

Cool. lets leave it then :)


---

[GitHub] activemq-artemis pull request #1757: ARTEMIS-1586 Reduce GC pressure due to ...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1757#discussion_r160347432
  
--- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
 ---
@@ -259,22 +281,23 @@ public boolean equals(final Object other) {
   if (other instanceof SimpleString) {
  SimpleString s = (SimpleString) other;
 
- if (data.length != s.data.length) {
-return false;
- }
-
- for (int i = 0; i < data.length; i++) {
-if (data[i] != s.data[i]) {
-   return false;
-}
- }
-
- return true;
+ return ByteUtil.equals(data, s.data);
--- End diff --

And there is a correctness issue around it (in my code too!!!): 
if `s` is `null` `s.data` will throw NPE!


---

[GitHub] activemq-artemis issue #1757: ARTEMIS-1586 Reduce GC pressure due to String ...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1757
  
I will take a look on it now, but at a first look semms that there is a 
long living `RemoteConnectionImpl` that has a `destroyed` flag `true` which is 
not collected after a forced full GC


---

[GitHub] activemq-artemis pull request #1757: ARTEMIS-1586 Reduce GC pressure due to ...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1757#discussion_r160344540
  
--- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
 ---
@@ -259,22 +281,23 @@ public boolean equals(final Object other) {
   if (other instanceof SimpleString) {
  SimpleString s = (SimpleString) other;
 
- if (data.length != s.data.length) {
-return false;
- }
-
- for (int i = 0; i < data.length; i++) {
-if (data[i] != s.data[i]) {
-   return false;
-}
- }
-
- return true;
+ return ByteUtil.equals(data, s.data);
--- End diff --

It is just a further improvement, but I'm already happy with the code as it 
is now :+1: 


---

[GitHub] activemq-artemis pull request #1757: ARTEMIS-1586 Reduce GC pressure due to ...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1757#discussion_r160344336
  
--- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java
 ---
@@ -259,22 +281,23 @@ public boolean equals(final Object other) {
   if (other instanceof SimpleString) {
  SimpleString s = (SimpleString) other;
 
- if (data.length != s.data.length) {
-return false;
- }
-
- for (int i = 0; i < data.length; i++) {
-if (data[i] != s.data[i]) {
-   return false;
-}
- }
-
- return true;
+ return ByteUtil.equals(data, s.data);
--- End diff --

The benefit is not from the GC pov but for normal `SimpleString` usage 
inside Map/Set: if the `SimpleString` has already hash computed or it is 
string-based it won't perform array comparison (optimzed ones for sure) but 
will benenfit of `String::equals` that is intrinsified by the JVM.


---

[GitHub] activemq-artemis pull request #1750: ARTEMIS-1581 fix handshake-timeout prop...

[stanlyDoge]

Github user stanlyDoge commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1750#discussion_r160340487
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
 ---
@@ -97,4 +111,56 @@ public void testSetupJMSConfiguration() throws 
Exception {
 
   server.stop();
}
+
+   @Test
+   public void testHandshakeTimeoutWithValueSet() throws Exception {
+  JMSServerManager jmsServer;
--- End diff --

Aha. Thank you :)


---