[DISCUSS] Adding Derby as a dependency

2018-01-12 Thread Clebert Suconic
I would like to add an option on artemis create to enable jdbc.


By default (if you don't provide any other configuration) it will use
derby by default on the properties.


And I wanted to add derby as a dependency on ./lib


Anyone against it?


so, you would do ./artemis create --jdbc


and it would configure derby as an option



(JDBC is not encouraged.. the journal is the best option.. but same as
in ActiveMQ5, some people need it).




also: I'm trying to understand what I need to change on dep.xml under
artemis-distribution, but I can't make it to work... anyone can give
me a hand on that?




-- 
Clebert Suconic


[GitHub] activemq-artemis pull request #1766: ARTEMIS-1596 STOMP consumer/producer au...

2018-01-12 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1766


---


[GitHub] activemq-artemis issue #1771: ARTEMIS-1600 Support masked passwords in boots...

2018-01-12 Thread gaohoward
Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1771
  
that's fine. I'll remove it.


---


[GitHub] activemq-artemis issue #1771: ARTEMIS-1600 Support masked passwords in boots...

2018-01-12 Thread jbertram
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1771
  
In my opinion, you should remove the mask-password config property from 
this PR as it will require more code/documentation changes later when it's 
deprecated and eventually removed.


---


[GitHub] activemq-artemis issue #1771: ARTEMIS-1600 Support masked passwords in boots...

2018-01-12 Thread gaohoward
Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1771
  
OK, so I'd add ENC() syntax and keeps the mask-password as an option. (I 
mean I won't remove this from this PR, but won't add any more in the future if 
there is new password mask requirements).



---


[GitHub] activemq-artemis issue #1771: ARTEMIS-1600 Support masked passwords in boots...

2018-01-12 Thread jbertram
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1771
  
We should keep mask-password config support where it exists already, but 
don't add any new features that use it.  Instead we can rely on the ENC() 
syntax.


---


[GitHub] activemq-artemis issue #1766: ARTEMIS-1596 STOMP consumer/producer auto-crea...

2018-01-12 Thread jostbg
Github user jostbg commented on the issue:

https://github.com/apache/activemq-artemis/pull/1766
  
Done.


---


[GitHub] activemq-artemis pull request #1756: [ARTEMIS-1590] Properties-based SQLProv...

2018-01-12 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1756


---


[GitHub] activemq-artemis issue #1756: [ARTEMIS-1590] Properties-based SQLProvider

2018-01-12 Thread franz1981
Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1756
  
@jmesnil Perfect! Thanks for this PR, it is making JDBC customizations much 
simpler & cleaner :+1: 


---


[GitHub] activemq-artemis issue #1756: [ARTEMIS-1590] Properties-based SQLProvider

2018-01-12 Thread jmesnil
Github user jmesnil commented on the issue:

https://github.com/apache/activemq-artemis/pull/1756
  
@franz1981 done :)



---


[GitHub] activemq-artemis issue #1757: ARTEMIS-1586 Reduce GC pressure due to String ...

2018-01-12 Thread franz1981
Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1757
  
@michaelandrepearce Did you have had any chances to check if you've 
experienced similar improvements?
I hope to measure the client side too


---


[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

2018-01-12 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1775

ARTEMIS-1587 Add setting to control the queue durable property for au…

…to-created addresses

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1587

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1775


commit 5873e5b8d7d506c50f978b846f4f11520431ae99
Author: Stanislav Knot 
Date:   2018-01-09T10:47:10Z

ARTEMIS-1587 Add setting to control the queue durable property for 
auto-created addresses




---


[GitHub] activemq-artemis issue #1759: [ARTEMIS-1241] check for FQQN and autocreate q...

2018-01-12 Thread gtully
Github user gtully commented on the issue:

https://github.com/apache/activemq-artemis/pull/1759
  
@mtaylor  Pushed an update, with the check in the openwire session the 
change set is smaller and the new tests with an existing address work as 
expected.
the prefixing remains and the case of multiple routing types is handled 
already by returning the first entry in the set which may need a revisit when 
the prefix is handled.


---


[GitHub] activemq-artemis issue #1756: [ARTEMIS-1590] Properties-based SQLProvider

2018-01-12 Thread franz1981
Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1756
  
@jmesnil Could you please squash the commits? :)


---