[GitHub] activemq-artemis pull request #1819: ARTEMIS-1639 HornetQClientProtocolManag...

[gaohoward]

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/1819

ARTEMIS-1639 HornetQClientProtocolManager sending unsupported packet

HornetQClientProtocolManager is used to connect HornteQ servers.
During reconnect, it sends a CheckFailoverMessage packet to the
server as part of reconnection. This packet is not supported by
HornetQ server (existing release), so it will break the backward
compatibility.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis master_chk_failover

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1819.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1819


commit 02397268695cbd8e865c38961f3aaa876ee6bd66
Author: Howard Gao 
Date:   2018-01-26T04:40:24Z

ARTEMIS-1639 HornetQClientProtocolManager sending unsupported packet

HornetQClientProtocolManager is used to connect HornteQ servers.
During reconnect, it sends a CheckFailoverMessage packet to the
server as part of reconnection. This packet is not supported by
HornetQ server (existing release), so it will break the backward
compatibility.




---

[GitHub] activemq-artemis pull request #1818: DO-NOT-MERGE ARTEMIS-1638 Fixing Purge ...

[clebertsuconic]

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1818

DO-NOT-MERGE ARTEMIS-1638 Fixing Purge on rollback & paging



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1638

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1818.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1818


commit ba7edcad3b5a4a9adee799f0ebf8a0dd5a5df975
Author: Clebert Suconic 
Date:   2018-01-26T02:17:25Z

ARTEMIS-1638 Fixing Purge rollback behaviour (test only)

commit 70b5c67c91625ccd28f8c3cb9e2b6cc8f32c45c5
Author: Clebert Suconic 
Date:   2018-01-26T02:17:38Z

ARTEMIS-1638 Fixing Purge rollback behaviour (fix)

commit ed7e8d531b883649fa2ac86f2813d11d4e6775c7
Author: Clebert Suconic 
Date:   2018-01-26T03:24:25Z

ARTEMIS-1638 Paving investigation - do not merge




---

[GitHub] activemq-artemis pull request #1816: ARTEMIS-1633 - fire message routing cal...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1816


---

[GitHub] activemq-artemis issue #1817: ARTEMIS-1623 add logging codes to LoggingActiv...

[pgfox]

Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/1817
  
@michaelandrepearce  Thanks Mike


---

[GitHub] activemq-artemis pull request #1816: ARTEMIS-1633 - fire message routing cal...

[cshannon]

Github user cshannon commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1816#discussion_r163924828
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ---
@@ -772,6 +772,8 @@ public RoutingStatus route(final Message message,
 
   message.cleanupInternalProperties();
 
+  server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> 
plugin.beforeMessageRoute(message, context, direct, rejectDuplicates) : null);
--- End diff --

If there were messages sent to an address with no bindings the message 
would get dropped because of lack of bindings.  But with the old way the 
message route methods were only triggered if the routing status was OK.  With 
the change the methods are called even if there are no bindings but the status 
will say NO_BINDINGS, etc.


---

[GitHub] activemq-artemis pull request #1816: ARTEMIS-1633 - fire message routing cal...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1816#discussion_r163905434
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ---
@@ -772,6 +772,8 @@ public RoutingStatus route(final Message message,
 
   message.cleanupInternalProperties();
 
+  server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> 
plugin.beforeMessageRoute(message, context, direct, rejectDuplicates) : null);
--- End diff --

in what situation this was not happening? paging?


---

[GitHub] activemq-artemis issue #1817: ARTEMIS-1623 add logging codes to LoggingActiv...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1817
  
@pgfox thanks for this. It addresses my bits in the other pr so big +1 from 
me. 

I will wait for @jbertram to give a thumbs up too


---

[GitHub] activemq-artemis pull request #1817: ARTEMIS-1623 add logging codes to Loggi...

[pgfox]

GitHub user pgfox opened a pull request:

https://github.com/apache/activemq-artemis/pull/1817

ARTEMIS-1623 add logging codes to LoggingActiveMQServerPlugin


- added LoggingActiveMQServerPluginLogger to follow logging pattern
- clarified DEBUG Level usage in doc

This is a follow up PR to #1796

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pgfox/activemq-artemis 
log_codes_logging_plugin

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1817.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1817


commit 3879d1b62acd65aa78368780d49d42ea80f8f28a
Author: Pat Fox 
Date:   2018-01-24T08:09:08Z

ARTEMIS-1623 add logging codes to LoggingActiveMQServerPlugin




---