[GitHub] activemq-artemis issue #1851: ARTEMIS-1664 fix npe bug while getting element...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1851
  
@wy96f could you rebase (it seems clebert merged my branch (which had your 
original code) i used for checking that the build passed in the night)

Also once rebased could you apply the same change to the Set implementation 
also?

As for the test having a longer running test i think is fine, just i think 
if it goes in as a full test suite test e.g. it wont run every PR.


---

[GitHub] activemq-artemis issue #1851: ARTEMIS-1664 fix npe bug while getting element...

[wy96f]

Github user wy96f commented on the issue:

https://github.com/apache/activemq-artemis/pull/1851
  
@franz1981 lazySet is used to update capacity. Please review it :)


---

[GitHub] activemq-artemis issue #1851: ARTEMIS-1664 fix npe bug while getting element...

[wy96f]

Github user wy96f commented on the issue:

https://github.com/apache/activemq-artemis/pull/1851
  
Sorry for the late reply. Using lazySet to update capacity filed is a good 
point. As for the test, I modified test as follows:

@Test
   public void concurrentInsertionsAndReads() throws Throwable {
  ExecutorService executor = Executors.newCachedThreadPool();

  for (int x = 0; x < 1000; x++) {
 ConcurrentLongHashMap map = new ConcurrentLongHashMap<>(1, 
1);

 final int nThreads = 16;
 final int N = 100_000;
 String value = "v";

 List futures = new ArrayList<>();
 for (int i = 0; i < nThreads; i++) {
futures.add(executor.submit(() -> {
   Random random = new Random();

   for (int j = 0; j < N; j++) {
  long key = random.nextLong();
  // Ensure keys are uniques
  //key -= key % (threadIdx + 1);

  map.get(key);
   }
}));

final int threadIdx = i;

futures.add(executor.submit(() -> {
   Random random = new Random();

   for (int j = 0; j < N; j++) {
  long key = random.nextLong();
  // Ensure keys are uniques
  key -= key % (threadIdx + 1);

  map.put(key, value);
   }
}));

 }

 for (Future future : futures) {
future.get();
 }

 assertEquals(map.size(), N * nThreads);
  }

  executor.shutdown();
   }
Most likely, npe would occur. The test may cost a long time to trigger the 
bug. Is it ok to run the test for such a long time in the junit test?


---

[GitHub] activemq-artemis pull request #1893: NO-JIRA make MessageConsumerTest determ...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1893

NO-JIRA make MessageConsumerTest deterministic

The method testStopConnectionDuringOnMessage in this class was relying
on sleep() calls for critical timing. This test fails sometimes on
fast-tests so I modified it to use a latch and a few waitFor calls to be
more deterministic. It also runs in a third of the time now.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis messageConsumerTest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1893.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1893


commit d18cc6606d7026b9a6355e18231174b78dce7dcb
Author: Justin Bertram 
Date:   2018-02-23T03:03:22Z

NO-JIRA make MessageConsumerTest deterministic

The method testStopConnectionDuringOnMessage in this class was relying
on sleep() calls for critical timing. This test fails sometimes on
fast-tests so I modified it to use a latch and a few waitFor calls to be
more deterministic. It also runs in a third of the time now.




---

[GitHub] activemq-artemis pull request #1887: ARTEMIS-1696 allow empty 'address' for ...

[jbertram]

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1887#discussion_r170153460
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
 ---
@@ -1671,7 +1671,7 @@ private void 
parseClusterConnectionConfiguration(final Element e, final Configur
private void parseGroupingHandlerConfiguration(final Element node, 
final Configuration mainConfiguration) {
   String name = node.getAttribute("name");
   String type = getString(node, "type", null, 
Validators.NOT_NULL_OR_EMPTY);
-  String address = getString(node, "address", null, 
Validators.NOT_NULL_OR_EMPTY);
+  String address = getString(node, "address", "", Validators.NO_CHECK);
--- End diff --

I did that to match the change that was made for the cluster-connection 
address parsing.  See 
https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java#L1581.


---

[GitHub] activemq-artemis pull request #1892: ARTEMIS-1664 fix npe bug while getting ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1892


---

[GitHub] activemq-artemis pull request #1892: ARTEMIS-1664 fix npe bug while getting ...

[michaelandrepearce]

GitHub user michaelandrepearce reopened a pull request:

https://github.com/apache/activemq-artemis/pull/1892

ARTEMIS-1664 fix npe bug while getting element in the process of rehash



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1664-TAKE2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1892.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1892


commit b6efd3af272981085364c5e2ae27845e4757dd16
Author: yang wei 
Date:   2018-02-05T10:12:18Z

ARTEMIS-1664 fix npe bug while getting element in the process of rehash

commit ef96b6fc22486ccedf4157ad746a5cbcea34ac61
Author: Michael André Pearce 
Date:   2018-02-22T23:20:56Z

ARTEMIS-1664 fix npe bug while getting element in the process of rehash

Apply same fix to ConcurrentLongHashSet




---

[GitHub] activemq-artemis pull request #1887: ARTEMIS-1696 allow empty 'address' for ...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1887#discussion_r170118840
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
 ---
@@ -1671,7 +1671,7 @@ private void 
parseClusterConnectionConfiguration(final Element e, final Configur
private void parseGroupingHandlerConfiguration(final Element node, 
final Configuration mainConfiguration) {
   String name = node.getAttribute("name");
   String type = getString(node, "type", null, 
Validators.NOT_NULL_OR_EMPTY);
-  String address = getString(node, "address", null, 
Validators.NOT_NULL_OR_EMPTY);
+  String address = getString(node, "address", "", Validators.NO_CHECK);
--- End diff --

why "" for default not Null now you're removing the NOT NULL OR EMPTY check?


---

[GitHub] activemq-artemis pull request #1892: ARTEMIS-1664 fix npe bug while getting ...

[michaelandrepearce]

Github user michaelandrepearce closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1892


---

[GitHub] activemq-artemis issue #1892: ARTEMIS-1664 fix npe bug while getting element...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1892
  
closing as https://github.com/apache/activemq-artemis/pull/1851 is what 
should be merged was just branching from there to get a PR build done to check 
it.


---

[GitHub] activemq-artemis issue #1851: ARTEMIS-1664 fix npe bug while getting element...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1851
  
Seems first time travis build failed for unrelated reason second attempt 
https://github.com/apache/activemq-artemis/pull/1892

is fine.


---

[GitHub] activemq-artemis pull request #1892: ARTEMIS-1664 fix npe bug while getting ...

[michaelandrepearce]

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1892

ARTEMIS-1664 fix npe bug while getting element in the process of rehash



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1664-TAKE2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1892.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1892


commit b6efd3af272981085364c5e2ae27845e4757dd16
Author: yang wei 
Date:   2018-02-05T10:12:18Z

ARTEMIS-1664 fix npe bug while getting element in the process of rehash




---

[GitHub] activemq-artemis pull request #1891: ARTEMIS-1664 fix npe bug while getting ...

[michaelandrepearce]

Github user michaelandrepearce closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1891


---

[GitHub] activemq-artemis issue #1851: ARTEMIS-1664 fix npe bug while getting element...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1851
  
@jbertram i have taken @wy96f just rebased and done a PR so travis CI will 
build see https://github.com/apache/activemq-artemis/pull/1891

If that passes we can merge this PR (and ill close my branch of their work)


---

[GitHub] activemq-artemis pull request #1891: ARTEMIS-1664 fix npe bug while getting ...

[michaelandrepearce]

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1891

ARTEMIS-1664 fix npe bug while getting element in the process of rehash

https://github.com/apache/activemq-artemis/pull/1851


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1664

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1891.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1891


commit b6efd3af272981085364c5e2ae27845e4757dd16
Author: yang wei 
Date:   2018-02-05T10:12:18Z

ARTEMIS-1664 fix npe bug while getting element in the process of rehash




---

[GitHub] activemq-artemis issue #1888: ARTEMIS-1697 give ActivateCallback default met...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1888
  
Cleans the code nicely up , not on hot path, so defaults method is fine +1 
from me.


---

[GitHub] activemq-artemis pull request #1888: ARTEMIS-1697 give ActivateCallback defa...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1888


---

[GitHub] activemq-artemis pull request #1864: ARTEMIS-1677:Wrong documentation descri...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1864


---

[GitHub] activemq-artemis pull request #1886: ARTEMIS-1695 - Improve STOMP compatibli...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1886


---

[GitHub] activemq-artemis pull request #1890: NO-JIRA fix JMX examples

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1890

NO-JIRA fix JMX examples



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis jmxExamples

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1890.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1890


commit 9ec5aba6f3059be96e291c35e88dd5480e9779d1
Author: Justin Bertram 
Date:   2018-02-22T21:19:01Z

NO-JIRA fix JMX examples




---

[GitHub] activemq-artemis pull request #1884: NO-JIRA typo in jmx-ssl example pom fil...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1884


---

[GitHub] activemq-artemis pull request #1837: ARTEMIS-1603 fixed browsing tables unde...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1837


---

[GitHub] activemq-artemis pull request #1877: ARTEMIS-1692 fixed filtering consumers ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1877


---

[GitHub] activemq-artemis issue #1877: ARTEMIS-1692 fixed filtering consumers in hawt...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1877
  
+1 LGTM.


---

[GitHub] activemq-artemis issue #1837: ARTEMIS-1603 fixed browsing tables under JMX t...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1837
  
+1 LGTM. 

@stanlyDoge has got me thinking, we should a some sort of unit/integration 
testing framework to introduce to the web console maybe so we can start 
building a pack to avoid regressions, any idea's or preference?


---

[GitHub] activemq-artemis pull request #1889: ARTEMIS-1698 support 'instance' web dep...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1889

ARTEMIS-1698 support 'instance' web deployments



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1698

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1889.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1889


commit 63bd0b01aeda51c852d63cd4ab3ed845a9519ce1
Author: Justin Bertram 
Date:   2017-11-17T18:18:21Z

ARTEMIS-1698 support 'instance' web deployments




---

[GitHub] activemq-artemis pull request #1888: ARTEMIS-1697 give ActivateCallback defa...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1888

ARTEMIS-1697 give ActivateCallback default methods



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1697

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1888.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1888


commit 56f7c523b720f345243bbd423cce9042af6c3ba4
Author: Justin Bertram 
Date:   2018-02-22T18:42:18Z

ARTEMIS-1697 give ActivateCallback default methods




---

[GitHub] activemq-artemis pull request #1887: ARTEMIS-1696 allow empty 'address' for ...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1887

ARTEMIS-1696 allow empty 'address' for grouping-handler



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1696

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1887.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1887


commit 7b7af3519c4113124dcd04ce6922d37b61f3069f
Author: Justin Bertram 
Date:   2018-02-22T17:29:13Z

ARTEMIS-1696 allow empty 'address' for grouping-handler




---

[GitHub] activemq-artemis pull request #1886: ARTEMIS-1695 - Improve STOMP compatibli...

[cshannon]

GitHub user cshannon opened a pull request:

https://github.com/apache/activemq-artemis/pull/1886

ARTEMIS-1695 - Improve STOMP compatiblity with 5.x clients

Also make sure on authentication error in version 1.0 a client will
disconnect

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1695

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1886.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1886


commit e93fbf25fcf12319aa7ad07c49bbb1d7798bc681
Author: Christopher L. Shannon (cshannon) 
Date:   2018-02-22T15:28:57Z

ARTEMIS-1695 - Improve STOMP compatiblity with 5.x clients

Also make sure on authentication error in version 1.0 a client will
disconnect




---

[GitHub] activemq-artemis pull request #1885: ARTEMIS-1694 fix graceful-shutdown doc

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1885

ARTEMIS-1694 fix graceful-shutdown doc



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1694

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1885.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1885


commit a4533b1fa80125ca6e12f97075967265bca598e4
Author: Justin Bertram 
Date:   2018-02-22T15:05:14Z

ARTEMIS-1694 fix graceful-shutdown doc




---

Re: Active MQ-CPP library core dumps

[Timothy Bish]

Please direct questions to the users list, the dev list is for 
discussion of ongoing ActiveMQ development.


On 02/21/2018 11:16 PM, duttaab wrote:

Hi,

Hope not braking the sanctity of this Dev forum by posting it and not in
User forum, as I believe dev folks can identify the bt clearly.
   
I am getting the following core/crash dump while using the AcitveMQ-CPP

(C++) library. What I observe is if I disable the Inactivity Monitor this
crash occurs, even if my application is idle.

This is the configuration -
 
   
Any help in this regard will be appreciated.


(gdb) bt
#0  0x7f32ada79989 in raise () from /lib64/libc.so.6
#1  0x7f32ada7b098 in abort () from /lib64/libc.so.6
#2  0x7f32ae37d9d5 in __gnu_cxx::__verbose_terminate_handler() () from
/lib64/libstdc++.so.6
#3  0x7f32ae37b946 in ?? () from /lib64/libstdc++.so.6
#4  0x7f32ae37b973 in std::terminate() () from /lib64/libstdc++.so.6
#5  0x7f32ae37c4df in __cxa_pure_virtual () from /lib64/libstdc++.so.6
#6  0x7f32afe6b81d in decaf::util::concurrent::Lock::~Lock
(this=0x7f31e6ffcbf0, __in_chrg=) at
decaf/util/concurrent/Lock.cpp:45
#7  0x7f32afc88d30 in activemq::threads::CompositeTaskRunner::wakeup
(this=) at activemq/threads/CompositeTaskRunner.cpp:154
#8  0x7f32afce9ae5 in
activemq::transport::inactivity::InactivityMonitor::readCheck
(this=0x7f31ac00c130)
 at activemq/transport/inactivity/InactivityMonitor.cpp:400
#9  0x7f32afe66abd in decaf::util::TimerImpl::run (this=0x7f31ac00c890)
at decaf/util/Timer.cpp:156
#10 0x7f32afde23d2 in (anonymous namespace)::runCallback
(arg=0x7f31ac002050) at decaf/internal/util/concurrent/Threading.cpp:268
#11 0x7f32afde2c0c in (anonymous namespace)::threadEntryMethod
(arg=0x7f31ac002050) at decaf/internal/util/concurrent/Threading.cpp:256
#12 0x7f32b06b7df3 in start_thread () from /lib64/libpthread.so.0
#13 0x7f32adb3a3dd in clone () from /lib64/libc.so.6


Thanks
Abhi



--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html



--
Tim Bish
twitter: @tabish121
blog: http://timbish.blogspot.com/

[GitHub] activemq-artemis pull request #1884: NO-JIRA typo in jmx-ssl example pom fil...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1884

NO-JIRA typo in jmx-ssl example pom file

+ code format

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis pomtypo

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1884.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1884


commit 0f433ec7e03d5c45c470059a939a6f492f6c0552
Author: Stanislav Knot 
Date:   2018-02-22T13:37:41Z

NO-JIRA typo in jmx-ssl example pom file




---