[GitHub] activemq-artemis issue #1945: ARTEMIS-1737 Fixing WebServer stopped

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1945
  
@michaelandrepearce ^^


---

[GitHub] activemq-artemis pull request #1945: ARTEMIS-1737 Fixing WebServer stopped

[clebertsuconic]

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1945

ARTEMIS-1737 Fixing WebServer stopped

This is replacing #1940 

#1940 will be closed when this one is merged.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1737

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1945.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1945


commit dc096f950d24e47f48883fdd49b27f51914d5783
Author: Stanislav Knot 
Date:   2018-03-08T10:03:37Z

ARTEMIS-1737 fix for inaccessible slave console after failover

commit 6a0f3232c7921e6e67cd8211e4b05d065cffcceb
Author: Clebert Suconic 
Date:   2018-03-08T21:24:38Z

ARTEMIS-1737 Fixing semantic of ServerControl.forceFailover

This closes #1940




---

Failing unit test

[Tim Bain]

Can someone please assist with the unit test failure described in
http://activemq.2283324.n4.nabble.com/testRecoveryOnArchiveFailure-failing-test-td4737530.html
?

Thanks,
Tim

[GitHub] activemq-artemis pull request #1943: NO-JIRA review docs for content, style,...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1943


---

Re: [HEADS-UP] 2.5.0 release some time next week... (after wed)

[Clebert Suconic]

I think it’s importsnt to fix this bug.  I broke it and I want to fix it :)

On Thu, Mar 8, 2018 at 6:12 PM Timothy Bish  wrote:

> On 03/08/2018 05:59 PM, Clebert Suconic wrote:
> > I'm pushing this back to monday...I thought that was an easy fix and i
> > will need some more tweaking.
> >
> >
> > Meanwhile.. @everyone: avoiding pushing anything that will break the
> > release now :) doc fixes and test fixes is of course fine. I'm running
> > the whole testsuite before each PR I send now.. which is 2 hours..
> > anything other than that will push the release further.
>
> Why not just cut a branch now then and cherry-pick things that should go
> into 2.5.0 to make it simpler to mange ?  That way work can progress on
> things that might be better in 2.6.0 concurrently
>
> >
> > On Thu, Mar 8, 2018 at 1:55 PM, Clebert Suconic
> >  wrote:
> >> I'm already on it... i'm working on it.
> >>
> >> On Thu, Mar 8, 2018 at 8:35 AM, Michael André Pearce
> >>  wrote:
> >>> Can we add
> >>>
> >>> https://github.com/apache/activemq-artemis/pull/1940
> >>>
> >>> As a blocker.
> >>>
> >>> On reviewing the PR and seeing why this PR is needed/wanted, it seems
> whilst console is most visibly affected by a change done , it has more
> serious effect that the network pinger also seems to get shutdown and not
> kept alive on slave failback. Concern also is if there is anything else.
> >>>
> >>> Sent from my iPhone
> >>>
>  On 8 Mar 2018, at 12:28, Andy Taylor  wrote:
> 
>  I think  https://issues.apache.org/jira/browse/ARTEMIS-1736 is a
> blocker as
>  well, Ive just sent a PR with a fix
> 
>  On 7 March 2018 at 04:59, Michael André Pearce <
> michael.andre.pea...@me.com>
>  wrote:
> 
> > @Clebert
> >
> > Someone in the user threads has raised what looks like a blocker if
> it’s
> > real.
> >
> > Something to do with large messages and broker crashing with
> > 2.5.0-SNAPSHOTz
> >
> > Have you seen it?
> >
> > Sent from my iPhone
> >
> >> On 2 Mar 2018, at 23:42, Clebert Suconic  >
> > wrote:
> >> If you have anything in mind that you consider a blocking.
> >>
> >> That’s the idea of the heads up.  My expectation was the examples.
> But
> > if
> >> you want to request another change, like be PR pending you have
> that I
> > need
> >> to work on ? :)
> >>
> >>
> >> Let me know if you have anything in mind that is a blocker.
> >>
> >> On Fri, Mar 2, 2018 at 12:46 AM MichaelAndrePearce <
> >> michael.andre.pea...@me.com> wrote:
> >>
> >>> yes a list of blocking tasks, so that we can all focus on those if
> > needed.
> >>> It
> >>> sounded like there were a few examples, but it seems like you have
> that
> > in
> >>> hand already.
> >>>
> >>>
> >>>
> >>> --
> >>> Sent from:
> >>> http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
> >>>
> >> --
> >> Clebert Suconic
> >>
> >>
> >> --
> >> Clebert Suconic
> >
> >
>
> --
> Tim Bish
> twitter: @tabish121
> blog: http://timbish.blogspot.com/
>
> --
Clebert Suconic

Re: [HEADS-UP] 2.5.0 release some time next week... (after wed)

[Timothy Bish]

On 03/08/2018 05:59 PM, Clebert Suconic wrote:

I'm pushing this back to monday...I thought that was an easy fix and i
will need some more tweaking.


Meanwhile.. @everyone: avoiding pushing anything that will break the
release now :) doc fixes and test fixes is of course fine. I'm running
the whole testsuite before each PR I send now.. which is 2 hours..
anything other than that will push the release further.


Why not just cut a branch now then and cherry-pick things that should go 
into 2.5.0 to make it simpler to mange ?  That way work can progress on 
things that might be better in 2.6.0 concurrently




On Thu, Mar 8, 2018 at 1:55 PM, Clebert Suconic
 wrote:

I'm already on it... i'm working on it.

On Thu, Mar 8, 2018 at 8:35 AM, Michael André Pearce
 wrote:

Can we add

https://github.com/apache/activemq-artemis/pull/1940

As a blocker.

On reviewing the PR and seeing why this PR is needed/wanted, it seems whilst 
console is most visibly affected by a change done , it has more serious effect 
that the network pinger also seems to get shutdown and not kept alive on slave 
failback. Concern also is if there is anything else.

Sent from my iPhone


On 8 Mar 2018, at 12:28, Andy Taylor  wrote:

I think  https://issues.apache.org/jira/browse/ARTEMIS-1736 is a blocker as
well, Ive just sent a PR with a fix

On 7 March 2018 at 04:59, Michael André Pearce 
wrote:


@Clebert

Someone in the user threads has raised what looks like a blocker if it’s
real.

Something to do with large messages and broker crashing with
2.5.0-SNAPSHOTz

Have you seen it?

Sent from my iPhone


On 2 Mar 2018, at 23:42, Clebert Suconic 

wrote:

If you have anything in mind that you consider a blocking.

That’s the idea of the heads up.  My expectation was the examples.  But

if

you want to request another change, like be PR pending you have that I

need

to work on ? :)


Let me know if you have anything in mind that is a blocker.

On Fri, Mar 2, 2018 at 12:46 AM MichaelAndrePearce <
michael.andre.pea...@me.com> wrote:


yes a list of blocking tasks, so that we can all focus on those if

needed.

It
sounded like there were a few examples, but it seems like you have that

in

hand already.



--
Sent from:
http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html


--
Clebert Suconic



--
Clebert Suconic





--
Tim Bish
twitter: @tabish121
blog: http://timbish.blogspot.com/

Re: [HEADS-UP] 2.5.0 release some time next week... (after wed)

[Clebert Suconic]

I'm pushing this back to monday...I thought that was an easy fix and i
will need some more tweaking.


Meanwhile.. @everyone: avoiding pushing anything that will break the
release now :) doc fixes and test fixes is of course fine. I'm running
the whole testsuite before each PR I send now.. which is 2 hours..
anything other than that will push the release further.

On Thu, Mar 8, 2018 at 1:55 PM, Clebert Suconic
 wrote:
> I'm already on it... i'm working on it.
>
> On Thu, Mar 8, 2018 at 8:35 AM, Michael André Pearce
>  wrote:
>> Can we add
>>
>> https://github.com/apache/activemq-artemis/pull/1940
>>
>> As a blocker.
>>
>> On reviewing the PR and seeing why this PR is needed/wanted, it seems whilst 
>> console is most visibly affected by a change done , it has more serious 
>> effect that the network pinger also seems to get shutdown and not kept alive 
>> on slave failback. Concern also is if there is anything else.
>>
>> Sent from my iPhone
>>
>>> On 8 Mar 2018, at 12:28, Andy Taylor  wrote:
>>>
>>> I think  https://issues.apache.org/jira/browse/ARTEMIS-1736 is a blocker as
>>> well, Ive just sent a PR with a fix
>>>
>>> On 7 March 2018 at 04:59, Michael André Pearce 
>>> wrote:
>>>
 @Clebert

 Someone in the user threads has raised what looks like a blocker if it’s
 real.

 Something to do with large messages and broker crashing with
 2.5.0-SNAPSHOTz

 Have you seen it?

 Sent from my iPhone

> On 2 Mar 2018, at 23:42, Clebert Suconic 
 wrote:
>
> If you have anything in mind that you consider a blocking.
>
> That’s the idea of the heads up.  My expectation was the examples.  But
 if
> you want to request another change, like be PR pending you have that I
 need
> to work on ? :)
>
>
> Let me know if you have anything in mind that is a blocker.
>
> On Fri, Mar 2, 2018 at 12:46 AM MichaelAndrePearce <
> michael.andre.pea...@me.com> wrote:
>
>> yes a list of blocking tasks, so that we can all focus on those if
 needed.
>> It
>> sounded like there were a few examples, but it seems like you have that
 in
>> hand already.
>>
>>
>>
>> --
>> Sent from:
>> http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
>>
> --
> Clebert Suconic

>
>
>
> --
> Clebert Suconic



-- 
Clebert Suconic

[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
@michaelandrepearce will do.. I thought I would be able to do it tonight... 
I'm hitting another issue.. so it will be tomorrow.


---

[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
@clebertsuconic i assume you will PR your modifications before merge.


---

[GitHub] activemq-artemis issue #1943: NO-JIRA review docs for content, style, & form...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1943
  
Nice nice job!


---

[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
I'm running the testsuite... I will merge a modified patch.. thanks a lot 
@stanlyDoge 


---

[GitHub] activemq-artemis pull request #1944: ARTEMIS-1739 Set automatic module name ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1944


---

[GitHub] activemq-artemis pull request #1942: ARTEMIS-1682 Set packaging jar for arte...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1942


---

[GitHub] activemq-artemis issue #1942: ARTEMIS-1682 Set packaging jar for artemis-ser...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1942
  
Agreed.  I just wanted to make a note for posterity's sake before I merged 
it.  :)


---

[GitHub] activemq-artemis issue #1942: ARTEMIS-1682 Set packaging jar for artemis-ser...

[mtaylor]

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1942
  
@jbertram There's actually a seperate "artemis-server-osgi" module that 
should be used for osgi related stuff.  We shouldn't be including classes from 
other modules in our jars.


---

[GitHub] activemq-artemis pull request #1862: ARTEMIS-1676 Support overriding of JAVA...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1862#discussion_r173290483
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile
 ---
@@ -21,14 +21,20 @@ ARTEMIS_INSTANCE='${artemis.instance}'
 # The logging config will need an URI
 # this will be encoded in case you use spaces or special characters
 # on your directory structure
-ARTEMIS_INSTANCE_URI='${artemis.instance.uri}'
 
-# Cluster Properties: Used to pass arguments to ActiveMQ Artemis which can 
be referenced in broker.xml
-#ARTEMIS_CLUSTER_PROPS="-Dactivemq.remoting.default.port=61617 
-Dactivemq.remoting.amqp.port=5673 -Dactivemq.remoting.stomp.port=61614 
-Dactivemq.remoting.hornetq.port=5446"
+if [ -z "$ARTEMIS_INSTANCE_URI" ]; then
+ARTEMIS_INSTANCE_URI='${artemis.instance.uri}'
+fi
 
+# Cluster Properties: Used to pass arguments to ActiveMQ Artemis which can 
be referenced in broker.xml
+if [ -z "$ARTEMIS_CLUSTER_PROPS" ]; then
+#ARTEMIS_CLUSTER_PROPS="-Dactivemq.remoting.default.port=61617 
-Dactivemq.remoting.amqp.port=5673 -Dactivemq.remoting.stomp.port=61614 
-Dactivemq.remoting.hornetq.port=5446"
--- End diff --

I would be ok with this on ARTEMIS_HOME.. ARTEMIS_INSTANCE is a bit 
dangerous IMO.

Say you went to cd /artemis-servers/server1


and by accident previously you set ARTEMIS-INSTANCE = 
/artemis-server/myOtherServer


You wouldn't be able to figure out easily... I think it's a bit dangerous...


the best way we can do about this is like what we do now.. we figure out 
ARTEMIS-INSTANCE by the location of the executable's. if you do 
/my-other-server/bin/artemis start


then you will know you're starting the right server.


---

[GitHub] activemq-artemis issue #1942: ARTEMIS-1682 Set packaging jar for artemis-ser...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1942
  
I'm guessing that this will break the stuff committed for 
https://issues.apache.org/jira/browse/ARTEMIS-1630, but at this point I can't 
even get the tests in that commit to run successfully so it might already be 
broken anyway.


---

[GitHub] activemq-artemis pull request #1944: ARTEMIS-1739 Set automatic module name ...

[mtaylor]

GitHub user mtaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/1944

ARTEMIS-1739 Set automatic module name for native



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1739

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1944


commit c5efe6eb0c1ff3bf4ac8c2e693e1405ebbe61d00
Author: Martyn Taylor 
Date:   2018-03-08T20:57:46Z

ARTEMIS-1739 Set automatic module name for native




---

[GitHub] activemq-artemis pull request #1943: NO-JIRA review docs for content, style,...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1943

NO-JIRA review docs for content, style, & format



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis docReview

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1943.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1943


commit b399411c6b50763d9ab3342af979d1285444ad06
Author: Justin Bertram 
Date:   2018-03-08T20:46:38Z

NO-JIRA review docs for content, style, & format




---

[GitHub] activemq pull request #269: AMQ-6781: The ActiveMQ Web Console doesn’t sup...

[snurmine]

Github user snurmine closed the pull request at:

https://github.com/apache/activemq/pull/269


---

[GitHub] activemq-artemis pull request #1942: ARTEMIS-1682 Set packaging jar for arte...

[mtaylor]

GitHub user mtaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/1942

ARTEMIS-1682 Set packaging jar for artemis-server



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1682

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1942.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1942


commit fde86c0c3ad1390feba92fcf151558abfacc4a48
Author: Martyn Taylor 
Date:   2018-03-08T20:07:41Z

ARTEMIS-1682 Set packaging jar for artemis-server




---

[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
@stanlyDoge nice test though!! What ever the fix worth making sure it gets 
added in :)


---

[GitHub] activemq-artemis issue #1941: ARTEMIS-1714 update link

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1941
  
@jbertram great. Closing


---

[GitHub] activemq-artemis pull request #1941: ARTEMIS-1714 update link

[michaelandrepearce]

Github user michaelandrepearce closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1941


---

[GitHub] activemq-artemis issue #1941: ARTEMIS-1714 update link

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1941
  
I've got a bunch of other doc updates coming ASAP, and I'll include this 
one so you can just close this so I don't have to merge and rebase.


---

[GitHub] activemq-artemis issue #1941: ARTEMIS-1714 update link

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1941
  
Was just reviewing the other pr when it got merged, as such just raising 
the only comment I was adding as a PR as easiest


---

[GitHub] activemq-artemis pull request #1941: ARTEMIS-1714 update link

[michaelandrepearce]

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1941

ARTEMIS-1714 update link

Link to dedicate page about exclusive queue feature

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis patch-5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1941.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1941


commit 3f9d9d390b647f68917fa7a43fb92321d8729466
Author: Michael André Pearce 
Date:   2018-03-08T19:35:42Z

ARTEMIS-1714 update link

Link to dedicate page about exclusive queue feature




---

[GitHub] activemq-artemis pull request #1938: Documentation about versions and upgrad...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1938


---

Re: [HEADS-UP] 2.5.0 release some time next week... (after wed)

[Clebert Suconic]

I'm already on it... i'm working on it.

On Thu, Mar 8, 2018 at 8:35 AM, Michael André Pearce
 wrote:
> Can we add
>
> https://github.com/apache/activemq-artemis/pull/1940
>
> As a blocker.
>
> On reviewing the PR and seeing why this PR is needed/wanted, it seems whilst 
> console is most visibly affected by a change done , it has more serious 
> effect that the network pinger also seems to get shutdown and not kept alive 
> on slave failback. Concern also is if there is anything else.
>
> Sent from my iPhone
>
>> On 8 Mar 2018, at 12:28, Andy Taylor  wrote:
>>
>> I think  https://issues.apache.org/jira/browse/ARTEMIS-1736 is a blocker as
>> well, Ive just sent a PR with a fix
>>
>> On 7 March 2018 at 04:59, Michael André Pearce 
>> wrote:
>>
>>> @Clebert
>>>
>>> Someone in the user threads has raised what looks like a blocker if it’s
>>> real.
>>>
>>> Something to do with large messages and broker crashing with
>>> 2.5.0-SNAPSHOTz
>>>
>>> Have you seen it?
>>>
>>> Sent from my iPhone
>>>
 On 2 Mar 2018, at 23:42, Clebert Suconic 
>>> wrote:

 If you have anything in mind that you consider a blocking.

 That’s the idea of the heads up.  My expectation was the examples.  But
>>> if
 you want to request another change, like be PR pending you have that I
>>> need
 to work on ? :)


 Let me know if you have anything in mind that is a blocker.

 On Fri, Mar 2, 2018 at 12:46 AM MichaelAndrePearce <
 michael.andre.pea...@me.com> wrote:

> yes a list of blocking tasks, so that we can all focus on those if
>>> needed.
> It
> sounded like there were a few examples, but it seems like you have that
>>> in
> hand already.
>
>
>
> --
> Sent from:
> http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
>
 --
 Clebert Suconic
>>>



-- 
Clebert Suconic

[GitHub] activemq-artemis pull request #1939: ARTEMIS-1736 - make sure access methods...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1939


---

[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...

[stanlyDoge]

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
Ah, I see. Yeah, it seem to be changed in 
[ARTEMIS-1440](https://issues.apache.org/jira/browse/ARTEMIS-1440). 
@clebertsuconic can you take a look?


---

[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
@stanlyDoge its not just the console affected. the root cause of the issue 
you are seeing was that actually fail() method called prior to your change used 
to have the isExit flag to false, there are actually a few places that can be 
invoked as well, as such whilst the negative effect of this change that ive 
called out, is most visible with the console, there are more serious bits seen 
that also look like they're affected such as Network Pinger. 

This really needs to have @clebertsuconic look over his original change, as 
it seems that it is what caused this, also others in my opinion. And any fix 
needs to not just care about the console.


---

[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...

[stanlyDoge]

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
Yes, it is. I used this conf: https://pastebin.com/2G0c341X
If I am not wrong, restaring logic is implemented as 
[this](https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java#L194).
I am not sure if it would be ok to iterate all ExternalComponents here and 
if it is web one, just start it again. What do you think?


---

Re: [HEADS-UP] 2.5.0 release some time next week... (after wed)

[Michael André Pearce]

Can we add 

https://github.com/apache/activemq-artemis/pull/1940

As a blocker.

On reviewing the PR and seeing why this PR is needed/wanted, it seems whilst 
console is most visibly affected by a change done , it has more serious effect 
that the network pinger also seems to get shutdown and not kept alive on slave 
failback. Concern also is if there is anything else.

Sent from my iPhone

> On 8 Mar 2018, at 12:28, Andy Taylor  wrote:
> 
> I think  https://issues.apache.org/jira/browse/ARTEMIS-1736 is a blocker as
> well, Ive just sent a PR with a fix
> 
> On 7 March 2018 at 04:59, Michael André Pearce 
> wrote:
> 
>> @Clebert
>> 
>> Someone in the user threads has raised what looks like a blocker if it’s
>> real.
>> 
>> Something to do with large messages and broker crashing with
>> 2.5.0-SNAPSHOTz
>> 
>> Have you seen it?
>> 
>> Sent from my iPhone
>> 
>>> On 2 Mar 2018, at 23:42, Clebert Suconic 
>> wrote:
>>> 
>>> If you have anything in mind that you consider a blocking.
>>> 
>>> That’s the idea of the heads up.  My expectation was the examples.  But
>> if
>>> you want to request another change, like be PR pending you have that I
>> need
>>> to work on ? :)
>>> 
>>> 
>>> Let me know if you have anything in mind that is a blocker.
>>> 
>>> On Fri, Mar 2, 2018 at 12:46 AM MichaelAndrePearce <
>>> michael.andre.pea...@me.com> wrote:
>>> 
 yes a list of blocking tasks, so that we can all focus on those if
>> needed.
 It
 sounded like there were a few examples, but it seems like you have that
>> in
 hand already.
 
 
 
 --
 Sent from:
 http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
 
>>> --
>>> Clebert Suconic
>> 

[GitHub] activemq-artemis issue #1940: ARTEMIS-1737 fix for inaccessible slave consol...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
Is this on fail back to master? With restart enabled?

If so shouldn’t the console be in the restarting logic with the other 
components?


---

Re: [HEADS-UP] 2.5.0 release some time next week... (after wed)

[Andy Taylor]

I think  https://issues.apache.org/jira/browse/ARTEMIS-1736 is a blocker as
well, Ive just sent a PR with a fix

On 7 March 2018 at 04:59, Michael André Pearce 
wrote:

> @Clebert
>
> Someone in the user threads has raised what looks like a blocker if it’s
> real.
>
> Something to do with large messages and broker crashing with
> 2.5.0-SNAPSHOTz
>
> Have you seen it?
>
> Sent from my iPhone
>
> > On 2 Mar 2018, at 23:42, Clebert Suconic 
> wrote:
> >
> > If you have anything in mind that you consider a blocking.
> >
> > That’s the idea of the heads up.  My expectation was the examples.  But
> if
> > you want to request another change, like be PR pending you have that I
> need
> > to work on ? :)
> >
> >
> > Let me know if you have anything in mind that is a blocker.
> >
> > On Fri, Mar 2, 2018 at 12:46 AM MichaelAndrePearce <
> > michael.andre.pea...@me.com> wrote:
> >
> >> yes a list of blocking tasks, so that we can all focus on those if
> needed.
> >> It
> >> sounded like there were a few examples, but it seems like you have that
> in
> >> hand already.
> >>
> >>
> >>
> >> --
> >> Sent from:
> >> http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
> >>
> > --
> > Clebert Suconic
>

[GitHub] activemq-artemis pull request #1940: ARTEMIS-1737 fix for inaccessible slave...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1940

ARTEMIS-1737 fix for inaccessible slave console after failover

Can anybody review this? I will try to write some tests meanwhile. Thank 
you.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis E1018

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1940.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1940


commit 81d6328850b77b3d314aa64ea61a24bbb1baf055
Author: Stanislav Knot 
Date:   2018-03-08T10:03:37Z

ARTEMIS-1737 fix for inaccessible slave console after failover




---

[GitHub] activemq-artemis pull request #1939: ARTEMIS-1736 - make sure access methods...

[andytaylor]

GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/1939

ARTEMIS-1736 - make sure access methods are ordered when used

https://issues.apache.org/jira/browse/ARTEMIS-1736

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-artemis ARTEMIS-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1939.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1939


commit 56c2e2b29984fa6c637921517e8deff71c5f648f
Author: andytaylor 
Date:   2018-03-08T09:49:56Z

ARTEMIS-1736 - make sure access methods are ordered when used

https://issues.apache.org/jira/browse/ARTEMIS-1736




---