[VOTE] Apache ActiveMQ Artemis 2.5.0

[Clebert Suconic]

I would like to propose an Apache ActiveMQ Artemis 2.5.0 release.

This is a great release, with 190 tasks completed including bug fixes,
improvements, new features and additional tasks. I really appreciate
everyone's contribution on making this happening. Thank you so much!


I would like to highlight the features introduced on this release:

[ARTEMIS-853] - Support for exclusive consumers
[ARTEMIS-1030] - Support equivilent ActiveMQ 5.x Virtual Topic Naming Abilities
[ARTEMIS-1548] - Support CRL
[ARTEMIS-1550] - Support LVQ for OpenWire
[ARTEMIS-1600] - Support masked passwords in bootstrap.xm and login.config
[ARTEMIS-1623] - create an ActiveMQServerPlugin for logging various
broker events
[ARTEMIS-1649] - enable openssl provider for Netty
[ARTEMIS-1661] - Enable splitting of broker.xml into multiple files
[ARTEMIS-1663] - Add enhanced message count and size metrics for Queues


Given the length of this release, please refer to JIRA for the
complete report of fixes included on 2.5.0:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920=12342127



Source and binary distributions can be found here:
https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.5.0


The Maven repository is here:
https://repository.apache.org/content/repositories/orgapacheactivemq-1156


In case you want to give it a try with the maven repo on examples:
http://activemq.apache.org/artemis/docs/latest/hacking-guide/validating-releases.html


The source tag:
https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;a=tag;h=refs/tags/2.5.0

I will update the website after the vote has passed.



[ ] +1 approve the release as Apache Artemis 2.4.0
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Here's my +1

[GitHub] activemq-artemis pull request #1951: ARTEMIS-1744 fix removing addresses and...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1951

ARTEMIS-1744 fix removing addresses and queues with '*' or '?' in their 
names via hawtio console



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis E1027

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1951.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1951


commit 913320fa631931dfc911ec8e78f0893940147b68
Author: Stanislav Knot 
Date:   2018-03-12T16:21:58Z

ARTEMIS-1744 fix removing addresses and queues with '*' or '?' in their 
names via hawtio console




---

[GitHub] activemq-cpp pull request #5: Move timer objects to the end of member list

[unjello]

GitHub user unjello opened a pull request:

https://github.com/apache/activemq-cpp/pull/5

Move timer objects to the end of member list

In high CPU load it can happen, that Timer thread wakes up,
is swapped out, and when application resumes it does not resume with timer
thread, but transport thread, that decides to do failover, destroys
`InactivityMonitor` object. When its members are getting destroyed,
they arrive at `Timer` object that joins, timer thread resumes in
`writeCheck` or `readCheck` method, only to find out `asyncTasks` is already
destroyed because it comes later in member declaration list so it was
destroyed first. Moving `Timer` object to the end of the list, guarantees
that they will be destroyed first, so their threads will get joined and
allowed to finish, before the rest of the object is destroyed.

Closes AMQCPP-626

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/unjello/activemq-cpp fix/amqcpp-626

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-cpp/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5


commit fced83a9da3531e0b6875c80714d47424449f29c
Author: Andrzej Lichnerowicz 
Date:   2018-03-12T15:20:31Z

Move timer objects to the end of member list

In high CPU load it can happen, that Timer thread wakes up,
is swapped out, and when application resumes it does not resume with timer
thread, but transport thread, that decides to do failover, destroys
`InactivityMonitor` object. When its members are getting destroyed,
they arrive at `Timer` object that joins, timer thread resumes in
`writeCheck` or `readCheck` method, only to find out `asyncTasks` is already
destroyed because it comes later in member declaration list so it was
destroyed first. Moving `Timer` object to the end of the list, guarantees
that they will be destroyed first, so their threads will get joined and
allowed to finish, before the rest of the object is destroyed.

Closes AMQCPP-626




---

[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1950
  
ok


---

[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1950
  
We will have a 2.5.1 shortly



---

[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1950
  
Lets leave this out of the release... please don't merge this!!!

I will get back to this after the release.


---

[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1950
  
@clebertsuconic thanks.


---

[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1950
  
this is not complete. if your disk is full... and no more producing is 
happening you will never release the executables.

Besides.. I will look if there is a way to use the PagingStoreManager to do 
this, or to avoid the duplicate code... (which would fix the issue I mentioned)


---