[GitHub] activemq-artemis pull request #1993: ARTEMIS-618 Using proper block size on ...

[clebertsuconic]

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1993

ARTEMIS-618 Using proper block size on Native One Mega Buffer

This buffer is used on fill

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis aio

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1993.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1993


commit 64fec0478bcecb5b48cc1684cf4dee8e2a1871dd
Author: Clebert Suconic 
Date:   2018-04-05T00:37:38Z

ARTEMIS-618 Using proper block size on Native One Mega Buffer

This buffer is used on fill




---

[GitHub] activemq-artemis pull request #1992: ARTEMIS-1785 Fixing --message-size on ....

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1992


---

Re: Board report for April 2018

[Bruce Snyder]

I am following up again to request your contribution to the ASF board
report for April. The deadline to contribute is April 11th.

If you are contributing code to any modules within the ActiveMQ project,
please take a few moments to edit the following wiki page to report on the
activity that has taken place over the last two months:

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75977784

Thank you!

Bruce

On Thu, Mar 29, 2018 at 9:30 PM, Bruce Snyder 
wrote:

> It is time once again to submit a report to the ASF board for April.
> Please take 5 minutes to contribute some of the project activity to the
> report at the wiki page below:
>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75977784
>
> This report must be submitted by April 11th.
>
> I really appreciate your contributions!
>
> Bruce
>
> --
> perl -e 'print unpack("u30","D0G)U8V4\@4VYY9&
> 5R\"F)R=6-E+G-N>61E
> ActiveMQ in Action: http://bit.ly/2je6cQ
> Blog: http://bsnyder.org/ 
> Twitter: http://twitter.com/brucesnyder
>



-- 
perl -e 'print
unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E
Twitter: http://twitter.com/brucesnyder

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1990#discussion_r179284287
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
 ---
@@ -1539,6 +1540,8 @@ public void end(final Xid xid, final int flags) 
throws XAException {
 startCall();
 try {
sessionContext.xaEnd(xid, flags);
+} catch (ActiveMQNotConnectedException ex) {
+   
ActiveMQClientLogger.LOGGER.connectionClosedWarn(ex.getType(), ex.getMessage());
--- End diff --

and as I requested you this small change.. can you rebase against master? 
that would help me to find that pesky AIO failure on travis.


---

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1990#discussion_r179284174
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
 ---
@@ -1539,6 +1540,8 @@ public void end(final Xid xid, final int flags) 
throws XAException {
 startCall();
 try {
sessionContext.xaEnd(xid, flags);
+} catch (ActiveMQNotConnectedException ex) {
+   
ActiveMQClientLogger.LOGGER.connectionClosedWarn(ex.getType(), ex.getMessage());
--- End diff --

can you at least keep a logger.debug(ex.getMessage(), ex) here?

This way if a developer ever needs to debug on why.. it would give the 
developer more information?


---

[GitHub] activemq-artemis pull request #1992: ARTEMIS-1785 Fixing --message-size on ....

[clebertsuconic]

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1992

ARTEMIS-1785 Fixing --message-size on ./artemis producer



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis producer-cli

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1992.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1992


commit 41128fe4cbca194924f01cf635c93a8828ef2023
Author: Clebert Suconic 
Date:   2018-04-04T19:19:02Z

ARTEMIS-1785 Fixing --message-size on ./artemis producer




---

[GitHub] activemq-artemis pull request #1991: NO-JIRA Providing information about fai...

[clebertsuconic]

Github user clebertsuconic closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1991


---

[GitHub] activemq-artemis issue #1990: [ARTEMIS-1770] Log warning instead of stacktra...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1990
  
@rstancel looking :#1991


---

[GitHub] activemq-artemis pull request #1991: NO-JIRA Providing information about fai...

[clebertsuconic]

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1991

NO-JIRA Providing information about failure on test

Travis CI has been reporting test failures.
Looking on logs I could see a critical failure happening but not much 
information on why.
This will help identify further issues.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis aio

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1991.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1991


commit fe5d47dd276428a9d4809f74ec8bf7b57638908c
Author: Clebert Suconic 
Date:   2018-04-04T17:46:40Z

NO-JIRA Providing information about failure on test

Travis CI has been reporting test failures.
Looking on logs I could see a critical failure happening but not much 
information on why.
This will help identify further issues.




---

[GitHub] activemq-artemis issue #1991: DO-NOT-MERGE NO-JIRA Providing information abo...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1991
  
I will merge this myself.. I want to make a couple runs until it failed and 
I can debug why.


---

[GitHub] activemq-artemis pull request #1985: ARTEMIS-1780 Handle conversion of large...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1985


---

[GitHub] activemq-artemis pull request #1986: ARTEMIS-1653 Allow database tables to b...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1986#discussion_r179124397
  
--- Diff: 
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
 ---
@@ -191,9 +191,18 @@ private void createTableIfNotExists(String tableName, 
String... sqls) throws SQL
 } else {
try (Statement statement = connection.createStatement();
  ResultSet cntRs = 
statement.executeQuery(sqlProvider.getCountJournalRecordsSQL())) {
-  if (rs.next() && rs.getInt(1) > 0) {
+  int rows;
+  if (cntRs.next() && (rows = cntRs.getInt(1)) > 0) {
  logger.tracef("Table %s did exist but is not empty. 
Skipping initialization.", tableName);
+ if (logger.isDebugEnabled()) {
+final long expectedRows = 
Stream.of(sqls).map(String::toUpperCase).filter(sql -> sql.contains("INSERT 
INTO")).count();
--- End diff --

Nope, I meant that the check should be performed only with debug log level 
to help spotting weird behavious.
It is not the most robust check ever, but it is pretty helpfull for HA (for 
example).


---

[GitHub] activemq-artemis issue #1990: [ARTEMIS-1770] Log warning instead of stacktra...

[rstancel]

Github user rstancel commented on the issue:

https://github.com/apache/activemq-artemis/pull/1990
  
Can someone please run retest? I have the same issue on Travis as this PR: 
https://github.com/apache/activemq-artemis/pull/1985 and I think it has nothing 
to do with my PR


---