[GitHub] activemq-artemis pull request #2041: ARTEMIS-1825 Live-backup topology not c...

[gaohoward]

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/2041

ARTEMIS-1825 Live-backup topology not correctly displayed on console



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis h1825

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2041.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2041


commit 82241555d48ece29a76b6b48da8921225e747d87
Author: Howard Gao 
Date:   2018-04-24T04:08:33Z

ARTEMIS-1825 Live-backup topology not correctly displayed on console




---

[GitHub] activemq-artemis pull request #2036: ARTEMIS-1821 LDAPLoginModule always ret...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2036


---

[GitHub] activemq-artemis pull request #2013: ARTEMIS-1805 fix for broker operations ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2013


---

[GitHub] activemq-artemis pull request #2039: [ARTEMIS-1823] - Log warning on boot wh...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2039#discussion_r183472200
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
 ---
@@ -2323,6 +2324,16 @@ synchronized boolean initialisePart1(boolean 
scalingDown) throws Exception {
  deployAddressSettingsFromConfiguration();
   }
 
+  //fix of ARTEMIS-1823
+  if (!configuration.isPersistenceEnabled()) {
+ for (AddressSettings addressSettings : 
addressSettingsRepository.values()) {
+if (addressSettings.getAddressFullMessagePolicy() == 
AddressFullMessagePolicy.PAGE) {
+   ActiveMQServerLogger.LOGGER.pageWillBePersisted();
--- End diff --

really? did you have any user complaining about it?


---

[GitHub] activemq-artemis pull request #2040: ARTEMIS-1824 running broker from path w...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2040#discussion_r183471882
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/XMLUtil.java
 ---
@@ -323,7 +323,7 @@ public static double parseDouble(final Node elem) {
public static void validate(final Node node, final String schemaFile) 
throws Exception {
   SchemaFactory factory = 
SchemaFactory.newInstance(XMLConstants.W3C_XML_SCHEMA_NS_URI);
 
-  Schema schema = factory.newSchema(findResource(schemaFile));
+  Schema schema = factory.newSchema(new 
URL(findResource(schemaFile).toURI().toASCIIString()));
--- End diff --

Please.. check ./artemis-distribution/src/test/scripts/validate-spaces.sh


Please add the failing pattern that you found on that test.. and run it 
after building the release.


validate-spaces.sh has been added to avoid such issues. if you hit one i 
would like to have the test updated.


---

[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2010#discussion_r183418125
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ---
@@ -2712,6 +2714,11 @@ private Message makeCopy(final MessageReference ref, 
final boolean expiry) throw
private Message makeCopy(final MessageReference ref,
 final boolean expiry,
 final boolean copyOriginalHeaders) throws 
Exception {
+  if (ref == null) {
+ ActiveMQServerLogger.LOGGER.nullRefMessage();
+ NULL_REF.createException("Reference to message is null");
--- End diff --

didn't you miss throw NULL_REF here?


---

[GitHub] activemq-artemis issue #2010: ARTEMIS-1801 removing null-unchecked dereferen...

[stanlyDoge]

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/2010
  
@clebertsuconic polished :)


---

[GitHub] activemq-artemis issue #2013: ARTEMIS-1805 fix for broker operations in hawt...

[stanlyDoge]

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/2013
  
@gaohoward Done.


---

[GitHub] activemq-artemis pull request #2040: ARTEMIS-1824 running broker from path w...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/2040

ARTEMIS-1824 running broker from path with non-ascii chars



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1824

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2040.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2040


commit 5407f674d536e294dbc1b8925c964682863189da
Author: Stanislav Knot 
Date:   2018-04-23T13:12:01Z

ARTEMIS-1824 running broker from path with non-ascii chars




---

[GitHub] activemq-artemis pull request #2039: [ARTEMIS-1823] - Log warning on boot wh...

[JiriOndrusek]

GitHub user JiriOndrusek opened a pull request:

https://github.com/apache/activemq-artemis/pull/2039

[ARTEMIS-1823] - Log warning on boot when persistence is disabled and…

… paging enabled

Issue: https://issues.apache.org/jira/browse/ARTEMIS-1823

Added warning in case that paging is on and persistence is disabled.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JiriOndrusek/activemq-artemis ARTEMIS-1823

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2039.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2039


commit b4cf6aa37484be1b3aa1b9ce2438e0df289f97c7
Author: JiriOndrusek 
Date:   2018-04-23T12:57:09Z

[ARTEMIS-1823] - Log warning on boot when persistence is disabled and 
paging enabled




---

[GitHub] activemq-artemis issue #2035: [ARTEMIS-1819] Missing fields on listAllConsum...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2035
  
I think the first thing to clarify is exactly what information is missing 
which your clients need.


---

[GitHub] activemq-artemis issue #2035: [ARTEMIS-1819] Missing fields on listAllConsum...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2035
  
It’s on the address and queue information


---

[GitHub] activemq-artemis issue #2035: [ARTEMIS-1819] Missing fields on listAllConsum...

[iweiss]

Github user iweiss commented on the issue:

https://github.com/apache/activemq-artemis/pull/2035
  
@michaelandrepearce @jbertram Thanks for your comments. Where would be the 
best place to add this information back to a consumer of these methods?


---