[GitHub] activemq-artemis pull request #2051: ARTEMIS-1836 Bug with broker when runni...

[acemanace]

GitHub user acemanace opened a pull request:

https://github.com/apache/activemq-artemis/pull/2051

ARTEMIS-1836 Bug with broker when running on Windows,

cannot find login.config

The Windows variable ARTEMIS_ETC_INSTANCE was not set correctly,
as it was used as ARTEMIS_INSTANCE_ETC. So the fix is to make sure
that the two match, and additionally they it was renamed to more
closely match the other variables naming convention. This was done
in two files; so when 'artemis create mybroker' is run on a Windows
machine, the broker is correctly configured with login.config.

Minor fix of changing use of single quotes to correct usage of
double quotes when declaring variable.

Issue: https://issues.apache.org/jira/browse/ARTEMIS-1836

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/acemanace/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2051.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2051






---

[GitHub] activemq-artemis pull request #2050: NO-JIRA update release instructions

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/2050

NO-JIRA update release instructions



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis master_work

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2050.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2050


commit 50de8015912264a8065f507bdc2ecf04ad86c868
Author: Justin Bertram 
Date:   2018-04-27T20:08:55Z

NO-JIRA update release instructions




---

Re: Webconsole deprecation

[Arthur Naseef]

I'd like to propose the following approach for the WebConsole:

   - AMQ adopts the position that the web console is for internal use only
   and that exposing it to third parties is not recommended due to possible
   vulnerabilities (I've personally always held this view and made this
   recommendation to all).  It is a "web console" for management and control
   of the broker - not a messaging application front-end.
   - We update the ActiveMQ website to clearly document this position and
   warn folks that it is enabled by default out-of-the-box
   - As CVEs are reported, we open jira tickets with the core details, and
   respond to the reporter with thanks for their contribution and that we may
   address at a future time, then reject the CVE with the statement that web
   console vulnerabilities are recognized and the solution is to firewall the
   web console

In addition, for those that feel a strong need to fully secure the broker
for whatever reason, how about we look to simplify the work of disabling
the console?  If there already exists a simple way, please let me know and
I'll update this page, http://activemq.apache.org/web-console.html, with
those instructions.

Please let me know your thoughts.

Art




On Thu, Apr 26, 2018 at 12:58 PM, Daniel Kulp  wrote:

>
>
> > Furthermore, there are certain things that require PMC members to
> > handle so there would still need to be people on the PMC willing to
> > support the web console as well (which hasn't really been the case
> > other than a few minor fixes I have committed the past couple years).
>
> That’s something that is easily fixed by the PMC if someone steps up to
> work on the console:  vote them into the PMC.
>
>
> --
> Daniel Kulp
> dk...@apache.org - http://dankulp.com/blog
> Talend Community Coder - http://coders.talend.com
>
>

[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2010#discussion_r184701274
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ---
@@ -2712,6 +2713,11 @@ private Message makeCopy(final MessageReference ref, 
final boolean expiry) throw
private Message makeCopy(final MessageReference ref,
 final boolean expiry,
 final boolean copyOriginalHeaders) throws 
Exception {
+  if (ref == null) {
+ ActiveMQServerLogger.LOGGER.nullRefMessage();
+ throw new ActiveMQNullRefException("Reference to message is 
null");
--- End diff --

The method I saw didn't have a throw.. I'm not sure what happened to github 
diffs here.


---

[GitHub] activemq-artemis pull request #2049: NO-JIRA: Added a AMQP JMS LargeMessage ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2049


---

[GitHub] activemq-artemis pull request #2049: NO-JIRA: Added a AMQP JMS LargeMessage ...

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2049#discussion_r184700517
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSDurableConsumerTest.java
 ---
@@ -221,4 +224,66 @@ public void 
testDurableConsumerUnsubscribeWhileActive() throws Exception {
  connection.close();
   }
}
+
+   @Test(timeout = 3)
+   public void testDurableConsumerLarge() throws Exception {
+  String durableClientId = getTopicName() + "-ClientId";
+
+  Connection connection = createConnection(durableClientId);
+  try {
+ Session session = connection.createSession(false, 
Session.AUTO_ACKNOWLEDGE);
+ Topic topic = session.createTopic(getTopicName());
+ final MessageConsumer consumer1 = 
session.createDurableSubscriber(topic, "DurbaleSub1");
+ final MessageConsumer consumer2 = 
session.createDurableSubscriber(topic, "DurbaleSub2");
+ MessageProducer producer = session.createProducer(topic);
+ producer.setDeliveryMode(DeliveryMode.PERSISTENT);
+ connection.start();
+
+ ObjectMessage objMessage = session.createObjectMessage();
+ BigObject bigObject = new 
BigObject(ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE);
+ objMessage.setObject(bigObject);
+ producer.send(objMessage);
+
+ final AtomicReference msg1 = new AtomicReference<>();
+ final AtomicReference msg2 = new AtomicReference<>();
+
+ assertTrue(Wait.waitFor(new Wait.Condition() {
+
+@Override
+public boolean isSatisfied() throws Exception {
+   msg1.set(consumer1.receiveNoWait());
+   return msg1.get() != null;
+}
+ }, TimeUnit.SECONDS.toMillis(25), 
TimeUnit.MILLISECONDS.toMillis(200)));
--- End diff --

Thanks, I just copy/modify from other test and didn't think much of it. :)


---

[GitHub] activemq-artemis pull request #2049: NO-JIRA: Added a AMQP JMS LargeMessage ...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2049#discussion_r184699818
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSDurableConsumerTest.java
 ---
@@ -221,4 +224,66 @@ public void 
testDurableConsumerUnsubscribeWhileActive() throws Exception {
  connection.close();
   }
}
+
+   @Test(timeout = 3)
+   public void testDurableConsumerLarge() throws Exception {
+  String durableClientId = getTopicName() + "-ClientId";
+
+  Connection connection = createConnection(durableClientId);
+  try {
+ Session session = connection.createSession(false, 
Session.AUTO_ACKNOWLEDGE);
+ Topic topic = session.createTopic(getTopicName());
+ final MessageConsumer consumer1 = 
session.createDurableSubscriber(topic, "DurbaleSub1");
+ final MessageConsumer consumer2 = 
session.createDurableSubscriber(topic, "DurbaleSub2");
+ MessageProducer producer = session.createProducer(topic);
+ producer.setDeliveryMode(DeliveryMode.PERSISTENT);
+ connection.start();
+
+ ObjectMessage objMessage = session.createObjectMessage();
+ BigObject bigObject = new 
BigObject(ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE);
+ objMessage.setObject(bigObject);
+ producer.send(objMessage);
+
+ final AtomicReference msg1 = new AtomicReference<>();
+ final AtomicReference msg2 = new AtomicReference<>();
+
+ assertTrue(Wait.waitFor(new Wait.Condition() {
+
+@Override
+public boolean isSatisfied() throws Exception {
+   msg1.set(consumer1.receiveNoWait());
+   return msg1.get() != null;
+}
+ }, TimeUnit.SECONDS.toMillis(25), 
TimeUnit.MILLISECONDS.toMillis(200)));
--- End diff --

never mind.. I'm fixing it.


---

[GitHub] activemq-artemis pull request #2049: NO-JIRA: Added a AMQP JMS LargeMessage ...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2049#discussion_r184698179
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSDurableConsumerTest.java
 ---
@@ -221,4 +224,66 @@ public void 
testDurableConsumerUnsubscribeWhileActive() throws Exception {
  connection.close();
   }
}
+
+   @Test(timeout = 3)
+   public void testDurableConsumerLarge() throws Exception {
+  String durableClientId = getTopicName() + "-ClientId";
+
+  Connection connection = createConnection(durableClientId);
+  try {
+ Session session = connection.createSession(false, 
Session.AUTO_ACKNOWLEDGE);
+ Topic topic = session.createTopic(getTopicName());
+ final MessageConsumer consumer1 = 
session.createDurableSubscriber(topic, "DurbaleSub1");
+ final MessageConsumer consumer2 = 
session.createDurableSubscriber(topic, "DurbaleSub2");
+ MessageProducer producer = session.createProducer(topic);
+ producer.setDeliveryMode(DeliveryMode.PERSISTENT);
+ connection.start();
+
+ ObjectMessage objMessage = session.createObjectMessage();
+ BigObject bigObject = new 
BigObject(ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE);
+ objMessage.setObject(bigObject);
+ producer.send(objMessage);
+
+ final AtomicReference msg1 = new AtomicReference<>();
+ final AtomicReference msg2 = new AtomicReference<>();
+
+ assertTrue(Wait.waitFor(new Wait.Condition() {
+
+@Override
+public boolean isSatisfied() throws Exception {
+   msg1.set(consumer1.receiveNoWait());
+   return msg1.get() != null;
+}
+ }, TimeUnit.SECONDS.toMillis(25), 
TimeUnit.MILLISECONDS.toMillis(200)));
--- End diff --

The Wait condition here is doing nothing.. you could simplify this a lot by 
just using consumer.receive(timeout);


---

[GitHub] activemq-artemis pull request #2049: NO-JIRA: Added a AMQP JMS LargeMessage ...

[gaohoward]

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/2049

NO-JIRA: Added a AMQP JMS LargeMessage test



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis f_1461

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2049


commit 7ba4f75feeaf6c01e8a2ae7db63553741ab36960
Author: Howard Gao 
Date:   2018-04-27T12:22:28Z

NO-JIRA: Added a AMQP JMS LargeMessage test




---

[GitHub] activemq-artemis issue #2038: ARTEMIS-1828 CLI option for queue's routing-ty...

[rakstar]

Github user rakstar commented on the issue:

https://github.com/apache/activemq-artemis/pull/2038
  
@jbertram Thanks for creating the issue. I updated my commit message and 
pushed (twice because I didn't rebase the first time, sorry).

@clebertsuconic It is backward compatible as it defaults to anycast if 
unspecified. I indicate this in the CLI help as well.

Thanks!


---

[GitHub] activemq-artemis pull request #2048: [ARTEMIS-1823] - Log warning on boot wh...

[JiriOndrusek]

GitHub user JiriOndrusek opened a pull request:

https://github.com/apache/activemq-artemis/pull/2048

[ARTEMIS-1823] - Log warning on boot when persistence is disabled and…

… paging enabled

Issue: https://issues.apache.org/jira/browse/ARTEMIS-1823

no tests are needed as this is a simple logging change.

cherry-picked from 04d8390513b8e33c744cb2e98675229b4956b92e

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JiriOndrusek/activemq-artemis ARTEMIS-1823-1x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2048.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2048


commit 0dd84db98fc242591810fb742d76d7703ad72829
Author: JiriOndrusek 
Date:   2018-04-23T12:57:09Z

[ARTEMIS-1823] - Log warning on boot when persistence is disabled and 
paging enabled

no tests are needed as this is a simple logging change.

cherry-picked from 04d8390513b8e33c744cb2e98675229b4956b92e




---

[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...

[stanlyDoge]

Github user stanlyDoge commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2010#discussion_r184601120
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ---
@@ -2712,6 +2713,11 @@ private Message makeCopy(final MessageReference ref, 
final boolean expiry) throw
private Message makeCopy(final MessageReference ref,
 final boolean expiry,
 final boolean copyOriginalHeaders) throws 
Exception {
+  if (ref == null) {
+ ActiveMQServerLogger.LOGGER.nullRefMessage();
+ throw new ActiveMQNullRefException("Reference to message is 
null");
--- End diff --

ActiveMQNullRefException calls super(ActiveMQExceptionType.NULL_REF), which 
as I understand invokes NULL_REF.createException.


---

[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...

[stanlyDoge]

Github user stanlyDoge commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2010#discussion_r184600627
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ---
@@ -2712,6 +2714,11 @@ private Message makeCopy(final MessageReference ref, 
final boolean expiry) throw
private Message makeCopy(final MessageReference ref,
 final boolean expiry,
 final boolean copyOriginalHeaders) throws 
Exception {
+  if (ref == null) {
+ ActiveMQServerLogger.LOGGER.nullRefMessage();
+ NULL_REF.createException("Reference to message is null");
--- End diff --

Yeah, i forgot to throw that. I am throwing ActiveMQNullRefException, which 
under the hood does super(ActiveMQExceptionType.NULL_REF). Is that ok?


---