[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2093
  
These following tests are failing:

Test Result (14 failures / +14)

org.apache.activemq.artemis.tests.integration.amqp.JMSConnectionWithSecurityTest.testCreateTemporaryQueueNotAuthorized

org.apache.activemq.artemis.tests.integration.amqp.JMSConnectionWithSecurityTest.testCreateTemporaryTopicNotAuthorized

org.apache.activemq.artemis.tests.integration.jms.consumer.JmsConsumerTest.testValidateExceptionsThroughSharedConsumers

org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedNonDurableSubOnDifferentSelector

org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedDurableSubOnDifferentSelector

org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedDurableSubOnDifferentTopic

org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedNonDurableSubOnDifferentSelectorSrcFilterNull

org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedDurableSubOnDifferentSelectorSrcFilterNull

org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedDurableSubOnDifferentSelectorTargetFilterNull

org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedNonDurableSubOnDifferentSelectorTargetFilterNull


These tests also failed when I ran but they are probably part of the 
intermittent failures:

org.apache.activemq.artemis.protocol.amqp.util.CreditsSemaphoreTest.testDownAndUp

org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageWithDelayFailoverTest.testFailThenReceiveMoreMessagesAfterFailover2

org.apache.activemq.artemis.tests.integration.cluster.reattach.MultiThreadRandomReattachTest.testD

org.apache.activemq.artemis.tests.integration.cluster.reattach.NettyMultiThreadRandomReattachTest.testE


(Although I believe CreditsSemaphoreTest failed because of these changes.. 
I'm not 100% sure)


---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2089
  
if I merged this now I would need to use cherry-picks from master into 
2.6.x... if I could wait a week before merging this?


---

[GitHub] activemq-artemis pull request #2091: ARTEMIS-1870:Missing documentation for ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2091


---

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2093
  
I'm running the testsuite first before merging this... 


---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2089
  
@RaiSaurabh thanks for adding test, i would ask this goes in after a 2.6.1 
release though, as this is new feature, and i think 2.6.1 should just be bug 
fixes to avoid scope of the fix release.


---

[GitHub] activemq-artemis pull request #2094: ARTEMIS-1874 fix NPE setting object pro...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2094


---

[GitHub] activemq-artemis pull request #2092: ARTEMIS-1853 Adding Netty OpenSSL provi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2092


---

[GitHub] activemq-artemis pull request #2090: ARTEMIS-1868 Openwire doesn't add deliv...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2090


---

[GitHub] activemq-artemis pull request #2095: ARTEMIS-1875 Add message address if not...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2095


---

[GitHub] activemq-artemis issue #2095: ARTEMIS-1875 Add message address if not set du...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2095
  
I ran the whole testsuite and this was fine.. making this failure a non 
issue.

Merging this.


---

Re: [HEADS-UP] ActiveMQ Artemis release in week.

[Clebert Suconic]

Good point...

Just created 2.6.x


However.. if I need to pick everything from master.. .I will just do
the following:

git checkout 2.6.x
git pulll --rebase apache master


And in case I find things that are not supposed to be on 2.6.1.. i
will use cherry-picking.

On Mon, May 21, 2018 at 2:29 PM, Timothy Bish  wrote:
> On 05/21/2018 02:03 PM, Clebert Suconic wrote:
>>
>> As we talked during the voting thread, we will follow up 2.6.0 with a
>> short 2.6.1 in 1 week from now.
>>
>>
>> meanwhile... please try to not break anything :)
>>
> Branch now and cherry-pick, then it doesn't matter if anyone breaks
> anything,
>
> --
> Tim Bish
>



-- 
Clebert Suconic

Re: [HEADS-UP] ActiveMQ Artemis release in week.

[Timothy Bish]

On 05/21/2018 02:03 PM, Clebert Suconic wrote:

As we talked during the voting thread, we will follow up 2.6.0 with a
short 2.6.1 in 1 week from now.


meanwhile... please try to not break anything :)

Branch now and cherry-pick, then it doesn't matter if anyone breaks 
anything,


--
Tim Bish

[HEADS-UP] ActiveMQ Artemis release in week.

[Clebert Suconic]

As we talked during the voting thread, we will follow up 2.6.0 with a
short 2.6.1 in 1 week from now.


meanwhile... please try to not break anything :)

-- 
Clebert Suconic

Re: [DISCUSS] Commits report

[Clebert Suconic]

If we update the Release guide to include the commit report. Is there
any git repo we could include it, as a sub project of ActiveMQ?

The report could actually work on both ActiveMQ and Artemis codebases.

On Thu, May 17, 2018 at 8:35 AM, Clebert Suconic
 wrote:
> I meant the announcement email.  And the report staying along with the
> release notes as you said.  Not on the mirrors no.
>
>
> On Thu, May 17, 2018 at 7:29 AM Robbie Gemmell 
> wrote:
>>
>> I think the report is nice, consolidating the details as it does. Its
>> worth saying much of it is essentially available live via the JIRA
>> release notes though given appropriate JIRA/commit handling.
>>
>> When you mention "the release report", do you mean the announcement
>> email? If so I dont think including it would be an issue, though I
>> probably wouldnt as the existing JIRA based release notes output (e.g
>> http://activemq.apache.org/artemis/release-notes-2.5.0.html) seems
>> more suited for typical user needs to me than this, which feels like
>> it would be more useful to e.g the community before/during the vote.
>>
>> I dont think it should be put on the mirrors however, which it
>> currently would be if left in the location it is now and the release
>> is published in the prior manner. Putting it on the website seems more
>> appropriate. If it is to be put on the mirrors however its essentially
>> 'released' and so likely needs some licensing information added as the
>> HTML has none (though it is generated, so that may be ok) and the js
>> files distributed alongside dont detail any other than URLs which isnt
>> sufficient. The css at least mentions the names along with its URLs,
>> but thats perhaps not sufficient either.
>>
>> Robbie
>>
>> On 17 May 2018 at 03:52, Clebert Suconic 
>> wrote:
>> > Before someone asks on the VOTE Thread.. I wanted to point out that I
>> > made a small project to parse git commit and generate a report.
>> >
>> > I have ran the report on top of artemis and I'm adding a commit report
>> > here that can be useful at least on the voter's thread:
>> >
>> >
>> > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.6.0/artemis-2.6.0.html
>> >
>> >
>> >
>> > I think it would be useful to have this one on top of the release
>> > report as well. If nobody opposes I would like to add it to the next
>> > release report.
>> >
>> > The report generator current lives on my github page but it could be
>> > moved somewhere else if someone bothers about being on my github fork:
>> >
>> > https://github.com/clebertsuconic/git-release-report
>> >
>> > --
>> > Clebert Suconic
>
> --
> Clebert Suconic



-- 
Clebert Suconic

[RESULT] [VOTE] Apache ActiveMQ Artemis 2.6.0

[Clebert Suconic]

Results of the Apache ActiveMQ Artemis 2.6.0 release vote.


Vote passes with 6 votes (3 binding and 3 non binding)


The following votes were received:


Binding:

+1 Timothy Bish
+1 Christopher Shannon
+1 Clebert Suconic

Non Binding:

+1 Robbie Gemmell
+1 Francesco Nigro
+1 Howard Gao


Thank you to everyone who contributed and took the time to review the
release candidates and vote.


I'll move forward with the getting the release out and updating the
relevant documentation.


Regards

[GitHub] activemq-artemis pull request #2095: ARTEMIS-1875 Add message address if not...

[mtaylor]

GitHub user mtaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/2095

ARTEMIS-1875 Add message address if not set during redistribution



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1875

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2095.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2095


commit 4b04b53bc9b34e622329e890e4b4613cbc385498
Author: Martyn Taylor 
Date:   2018-05-21T17:21:26Z

ARTEMIS-1875 Add message address if not set during redistribution




---

[GitHub] activemq-artemis pull request #2094: ARTEMIS-1874 fix NPE setting object pro...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/2094

ARTEMIS-1874 fix NPE setting object property



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1874

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2094.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2094


commit 29aa0d340b12e84aae6047f18a5759b94495652e
Author: Justin Bertram 
Date:   2018-05-21T14:55:15Z

ARTEMIS-1874 fix NPE setting object property




---

Re: [VOTE] Apache ActiveMQ Artemis 2.6.0

[Clebert Suconic]

ok.. fair enough... I will finish the release 2.6.0 as is.. and
shortly after I'm sending a HEADS-UP for 2.6.1 in 1 week.

On Mon, May 21, 2018 at 6:29 AM, Robbie Gemmell
 wrote:
> I'd say the same. It is essentially the same amount of work to respin
> as it is to do another release, and it isnt a regression in this
> release, so I'd personally proceed and just use this as reason to do a
> quick 2.6.1 along with any other approriate fixes.
>
> Robbie
>
> On 19 May 2018 at 15:27, Timothy Bish  wrote:
>> On 05/18/2018 06:24 PM, Michael André Pearce wrote:
>>>
>>> Hi All,
>>>
>>> On upgrading to 2.5.0 we have found quite a blocking issue to 2.5.0 for
>>> anyone who secures durable queue creation so clients cannot create, but
>>> doesn’t secure non-durable.
>>>
>>> https://issues.apache.org/jira/browse/ARTEMIS-1872
>>>
>>> In summary prior to 2.5.0 the security check incorrectly always checked
>>> for security rights for non-durable, even if the queue was a durable, this
>>> was security hole was fixed in 2.5.0, but a knock on effect is it has
>>> highlighted/exposed some logic issues in the CoreClient and also in AMQP and
>>> OpenWire protocol managers, where in some cases a queue is not check for
>>> being present before calling create queue, meaning if user is not allowed to
>>> create a queue, but is allowed to consume, and the queue exists, the client
>>> still cannot consume, as the code tries to create and throws exception.
>>>
>>> We have created a test case that re-creates the issues, and also a
>>> possible solution its in PR here.
>>>
>>> https://github.com/apache/activemq-artemis/pull/2093
>>>
>>> Whilst it is not technically caused by any changes in the just created RC
>>> for 2.6.0 since 2.5.0, i think the severity/impact of this may deem it
>>> worthy to fix, and re-spin.
>>>
>>> Cheers
>>> Mike
>>
>>
>> This seems like a good opportunity to practice turning around a quick 2.6.1
>> release as this is not a blocking issue given it's been in the code for
>> quite some time already.
>>
>>
>>
 On 17 May 2018, at 20:02, Christopher Shannon
  wrote:

 +1

 On Thu, May 17, 2018 at 2:51 PM, Timothy Bish 
 wrote:

> On 05/16/2018 10:49 PM, Clebert Suconic wrote:
>
>> I would like to propose an Apache ActiveMQ Artemis 2.6.0 release.
>>
>> The release notes can be found here:
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?versi
>> on=12342903&=12315920
>>
>> There is a new commits report I made that I'm introducing on this
>> release:
>> https://dist.apache.org/repos/dist/dev/activemq/activemq-art
>> emis/2.6.0/artemis-2.6.0.html
>>
>> Source and binary distributions can be found here:
>> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.6.0
>>
>> The Maven repository is here:
>>
>> https://repository.apache.org/content/repositories/orgapacheactivemq-1157
>>
>> In case you want to give it a try with the maven repo on examples:
>> http://activemq.apache.org/artemis/docs/latest/hacking-guide
>> /validating-releases.html
>>
>> The source tag:
>> https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.g
>> it;a=tag;h=refs/tags/2.6.0
>>
>> I will update the website after the vote has passed.
>>
>>
>> [ ] +1 approve the release as Apache Artemis 2.4.0
>> [ ] +0 no opinion
>> [ ] -1 disapprove (and reason why)
>>
>>
>> Here's my +1
>> .
>>
>>
> +1
>
> * Validate the signatures and checksums
> * Review license and notice files in the archives
> * Build from source and ran some of the tests
> * Ran binary broker and ran some samples and performance tests against
> it
> * Used mvn apache-rat:check to validate license headers in place
>
>
> --
> Tim Bish
> twitter: @tabish121
> blog: http://timbish.blogspot.com/
>
>
>>>
>>
>> --
>> Tim Bish
>> twitter: @tabish121
>> blog: http://timbish.blogspot.com/
>>



-- 
Clebert Suconic

Re: [RESULT][VOTE] Apache ActiveMQ 5.15.4

[Christopher Shannon]

Ok nevermind, it apparently sent right the first time but my gmail
collapsed it so it appeared to be missing the [RESULT] block in the subject
so you can ignore the second email.

On Mon, May 21, 2018 at 8:39 AM, Christopher Shannon <
christopher.l.shan...@gmail.com> wrote:

> Resending with the proper tags in the subject...
>
> Results of the Apache ActiveMQ 5.15.4 vote:
>
> Vote passes with 3 +1 binding votes.
>
> The following votes were received:
>
> Binding:
> +1 Timothy Bish
> +1 Christopher Shannon
> +1 Clebert Suconic
>
> Non-Binding
> +1 Jean-Baptiste Onofré
> +1 Francois Papon
> +1 Ragnar Paulson
> +1 Robbie Gemmell
>
>
> I'll start pushing out the release bundles and update the Wiki.
>
>

[RESULT][VOTE] Apache ActiveMQ 5.15.4

[Christopher Shannon]

Resending with the proper tags in the subject...

Results of the Apache ActiveMQ 5.15.4 vote:

Vote passes with 3 +1 binding votes.

The following votes were received:

Binding:
+1 Timothy Bish
+1 Christopher Shannon
+1 Clebert Suconic

Non-Binding
+1 Jean-Baptiste Onofré
+1 Francois Papon
+1 Ragnar Paulson
+1 Robbie Gemmell


I'll start pushing out the release bundles and update the Wiki.

[RESULT][VOTE] Apache ActiveMQ 5.15.4

[Christopher Shannon]

Results of the Apache ActiveMQ 5.15.4 vote:

Vote passes with 3 +1 binding votes.

The following votes were received:

Binding:
+1 Timothy Bish
+1 Christopher Shannon
+1 Clebert Suconic

Non-Binding
+1 Jean-Baptiste Onofré
+1 Francois Papon
+1 Ragnar Paulson
+1 Robbie Gemmell


I'll start pushing out the release bundles and update the Wiki.

Re: [VOTE] Apache ActiveMQ 5.15.4

[Christopher Shannon]

I removed the MD5 checksums, thanks Robbie.

On Mon, May 21, 2018 at 6:59 AM, Robbie Gemmell 
wrote:

> +1 (non-binding)
>
> I checked things over as follows:
> - Verified the signature and checksum files (see note below).
> - Checked for LICENCE and NOTICE files being present in the archives.
> - Ran the source build.
> - Ran the smoke tests.
> - Started the broker from the tar.gz binary and ran some AMQP client
> examples with it.
> - Used the staging repo to run the Qpid JMS master tests against the
> broker.
>
> One note is that the current release distribution policy says we
> should not include MD5 checksums anymore, so I think those should be
> removed before release.
>
> Robbie
>
> On 17 May 2018 at 19:15, Christopher Shannon
>  wrote:
> > Hi Everyone,
> >
> > I have created the ActiveMQ 5.15.4 release and it's ready for a vote.
> This
> > release includes 10 fixes/improvements.
> >
> > The list of resolved issues is here:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12311210=12342685
> >
> > You can get the release artifacts here:
> > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.15.4/
> >
> > Maven repository is at:
> > https://repository.apache.org/content/repositories/
> orgapacheactivemq-1158/
> >
> > Source tag:
> > https://git-wip-us.apache.org/repos/asf?p=activemq.git;a=commit;h=
> 165cba235a915cdd40f1735918d646df9a49e521
> >
> > Please vote to approve this release.  The vote will remain open for 72
> > hours.
> >
> > [ ] +1 Release the binary as Apache ActiveMQ 5.15.4
> > [ ] -1 (provide specific comments)
> >
> > Here's my +1
>

Re: [VOTE] Apache ActiveMQ 5.15.4

[Robbie Gemmell]

+1 (non-binding)

I checked things over as follows:
- Verified the signature and checksum files (see note below).
- Checked for LICENCE and NOTICE files being present in the archives.
- Ran the source build.
- Ran the smoke tests.
- Started the broker from the tar.gz binary and ran some AMQP client
examples with it.
- Used the staging repo to run the Qpid JMS master tests against the broker.

One note is that the current release distribution policy says we
should not include MD5 checksums anymore, so I think those should be
removed before release.

Robbie

On 17 May 2018 at 19:15, Christopher Shannon
 wrote:
> Hi Everyone,
>
> I have created the ActiveMQ 5.15.4 release and it's ready for a vote.  This
> release includes 10 fixes/improvements.
>
> The list of resolved issues is here:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210=12342685
>
> You can get the release artifacts here:
> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.15.4/
>
> Maven repository is at:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1158/
>
> Source tag:
> https://git-wip-us.apache.org/repos/asf?p=activemq.git;a=commit;h=165cba235a915cdd40f1735918d646df9a49e521
>
> Please vote to approve this release.  The vote will remain open for 72
> hours.
>
> [ ] +1 Release the binary as Apache ActiveMQ 5.15.4
> [ ] -1 (provide specific comments)
>
> Here's my +1

Re: [VOTE] Apache ActiveMQ Artemis 2.6.0

[Robbie Gemmell]

I'd say the same. It is essentially the same amount of work to respin
as it is to do another release, and it isnt a regression in this
release, so I'd personally proceed and just use this as reason to do a
quick 2.6.1 along with any other approriate fixes.

Robbie

On 19 May 2018 at 15:27, Timothy Bish  wrote:
> On 05/18/2018 06:24 PM, Michael André Pearce wrote:
>>
>> Hi All,
>>
>> On upgrading to 2.5.0 we have found quite a blocking issue to 2.5.0 for
>> anyone who secures durable queue creation so clients cannot create, but
>> doesn’t secure non-durable.
>>
>> https://issues.apache.org/jira/browse/ARTEMIS-1872
>>
>> In summary prior to 2.5.0 the security check incorrectly always checked
>> for security rights for non-durable, even if the queue was a durable, this
>> was security hole was fixed in 2.5.0, but a knock on effect is it has
>> highlighted/exposed some logic issues in the CoreClient and also in AMQP and
>> OpenWire protocol managers, where in some cases a queue is not check for
>> being present before calling create queue, meaning if user is not allowed to
>> create a queue, but is allowed to consume, and the queue exists, the client
>> still cannot consume, as the code tries to create and throws exception.
>>
>> We have created a test case that re-creates the issues, and also a
>> possible solution its in PR here.
>>
>> https://github.com/apache/activemq-artemis/pull/2093
>>
>> Whilst it is not technically caused by any changes in the just created RC
>> for 2.6.0 since 2.5.0, i think the severity/impact of this may deem it
>> worthy to fix, and re-spin.
>>
>> Cheers
>> Mike
>
>
> This seems like a good opportunity to practice turning around a quick 2.6.1
> release as this is not a blocking issue given it's been in the code for
> quite some time already.
>
>
>
>>> On 17 May 2018, at 20:02, Christopher Shannon
>>>  wrote:
>>>
>>> +1
>>>
>>> On Thu, May 17, 2018 at 2:51 PM, Timothy Bish 
>>> wrote:
>>>
 On 05/16/2018 10:49 PM, Clebert Suconic wrote:

> I would like to propose an Apache ActiveMQ Artemis 2.6.0 release.
>
> The release notes can be found here:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?versi
> on=12342903&=12315920
>
> There is a new commits report I made that I'm introducing on this
> release:
> https://dist.apache.org/repos/dist/dev/activemq/activemq-art
> emis/2.6.0/artemis-2.6.0.html
>
> Source and binary distributions can be found here:
> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.6.0
>
> The Maven repository is here:
>
> https://repository.apache.org/content/repositories/orgapacheactivemq-1157
>
> In case you want to give it a try with the maven repo on examples:
> http://activemq.apache.org/artemis/docs/latest/hacking-guide
> /validating-releases.html
>
> The source tag:
> https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.g
> it;a=tag;h=refs/tags/2.6.0
>
> I will update the website after the vote has passed.
>
>
> [ ] +1 approve the release as Apache Artemis 2.4.0
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
>
> Here's my +1
> .
>
>
 +1

 * Validate the signatures and checksums
 * Review license and notice files in the archives
 * Build from source and ran some of the tests
 * Ran binary broker and ran some samples and performance tests against
 it
 * Used mvn apache-rat:check to validate license headers in place


 --
 Tim Bish
 twitter: @tabish121
 blog: http://timbish.blogspot.com/


>>
>
> --
> Tim Bish
> twitter: @tabish121
> blog: http://timbish.blogspot.com/
>

Re: [VOTE] Apache ActiveMQ Artemis 2.6.0

[Robbie Gemmell]

+1 (non-binding)

I gave things a look over as follows:
- Verified all the signature and checksum files.
- Checked for licence + notice files being present in the archives.
- Ran mvn apache-rat:check to verify licence headers in the source tar.gz
- Ran the build (only, no tests) from the tar.gz.
- Ran the tests in the amqp package from integration-tests.
- Started the broker from the tar.gz binary, ran some AMQP client
examples against it.

One note is that per my comment on the recent thread about the commit
report, the final release steps will need changed (or the files moved
before then) to account for its presence and avoid copying it into the
mirrors+archive, or it needs licensing details added.

Robbie

On 17 May 2018 at 03:49, Clebert Suconic  wrote:
> I would like to propose an Apache ActiveMQ Artemis 2.6.0 release.
>
> The release notes can be found here:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342903&=12315920
>
> There is a new commits report I made that I'm introducing on this release:
> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.6.0/artemis-2.6.0.html
>
> Source and binary distributions can be found here:
> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.6.0
>
> The Maven repository is here:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1157
>
> In case you want to give it a try with the maven repo on examples:
> http://activemq.apache.org/artemis/docs/latest/hacking-guide/validating-releases.html
>
> The source tag:
> https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;a=tag;h=refs/tags/2.6.0
>
> I will update the website after the vote has passed.
>
>
> [ ] +1 approve the release as Apache Artemis 2.4.0
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
>
> Here's my +1

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/2093
  
@michaelandrepearce Yep, makes sense indeed. I will probably implemented it 
in the same you've done (on Core). I haven't finished to read the AMQP part yet 
:+1: 


---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

[RaiSaurabh]

Github user RaiSaurabh commented on the issue:

https://github.com/apache/activemq-artemis/pull/2089
  
@franz1981 @michaelandrepearce I have added the test case to check for 
default 30 is used if not set or configured.  I hope now it is okay.


---