[GitHub] activemq-artemis issue #1975: [ARTEMIS-1761] Log warning if cluster is not a...

2018-12-14 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1975
  
I think this PR is moot at this point as this change is on the master and 
2.6.x branches (and Wildfly has moved to 2.6.x). @rstancel, can you close this 
PR?


---

[GitHub] activemq-artemis pull request #1982: JUnit rules to be usable against extern...

2018-12-14 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1982


---

[GitHub] activemq-artemis issue #2265: [ARTEMIS-2050] It is possible to get AMQ224000...

2018-12-14 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2265
  
I cherry-picked this manually. Please close this PR, @JiriOndrusek. Thanks!


---

[GitHub] activemq-artemis issue #2266: [ARTEMIS-2050] It is possible to get AMQ224000...

2018-12-14 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2266
  
I cherry-picked this manually. Please close this PR, @JiriOndrusek. Thanks!


---

[GitHub] activemq-artemis pull request #2264: [ARTEMIS-2050] It is possible to get AM...

2018-12-14 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2264


---

[GitHub] activemq-artemis pull request #2412: DO NOT MERGE

2018-12-14 Thread michaelandrepearce 
Github user michaelandrepearce closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2412


---

[GitHub] activemq-artemis issue #2412: DO NOT MERGE

2018-12-14 Thread michaelandrepearce 
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2412
  
No worries closed 


---

[GitHub] activemq-artemis issue #2412: DO NOT MERGE

2018-12-14 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2412
  
@michaelandrepearce, I'm doing my best to clean up all the out-standing 
PRs. Can you close this one if possible?


---

[GitHub] activemq-artemis pull request #2442: ARTEMIS-2139 Fix setJMSReplyTo for 1.x ...

2018-12-14 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2442


---

[GitHub] activemq-artemis pull request #2454: ARTEMIS-2196 Avoid creating RandomAcces...

2018-12-14 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2454


---

[GitHub] activemq-artemis pull request #2456: ARTEMIS-2198 Reduce GC pressure on Tran...

2018-12-14 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2456


---

[GitHub] activemq-artemis issue #2459: ARTEMIS-2200 NPE while dropping/failing large ...

2018-12-14 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2459
  
Do you want to implement a better test before this is merged? The test 
looks fine to me. :+1: 


---

[GitHub] activemq-artemis issue #2434: ARTEMIS-1867 FQQN for producers

2018-12-14 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2434
  
From what I can tell everything in this PR is sorted now. I'd like to get 
this in for the upcoming 2.7.0.


---

Re: [PROPOSAL] Move to gitbox.apache.org

2018-12-14 Thread Robbie Gemmell 
For what its worth, I've now been through migration of the various
Qpid repositories to the Gitbox service, it was very straightforward.

I proposed we migrate shortly after replying below, raised the JIRA
request yesterday afternoon, Infra did the migrations during the night
(for me at least), and I then updated the various metadata and links
in the repos and the website content/build bits today.

Robbie

On Mon, 10 Dec 2018 at 15:31, Robbie Gemmell  wrote:
>
> I agree a formal vote isnt needed but a documented consensus on the
> mailing list is required in order to be included in the initial
> voluntary moves, which seems to be what Jean-Baptiste is proposing, so
> it does at minimum need this discussion and probably a direct lazy
> consensus statement on the matter.
>
> I'd echo your comment about being fine with it any time so long as
> noone is planning an imminent release.
>
> Robbie
>
> On Fri, 7 Dec 2018 at 17:14, Daniel Kulp  wrote:
> >
> >
> > You don’t need a vote… It’s going to happen one way or another by Feb 7.
> >
> > The only issue is weather to be pro-active and do it now or wait a little 
> > bit.  If we have releases imminent, I’d say wait till after the 
> > release.   Otherwise, I’m OK at any time.
> >
> > Dan
> >
> >
> >
> > > On Dec 7, 2018, at 12:03 PM, Jean-Baptiste Onofré  
> > > wrote:
> > >
> > > Hi all,
> > >
> > > Our repositories are currently located on git-wip-us.apache.org.
> > >
> > > This service will be decommissioned in the coming month.
> > >
> > > I'm proposing to move our repositories to gitbox.apache.org.
> > >
> > > I'm volunteer to start a vote, and if OK, I will deal with the infra.
> > >
> > > Thoughts ?
> > >
> > > Regards
> > > JB
> > > --
> > > Jean-Baptiste Onofré
> > > jbono...@apache.org
> > > http://blog.nanthrax.net
> > > Talend - http://www.talend.com
> >
> > --
> > Daniel Kulp
> > dk...@apache.org  - http://dankulp.com/blog 
> > 
> > Talend Community Coder - http://talend.com

[GitHub] activemq-artemis pull request #2465: ARTEMIS-2130 - This is to allow views t...

2018-12-14 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2465


---

[GitHub] activemq-artemis issue #2465: ARTEMIS-2130 - This is to allow views to have ...

2018-12-14 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2465
  
This does appear to be the simplest solution to a complex issue. Could you 
use the 
`org.apache.activemq.artemis.jms.client.ActiveMQConnection#JMS_SESSION_CLIENT_ID_PROPERTY`
 constant instead of straight "jms-client-id"? You'll need to add a new 
dependency on the `artemis-server` pom.xml for `artemis-jms-client`.


---

[GitHub] activemq-artemis issue #2465: ARTEMIS-2130 - This is to allow views to have ...

2018-12-14 Thread andytaylor 
Github user andytaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/2465
  
The thing is we have a place for client id, the other protocols use this


---

[GitHub] activemq-artemis issue #2465: ARTEMIS-2130 - This is to allow views to have ...

2018-12-14 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2465
  
Could there just be a column where we dump all the session metadata?


---

[GitHub] activemq-artemis issue #2465: ARTEMIS-2130 - This is to allow views to have ...

2018-12-14 Thread andytaylor 
Github user andytaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/2465
  
when the core protocol is used the client is not available in the 
connection, via jmx or console, because it is set on the connecting session. 
This adds this info at the view level. I couldnt find a better way to do this


---

[GitHub] activemq-artemis pull request #2465: ARTEMIS-2130 - This is to allow views t...

2018-12-14 Thread andytaylor 
GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/2465

ARTEMIS-2130 - This is to allow views to have the client id when set …

…on core protocol

https://issues.apache.org/jira/browse/ARTEMIS-2130

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2465


commit 433032eab8729ad12c3120d06d102fda095b4b85
Author: andytaylor 
Date:   2018-12-14T11:54:10Z

ARTEMIS-2130 - This is to allow views to have the client id when set on 
core protocol

https://issues.apache.org/jira/browse/ARTEMIS-2130




---

[GitHub] activemq-artemis pull request #2450: ARTEMIS-2190 core JMS client leaks temp...

2018-12-14 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2450


---

[GitHub] activemq-artemis pull request #2460: ARTEMIS-2201 Added tests on DEFAULT_JOU...

2018-12-14 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2460


---