Re: Porting JAVA examples to C#
I would be comfortable to use a maven profile that is disabled by default together with the plugin to do the C# build. Any concerns with that approach? Art P.S. Apologies if I missed something from your messages Michael - the spacing on my screen is a mess (looks like lost newlines). On Tue, Apr 7, 2020 at 2:21 PM michael.andre.pearce wrote: > Plugin that we use internally at work where a project is java and dotnet > and use maven to perform the build and release. > https://github.com/kaspersorensen/dotnet-maven-pluginIts apache licensed > so no issues there.Sent from my Samsung Galaxy smartphone. > Original message From: "michael.andre.pearce" < > michael.andre.pea...@me.com> Date: 07/04/2020 22:15 (GMT+00:00) To: > dev@activemq.apache.org Subject: Re: Porting JAVA examples to C# A few > things here.You can actually bind the build with maven and dotnet, theres a > maven plugin that will actually download bits needed for dotnet core and > compile and even run. This way you could actually tie it into the maven > release.Re core 3. Before anything in examples can be updated theres > outstanding work on nms openwire to make it compatible with netstd this > really needs to complete first.Lastly as a community the efforts to slowly > drive Artemis forwards i would want to see examples added to > Artemis. BestMikeSent from my Samsung Galaxy smartphone.
Re: [HEADS UP] ActiveMQ Artemis 2.12 release on April 13th and May 4th
So, TL;DR: I had been keeping an eye on the testsuite, and we are clear at this point. You spotted an intermittent failure that would fail 1 in 10 and I just fixed it. So, we are fine. if you see any other issues please let me know here. On Tue, Apr 7, 2020 at 9:13 PM Clebert Suconic wrote: > > The issues reported on ARTEMIS-2659 I fixed last week, as I had an > encoding issue for Large Messages that I fixed. > > The one thing I'm not sure what's happening is on > testAcceptWithoutSettling that fails in a loop. But the test has been > clear for the past week after I fixed the encoding. > > > I have recently fixed an issue with threading in AMQP that was leading > to scalability issues. Perhaps some asynchronous factor caused some > issue to the test. I will investigate. > > > > On Tue, Apr 7, 2020 at 8:29 PM Timothy Bish wrote: > > > > I'd recommend looking into the failures documented in this issue as they > > seem to indicate regressions in the AMQP protocol handler stack as > > compared to the previous release which doesn't seem to reproduce these > > from testing myself and Robbie have done. > > > > https://issues.apache.org/jira/browse/ARTEMIS-2659 > > > > I'd be inclined to -1 any release that still expresses those failures. > > > > On 4/7/20 7:22 PM, Clebert Suconic wrote: > > > I asked Justin, and he will try for it... if it's just a day or two > > > delay we should probably wait. if it delays any further that's what I > > > meant for another release in about a month. > > > > > > On Tue, Apr 7, 2020 at 5:24 PM Michael Pearce > > > wrote: > > >> Is it worth getting the queue config refactor in before this release? > > >> That > > >> Justin has worked on. That way we can have a release with the refactor > > >> and > > >> then the test cases could be refactored for the following release. > > >> > > >> > > >> > > >> > > >> > > >> On Tue, 7 Apr 2020, 17:57 Clebert Suconic, > > >> wrote: > > >> > > >>> I am planning a release on April 13th. > > >>> > > >>> and at least for the short term I want to keep a more frequent release > > >>> schedule, with another one in the first week of May. which I will send > > >>> another heads up by the end of this month. > > >>> > > >>> > > >>> There are a lot of good enhancements to be released now.. good fixes. > > >>> The testsuite is quite stable on my long running internal jenkins > > >>> instance (nothing fancy.. just running the whole testsuite daily). > > >>> > > >>> > > >>> so, If we could merge / review the PRs we have now.. and if there is > > >>> anyone wanting to hold a bit. .this is channel to discuss about it. > > >>> > > >>> > > >>> Thanks > > >>> > > >>> -- > > >>> Clebert Suconic > > >>> > > > > > > > > > > -- > > Tim Bish > > > > > -- > Clebert Suconic -- Clebert Suconic
Re: [HEADS UP] ActiveMQ Artemis 2.12 release on April 13th and May 4th
I wasn't aware of the JIRA you mentioned, even though I had been following the testsuite... and hence I fixed quite a lot of those issues. Recently I broke the test you mentioned, and I just sent a PR to fix it. The testsuite has been clear to my best knowledge as of last week after these fixes on the encoders for large message I did. On Tue, Apr 7, 2020 at 9:13 PM Clebert Suconic wrote: > > The issues reported on ARTEMIS-2659 I fixed last week, as I had an > encoding issue for Large Messages that I fixed. > > The one thing I'm not sure what's happening is on > testAcceptWithoutSettling that fails in a loop. But the test has been > clear for the past week after I fixed the encoding. > > > I have recently fixed an issue with threading in AMQP that was leading > to scalability issues. Perhaps some asynchronous factor caused some > issue to the test. I will investigate. > > > > On Tue, Apr 7, 2020 at 8:29 PM Timothy Bish wrote: > > > > I'd recommend looking into the failures documented in this issue as they > > seem to indicate regressions in the AMQP protocol handler stack as > > compared to the previous release which doesn't seem to reproduce these > > from testing myself and Robbie have done. > > > > https://issues.apache.org/jira/browse/ARTEMIS-2659 > > > > I'd be inclined to -1 any release that still expresses those failures. > > > > On 4/7/20 7:22 PM, Clebert Suconic wrote: > > > I asked Justin, and he will try for it... if it's just a day or two > > > delay we should probably wait. if it delays any further that's what I > > > meant for another release in about a month. > > > > > > On Tue, Apr 7, 2020 at 5:24 PM Michael Pearce > > > wrote: > > >> Is it worth getting the queue config refactor in before this release? > > >> That > > >> Justin has worked on. That way we can have a release with the refactor > > >> and > > >> then the test cases could be refactored for the following release. > > >> > > >> > > >> > > >> > > >> > > >> On Tue, 7 Apr 2020, 17:57 Clebert Suconic, > > >> wrote: > > >> > > >>> I am planning a release on April 13th. > > >>> > > >>> and at least for the short term I want to keep a more frequent release > > >>> schedule, with another one in the first week of May. which I will send > > >>> another heads up by the end of this month. > > >>> > > >>> > > >>> There are a lot of good enhancements to be released now.. good fixes. > > >>> The testsuite is quite stable on my long running internal jenkins > > >>> instance (nothing fancy.. just running the whole testsuite daily). > > >>> > > >>> > > >>> so, If we could merge / review the PRs we have now.. and if there is > > >>> anyone wanting to hold a bit. .this is channel to discuss about it. > > >>> > > >>> > > >>> Thanks > > >>> > > >>> -- > > >>> Clebert Suconic > > >>> > > > > > > > > > > -- > > Tim Bish > > > > > -- > Clebert Suconic -- Clebert Suconic
Re: [HEADS UP] ActiveMQ Artemis 2.12 release on April 13th and May 4th
The issues reported on ARTEMIS-2659 I fixed last week, as I had an encoding issue for Large Messages that I fixed. The one thing I'm not sure what's happening is on testAcceptWithoutSettling that fails in a loop. But the test has been clear for the past week after I fixed the encoding. I have recently fixed an issue with threading in AMQP that was leading to scalability issues. Perhaps some asynchronous factor caused some issue to the test. I will investigate. On Tue, Apr 7, 2020 at 8:29 PM Timothy Bish wrote: > > I'd recommend looking into the failures documented in this issue as they > seem to indicate regressions in the AMQP protocol handler stack as > compared to the previous release which doesn't seem to reproduce these > from testing myself and Robbie have done. > > https://issues.apache.org/jira/browse/ARTEMIS-2659 > > I'd be inclined to -1 any release that still expresses those failures. > > On 4/7/20 7:22 PM, Clebert Suconic wrote: > > I asked Justin, and he will try for it... if it's just a day or two > > delay we should probably wait. if it delays any further that's what I > > meant for another release in about a month. > > > > On Tue, Apr 7, 2020 at 5:24 PM Michael Pearce > > wrote: > >> Is it worth getting the queue config refactor in before this release? That > >> Justin has worked on. That way we can have a release with the refactor and > >> then the test cases could be refactored for the following release. > >> > >> > >> > >> > >> > >> On Tue, 7 Apr 2020, 17:57 Clebert Suconic, > >> wrote: > >> > >>> I am planning a release on April 13th. > >>> > >>> and at least for the short term I want to keep a more frequent release > >>> schedule, with another one in the first week of May. which I will send > >>> another heads up by the end of this month. > >>> > >>> > >>> There are a lot of good enhancements to be released now.. good fixes. > >>> The testsuite is quite stable on my long running internal jenkins > >>> instance (nothing fancy.. just running the whole testsuite daily). > >>> > >>> > >>> so, If we could merge / review the PRs we have now.. and if there is > >>> anyone wanting to hold a bit. .this is channel to discuss about it. > >>> > >>> > >>> Thanks > >>> > >>> -- > >>> Clebert Suconic > >>> > > > > > > -- > Tim Bish > -- Clebert Suconic
Re: [HEADS UP] ActiveMQ Artemis 2.12 release on April 13th and May 4th
I'd recommend looking into the failures documented in this issue as they seem to indicate regressions in the AMQP protocol handler stack as compared to the previous release which doesn't seem to reproduce these from testing myself and Robbie have done. https://issues.apache.org/jira/browse/ARTEMIS-2659 I'd be inclined to -1 any release that still expresses those failures. On 4/7/20 7:22 PM, Clebert Suconic wrote: I asked Justin, and he will try for it... if it's just a day or two delay we should probably wait. if it delays any further that's what I meant for another release in about a month. On Tue, Apr 7, 2020 at 5:24 PM Michael Pearce wrote: Is it worth getting the queue config refactor in before this release? That Justin has worked on. That way we can have a release with the refactor and then the test cases could be refactored for the following release. On Tue, 7 Apr 2020, 17:57 Clebert Suconic, wrote: I am planning a release on April 13th. and at least for the short term I want to keep a more frequent release schedule, with another one in the first week of May. which I will send another heads up by the end of this month. There are a lot of good enhancements to be released now.. good fixes. The testsuite is quite stable on my long running internal jenkins instance (nothing fancy.. just running the whole testsuite daily). so, If we could merge / review the PRs we have now.. and if there is anyone wanting to hold a bit. .this is channel to discuss about it. Thanks -- Clebert Suconic -- Tim Bish
Re: [HEADS UP] ActiveMQ Artemis 2.12 release on April 13th and May 4th
I asked Justin, and he will try for it... if it's just a day or two delay we should probably wait. if it delays any further that's what I meant for another release in about a month. On Tue, Apr 7, 2020 at 5:24 PM Michael Pearce wrote: > > Is it worth getting the queue config refactor in before this release? That > Justin has worked on. That way we can have a release with the refactor and > then the test cases could be refactored for the following release. > > > > > > On Tue, 7 Apr 2020, 17:57 Clebert Suconic, > wrote: > > > I am planning a release on April 13th. > > > > and at least for the short term I want to keep a more frequent release > > schedule, with another one in the first week of May. which I will send > > another heads up by the end of this month. > > > > > > There are a lot of good enhancements to be released now.. good fixes. > > The testsuite is quite stable on my long running internal jenkins > > instance (nothing fancy.. just running the whole testsuite daily). > > > > > > so, If we could merge / review the PRs we have now.. and if there is > > anyone wanting to hold a bit. .this is channel to discuss about it. > > > > > > Thanks > > > > -- > > Clebert Suconic > > -- Clebert Suconic
Re: [HEADS UP] ActiveMQ Artemis 2.12 release on April 13th and May 4th
Is it worth getting the queue config refactor in before this release? That Justin has worked on. That way we can have a release with the refactor and then the test cases could be refactored for the following release. On Tue, 7 Apr 2020, 17:57 Clebert Suconic, wrote: > I am planning a release on April 13th. > > and at least for the short term I want to keep a more frequent release > schedule, with another one in the first week of May. which I will send > another heads up by the end of this month. > > > There are a lot of good enhancements to be released now.. good fixes. > The testsuite is quite stable on my long running internal jenkins > instance (nothing fancy.. just running the whole testsuite daily). > > > so, If we could merge / review the PRs we have now.. and if there is > anyone wanting to hold a bit. .this is channel to discuss about it. > > > Thanks > > -- > Clebert Suconic >
Re: Porting JAVA examples to C#
Plugin that we use internally at work where a project is java and dotnet and use maven to perform the build and release.https://github.com/kaspersorensen/dotnet-maven-pluginIts apache licensed so no issues there.Sent from my Samsung Galaxy smartphone. Original message From: "michael.andre.pearce" Date: 07/04/2020 22:15 (GMT+00:00) To: dev@activemq.apache.org Subject: Re: Porting JAVA examples to C# A few things here.You can actually bind the build with maven and dotnet, theres a maven plugin that will actually download bits needed for dotnet core and compile and even run. This way you could actually tie it into the maven release.Re core 3. Before anything in examples can be updated theres outstanding work on nms openwire to make it compatible with netstd this really needs to complete first.Lastly as a community the efforts to slowly drive Artemis forwards i would want to see examples added to Artemis. BestMikeSent from my Samsung Galaxy smartphone.
Re: Porting JAVA examples to C#
A few things here.You can actually bind the build with maven and dotnet, theres a maven plugin that will actually download bits needed for dotnet core and compile and even run. This way you could actually tie it into the maven release.Re core 3. Before anything in examples can be updated theres outstanding work on nms openwire to make it compatible with netstd this really needs to complete first.Lastly as a community the efforts to slowly drive Artemis forwards i would want to see examples added to Artemis. BestMikeSent from my Samsung Galaxy smartphone. Original message From: "Ruslan.Shupoval" Date: 07/04/2020 21:05 (GMT+00:00) To: dev@activemq.apache.org Subject: Re: Porting JAVA examples to C# not yet and thank you for your reply.I don't have experience with Java and Maven but I do agree that it is not agood idea to mix examples in a way I proposed before.Answering your question regarding the C# sources, they will be built bymsbuild.I have another idea, but it will require small changes to the existingfolder structure within the"activemq/assembly/src/release/examples/openwire/".This is an existing folder structure:> activemq/assembly/src/release/examples/openwire/advanced-scenarios> activemq/assembly/src/release/examples/openwire/cpp/*.*> activemq/assembly/src/release/examples/openwire/csharp/*.*> activemq/assembly/src/release/examples/openwire/ecommerce> activemq/assembly/src/release/examples/openwire/exploring-jms> activemq/assembly/src/release/examples/openwire/java/*.*> activemq/assembly/src/release/examples/openwire/swissarmyAt this moment the following folders contain example ported to differentlanguages (e.g. without any subfolder with the name of example):> activemq/assembly/src/release/examples/openwire/cpp/*.*> activemq/assembly/src/release/examples/openwire/csharp/*.*> activemq/assembly/src/release/examples/openwire/java/*.*What I'd like to propose first, as part of folders rearrangement, is to movethe content of cpp, csharp and java folder into the corresponding examplespecific folder with the name e.g. /*pub-sub*/. So the folder structure willlook like the following:> activemq/assembly/src/release/examples/openwire/cpp/*> pub-sub*> /*.*> activemq/assembly/src/release/examples/openwire/csharp/*> pub-sub*> /*.*> activemq/assembly/src/release/examples/openwire/java/*> pub-sub*> /*.*After that, I'd like to move the remaining java samples into the java folderlike the following:> activemq/assembly/src/release/examples/openwire/java/pub-sub> activemq/assembly/src/release/examples/openwire/java/*> ecommerce*> activemq/assembly/src/release/examples/openwire/java/*> exploring-jms*> activemq/assembly/src/release/examples/openwire/java/*> advanced-scenarios*> activemq/assembly/src/release/examples/openwire/java/*> swissarmy*And finally, put the ported C# samples into the csharp folder> activemq/assembly/src/release/examples/openwire/csharp/pub-sub> activemq/assembly/src/release/examples/openwire/csharp/*> ecommerce*> activemq/assembly/src/release/examples/openwire/csharp/*> exploring-nms*> => original java sample is named exploring-jms but jms port into c# is> named nms.> activemq/assembly/src/release/examples/openwire/csharp/*> advanced-scenarios*Could you please share your thoughts on this? --Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
Re: Porting JAVA examples to C#
not yet and thank you for your reply. I don't have experience with Java and Maven but I do agree that it is not a good idea to mix examples in a way I proposed before. Answering your question regarding the C# sources, they will be built by msbuild. I have another idea, but it will require small changes to the existing folder structure within the "activemq/assembly/src/release/examples/openwire/". This is an existing folder structure: > activemq/assembly/src/release/examples/openwire/advanced-scenarios > activemq/assembly/src/release/examples/openwire/cpp/*.* > activemq/assembly/src/release/examples/openwire/csharp/*.* > activemq/assembly/src/release/examples/openwire/ecommerce > activemq/assembly/src/release/examples/openwire/exploring-jms > activemq/assembly/src/release/examples/openwire/java/*.* > activemq/assembly/src/release/examples/openwire/swissarmy At this moment the following folders contain example ported to different languages (e.g. without any subfolder with the name of example): > activemq/assembly/src/release/examples/openwire/cpp/*.* > activemq/assembly/src/release/examples/openwire/csharp/*.* > activemq/assembly/src/release/examples/openwire/java/*.* What I'd like to propose first, as part of folders rearrangement, is to move the content of cpp, csharp and java folder into the corresponding example specific folder with the name e.g. /*pub-sub*/. So the folder structure will look like the following: > activemq/assembly/src/release/examples/openwire/cpp/ * > pub-sub * > /*.* > activemq/assembly/src/release/examples/openwire/csharp/ * > pub-sub * > /*.* > activemq/assembly/src/release/examples/openwire/java/ * > pub-sub * > /*.* After that, I'd like to move the remaining java samples into the java folder like the following: > activemq/assembly/src/release/examples/openwire/java/pub-sub > activemq/assembly/src/release/examples/openwire/java/ * > ecommerce * > activemq/assembly/src/release/examples/openwire/java/ * > exploring-jms * > activemq/assembly/src/release/examples/openwire/java/ * > advanced-scenarios * > activemq/assembly/src/release/examples/openwire/java/ * > swissarmy * And finally, put the ported C# samples into the csharp folder > activemq/assembly/src/release/examples/openwire/csharp/pub-sub > activemq/assembly/src/release/examples/openwire/csharp/ * > ecommerce * > activemq/assembly/src/release/examples/openwire/csharp/ * > exploring-nms * > => original java sample is named exploring-jms but jms port into c# is > named nms. > activemq/assembly/src/release/examples/openwire/csharp/ * > advanced-scenarios * Could you please share your thoughts on this? -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
Re: Porting JAVA examples to C#
Did you get any feedback on this? Here are thoughts that come to mind... The src/main/java/... structure is used by (and "encouraged" by) Maven. Would the C# sources be built as part of the maven build process? If so, how do we ensure folks can build the Java sources even when they don't have the tooling to build the C# sources? Art On Mon, Mar 23, 2020 at 4:15 AM Ruslan.Shupoval wrote: > Hello to everyone. > > I'd like to port java examples located at " ActiveMQ OpenWire > < > https://github.com/apache/activemq/tree/master/assembly/src/release/examples/openwire> > > " to C#. > Prior to start doing this I'd like to clarify a few things: > Does the ActiveMQ OpenWire > < > https://github.com/apache/activemq/tree/master/assembly/src/release/examples/openwire> > > location is the place in repo where examples are stored (those examples > that > are included into e.g. apache-activemq-5.15.12-bin.zip > < > http://www.apache.org/dyn/closer.cgi?filename=/activemq/5.15.12/apache-activemq-5.15.12-bin.zip=download> > > ? > Would it be acceptable to create charp directory (sibling to corresponding > java directory) for c# examples (e.g. > > "/activemq/assembly/src/release/examples/openwire/advanced-scenarios/jms-example-wildcard-consumer/src/main/*java*/" > directory currently contains java samples and to create new > > "/activemq/assembly/src/release/examples/openwire/advanced-scenarios/jms-example-wildcard-consumer/src/main/*charp*/" > for the same example but in c# > I'l like to use .net core 3.1 (latest at this moment) > Shall I create a separate Jira ticker for this? > > Please let me know in case of any other questions or suggestions. > > Kind regards, > Ruslan > > > > -- > Sent from: > http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
[HEADS UP] ActiveMQ Artemis 2.12 release on April 13th and May 4th
I am planning a release on April 13th. and at least for the short term I want to keep a more frequent release schedule, with another one in the first week of May. which I will send another heads up by the end of this month. There are a lot of good enhancements to be released now.. good fixes. The testsuite is quite stable on my long running internal jenkins instance (nothing fancy.. just running the whole testsuite daily). so, If we could merge / review the PRs we have now.. and if there is anyone wanting to hold a bit. .this is channel to discuss about it. Thanks -- Clebert Suconic
Re: Update Website on Windows
Of course I should, but right after checking out the repo I've got thousands of changes that I didn't make, it's hard to distinguish which are mine, and which are not. I will try to do this on Linux, hopefully with better luck. On Tue, Apr 7, 2020 at 10:05 AM michael.andre.pearce wrote: > Hi KrysztofYou should only have a change in the file you amended. And its > generated counterpart. BestMikeSent from my Samsung Galaxy smartphone. > Original message From: Krzysztof > Date: 06/04/2020 19:58 (GMT+00:00) To: dev@activemq.apache.org Subject: > Update Website on Windows Hi,I am trying to update website with the info > about the new release of nmsamqp, but right after I checked out the > repository I have changes inthousands of files. Do you guys have any hints > what I should do deal withthis seamlessly?Thanks,Havret
RE: Update Website on Windows
Hi KrysztofYou should only have a change in the file you amended. And its generated counterpart. BestMikeSent from my Samsung Galaxy smartphone. Original message From: Krzysztof Date: 06/04/2020 19:58 (GMT+00:00) To: dev@activemq.apache.org Subject: Update Website on Windows Hi,I am trying to update website with the info about the new release of nmsamqp, but right after I checked out the repository I have changes inthousands of files. Do you guys have any hints what I should do deal withthis seamlessly?Thanks,Havret
