Re: [RESULT][VOTE] Apache ActiveMQ 5.17.1 release

2022-04-29 Thread Jean-Baptiste Onofré
Hi,

Yes, it's OK for me too, dlcdn is up to date.

I'm moving forward on website and announcement.

Thanks,
Regards
JB

On Fri, Apr 29, 2022 at 6:24 PM Robbie Gemmell  wrote:
>
> The dir listing has now updated for me also, so seems to be good now
> for site update etc.
>
> On Fri, 29 Apr 2022 at 15:56, Robbie Gemmell  wrote:
> >
> > I am now able to download the bin tar.gz on the second network so
> > things seem to be mostly working now, other than the dir listing still
> > being stale for some people.
> >
> > On Fri, 29 Apr 2022 at 15:16, Robbie Gemmell  
> > wrote:
> > >
> > > The situation seems much improved but is not entirely sorted yet.
> > > Current suggestion is to wait and see if the CDN 'catches up'.
> > >
> > > The base dir listing is still stale for me, still listing 5.17.0
> > > though isnt actually there anymore and now 404's on attempted entry,
> > > whereas 5.17.1 is still not shown yet for me (but is for others),
> > > while is mostly actually there if you manually enter the dir which
> > > then does list. However one of the files (the bin tar.gz) is still
> > > 404'ing for me on some occasions on 1 network and always on another.
> > >
> > > On Fri, 29 Apr 2022 at 13:16, Robbie Gemmell  
> > > wrote:
> > > >
> > > > I have asked on infras slack channel about the apparent CDN sync issue
> > > > with this.
> > > >
> > > > On Fri, 29 Apr 2022 at 07:26, Jean-Baptiste Onofré  
> > > > wrote:
> > > > >
> > > > > Hi everyone,
> > > > >
> > > > > This vote passed with the following result:
> > > > >
> > > > > +1 (binding): Tim Bish, Robbie Gemmell, Chris Shannon, Clebert
> > > > > Suconic, JB Onofré
> > > > > +1 (non binding): Matt Pavlovich, Charlie Chen
> > > > >
> > > > > I'm promoting the artifacts on Maven Central and dist.apache.org, and
> > > > > then I will do related updates (Jira, website, reporter, etc). I will
> > > > > do the announcement once all is done.
> > > > >
> > > > > Thanks all for your vote!
> > > > >
> > > > > Regards
> > > > > JB
> > > > >
> > > > > On Mon, Apr 25, 2022 at 4:21 PM Jean-Baptiste Onofré 
> > > > >  wrote:
> > > > > >
> > > > > > Hi guys,
> > > > > >
> > > > > > I submit the ActiveMQ 5.17.1 release to your vote.
> > > > > >
> > > > > > This release is an important release on the 5.17.x series, bringing
> > > > > > major changes:
> > > > > > - upgrade to Spring 5.3.19, fixing Spring4shell vulnerability (even 
> > > > > > if
> > > > > > ActiveMQ is not directly impacted)
> > > > > > - XBean 4.21 (supporting Spring 5.x) and ASM 9.3 for better Java 
> > > > > > 18+ support
> > > > > > - and much much more
> > > > > >
> > > > > > Please take a look on the Release Notes for details:
> > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12351348
> > > > > >
> > > > > > Maven Staging Repository:
> > > > > > https://repository.apache.org/content/repositories/orgapacheactivemq-1250/
> > > > > >
> > > > > > Dist Staging Repository:
> > > > > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.1/
> > > > > >
> > > > > > Git tag: activemq-5.17.1
> > > > > >
> > > > > > Please vote to approve this release:
> > > > > > [ ] +1 Approve the release
> > > > > > [ ] -1 Don't approve the release (please provide specific comments)
> > > > > >
> > > > > > This vote will be open for at least 72 hours.
> > > > > >
> > > > > > Thanks !
> > > > > > Regards
> > > > > > JB


Re: Removing non-inclusive terminology

2022-04-29 Thread Matt Pavlovich
Hey Lucas,

I think this is a good time to start working in these changes as work starts on 
5.18.0.

My thoughts:

Pav-1. This is a widely used url, we should take care to transition users. I 
suggest add this new handler and deprecate masterslave. 

Pav-2. IMHO 'leaderfollower’ is incorrect terminology— in this use case, it 
really is just a ‘failover’ behavior and there is no relation to the 
architecture of the target broker(s).

Thanks,
Matt Pavlovich

> On Apr 29, 2022, at 1:08 PM, Tetreault, Lucas  
> wrote:
> 
> Hey folks, 
> 
> TLDR; 
> I am submitting a PR to rename the "masterslave" network connector transport 
> to "leaderfollower" and I propose that we use leader/follower going forward 
> to replace all references to master/slave.
> 
> The Long Version: 
> A tweet from a few days ago [1] raised the issue of non-inclusive terminology 
> in the AWS docs [2] and suggested that we should replace masterslave with a 
> more inclusive name for the network connector transport. The AWS docs refer 
> to a feature of ActiveMQ that is a convenience discovery agent: 
> https://activemq.apache.org/networks-of-brokers#masterslave-discovery. We are 
> planning to change the docs to remove the recommendation to use the 
> masterslave transport. 
> 
> Replacing master/slave nomenclature in ActiveMQ was raised in July 2020 [3]. 
> There was some initial work to rename the git branch from master to main and 
> there have been some attempts at making some changes to the code 
> (https://github.com/apache/activemq/pull/679, 
> https://github.com/apache/activemq/pull/714, 
> https://github.com/apache/activemq/pull/788) however we have not been able to 
> come to an agreement on nomenclature so these efforts seem to have stalled 
> out.
> 
> If we are able to come to an agreement on nomenclature, we can move forward 
> with removing more non-inclusive terminology on the website (I will follow up 
> with some PRs to the website), in discussions with the community and of 
> course in the codebase. This will remove barriers to adoption and make 
> ActiveMQ a more approachable and inclusive project for everyone! Other Apache 
> projects such as Solr and Kafka have moved from master/slave to 
> leader/follower. Leader/follower is also recommended by the IETF [4] and 
> inclusivenaming.org [5] which is supported by companies such as Cisco, Intel, 
> and RedHat. At AWS, we have used active/standby to describe HA deployments, 
> however from previous discussions it's clear that active/standby is not a 
> viable option for this community since 'active' can be used to describe so 
> many things. If we can agree on leader/follower or some alternate we would 
> follow the community's preference and adopt leader/follower to better serve 
> our ActiveMQ users. 
> 
> If we can't come to an agreement on Leader/Follower or some other 
> nomenclature I will, at the very least, create a follow up PR to remove the 
> masterslave transport since it is just a convenience method to use 
> static+failover with ?randomize=false&maxReconnectAttempts=0.
> 
> [1] https://twitter.com/owenblacker/status/1517156221207212032
> [2] 
> https://docs.aws.amazon.com/amazon-mq/latest/developer-guide/amazon-mq-creating-configuring-network-of-brokers.html#creating-configuring-network-of-brokers-configure-network-connectors
>  
> [3] https://issues.apache.org/jira/browse/AMQ-7514 
> [4] https://tools.ietf.org/id/draft-knodel-terminology-02.html 
> [5] https://inclusivenaming.org/word-lists/tier-1/ 
> 
> Thanks,
> 
> Lucas Tétreault
> Software Development Manager, Amazon MQ
> email: tetlu...@amazon.com 
> 



[DISCUSS] Use a generic logger in ActiveMQ Artemis

2022-04-29 Thread Clebert Suconic
For a while, I thought it would be nice to remove jboss-logging from
artemis and use a generic logger. (SLF4J, Log4j, commons.. whatever..
it's all orthogonal and transparent to this discussion, we can decide
that at a later point).


One of the issues we had while making the move would be the generated
error codes out of the Log Processor.


So, I put together a prototype here that would generate code based on
an interface and that could use whatever logger we choose. I will try
to never remove the branch for future reference:


https://github.com/clebertsuconic/activemq-artemis/tree/prototype-log-processor



the Log processor would read the annotations and generate the code:

https://github.com/clebertsuconic/activemq-artemis/blob/prototype-log-processor/artemis-log-processor/src/main/java/org/apache/activemq/artemis/logprocessor/processor/LogProcessor.java




A testcase here would show how such processing would work:

https://github.com/clebertsuconic/activemq-artemis/blob/prototype-log-processor/artemis-log-processor/src/test/java/org/apache/activemq/i18n/test/SimpleBundleTest.java


I have added some code on the artemis-server, trying to simulate what
we would do in "real life":


https://github.com/clebertsuconic/activemq-artemis/blob/prototype-log-processor/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerNewLogger.java



This test here is making a call to the NewLogger, just to show how
processing would work. Everything would work just like it would now:

https://github.com/clebertsuconic/activemq-artemis/blob/prototype-log-processor/artemis-server/src/test/java/org/apache/activemq/artemis/core/TestSample.java




I would appreciate some feedback if this is a good way forward or not...

(please let's not diverge on what logging framework we are choosing
now... that's a separate discussion).





-- 
Clebert Suconic


Removing non-inclusive terminology

2022-04-29 Thread Tetreault, Lucas
Hey folks, 

TLDR; 
I am submitting a PR to rename the "masterslave" network connector transport to 
"leaderfollower" and I propose that we use leader/follower going forward to 
replace all references to master/slave.

The Long Version: 
A tweet from a few days ago [1] raised the issue of non-inclusive terminology 
in the AWS docs [2] and suggested that we should replace masterslave with a 
more inclusive name for the network connector transport. The AWS docs refer to 
a feature of ActiveMQ that is a convenience discovery agent: 
https://activemq.apache.org/networks-of-brokers#masterslave-discovery. We are 
planning to change the docs to remove the recommendation to use the masterslave 
transport. 

Replacing master/slave nomenclature in ActiveMQ was raised in July 2020 [3]. 
There was some initial work to rename the git branch from master to main and 
there have been some attempts at making some changes to the code 
(https://github.com/apache/activemq/pull/679, 
https://github.com/apache/activemq/pull/714, 
https://github.com/apache/activemq/pull/788) however we have not been able to 
come to an agreement on nomenclature so these efforts seem to have stalled out.

If we are able to come to an agreement on nomenclature, we can move forward 
with removing more non-inclusive terminology on the website (I will follow up 
with some PRs to the website), in discussions with the community and of course 
in the codebase. This will remove barriers to adoption and make ActiveMQ a more 
approachable and inclusive project for everyone! Other Apache projects such as 
Solr and Kafka have moved from master/slave to leader/follower. Leader/follower 
is also recommended by the IETF [4] and inclusivenaming.org [5] which is 
supported by companies such as Cisco, Intel, and RedHat. At AWS, we have used 
active/standby to describe HA deployments, however from previous discussions 
it's clear that active/standby is not a viable option for this community since 
'active' can be used to describe so many things. If we can agree on 
leader/follower or some alternate we would follow the community's preference 
and adopt leader/follower to better serve our ActiveMQ users. 

If we can't come to an agreement on Leader/Follower or some other nomenclature 
I will, at the very least, create a follow up PR to remove the masterslave 
transport since it is just a convenience method to use static+failover with 
?randomize=false&maxReconnectAttempts=0.

[1] https://twitter.com/owenblacker/status/1517156221207212032
[2] 
https://docs.aws.amazon.com/amazon-mq/latest/developer-guide/amazon-mq-creating-configuring-network-of-brokers.html#creating-configuring-network-of-brokers-configure-network-connectors
 
[3] https://issues.apache.org/jira/browse/AMQ-7514 
[4] https://tools.ietf.org/id/draft-knodel-terminology-02.html 
[5] https://inclusivenaming.org/word-lists/tier-1/ 

Thanks,

Lucas Tétreault
Software Development Manager, Amazon MQ
email: tetlu...@amazon.com 



Re: [RESULT][VOTE] Apache ActiveMQ 5.17.1 release

2022-04-29 Thread Robbie Gemmell
The dir listing has now updated for me also, so seems to be good now
for site update etc.

On Fri, 29 Apr 2022 at 15:56, Robbie Gemmell  wrote:
>
> I am now able to download the bin tar.gz on the second network so
> things seem to be mostly working now, other than the dir listing still
> being stale for some people.
>
> On Fri, 29 Apr 2022 at 15:16, Robbie Gemmell  wrote:
> >
> > The situation seems much improved but is not entirely sorted yet.
> > Current suggestion is to wait and see if the CDN 'catches up'.
> >
> > The base dir listing is still stale for me, still listing 5.17.0
> > though isnt actually there anymore and now 404's on attempted entry,
> > whereas 5.17.1 is still not shown yet for me (but is for others),
> > while is mostly actually there if you manually enter the dir which
> > then does list. However one of the files (the bin tar.gz) is still
> > 404'ing for me on some occasions on 1 network and always on another.
> >
> > On Fri, 29 Apr 2022 at 13:16, Robbie Gemmell  
> > wrote:
> > >
> > > I have asked on infras slack channel about the apparent CDN sync issue
> > > with this.
> > >
> > > On Fri, 29 Apr 2022 at 07:26, Jean-Baptiste Onofré  
> > > wrote:
> > > >
> > > > Hi everyone,
> > > >
> > > > This vote passed with the following result:
> > > >
> > > > +1 (binding): Tim Bish, Robbie Gemmell, Chris Shannon, Clebert
> > > > Suconic, JB Onofré
> > > > +1 (non binding): Matt Pavlovich, Charlie Chen
> > > >
> > > > I'm promoting the artifacts on Maven Central and dist.apache.org, and
> > > > then I will do related updates (Jira, website, reporter, etc). I will
> > > > do the announcement once all is done.
> > > >
> > > > Thanks all for your vote!
> > > >
> > > > Regards
> > > > JB
> > > >
> > > > On Mon, Apr 25, 2022 at 4:21 PM Jean-Baptiste Onofré 
> > > >  wrote:
> > > > >
> > > > > Hi guys,
> > > > >
> > > > > I submit the ActiveMQ 5.17.1 release to your vote.
> > > > >
> > > > > This release is an important release on the 5.17.x series, bringing
> > > > > major changes:
> > > > > - upgrade to Spring 5.3.19, fixing Spring4shell vulnerability (even if
> > > > > ActiveMQ is not directly impacted)
> > > > > - XBean 4.21 (supporting Spring 5.x) and ASM 9.3 for better Java 18+ 
> > > > > support
> > > > > - and much much more
> > > > >
> > > > > Please take a look on the Release Notes for details:
> > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12351348
> > > > >
> > > > > Maven Staging Repository:
> > > > > https://repository.apache.org/content/repositories/orgapacheactivemq-1250/
> > > > >
> > > > > Dist Staging Repository:
> > > > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.1/
> > > > >
> > > > > Git tag: activemq-5.17.1
> > > > >
> > > > > Please vote to approve this release:
> > > > > [ ] +1 Approve the release
> > > > > [ ] -1 Don't approve the release (please provide specific comments)
> > > > >
> > > > > This vote will be open for at least 72 hours.
> > > > >
> > > > > Thanks !
> > > > > Regards
> > > > > JB


Re: [VOTE] Apache ActiveMQ Artemis 2.22.0

2022-04-29 Thread Justin Bertram
+1

 - Ran a few tests
 - Verified signature and checksum
 - Built from source


Justin

On Thu, Apr 28, 2022 at 11:30 AM Clebert Suconic 
wrote:

> I would like to propose an Apache ActiveMQ Artemis 2.22.0 release.
>
>
> There are no new features on this release, however there are many
> improvements and bug fixes.
>
> In particular there's a default change on cluster connections where we
> now use 1MB bytes for flow control, avoiding Out Of Memory exception
> on situations with high latency networking:
>
> * ARTEMIS-3083 Set a default producer-window-size on cluster connection
>
>
> There are many other improvements and bug fixes and the full release
> notes is available here for more information:
>
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12351488
>
>
> Ths git commit report is here:
>
> https://activemq.apache.org/components/artemis/download/commit-report-2.22.0
>
>
> Source and binary distributions can be found here:
> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.22.0
>
> The Maven staged repository is here:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1251
>
>
> In case you want to give it a try with the maven repo on examples:
>
> https://activemq.apache.org/components/artemis/documentation/hacking-guide/validating-releases.html
>
>
> The source tag:
>
>
> https://gitbox.apache.org/repos/asf/activemq-artemis.git;a=tag;h=refs/tags/2.22.0
>
>
> [ ] +1 approve this release
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
>
> Here's my +1 (Binding) vote
>
>
>
> I should keep this release open for 72 Hours, and I'm not going to
> count the weekend as business hours. That means I will keep this
> release open until at least May-3rd, Noon USA EST.
>
>


Re: [VOTE] Apache ActiveMQ 5.16.5 release

2022-04-29 Thread Timothy Bish

On 4/29/22 05:01, Jean-Baptiste Onofré wrote:

Hi guys,

I submit the ActiveMQ 5.16.5 release to your vote.

This release is a maintenance release on the 5.16.x series including:
- fix on configuration when wrapper is used
- fix memory lead on temp store
- avoid potential NPE when starting ActiveMQ
- add missing Jetty continuation artifact and use of atomic jetty
artifacts instead of the uber server one
- bunch of dependency updates

NB: 5.16.5 will be announced as the last release on the 5.16.x series,
5.16.x will go EOL after this release.

Please take a look on the Release Notes for details:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12351117

Maven Staging Repository:
https://repository.apache.org/content/repositories/orgapacheactivemq-1252/

Dist Staging Repository:
https://dist.apache.org/repos/dist/dev/activemq/activemq/5.16.5/

Git tag: activemq-5.16.5

Please vote to approve this release:
[ ] +1 Approve the release
[ ] -1 Don't approve the release (please provide specific comments)

This vote will be open for at least 72 hours.

Thanks !
Regards
JB
.

+1

* Validated signatures and checksums
* Verified license and notice files
* Checked source license headers with 'mvn apache-rat:check'
* Built from source and ran a portion of the test suite
* Exercised the web console to check it works
* Ran some java and .NET AMQP examples against the binary broker instance.


--
Tim Bish



Re: [RESULT][VOTE] Apache ActiveMQ 5.17.1 release

2022-04-29 Thread Robbie Gemmell
I am now able to download the bin tar.gz on the second network so
things seem to be mostly working now, other than the dir listing still
being stale for some people.

On Fri, 29 Apr 2022 at 15:16, Robbie Gemmell  wrote:
>
> The situation seems much improved but is not entirely sorted yet.
> Current suggestion is to wait and see if the CDN 'catches up'.
>
> The base dir listing is still stale for me, still listing 5.17.0
> though isnt actually there anymore and now 404's on attempted entry,
> whereas 5.17.1 is still not shown yet for me (but is for others),
> while is mostly actually there if you manually enter the dir which
> then does list. However one of the files (the bin tar.gz) is still
> 404'ing for me on some occasions on 1 network and always on another.
>
> On Fri, 29 Apr 2022 at 13:16, Robbie Gemmell  wrote:
> >
> > I have asked on infras slack channel about the apparent CDN sync issue
> > with this.
> >
> > On Fri, 29 Apr 2022 at 07:26, Jean-Baptiste Onofré  
> > wrote:
> > >
> > > Hi everyone,
> > >
> > > This vote passed with the following result:
> > >
> > > +1 (binding): Tim Bish, Robbie Gemmell, Chris Shannon, Clebert
> > > Suconic, JB Onofré
> > > +1 (non binding): Matt Pavlovich, Charlie Chen
> > >
> > > I'm promoting the artifacts on Maven Central and dist.apache.org, and
> > > then I will do related updates (Jira, website, reporter, etc). I will
> > > do the announcement once all is done.
> > >
> > > Thanks all for your vote!
> > >
> > > Regards
> > > JB
> > >
> > > On Mon, Apr 25, 2022 at 4:21 PM Jean-Baptiste Onofré  
> > > wrote:
> > > >
> > > > Hi guys,
> > > >
> > > > I submit the ActiveMQ 5.17.1 release to your vote.
> > > >
> > > > This release is an important release on the 5.17.x series, bringing
> > > > major changes:
> > > > - upgrade to Spring 5.3.19, fixing Spring4shell vulnerability (even if
> > > > ActiveMQ is not directly impacted)
> > > > - XBean 4.21 (supporting Spring 5.x) and ASM 9.3 for better Java 18+ 
> > > > support
> > > > - and much much more
> > > >
> > > > Please take a look on the Release Notes for details:
> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12351348
> > > >
> > > > Maven Staging Repository:
> > > > https://repository.apache.org/content/repositories/orgapacheactivemq-1250/
> > > >
> > > > Dist Staging Repository:
> > > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.1/
> > > >
> > > > Git tag: activemq-5.17.1
> > > >
> > > > Please vote to approve this release:
> > > > [ ] +1 Approve the release
> > > > [ ] -1 Don't approve the release (please provide specific comments)
> > > >
> > > > This vote will be open for at least 72 hours.
> > > >
> > > > Thanks !
> > > > Regards
> > > > JB


Re: [VOTE] Apache ActiveMQ Artemis 2.22.0

2022-04-29 Thread Gary Tully
+1

On Fri, 29 Apr 2022 at 12:26, Robbie Gemmell  wrote:
>
> On Thu, 28 Apr 2022 at 17:25, Clebert Suconic  
> wrote:
> >
> > I would like to propose an Apache ActiveMQ Artemis 2.22.0 release.
> >
> >
> > There are no new features on this release, however there are many
> > improvements and bug fixes.
> >
> > In particular there's a default change on cluster connections where we
> > now use 1MB bytes for flow control, avoiding Out Of Memory exception
> > on situations with high latency networking:
> >
> > * ARTEMIS-3083 Set a default producer-window-size on cluster connection
> >
> >
> > There are many other improvements and bug fixes and the full release
> > notes is available here for more information:
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12351488
> >
> >
> > Ths git commit report is here:
> > https://activemq.apache.org/components/artemis/download/commit-report-2.22.0
> >
> >
> > Source and binary distributions can be found here:
> > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.22.0
> >
> > The Maven staged repository is here:
> > https://repository.apache.org/content/repositories/orgapacheactivemq-1251
> >
> >
> > In case you want to give it a try with the maven repo on examples:
> > https://activemq.apache.org/components/artemis/documentation/hacking-guide/validating-releases.html
> >
> >
> > The source tag:
> >
> > https://gitbox.apache.org/repos/asf/activemq-artemis.git;a=tag;h=refs/tags/2.22.0
> >
> >
> > [ ] +1 approve this release
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> >
> > Here's my +1 (Binding) vote
> >
> >
> >
> > I should keep this release open for 72 Hours, and I'm not going to
> > count the weekend as business hours. That means I will keep this
> > release open until at least May-3rd, Noon USA EST.
>
> +1
>
> I checked things out as follows:
> - Verified the signature + checksum files.
> - Checked for LICENCE and NOTICE files in the archives.
> - Checked licence headers in the source archive by running:
>   "mvn apache-rat:check"
> - Ran the Qpid JMS 2.0.0 HelloWorld against the broker from the binary 
> archive.
> - Ran the source build and the AMQP integration tests on JDK11 with:
>   "mvn clean install -DskipTests && cd tests/integration-tests/ && mvn
> -Ptests -Dtest=org.apache.activemq.artemis.tests.integration.amqp.**
> test"
>
> Robbie


Re: [VOTE] Apache ActiveMQ 5.16.5 release

2022-04-29 Thread Robbie Gemmell
On Fri, 29 Apr 2022 at 10:02, Jean-Baptiste Onofré  wrote:
>
> Hi guys,
>
> I submit the ActiveMQ 5.16.5 release to your vote.
>
> This release is a maintenance release on the 5.16.x series including:
> - fix on configuration when wrapper is used
> - fix memory lead on temp store
> - avoid potential NPE when starting ActiveMQ
> - add missing Jetty continuation artifact and use of atomic jetty
> artifacts instead of the uber server one
> - bunch of dependency updates
>
> NB: 5.16.5 will be announced as the last release on the 5.16.x series,
> 5.16.x will go EOL after this release.
>
> Please take a look on the Release Notes for details:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12351117
>
> Maven Staging Repository:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1252/
>
> Dist Staging Repository:
> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.16.5/
>
> Git tag: activemq-5.16.5
>
> Please vote to approve this release:
> [ ] +1 Approve the release
> [ ] -1 Don't approve the release (please provide specific comments)
>
> This vote will be open for at least 72 hours.
>
> Thanks !
> Regards
> JB

+1

I checked things out as follows:
- Verified the signature + checksum files.
- Checked for LICENCE + NOTICE files present in the archives.
- Checked headers in the source archive with: mvn apache-rat:check
- Ran the source build and the AMQP tests on JDK 8.
- Ran the Qpid JMS 2.0.0 HelloWorld against a broker started from the
tar.gz binary.

Robbie


Re: [RESULT][VOTE] Apache ActiveMQ 5.17.1 release

2022-04-29 Thread Robbie Gemmell
The situation seems much improved but is not entirely sorted yet.
Current suggestion is to wait and see if the CDN 'catches up'.

The base dir listing is still stale for me, still listing 5.17.0
though isnt actually there anymore and now 404's on attempted entry,
whereas 5.17.1 is still not shown yet for me (but is for others),
while is mostly actually there if you manually enter the dir which
then does list. However one of the files (the bin tar.gz) is still
404'ing for me on some occasions on 1 network and always on another.

On Fri, 29 Apr 2022 at 13:16, Robbie Gemmell  wrote:
>
> I have asked on infras slack channel about the apparent CDN sync issue
> with this.
>
> On Fri, 29 Apr 2022 at 07:26, Jean-Baptiste Onofré  wrote:
> >
> > Hi everyone,
> >
> > This vote passed with the following result:
> >
> > +1 (binding): Tim Bish, Robbie Gemmell, Chris Shannon, Clebert
> > Suconic, JB Onofré
> > +1 (non binding): Matt Pavlovich, Charlie Chen
> >
> > I'm promoting the artifacts on Maven Central and dist.apache.org, and
> > then I will do related updates (Jira, website, reporter, etc). I will
> > do the announcement once all is done.
> >
> > Thanks all for your vote!
> >
> > Regards
> > JB
> >
> > On Mon, Apr 25, 2022 at 4:21 PM Jean-Baptiste Onofré  
> > wrote:
> > >
> > > Hi guys,
> > >
> > > I submit the ActiveMQ 5.17.1 release to your vote.
> > >
> > > This release is an important release on the 5.17.x series, bringing
> > > major changes:
> > > - upgrade to Spring 5.3.19, fixing Spring4shell vulnerability (even if
> > > ActiveMQ is not directly impacted)
> > > - XBean 4.21 (supporting Spring 5.x) and ASM 9.3 for better Java 18+ 
> > > support
> > > - and much much more
> > >
> > > Please take a look on the Release Notes for details:
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12351348
> > >
> > > Maven Staging Repository:
> > > https://repository.apache.org/content/repositories/orgapacheactivemq-1250/
> > >
> > > Dist Staging Repository:
> > > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.1/
> > >
> > > Git tag: activemq-5.17.1
> > >
> > > Please vote to approve this release:
> > > [ ] +1 Approve the release
> > > [ ] -1 Don't approve the release (please provide specific comments)
> > >
> > > This vote will be open for at least 72 hours.
> > >
> > > Thanks !
> > > Regards
> > > JB


Re: [VOTE] Apache ActiveMQ 5.16.5 release

2022-04-29 Thread Robbie Gemmell
On Fri, 29 Apr 2022 at 10:02, Jean-Baptiste Onofré  wrote:
>
> Hi guys,
>
> I submit the ActiveMQ 5.16.5 release to your vote.
>
> This release is a maintenance release on the 5.16.x series including:
> - fix on configuration when wrapper is used
> - fix memory lead on temp store
> - avoid potential NPE when starting ActiveMQ
> - add missing Jetty continuation artifact and use of atomic jetty
> artifacts instead of the uber server one
> - bunch of dependency updates
>
> NB: 5.16.5 will be announced as the last release on the 5.16.x series,
> 5.16.x will go EOL after this release.
>

I have updated the website generation bits so that when 5.16.5 is
added it will be noted as the last 5.16.x and point folks to 5.17.x.

> Please take a look on the Release Notes for details:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12351117
>
> Maven Staging Repository:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1252/
>
> Dist Staging Repository:
> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.16.5/
>
> Git tag: activemq-5.16.5
>
> Please vote to approve this release:
> [ ] +1 Approve the release
> [ ] -1 Don't approve the release (please provide specific comments)
>
> This vote will be open for at least 72 hours.
>
> Thanks !
> Regards
> JB


Re: [RESULT][VOTE] Apache ActiveMQ 5.17.1 release

2022-04-29 Thread Robbie Gemmell
I have asked on infras slack channel about the apparent CDN sync issue
with this.

On Fri, 29 Apr 2022 at 07:26, Jean-Baptiste Onofré  wrote:
>
> Hi everyone,
>
> This vote passed with the following result:
>
> +1 (binding): Tim Bish, Robbie Gemmell, Chris Shannon, Clebert
> Suconic, JB Onofré
> +1 (non binding): Matt Pavlovich, Charlie Chen
>
> I'm promoting the artifacts on Maven Central and dist.apache.org, and
> then I will do related updates (Jira, website, reporter, etc). I will
> do the announcement once all is done.
>
> Thanks all for your vote!
>
> Regards
> JB
>
> On Mon, Apr 25, 2022 at 4:21 PM Jean-Baptiste Onofré  
> wrote:
> >
> > Hi guys,
> >
> > I submit the ActiveMQ 5.17.1 release to your vote.
> >
> > This release is an important release on the 5.17.x series, bringing
> > major changes:
> > - upgrade to Spring 5.3.19, fixing Spring4shell vulnerability (even if
> > ActiveMQ is not directly impacted)
> > - XBean 4.21 (supporting Spring 5.x) and ASM 9.3 for better Java 18+ support
> > - and much much more
> >
> > Please take a look on the Release Notes for details:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12351348
> >
> > Maven Staging Repository:
> > https://repository.apache.org/content/repositories/orgapacheactivemq-1250/
> >
> > Dist Staging Repository:
> > https://dist.apache.org/repos/dist/dev/activemq/activemq/5.17.1/
> >
> > Git tag: activemq-5.17.1
> >
> > Please vote to approve this release:
> > [ ] +1 Approve the release
> > [ ] -1 Don't approve the release (please provide specific comments)
> >
> > This vote will be open for at least 72 hours.
> >
> > Thanks !
> > Regards
> > JB


Re: [VOTE] Apache ActiveMQ Artemis 2.22.0

2022-04-29 Thread Robbie Gemmell
On Thu, 28 Apr 2022 at 17:25, Clebert Suconic  wrote:
>
> I would like to propose an Apache ActiveMQ Artemis 2.22.0 release.
>
>
> There are no new features on this release, however there are many
> improvements and bug fixes.
>
> In particular there's a default change on cluster connections where we
> now use 1MB bytes for flow control, avoiding Out Of Memory exception
> on situations with high latency networking:
>
> * ARTEMIS-3083 Set a default producer-window-size on cluster connection
>
>
> There are many other improvements and bug fixes and the full release
> notes is available here for more information:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12351488
>
>
> Ths git commit report is here:
> https://activemq.apache.org/components/artemis/download/commit-report-2.22.0
>
>
> Source and binary distributions can be found here:
> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.22.0
>
> The Maven staged repository is here:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1251
>
>
> In case you want to give it a try with the maven repo on examples:
> https://activemq.apache.org/components/artemis/documentation/hacking-guide/validating-releases.html
>
>
> The source tag:
>
> https://gitbox.apache.org/repos/asf/activemq-artemis.git;a=tag;h=refs/tags/2.22.0
>
>
> [ ] +1 approve this release
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
>
> Here's my +1 (Binding) vote
>
>
>
> I should keep this release open for 72 Hours, and I'm not going to
> count the weekend as business hours. That means I will keep this
> release open until at least May-3rd, Noon USA EST.

+1

I checked things out as follows:
- Verified the signature + checksum files.
- Checked for LICENCE and NOTICE files in the archives.
- Checked licence headers in the source archive by running:
  "mvn apache-rat:check"
- Ran the Qpid JMS 2.0.0 HelloWorld against the broker from the binary archive.
- Ran the source build and the AMQP integration tests on JDK11 with:
  "mvn clean install -DskipTests && cd tests/integration-tests/ && mvn
-Ptests -Dtest=org.apache.activemq.artemis.tests.integration.amqp.**
test"

Robbie


Re: [VOTE] Apache ActiveMQ Artemis 2.22.0

2022-04-29 Thread Christopher Shannon
+1

built from source and ran through the test suite

On Fri, Apr 29, 2022 at 2:14 AM Francesco Nigro  wrote:

> +1 binding
> Very happy re the change on the cluster connection!!!
>
> Il gio 28 apr 2022, 18:25 Clebert Suconic  ha
> scritto:
>
> > I would like to propose an Apache ActiveMQ Artemis 2.22.0 release.
> >
> >
> > There are no new features on this release, however there are many
> > improvements and bug fixes.
> >
> > In particular there's a default change on cluster connections where we
> > now use 1MB bytes for flow control, avoiding Out Of Memory exception
> > on situations with high latency networking:
> >
> > * ARTEMIS-3083 Set a default producer-window-size on cluster connection
> >
> >
> > There are many other improvements and bug fixes and the full release
> > notes is available here for more information:
> >
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12351488
> >
> >
> > Ths git commit report is here:
> >
> >
> https://activemq.apache.org/components/artemis/download/commit-report-2.22.0
> >
> >
> > Source and binary distributions can be found here:
> > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.22.0
> >
> > The Maven staged repository is here:
> >
> https://repository.apache.org/content/repositories/orgapacheactivemq-1251
> >
> >
> > In case you want to give it a try with the maven repo on examples:
> >
> >
> https://activemq.apache.org/components/artemis/documentation/hacking-guide/validating-releases.html
> >
> >
> > The source tag:
> >
> >
> >
> https://gitbox.apache.org/repos/asf/activemq-artemis.git;a=tag;h=refs/tags/2.22.0
> >
> >
> > [ ] +1 approve this release
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> >
> > Here's my +1 (Binding) vote
> >
> >
> >
> > I should keep this release open for 72 Hours, and I'm not going to
> > count the weekend as business hours. That means I will keep this
> > release open until at least May-3rd, Noon USA EST.
> >
>


[VOTE] Apache ActiveMQ 5.16.5 release

2022-04-29 Thread Jean-Baptiste Onofré
Hi guys,

I submit the ActiveMQ 5.16.5 release to your vote.

This release is a maintenance release on the 5.16.x series including:
- fix on configuration when wrapper is used
- fix memory lead on temp store
- avoid potential NPE when starting ActiveMQ
- add missing Jetty continuation artifact and use of atomic jetty
artifacts instead of the uber server one
- bunch of dependency updates

NB: 5.16.5 will be announced as the last release on the 5.16.x series,
5.16.x will go EOL after this release.

Please take a look on the Release Notes for details:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12351117

Maven Staging Repository:
https://repository.apache.org/content/repositories/orgapacheactivemq-1252/

Dist Staging Repository:
https://dist.apache.org/repos/dist/dev/activemq/activemq/5.16.5/

Git tag: activemq-5.16.5

Please vote to approve this release:
[ ] +1 Approve the release
[ ] -1 Don't approve the release (please provide specific comments)

This vote will be open for at least 72 hours.

Thanks !
Regards
JB