[GitHub] activemq-artemis issue #2460: ARTEMIS-2201 Added tests on DEFAULT_JOURNAL_FI...

2018-12-13 Thread feuillemorte 
Github user feuillemorte commented on the issue:

https://github.com/apache/activemq-artemis/pull/2460
  
seems that there is no byteman in mvn dependencies in this package. I don't 
know is it a good idea to add it to dependencies... So, I would like to add 
getter for journalFileOpenTimeout variable. @franz1981 


---

[GitHub] activemq-artemis pull request #2460: ARTEMIS-2201 Added tests on DEFAULT_JOU...

2018-12-11 Thread feuillemorte 
GitHub user feuillemorte opened a pull request:

https://github.com/apache/activemq-artemis/pull/2460

ARTEMIS-2201 Added tests on DEFAULT_JOURNAL_FILE_OPEN_TIMEOUT value



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/feuillemorte/activemq-artemis 
ARTEMIS-2201_default_journal_file_open_timeout

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2460


commit b67a624a5282e263938351ac89c21b01734609cf
Author: feuillemorte 
Date:   2018-12-11T14:05:45Z

#ARTEMIS-2201 Added tests on DEFAULT_JOURNAL_FILE_OPEN_TIMEOUT value




---

[GitHub] activemq-artemis issue #2410: ARTEMIS-2125 Tabs preference changes to displa...

2018-11-02 Thread feuillemorte 
Github user feuillemorte commented on the issue:

https://github.com/apache/activemq-artemis/pull/2410
  
@tadayosi could you review it please? 


---

[GitHub] activemq-artemis pull request #2410: ARTEMIS-2125 Tabs preference changes to...

2018-11-02 Thread feuillemorte 
GitHub user feuillemorte opened a pull request:

https://github.com/apache/activemq-artemis/pull/2410

ARTEMIS-2125 Tabs preference changes to display columns not persistent 
through page refresh

Fix based on
https://github.com/apache/activemq-artemis/pull/2373

Not all places was fixed. This fixes browse tab.

After refreshing:

FF:


![image](https://user-images.githubusercontent.com/9434344/47917052-97f3a800-dea8-11e8-93f5-06a9efec2e6c.png)

Chrome:


![image](https://user-images.githubusercontent.com/9434344/47917078-a80b8780-dea8-11e8-8588-348824b6ad31.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/feuillemorte/activemq-artemis ARTEMIS-2125

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2410.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2410


commit ab24d1b9778e141f5f5e4369b7194c22ab4962cc
Author: feuillemorte 
Date:   2018-11-02T12:53:43Z

ARTEMIS-2125 Tabs preference changes to display columns not persistent 
through page refresh




---

[GitHub] activemq-artemis pull request #2397: ARTEMIS-2116 Extend tests on producer C...

2018-10-26 Thread feuillemorte 
GitHub user feuillemorte opened a pull request:

https://github.com/apache/activemq-artemis/pull/2397

ARTEMIS-2116 Extend tests on producer CLI command with message body

Added tests on producer cli command

Cases:
* Produce 10 messages with default message body
* Produce 10 messages with custom message body
* Produce 10 messages with default message body (FQQN)
* Produce 10 messages with custom message body (FQQN)
* Produce 10 messages with custom message body (long string - 500 000 
symbols)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/feuillemorte/activemq-artemis 
ARTEMIS_2116_extend_tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2397.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2397


commit 681bec7a4bae990a123b47adbedaa596bd800d72
Author: feuillemorte 
Date:   2018-10-26T13:35:29Z

ARTEMIS-2116 Extend tests on producer CLI command with message body




---

[GitHub] activemq-artemis pull request #2260: Added several tests in artemis-cli//Mes...

2018-08-22 Thread feuillemorte 
GitHub user feuillemorte opened a pull request:

https://github.com/apache/activemq-artemis/pull/2260

Added several tests in artemis-cli//MessageSerializerTest

Hello!

I wrote some tests in MessageSerializerTest file, please review it.

Please, advice me how to fix these tests:
`testMulticastTopicToAnycastQueueBothAddress`
`testAnycastQueueToMulticastTopicBothAddress`

I want to import/export messages using topic subscription. And I don't know 
how to understand that my consumer started to listen messages. I tried to use 
this method:

https://github.com/apache/activemq-artemis/blob/c8792186e1ac5a92e8b72dcbd41e5d6731eff11f/artemis-cli/src/test/java/org/apache/activemq/cli/test/MessageSerializerTest.java#L324-L343
to catch some logs like "wait until 10 messages are consumed" but I get 
back only empty list 
also this consumer
```java
MessageConsumer consumer = 
session.createConsumer(getTopicDestination(address));
```
doesn't log anything

now I put "sleep" before sending messages and it works fine for me, but 
it's not a good way to do it.

Thank you!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/feuillemorte/activemq-artemis 
message_serializer_tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2260.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2260


commit b3dde26e0001bfad4af993fa40be4a69438dd031
Author: feuillemorte 
Date:   2018-08-22T14:59:15Z

Added several tests to artemis-cli//MessageSerializerTest




---