[GitHub] activemq-artemis issue #1511: ARTEMIS-1385 appendix

2017-09-06 Thread clebertsuconic 
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1511
  
thanks!


---

[GitHub] activemq-artemis issue #1511: ARTEMIS-1385 appendix

2017-09-06 Thread clebertsuconic 
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1511
  
appendix is not a very good commit name...

when reading logs (git log) you're supposed to give enough context so you 
don't need to open JIRA or anything else to know what was the change.


For two reasons:
i - it's not practical...
ii - If tomorrow there's no more JIRA, at least you have context on what 
was the change.


---

[GitHub] activemq-artemis issue #1511: ARTEMIS-1385 appendix

2017-09-06 Thread stanlyDoge 
Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/1511
  
retest this please


---