[GitHub] activemq-artemis issue #1643: ARTEMIS-1502 added addressMemorySize and pagin...

[pgfox]

Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/1643
  
Thanks @mtaylor. I will close this PR as it is the wrong approach, maybe 
followup later with another PR.



---

[GitHub] activemq-artemis issue #1643: ARTEMIS-1502 added addressMemorySize and pagin...

[mtaylor]

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1643
  
@pgfox There is some overhead in managing MBeans (creating, destroying and 
cleaning up).  The intent with the new console bits was to avoid any reliance 
on MBeans, so that going forward users could switch off MBean registration for 
certain object types and still be able to use management, via the 
ActiveMQServerControl.  The overhead doesn't seem that large at first, but once 
we start getting into the 1000s of addresses or connections it can start 
becoming significant.  Could you move the logic into a helper class or use the 
AddressInfo object instead? 


---

[GitHub] activemq-artemis issue #1643: ARTEMIS-1502 added addressMemorySize and pagin...

[pgfox]

Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/1643
  
@mtaylor I changed 
ActiveMQServerControlImpl#listAddresses(java.lang.String, int, int) to use 
``
server.getManagementService().getResources(AddressControl.class)
`` 
rather than call 
``
server.getPostOffice().getAddresses()
``
It was easier to get the memorySize and paging info from the 
AddressControl. 
It seems to work fine but just wondering if it is a bad idea as you avoided 
it initially?

thanks
Pat

 



---