[GitHub] activemq-artemis issue #1817: ARTEMIS-1623 add logging codes to LoggingActiv...

2018-01-31 Thread pgfox 
Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/1817
  
Hi @jbertram,  this is followup to  #1796, does this address your points on 
that PR?

Thanks
Pat



---

[GitHub] activemq-artemis issue #1817: ARTEMIS-1623 add logging codes to LoggingActiv...

2018-01-25 Thread pgfox 
Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/1817
  
@michaelandrepearce  Thanks Mike


---

[GitHub] activemq-artemis issue #1817: ARTEMIS-1623 add logging codes to LoggingActiv...

2018-01-25 Thread michaelandrepearce 
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1817
  
@pgfox thanks for this. It addresses my bits in the other pr so big +1 from 
me. 

I will wait for @jbertram to give a thumbs up too


---