[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 @stanlyDoge thanks, will merge shortly. ---
[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 Done, let's wait for result :) Is there any else way how to kick off build? ---
[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 LGTM, i think the PR build issue is resolved, if you could just do a comment change and force push or something, to trigger another build, just to get the green PR before merging. ---
[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 @michaelandrepearce Good point. Pushing changes & test in few minutes. ---
[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 @stanlyDoge just looking a bit closer at this, also i think you'll need to cover as well, UnsignedLong, UnsignedShort, UnsignedByte. ---
[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 @stanlyDoge can there be an added test case please for this change ---
[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 I do not think failed test has any in common with these changes. > Failed tests: NetworkHealthTest.testCheckUsingHTTP:213 null ---
[GitHub] activemq-artemis issue #1828: ARTEMIS-1646 fix for browsing messages sent vi...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1828 @stanlyDoge If this needs to be managed / handled for AMQP clients, this must be done within the AMQP protocol module only. We cannot have protocol specifics leaking out their modules. ---
