[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-27 Thread gaohoward 
Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1849
  
@franz1981 @michaelandrepearce I think it's good and am going to merge it.


---

[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-27 Thread franz1981 
Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1849
  
@michaelandrepearce Yep, it has passed the same tests as master with no 
regressions, hence it can be merged :+1: 


---

[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-26 Thread michaelandrepearce 
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1849
  
@franz1981 you noted you were going to merge this once you ran all openwire 
suite. 
Also you said "I'm fixing the last few bits and it is getting in the right 
shape to be merged". Did you get a chance to do this?




---

[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-21 Thread clebertsuconic 
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1849
  
@franz1981 can you rebase this please?


---

[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-16 Thread michaelandrepearce 
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1849
  
I have no further comments. I haven’t had a chance to run test suites but 
as long as you run them and they pass I’m happy 


---

[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-16 Thread franz1981 
Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1849
  
I'm going to merge this provided that is not causing any regressions on 
OpenWire tests/compatibility tests :+1: 


---

[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-12 Thread franz1981 
Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1849
  
@michaelandrepearce 
> FYI gains were with non persistence

Yep, I need to specify it on the JIRA thanks!
I'm fixing the last few bits and it is getting in the right shape to be 
merged :+1: 


---

[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-06 Thread michaelandrepearce 
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1849
  
FYI gains were with non persistence, still need to sort native support of 
open wire format for persistent.


---

[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-06 Thread michaelandrepearce 
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1849
  
Btw I ran a perf test using my POC physical server setup, I see similar 
gains, so +1 from me (once comments are addressed)


---

[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-03 Thread franz1981 
Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1849
  
I'm running the some sanity tests on it.
perf-wire now OpenWire is just 10/20% less than Core protocol for non 
durable messages (depending on message size), it has a much better scalability 
(like Core) and memory footprint thanks to transport buffer pooling.


---