[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

2018-03-06 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1928
  
@tabish121 I'm actually running tests... leave it with me


---


[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

2018-03-06 Thread tabish121
Github user tabish121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1928
  
Need @clebertsuconic to give it a look 


---


[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

2018-03-06 Thread jbertram
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1928
  
If we want this in 2.5 I think we should merge it today.


---


[GitHub] activemq-artemis issue #1928: ARTEMIS-1722 Don't copy message bytes unless n...

2018-03-06 Thread tabish121
Github user tabish121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1928
  
@franz1981 I've updated this PR with changes to the common path based on 
your suggestions to me over on my fork.  Thanks for the review and ideas, even 
better now.  


---