[GitHub] activemq-artemis issue #2198: ARTEMIS-856 - Support consumersBeforeDispatch ...

2018-07-31 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2198
  
@michaelandrepearce Ok.. there's an issue with packaging in Karaf for Util 
depending on how you use. I'm sure it will arise again.


---


[GitHub] activemq-artemis issue #2198: ARTEMIS-856 - Support consumersBeforeDispatch ...

2018-07-31 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2198
  
@clebertsuconic i removed the custom AtomicBooleanFieldUpdater as 
@franz1981 wanted and just used AtomicIntegerFieldUpdater direct. Seems i fix 
the issue and make @franz1981 happy. 


---


[GitHub] activemq-artemis issue #2198: ARTEMIS-856 - Support consumersBeforeDispatch ...

2018-07-31 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2198
  
@michaelandrepearce What did you do to fix the karaf verification? i lost 
some sleep the other trying to figure it out and I'm now curious.


---


[GitHub] activemq-artemis issue #2198: ARTEMIS-856 - Support consumersBeforeDispatch ...

2018-07-31 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2198
  
@clebertsuconic re-pushed to kick off build again and all green. You ok to 
merge?


---


[GitHub] activemq-artemis issue #2198: ARTEMIS-856 - Support consumersBeforeDispatch ...

2018-07-30 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2198
  
i think its the same issue @cshannon  is getting on his PR also. 
https://github.com/apache/activemq-artemis/pull/2191


---


[GitHub] activemq-artemis issue #2198: ARTEMIS-856 - Support consumersBeforeDispatch ...

2018-07-30 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2198
  
@clebertsuconic would let me re-open so heres new PR of the same branch. 
Ive deduced the failure in test case in is that it seems when the journal is 
reloaded the queues arent there, thus it doesnt reload messages, on debugging 
it seems to write to the journal as far as i can tell, but it seems something 
go wrong in that area.


---