[GitHub] activemq-artemis issue #2362: ARTEMIS-2117 Add custom LVQ Key and Non Destru...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2362 I will merge this now.. if there's any issues we can review later ---
[GitHub] activemq-artemis issue #2362: ARTEMIS-2117 Add custom LVQ Key and Non Destru...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2362 @michaelandrepearce I tested directly at your branch.. I just rebased on a new branch and ran it and it passed fine. There was a few fixes that you were behind I assume. I will merge it. ---
[GitHub] activemq-artemis issue #2362: ARTEMIS-2117 Add custom LVQ Key and Non Destru...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2362 I had to take kids to a piano lesson tonight. I donât have a computer now. I will have to connect later tonight. I will do some debug before I post as well. (Will run it again ) ---
[GitHub] activemq-artemis issue #2362: ARTEMIS-2117 Add custom LVQ Key and Non Destru...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2362 @clebertsuconic if you could share, im a bit surprised its this, as the new features should only impact if enabled, so wan't expecting any issues in old cases. Obviously like always happy to look at, as something could have been overlooked ---
[GitHub] activemq-artemis issue #2362: ARTEMIS-2117 Add custom LVQ Key and Non Destru...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2362 the testsuite is stalling... I will have to figure out where and put some context here. ---
[GitHub] activemq-artemis issue #2362: ARTEMIS-2117 Add custom LVQ Key and Non Destru...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2362 I'm running a whole testsuite before we can merge this.. will have results in 3 hours. ---
[GitHub] activemq-artemis issue #2362: ARTEMIS-2117 Add custom LVQ Key and Non Destru...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2362 My colleagues educated me on the non-descructive. Only question I have now is the deprecated method. ---
[GitHub] activemq-artemis issue #2362: ARTEMIS-2117 Add custom LVQ Key and Non Destru...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2362 What is Non Destructive? I had a hard time understanding the use case. ---
[GitHub] activemq-artemis issue #2362: ARTEMIS-2117 Add custom LVQ Key and Non Destru...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2362 will merge if no comments ---
