[GitHub] activemq-artemis issue #2388: ARTEMIS-1856 support delays before deleting ad...

2018-10-26 Thread michaelandrepearce 
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2388
  
@jbertram it wasn't a biggie, i guess more important things are a foot, so 
merging. And can always add the extra config to the other as and when needed in 
future.



---

[GitHub] activemq-artemis issue #2388: ARTEMIS-1856 support delays before deleting ad...

2018-10-24 Thread michaelandrepearce 
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2388
  
@jbertram went to merge this morning and during the process and noticed 
something, have added comment inline


---

[GitHub] activemq-artemis issue #2388: ARTEMIS-1856 support delays before deleting ad...

2018-10-23 Thread michaelandrepearce 
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2388
  
LGTM, will merge tomorrow if no one beats me to it.


---