[GitHub] activemq-artemis issue #782: ARTEMIS-738 Improving TX support on AMQP

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/782
  
@mtaylor / @gemmellr  This is now ready to merge... 

(tagging you guys since you both commented on this PR before)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis issue #782: ARTEMIS-738 Improving TX support on AMQP

2016-09-19 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/782
  
Please, don't merge this yet...  there's an issue with connections dropping 
and rolling back TXs.

The Transactions should be at the connection and should be rolled back when 
the connection failed. I will ammend this tomorrow. It's a small refactoring 
and I should finish it quickly.


But this serves as a review point already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---