[GitHub] activemq-artemis issue #905: added unit test for setting the user and passwo...

2016-12-13 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/905
  
@pgfox  you know you can also do new ActiveMQConnectionFactory(uri);, right?


Just asking.. maybe that's something we need to blog about it.. or maybe 
make it clearer on the docs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis issue #905: added unit test for setting the user and passwo...

2016-12-07 Thread pgfox
Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/905
  
@jbertram, 

as you suggested, enabled security on the test broker and add a role to 
ensure credentials passed with connection. Also enabled the default user to 
ensure existing tests passed without modification - I was trying to keep a 
small footprint. 

Thanks
Pat



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis issue #905: added unit test for setting the user and passwo...

2016-12-07 Thread pgfox
Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/905
  
@jbertram sure, I will give that a go


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis issue #905: added unit test for setting the user and passwo...

2016-12-07 Thread jbertram
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/905
  
Thanks for the test!

For the sake of thoroughness it would be best if security was enabled on 
the test broker and the test ensured the credentials set in the URL actually 
resulted in an authenticated session.  If you don't think you can add that I'll 
go ahead and merge what you have and try to get to it later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---