[GitHub] activemq-artemis pull request #1828: ARTEMIS-1646 fix for browsing messages ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1828


---

[GitHub] activemq-artemis pull request #1828: ARTEMIS-1646 fix for browsing messages ...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1828#discussion_r165007898
  
--- Diff: artemis-commons/pom.xml ---
@@ -79,6 +79,10 @@
  junit
  test
   
+   
--- End diff --

-1 see other comment , AMQP deps must stay within the AMQP module only.


---

[GitHub] activemq-artemis pull request #1828: ARTEMIS-1646 fix for browsing messages ...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1828#discussion_r165007277
  
--- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
 ---
@@ -31,6 +31,7 @@
 import org.apache.activemq.artemis.utils.AbstractByteBufPool;
 import org.apache.activemq.artemis.utils.ByteUtil;
 import org.apache.activemq.artemis.utils.DataConstants;
+import org.apache.qpid.proton.amqp.UnsignedInteger;
--- End diff --

-1 AMQP dependencies should only be within the AMQP Protocol module.


---

[GitHub] activemq-artemis pull request #1828: ARTEMIS-1646 fix for browsing messages ...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1828

ARTEMIS-1646 fix for browsing messages sent via JS client



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis E973

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1828.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1828


commit 50d92ca7d574315971b1b36cbcef07520d29300e
Author: Stanislav Knot 
Date:   2018-01-31T08:37:31Z

ARTEMIS-1646 fix for browsing messages sent via JS client




---