[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

[rpahli]

Github user rpahli commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1833#discussion_r165291242
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
 ---
@@ -416,6 +404,13 @@ private String getHttpUpgradeInfo() {
   return ", activemqServerName=" + serverName + ", 
httpUpgradeEndpoint=" + acceptor;
}
 
+   private String realKeyStorePath;
--- End diff --

If I move the variables into the method then I have to add some new copy 
variables because they have to be final or effective final. Is it ok?


---

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1833#discussion_r165285729
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
 ---
@@ -16,6 +16,11 @@
  */
 package org.apache.activemq.artemis.core.remoting.impl.netty;
 
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLEngine;
+import javax.net.ssl.SSLParameters;
+import javax.security.auth.Subject;
+import javax.security.auth.login.LoginContext;
--- End diff --

Un-needed change, please revert.


---

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1833#discussion_r165285067
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
 ---
@@ -416,6 +404,13 @@ private String getHttpUpgradeInfo() {
   return ", activemqServerName=" + serverName + ", 
httpUpgradeEndpoint=" + acceptor;
}
 
+   private String realKeyStorePath;
--- End diff --

These should remain within method scope.


---

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1833#discussion_r165284845
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
 ---
@@ -388,23 +392,7 @@ public NettyConnector(final Map 
configuration,
 
@Override
public String toString() {
-  return "NettyConnector [host=" + host +
- ", port=" +
- port +
- ", httpEnabled=" +
- httpEnabled +
- ", httpUpgradeEnabled=" +
- httpUpgradeEnabled +
- ", useServlet=" +
- useServlet +
- ", servletPath=" +
- servletPath +
- ", sslEnabled=" +
- sslEnabled +
- ", useNio=" +
- true +
- getHttpUpgradeInfo() +
- "]";
+  return "NettyConnector [host=" + host + ", port=" + port + ", 
httpEnabled=" + httpEnabled + ", httpUpgradeEnabled=" + httpUpgradeEnabled + ", 
useServlet=" + useServlet + ", servletPath=" + servletPath + ", sslEnabled=" + 
sslEnabled + ", useNio=" + true + getHttpUpgradeInfo() + "]";
--- End diff --

can you undo the formatting change please.


---

[GitHub] activemq-artemis pull request #1833: enable openssl provider for Netty

[rpahli]

GitHub user rpahli opened a pull request:

https://github.com/apache/activemq-artemis/pull/1833

enable openssl provider for Netty

We want to use the native Openssl Provider for netty to use the native 
openssl. 
Added the supprt to switch between JDK and OpenSSL Provider.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kiwigrid/activemq-artemis 
enable-openssl-provider

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1833.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1833


commit 6891c160b16ac314d6e92cafcd3f825311156bc7
Author: rico.pahlisch 
Date:   2018-02-01T08:15:34Z

enable openssl provider for native support




---