[GitHub] activemq-artemis pull request #1964: [ARTEMIS-1761] Log one warning if clust...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1964


---

[GitHub] activemq-artemis pull request #1964: [ARTEMIS-1761] Log one warning if clust...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1964#discussion_r176795441
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
 ---
@@ -927,9 +927,7 @@ protected void connect() {
scheduleRetryConnectFixedTimeout(this.retryInterval);
return;
 } else {
-   if (logger.isDebugEnabled()) {
-  logger.debug("Bridge " + this + " is unable to connect 
to destination. Retrying", e);
-   }
+   logger.warn("Bridge " + this + " is unable to connect to 
destination. Retrying...");
--- End diff --

Not really it should have its own, it’s a different issue, and so should 
have its own dedicated log error code and log output.


---

[GitHub] activemq-artemis pull request #1964: [ARTEMIS-1761] Log one warning if clust...

[rstancel]

Github user rstancel commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1964#discussion_r176724023
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
 ---
@@ -927,9 +927,7 @@ protected void connect() {
scheduleRetryConnectFixedTimeout(this.retryInterval);
return;
 } else {
-   if (logger.isDebugEnabled()) {
-  logger.debug("Bridge " + this + " is unable to connect 
to destination. Retrying", e);
-   }
+   logger.warn("Bridge " + this + " is unable to connect to 
destination. Retrying...");
--- End diff --

@michaelandrepearce I have used the same message as in another if-else 
condition. is it ok?


---

[GitHub] activemq-artemis pull request #1964: [ARTEMIS-1761] Log one warning if clust...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1964#discussion_r176662690
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
 ---
@@ -927,9 +927,7 @@ protected void connect() {
scheduleRetryConnectFixedTimeout(this.retryInterval);
return;
 } else {
-   if (logger.isDebugEnabled()) {
-  logger.debug("Bridge " + this + " is unable to connect 
to destination. Retrying", e);
-   }
+   logger.warn("Bridge " + this + " is unable to connect to 
destination. Retrying...");
--- End diff --

Can we use the logger class's for this, as its no longer a debug message, 
should have proper code etc. etc.


---

[GitHub] activemq-artemis pull request #1964: [ARTEMIS-1761] Log one warning if clust...

[rstancel]

GitHub user rstancel opened a pull request:

https://github.com/apache/activemq-artemis/pull/1964

[ARTEMIS-1761] Log one warning if cluster could not be formed because…

… it's not possible to connect to other cluster node

Jira: https://issues.apache.org/jira/browse/ARTEMIS-1761

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rstancel/jboss-activemq-artemis ARTEMIS-1761

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1964


commit 0aad3b89948df94fa414e81d4b5190505940f4b1
Author: Radovan STANCEL 
Date:   2018-03-21T17:26:20Z

[ARTEMIS-1761] Log one warning if cluster could not be formed because it's 
not possible to connect to other cluster node




---