[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1990


---

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[rstancel]

Github user rstancel commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1990#discussion_r179361706
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
 ---
@@ -1539,6 +1540,8 @@ public void end(final Xid xid, final int flags) 
throws XAException {
 startCall();
 try {
sessionContext.xaEnd(xid, flags);
+} catch (ActiveMQNotConnectedException ex) {
+   
ActiveMQClientLogger.LOGGER.connectionClosedWarn(ex.getType(), ex.getMessage());
--- End diff --

@clebertsuconic Done.


---

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1990#discussion_r179284287
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
 ---
@@ -1539,6 +1540,8 @@ public void end(final Xid xid, final int flags) 
throws XAException {
 startCall();
 try {
sessionContext.xaEnd(xid, flags);
+} catch (ActiveMQNotConnectedException ex) {
+   
ActiveMQClientLogger.LOGGER.connectionClosedWarn(ex.getType(), ex.getMessage());
--- End diff --

and as I requested you this small change.. can you rebase against master? 
that would help me to find that pesky AIO failure on travis.


---

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1990#discussion_r179284174
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
 ---
@@ -1539,6 +1540,8 @@ public void end(final Xid xid, final int flags) 
throws XAException {
 startCall();
 try {
sessionContext.xaEnd(xid, flags);
+} catch (ActiveMQNotConnectedException ex) {
+   
ActiveMQClientLogger.LOGGER.connectionClosedWarn(ex.getType(), ex.getMessage());
--- End diff --

can you at least keep a logger.debug(ex.getMessage(), ex) here?

This way if a developer ever needs to debug on why.. it would give the 
developer more information?


---

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[rstancel]

Github user rstancel commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1990#discussion_r178928320
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
 ---
@@ -29,12 +29,7 @@
 import java.util.concurrent.atomic.AtomicInteger;
 
 import org.apache.activemq.artemis.api.config.ActiveMQDefaultConfiguration;
-import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
-import org.apache.activemq.artemis.api.core.ActiveMQBuffers;
-import org.apache.activemq.artemis.api.core.ActiveMQException;
-import org.apache.activemq.artemis.api.core.ActiveMQExceptionType;
-import org.apache.activemq.artemis.api.core.Message;
-import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.api.core.*;
--- End diff --

@jbertram Fixed.


---

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[jbertram]

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1990#discussion_r178924323
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
 ---
@@ -29,12 +29,7 @@
 import java.util.concurrent.atomic.AtomicInteger;
 
 import org.apache.activemq.artemis.api.config.ActiveMQDefaultConfiguration;
-import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
-import org.apache.activemq.artemis.api.core.ActiveMQBuffers;
-import org.apache.activemq.artemis.api.core.ActiveMQException;
-import org.apache.activemq.artemis.api.core.ActiveMQExceptionType;
-import org.apache.activemq.artemis.api.core.Message;
-import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.api.core.*;
--- End diff --

Star imports like this are not allowed by our checkstyle config. You'll 
need to change this for the PR build to pass.


---

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[rstancel]

GitHub user rstancel opened a pull request:

https://github.com/apache/activemq-artemis/pull/1990

[ARTEMIS-1770] Log warning instead of stacktrace while shutdown

Jira: https://issues.apache.org/jira/browse/ARTEMIS-1770

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rstancel/jboss-activemq-artemis ARTEMIS-1770

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1990.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1990


commit 1b8eb06a14fcf03e37c29091e686748abb54d505
Author: Radovan Stancel 
Date:   2018-04-03T11:29:33Z

[ARTEMIS-1770] Log warning when connection is closed




---