[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2006


---

[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...

[jdanekrh]

Github user jdanekrh commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2006#discussion_r180483597
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
 ---
@@ -84,6 +85,10 @@
 import org.apache.activemq.util.LongSequenceGenerator;
 
 public class OpenWireProtocolManager implements 
ProtocolManager, ClusterTopologyListener {
+   static {
+  // this is not really a property, needs to be ignored
+  
FluentPropertyBeanIntrospectorWithIgnores.addIgnore(OpenWireProtocolManager.class.getName(),
 "setUpInactivityParams");
--- End diff --

@stanlyDoge told you so ))


---

[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2006#discussion_r180460101
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
 ---
@@ -84,6 +85,10 @@
 import org.apache.activemq.util.LongSequenceGenerator;
 
 public class OpenWireProtocolManager implements 
ProtocolManager, ClusterTopologyListener {
+   static {
+  // this is not really a property, needs to be ignored
+  
FluentPropertyBeanIntrospectorWithIgnores.addIgnore(OpenWireProtocolManager.class.getName(),
 "setUpInactivityParams");
--- End diff --

Instead of that.. what about renaming the method to 
configureInactivityParams.

You wouldn't need to do anything with Beans.


---

[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/2006

ARTEMIS-1798 DEBUG message bad write method arg count - fix

When the logging level was set up to DEBUG, 
FluentPropertyBeanIntrospectorWithIgnores threw an exception at 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager#setUpInactivityParams
 because it was not really setting up any property. I have added this method to 
FluentPropertyBeanIntrospectorWithIgnores's ignored method, which means this 
method is not checked anymore. That causes there is not error message in DEBUG 
output any longer.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis E638

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2006


commit 7f3962c0776fcfdda9c1dab2cc5260228a2edfc1
Author: Stanislav Knot 
Date:   2018-04-10T13:01:55Z

ARTEMIS-1798 DEBUG message bad write method arg count - fix




---