[GitHub] activemq-artemis pull request #2040: ARTEMIS-1824 running broker from path w...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2040


---

[GitHub] activemq-artemis pull request #2040: ARTEMIS-1824 running broker from path w...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2040#discussion_r184177998
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/XMLUtil.java
 ---
@@ -323,7 +323,7 @@ public static double parseDouble(final Node elem) {
public static void validate(final Node node, final String schemaFile) 
throws Exception {
   SchemaFactory factory = 
SchemaFactory.newInstance(XMLConstants.W3C_XML_SCHEMA_NS_URI);
 
-  Schema schema = factory.newSchema(findResource(schemaFile));
+  Schema schema = factory.newSchema(new 
URL(findResource(schemaFile).toURI().toASCIIString()));
--- End diff --

Nice!!! And the test is satisfactory! 


---

[GitHub] activemq-artemis pull request #2040: ARTEMIS-1824 running broker from path w...

[stanlyDoge]

Github user stanlyDoge commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2040#discussion_r183632055
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/XMLUtil.java
 ---
@@ -323,7 +323,7 @@ public static double parseDouble(final Node elem) {
public static void validate(final Node node, final String schemaFile) 
throws Exception {
   SchemaFactory factory = 
SchemaFactory.newInstance(XMLConstants.W3C_XML_SCHEMA_NS_URI);
 
-  Schema schema = factory.newSchema(findResource(schemaFile));
+  Schema schema = factory.newSchema(new 
URL(findResource(schemaFile).toURI().toASCIIString()));
--- End diff --

I have updated this test. I hope it is ok to have all special characters on 
the sigle line.


---

[GitHub] activemq-artemis pull request #2040: ARTEMIS-1824 running broker from path w...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2040#discussion_r183471882
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/XMLUtil.java
 ---
@@ -323,7 +323,7 @@ public static double parseDouble(final Node elem) {
public static void validate(final Node node, final String schemaFile) 
throws Exception {
   SchemaFactory factory = 
SchemaFactory.newInstance(XMLConstants.W3C_XML_SCHEMA_NS_URI);
 
-  Schema schema = factory.newSchema(findResource(schemaFile));
+  Schema schema = factory.newSchema(new 
URL(findResource(schemaFile).toURI().toASCIIString()));
--- End diff --

Please.. check ./artemis-distribution/src/test/scripts/validate-spaces.sh


Please add the failing pattern that you found on that test.. and run it 
after building the release.


validate-spaces.sh has been added to avoid such issues. if you hit one i 
would like to have the test updated.


---

[GitHub] activemq-artemis pull request #2040: ARTEMIS-1824 running broker from path w...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/2040

ARTEMIS-1824 running broker from path with non-ascii chars



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1824

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2040.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2040


commit 5407f674d536e294dbc1b8925c964682863189da
Author: Stanislav Knot 
Date:   2018-04-23T13:12:01Z

ARTEMIS-1824 running broker from path with non-ascii chars




---