[GitHub] activemq-artemis pull request #2377: ARTEMIS-2133 Artemis tab not showing on...

2018-10-17 Thread gaohoward 
Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2377#discussion_r226144345
  
--- Diff: 
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js ---
@@ -362,7 +362,7 @@ var ARTEMIS = (function(ARTEMIS) {
 
   workspace.subLevelTabs = subLevelTabs;
 
-  preLogoutTasks.addTask("clearArtemisCredentials", () => {
--- End diff --

surprisingly yes. :)


---

[GitHub] activemq-artemis pull request #2377: ARTEMIS-2133 Artemis tab not showing on...

2018-10-17 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2377


---

[GitHub] activemq-artemis pull request #2377: ARTEMIS-2133 Artemis tab not showing on...

2018-10-17 Thread clebertsuconic 
Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2377#discussion_r225992639
  
--- Diff: 
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js ---
@@ -362,7 +362,7 @@ var ARTEMIS = (function(ARTEMIS) {
 
   workspace.subLevelTabs = subLevelTabs;
 
-  preLogoutTasks.addTask("clearArtemisCredentials", () => {
--- End diff --

This will be enough to fix IE?


---

[GitHub] activemq-artemis pull request #2377: ARTEMIS-2133 Artemis tab not showing on...

2018-10-17 Thread gaohoward 
GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/2377

ARTEMIS-2133 Artemis tab not showing on IE browser

The web console on IE doesn't have 'Artemis' showed up because
it doesn't support javascripts => function.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis a_web_ie

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2377


commit 7206326c64c7f74da8ae8b2921e784cdfe8b2a4a
Author: Howard Gao 
Date:   2018-10-17T12:15:17Z

ARTEMIS-2133 Artemis tab not showing on IE browser

The web console on IE doesn't have 'Artemis' showed up because
it doesn't support javascripts => function.




---