[GitHub] clebertsuconic commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

2019-01-15 Thread GitBox 
clebertsuconic commented on a change in pull request #2498: ARTEMIS-2228 Large 
Messages over Management
URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247954437
 
 

 ##
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
 ##
 @@ -1005,9 +1006,9 @@ public RemotingConnection getRemotingConnection() {
  ByteBuffer buffer = ByteBuffer.allocate(8);
  buffer.putLong(queue.getID());
  message.putBytesProperty(Message.HDR_ROUTE_TO_IDS, buffer.array());
- postOffice.route(message, true);
+ 
server.getPostOffice().route(LargeServerMessageImpl.checkLargeMessage(message, 
server.getStorageManager()), true);
 
 Review comment:
   @michaelandrepearce I was just making the simple fix. but you're right.. I'm 
using the serverSession.send here now.
   
   I had to create a few fakes to allow the ServerSession creation, as I don't 
have a real connection on this case. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] clebertsuconic commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

2019-01-15 Thread GitBox 
clebertsuconic commented on a change in pull request #2498: ARTEMIS-2228 Large 
Messages over Management
URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247954437
 
 

 ##
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
 ##
 @@ -1005,9 +1006,9 @@ public RemotingConnection getRemotingConnection() {
  ByteBuffer buffer = ByteBuffer.allocate(8);
  buffer.putLong(queue.getID());
  message.putBytesProperty(Message.HDR_ROUTE_TO_IDS, buffer.array());
- postOffice.route(message, true);
+ 
server.getPostOffice().route(LargeServerMessageImpl.checkLargeMessage(message, 
server.getStorageManager()), true);
 
 Review comment:
   @michaelandrepearce I was just making the simple fix. but you're right.. I'm 
using the serverSession.send here now.
   
   I had to create a few fakes to allow the ServerSession creation, as I don't 
have a real connection on this case. you will see it when I push -f


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services